)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"abb999d8ac56b6166fc22f660d925f81e522025c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable IPv6 on bridge devices for LinuxBridgeManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The brq bridge should not have any IPv6 addresses, either"},{"line_number":10,"context_line":"link-local, or on the tenant\u0027s private network due to the"},{"line_number":11,"context_line":"bridge processing Router Advertisements from Neutron and"},{"line_number":12,"context_line":"auto-configuring addresses, since it will allow access to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_e083a6ca","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"updated":"2016-08-04 01:41:04.000000000","message":"Is this specifically what it\u0027s called? Could there be a different bridge being plugged with a different name? I\u0027m wondering if this code could be executed for nova-network in any way, and would you need to check that the bridge is \u0027brq\u0027? Sorry but I\u0027m unfamiliar with this.","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0173c160ffdb6968050e0a35523bdc3eb30bb5c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable IPv6 on bridge devices for LinuxBridgeManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The brq bridge should not have any IPv6 addresses, either"},{"line_number":10,"context_line":"link-local, or on the tenant\u0027s private network due to the"},{"line_number":11,"context_line":"bridge processing Router Advertisements from Neutron and"},{"line_number":12,"context_line":"auto-configuring addresses, since it will allow access to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_d37f2c15","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"in_reply_to":"bacf61ea_13438443","updated":"2016-08-04 18:04:23.000000000","message":"No, I think we should do this regardless of bridge name, which is what we did in neutron.  Bridges should only be used for transit traffic between ports, having addresses on them allows hypervisor access from VMs.","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"93b9195a407a36fca92223fbd1d477af215e93ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable IPv6 on bridge devices for LinuxBridgeManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The brq bridge should not have any IPv6 addresses, either"},{"line_number":10,"context_line":"link-local, or on the tenant\u0027s private network due to the"},{"line_number":11,"context_line":"bridge processing Router Advertisements from Neutron and"},{"line_number":12,"context_line":"auto-configuring addresses, since it will allow access to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_e7b8bc13","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"in_reply_to":"bacf61ea_e083a6ca","updated":"2016-08-04 14:13:36.000000000","message":"Yes, Tore\u0027s log trace in https://bugs.launchpad.net/neutron/+bug/1302080/comments/31 showed brq as the bridge prefix.","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"24e07e67e0005171e6d649bb464ac665cda87845","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable IPv6 on bridge devices for LinuxBridgeManager"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The brq bridge should not have any IPv6 addresses, either"},{"line_number":10,"context_line":"link-local, or on the tenant\u0027s private network due to the"},{"line_number":11,"context_line":"bridge processing Router Advertisements from Neutron and"},{"line_number":12,"context_line":"auto-configuring addresses, since it will allow access to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_13438443","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":7},"in_reply_to":"bacf61ea_e7b8bc13","updated":"2016-08-04 17:55:08.000000000","message":"So should we only do this conditionally based on the bridge name?","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"}],"nova/network/linux_net.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"abb999d8ac56b6166fc22f660d925f81e522025c","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"            _execute(\u0027brctl\u0027, \u0027setfd\u0027, bridge, 0, run_as_root\u003dTrue)"},{"line_number":1543,"context_line":"            # _execute(\u0027brctl setageing %s 10\u0027 % bridge, run_as_root\u003dTrue)"},{"line_number":1544,"context_line":"            _execute(\u0027brctl\u0027, \u0027stp\u0027, bridge, \u0027off\u0027, run_as_root\u003dTrue)"},{"line_number":1545,"context_line":"            disv6 \u003d \u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 % bridge"},{"line_number":1546,"context_line":"            if os.path.exists(disv6):"},{"line_number":1547,"context_line":"                _execute(\u0027tee\u0027,"},{"line_number":1548,"context_line":"                         disv6,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_80b90ace","line":1545,"updated":"2016-08-04 01:41:04.000000000","message":"Would be good to have a comment in here explaining why this is needed in case you need to respin.","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"93b9195a407a36fca92223fbd1d477af215e93ec","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"            _execute(\u0027brctl\u0027, \u0027setfd\u0027, bridge, 0, run_as_root\u003dTrue)"},{"line_number":1543,"context_line":"            # _execute(\u0027brctl setageing %s 10\u0027 % bridge, run_as_root\u003dTrue)"},{"line_number":1544,"context_line":"            _execute(\u0027brctl\u0027, \u0027stp\u0027, bridge, \u0027off\u0027, run_as_root\u003dTrue)"},{"line_number":1545,"context_line":"            disv6 \u003d \u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 % bridge"},{"line_number":1546,"context_line":"            if os.path.exists(disv6):"},{"line_number":1547,"context_line":"                _execute(\u0027tee\u0027,"},{"line_number":1548,"context_line":"                         disv6,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_a7f7e4d1","line":1545,"in_reply_to":"bacf61ea_80b90ace","updated":"2016-08-04 14:13:36.000000000","message":"If I need to respin I\u0027ll add a comment.","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a21f209ddccd1a73c4286779bb0b2ad6d6f7d29f","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"            _execute(\u0027brctl\u0027, \u0027setfd\u0027, bridge, 0, run_as_root\u003dTrue)"},{"line_number":1543,"context_line":"            # _execute(\u0027brctl setageing %s 10\u0027 % bridge, run_as_root\u003dTrue)"},{"line_number":1544,"context_line":"            _execute(\u0027brctl\u0027, \u0027stp\u0027, bridge, \u0027off\u0027, run_as_root\u003dTrue)"},{"line_number":1545,"context_line":"            disv6 \u003d \u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 % bridge"},{"line_number":1546,"context_line":"            if os.path.exists(disv6):"},{"line_number":1547,"context_line":"                _execute(\u0027tee\u0027,"},{"line_number":1548,"context_line":"                         disv6,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_74bf18d0","line":1545,"in_reply_to":"bacf61ea_a7f7e4d1","updated":"2016-08-05 14:56:42.000000000","message":"So just FYI, but this is all moving to os-vif with https://review.openstack.org/#/c/350595 so you\u0027re going to have to make the same fix in os-vif:\n\nhttps://github.com/openstack/os-vif/blob/1.0.0/vif_plug_linux_bridge/linux_net.py#L102","commit_id":"511da3ced33dc4e69afc596d1b0f5c88eb2d9f44"}]}