)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cf4dbf898ee7674192dc42d3b531008977f94369","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dineshbhor \u003cdinesh.bhor@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-13 09:36:43 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return 500 HTTP error for invalid flavor attributes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently create flavor API raises 500 error if you"},{"line_number":10,"context_line":"pass large value to ram, disk, vcpu, swap, ephemeral,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_8dd5591d","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":10},"updated":"2016-05-17 04:52:20.000000000","message":"400?","commit_id":"4861a133f952a08b5fd7401e40691326eeeb01a1"}],"nova/api/openstack/compute/schemas/flavor_manage.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"dfd11547ae8ff4f79aca8f12de5e1e3821e06c21","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":42,"context_line":"                    \u0027pattern\u0027: \u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":43,"context_line":"                    \u0027minimum\u0027: 0, \u0027exclusiveMinimum\u0027: True,"},{"line_number":44,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"},{"line_number":45,"context_line":"                },"},{"line_number":46,"context_line":"                \u0027os-flavor-access:is_public\u0027: parameter_types.boolean,"},{"line_number":47,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_1526f967","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":42},"updated":"2016-05-25 09:46:06.000000000","message":"The above other values(flavor_param_non_negative, etc) are readable, but this static value is not.\nCould we add some NOTE here to explain the reason why we need to put this static value?","commit_id":"8140c51a9f7e1b199ce44a697f6c488486505e8c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8770e781e19f1c616c7ed138130089981f5f8485","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":42,"context_line":"                    \u0027pattern\u0027: \u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":43,"context_line":"                    \u0027minimum\u0027: 0, \u0027exclusiveMinimum\u0027: True,"},{"line_number":44,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"},{"line_number":45,"context_line":"                },"},{"line_number":46,"context_line":"                \u0027os-flavor-access:is_public\u0027: parameter_types.boolean,"},{"line_number":47,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_7044b3b6","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":42},"in_reply_to":"bab6814e_1526f967","updated":"2016-05-25 10:08:36.000000000","message":"I would even create some named constant for this number to explain the meaning of it (I guess it some kind of MAX_FLOAT in the DB side)","commit_id":"8140c51a9f7e1b199ce44a697f6c488486505e8c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"e7d49f6de3930728386f69339ab986051b1b9614","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                    \u0027type\u0027: [\u0027number\u0027, \u0027string\u0027],"},{"line_number":42,"context_line":"                    \u0027pattern\u0027: \u0027^[0-9]+(\\.[0-9]+)?$\u0027,"},{"line_number":43,"context_line":"                    \u0027minimum\u0027: 0, \u0027exclusiveMinimum\u0027: True,"},{"line_number":44,"context_line":"                    \u0027maximum\u0027: 3.40282e+38"},{"line_number":45,"context_line":"                },"},{"line_number":46,"context_line":"                \u0027os-flavor-access:is_public\u0027: parameter_types.boolean,"},{"line_number":47,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_262f6089","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":42},"in_reply_to":"bab6814e_7044b3b6","updated":"2016-05-26 07:16:04.000000000","message":"Done","commit_id":"8140c51a9f7e1b199ce44a697f6c488486505e8c"}],"nova/api/openstack/extensions.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c3f0ccf5d4a1629e1246661462b16d873f7501f4","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                    # converts NotAuthorized to HTTPForbidden"},{"line_number":493,"context_line":"                    raise"},{"line_number":494,"context_line":"                elif isinstance(exc, (exception.ValidationError,"},{"line_number":495,"context_line":"                                      exception.InvalidInput)):"},{"line_number":496,"context_line":"                    # Note(oomichi): Handle validation and InvalidInput"},{"line_number":497,"context_line":"                    # error, which happens due to invalid API parameters, as an"},{"line_number":498,"context_line":"                    # expected error."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_78de4c12","line":495,"range":{"start_line":495,"start_character":38,"end_line":495,"end_character":47},"updated":"2016-05-09 18:51:35.000000000","message":"if it\u0027s flavor error, we probably can catch and handle there\nthis is not a good place since it\u0027s more generic code path\nyou can change in flavor_manage.py instead","commit_id":"ba2d3e8ad5f54fcc083a880e2acee5c1119828c9"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"4dc184b6784ad2da9b5e6f3b728fafbeda15a619","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                    # converts NotAuthorized to HTTPForbidden"},{"line_number":493,"context_line":"                    raise"},{"line_number":494,"context_line":"                elif isinstance(exc, (exception.ValidationError,"},{"line_number":495,"context_line":"                                      exception.InvalidInput)):"},{"line_number":496,"context_line":"                    # Note(oomichi): Handle validation and InvalidInput"},{"line_number":497,"context_line":"                    # error, which happens due to invalid API parameters, as an"},{"line_number":498,"context_line":"                    # expected error."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_3857cd03","line":495,"range":{"start_line":495,"start_character":38,"end_line":495,"end_character":47},"in_reply_to":"dab17558_78de4c12","updated":"2016-05-13 09:40:30.000000000","message":"Done","commit_id":"ba2d3e8ad5f54fcc083a880e2acee5c1119828c9"}],"nova/api/validation/parameter_types.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"dfd11547ae8ff4f79aca8f12de5e1e3821e06c21","unresolved":false,"context_lines":[{"line_number":350,"context_line":"}"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"volume_size \u003d {"},{"line_number":354,"context_line":"    \u0027type\u0027: [\u0027integer\u0027, \u0027string\u0027],"},{"line_number":355,"context_line":"    \u0027pattern\u0027: \u0027^[0-9]+$\u0027,"},{"line_number":356,"context_line":"    \u0027minimum\u0027: 1,"},{"line_number":357,"context_line":"    \u0027maximum\u0027: db.MAX_INT"},{"line_number":358,"context_line":"}"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"flavor_param_positive \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_15827900","line":358,"range":{"start_line":353,"start_character":0,"end_line":358,"end_character":1},"updated":"2016-05-25 09:46:06.000000000","message":"This is not a reason why this -1.\n\nWe can define common value to merge this existing value, but it is fine even if the next step on another patch.","commit_id":"8140c51a9f7e1b199ce44a697f6c488486505e8c"}],"nova/tests/unit/api/openstack/compute/test_flavor_manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8770e781e19f1c616c7ed138130089981f5f8485","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        self._create_flavor_bad_request_case(self.request_body)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_create_with_rxtx_factor_exceed_max_limit(self):"},{"line_number":304,"context_line":"        SQL_SP_FLOAT_MAX \u003d 3.40282e+38"},{"line_number":305,"context_line":"        self.request_body[\u0027flavor\u0027][\u0027rxtx_factor\u0027] \u003d SQL_SP_FLOAT_MAX * 2"},{"line_number":306,"context_line":"        self._create_flavor_bad_request_case(self.request_body)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_d0c63f15","line":304,"updated":"2016-05-25 10:08:36.000000000","message":"Can we have similar constant like MAX_INT? So the number does not need to be duplicated in the schema and in the test","commit_id":"8140c51a9f7e1b199ce44a697f6c488486505e8c"}]}