)]}'
{"api-ref/source/os-volumes.inc":[{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"c129dfe7e4f6f6558e7b85a18cebf56dac0a4a17","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Request"},{"line_number":24,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_eec23133","line":21,"updated":"2016-05-10 19:23:10.000000000","message":"I think list volumes should have BadRequest inlcuded as https://github.com/openstack/nova/blob/bc5035343d366a18cae587f92ecb4e871aba974a/nova/api/openstack/compute/volumes.py#L144 there is a possibility that this one can return bad request error 400. Would like to have others thought on this.","commit_id":"b2dc2dcc6eb4f422d9ea0f699ea824423ac1fe85"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c6de4c8bc5cba8e4d8bbe6994b7a84ab2973796","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Request"},{"line_number":24,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_a8592b37","line":21,"in_reply_to":"dab17558_eec23133","updated":"2016-05-11 07:01:44.000000000","message":"nice catch.\nWrong queries offset and limit can cause 400 like following:\n\n    offset \u003d request.GET.get(\"offset\", 0)\n    limit \u003d request.GET.get(\u0027limit\u0027, max_limit)\n\n    try:\n        offset \u003d utils.validate_integer(offset, \"offset\", min_value\u003d0)\n        limit \u003d utils.validate_integer(limit, \"limit\", min_value\u003d0)\n    except exception.InvalidInput as e:\n        raise webob.exc.HTTPBadRequest(explanation\u003de.format_message())","commit_id":"b2dc2dcc6eb4f422d9ea0f699ea824423ac1fe85"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"c129dfe7e4f6f6558e7b85a18cebf56dac0a4a17","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Normal response codes: 200"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Error response codes: unauthorized(401), forbidden(403)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request"},{"line_number":90,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ceedadb8","line":87,"updated":"2016-05-10 19:23:10.000000000","message":"Even this one should have BadRequest inlcuded fro above mentioned reason","commit_id":"b2dc2dcc6eb4f422d9ea0f699ea824423ac1fe85"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"c129dfe7e4f6f6558e7b85a18cebf56dac0a4a17","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Delete Volume"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. rest_method:: DELETE /v2.1/{tenant_id}/os-volumes/{volume_id}"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Deletes a volume."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_8eda85e6","line":134,"updated":"2016-05-10 19:23:10.000000000","message":"Delete volume method calls https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L442-L444 in cinder.py which raises few more exceptions. Should that be documented as well ?","commit_id":"b2dc2dcc6eb4f422d9ea0f699ea824423ac1fe85"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e27f4d159529fb72c9731848ac28d51026f0e98d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Delete Volume"},{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. rest_method:: DELETE /v2.1/{tenant_id}/os-volumes/{volume_id}"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Deletes a volume."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dab17558_ed6697b9","line":134,"in_reply_to":"dab17558_8eda85e6","updated":"2016-05-11 11:47:50.000000000","message":"Yes, definitely","commit_id":"b2dc2dcc6eb4f422d9ea0f699ea824423ac1fe85"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Request"},{"line_number":24,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_c3b97230","line":21,"range":{"start_line":21,"start_character":22,"end_line":21,"end_character":38},"updated":"2016-05-13 10:22:57.000000000","message":"I am not sure 400 is possible for most of these.","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Normal response codes: 200"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Request"},{"line_number":90,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_03e9ba1a","line":87,"range":{"start_line":87,"start_character":22,"end_line":87,"end_character":37},"updated":"2016-05-13 10:22:57.000000000","message":"as above, not sure this is possible.","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/os-volumes-get-resp.json"},{"line_number":130,"context_line":"   :language: javascript"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Delete Volume"},{"line_number":133,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_63d88680","line":131,"updated":"2016-05-13 10:22:57.000000000","message":"I think create volume should probably go in here?","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Normal response codes: 202"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"Error response codes: badRequest(400), unauthorized(401),"},{"line_number":142,"context_line":"forbidden(403), itemNotFound(404)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_38122d63","line":141,"range":{"start_line":141,"start_character":22,"end_line":141,"end_character":37},"updated":"2016-05-13 10:22:57.000000000","message":"400 isn\u0027t an option for Delete:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/volumes.py#n116","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Normal response codes: 200"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Request"},{"line_number":167,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_235b1ef8","line":164,"range":{"start_line":164,"start_character":22,"end_line":164,"end_character":32},"updated":"2016-05-13 10:22:57.000000000","message":"as above","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"Normal response codes: 200"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Error response codes: badRequest(400), unauthorized(401), forbidden(403)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Request"},{"line_number":225,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_631b661d","line":222,"range":{"start_line":222,"start_character":22,"end_line":222,"end_character":32},"updated":"2016-05-13 10:22:57.000000000","message":"as above","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"Normal response codes: 200"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Error response codes: badRequest(400), unauthorized(401),"},{"line_number":249,"context_line":"forbidden(403), itemNotFound(404)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_43dd8241","line":248,"range":{"start_line":248,"start_character":22,"end_line":248,"end_character":32},"updated":"2016-05-13 10:22:57.000000000","message":"as above","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":"Normal response codes: 202"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"Error response codes: badRequest(400), unauthorized(401),"},{"line_number":279,"context_line":"forbidden(403), itemNotFound(404)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Request"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_c3f172cf","line":278,"range":{"start_line":278,"start_character":22,"end_line":278,"end_character":32},"updated":"2016-05-13 10:22:57.000000000","message":"as above","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eddaea31ce771282ef9a1c31851f9a4ee0e07aad","unresolved":false,"context_lines":[{"line_number":276,"context_line":"Normal response codes: 202"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"Error response codes: badRequest(400), unauthorized(401),"},{"line_number":279,"context_line":"forbidden(403), itemNotFound(404)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"Request"},{"line_number":282,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"dab17558_e3bc76dd","line":279,"range":{"start_line":279,"start_character":16,"end_line":279,"end_character":28},"updated":"2016-05-13 10:22:57.000000000","message":"so 404 should be possible, looks like the code is broken right now, but I will ignore that.","commit_id":"030c2bb23ec101953659e18a224e33e7208a7cb8"}]}