)]}'
{"nova/crypto.py":[{"author":{"_account_id":11069,"name":"Corey Wright","email":"undefined+launchpad@pobox.com","username":"coreywright"},"change_message_id":"f6018f019f897cbe00dfa79fb9d4cc57d5c99049","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def generate_key_pair(bits\u003d2048):"},{"line_number":137,"context_line":"    key \u003d generate_key(bits)"},{"line_number":138,"context_line":"    keyout \u003d six.StringIO()"},{"line_number":139,"context_line":"    key.write_private_key(keyout)"},{"line_number":140,"context_line":"    private_key \u003d keyout.getvalue()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6c8bf7c3","line":137,"updated":"2016-05-10 15:49:04.000000000","message":"is there any reason to maintain this indirection with paramiko 2.x (as generate_keys() simply calls paramiko.RSAKey.generate())?\n\ni recommend we remove the indirection which, i believe, only requires a small change to a test\u0027s mock (introduced by the original pycrypto/pycryptodome work-around; see https://review.openstack.org/#/c/279909/1/nova/tests/unit/test_crypto.py).","commit_id":"fd9d93b1a453a53b5ed141fa0e78d1c44351b6b1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"2b621f000f2c3037b93639c6947d258cdbb9dfc0","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def generate_key_pair(bits\u003d2048):"},{"line_number":137,"context_line":"    key \u003d generate_key(bits)"},{"line_number":138,"context_line":"    keyout \u003d six.StringIO()"},{"line_number":139,"context_line":"    key.write_private_key(keyout)"},{"line_number":140,"context_line":"    private_key \u003d keyout.getvalue()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a995cc33","line":137,"in_reply_to":"dab17558_6c8bf7c3","updated":"2016-05-10 16:44:42.000000000","message":"sounds good to me, you want to take over the patch and do that?","commit_id":"fd9d93b1a453a53b5ed141fa0e78d1c44351b6b1"}]}