)]}'
{"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"a16c3b836f2444171968ac144afb235ba3af5f44","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        self.mox.ReplayAll()"},{"line_number":1060,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":1061,"context_line":"        instances \u003d conn.list_instance_uuids()"},{"line_number":1062,"context_line":"        # Only one should be listed, since domain with ID 0 must be skiped"},{"line_number":1063,"context_line":"        self.assertEquals(len(instances), 1)"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def test_list_defined_instances(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F8h4%3D","line":1062,"updated":"2013-06-05 15:08:15.000000000","message":"s/skiped/skipped/","commit_id":"dc428eb7a8bc048999b1ec918a958aca768b4664"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a6cad848618bc03a4bd7aea5ce3587801d5280b4","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"        self.mox.ReplayAll()"},{"line_number":1060,"context_line":"        conn \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":1061,"context_line":"        instances \u003d conn.list_instance_uuids()"},{"line_number":1062,"context_line":"        # Only one should be listed, since domain with ID 0 must be skiped"},{"line_number":1063,"context_line":"        self.assertEquals(len(instances), 1)"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def test_list_defined_instances(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F0K4%3D","line":1062,"in_reply_to":"AAAAPX%2F%2F8h4%3D","updated":"2013-06-09 12:39:56.000000000","message":"Done","commit_id":"dc428eb7a8bc048999b1ec918a958aca768b4664"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"3ee49d35973f6229467d7169d6d05229d0c41219","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def list_instance_uuids(self):"},{"line_number":687,"context_line":"        uuids \u003d set()"},{"line_number":688,"context_line":"        for domain_id in self.list_instance_ids():"},{"line_number":689,"context_line":"            try:"},{"line_number":690,"context_line":"                # We skip domains with ID 0 (hypervisors)."},{"line_number":691,"context_line":"                if domain_id !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FuE%3D","line":688,"updated":"2013-06-04 08:07:54.000000000","message":"There\u0027s a TODO on list_instance_ids() above that says to remove it when a certain bug is fixed.  It seems like adding another call to it here is not ideal if we plan to remove it?","commit_id":"c93c8daba1b19df4ba1cdbac2568aa5c6b261389"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1904aad088ace277d1765f487cbd26b984754c93","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def list_instance_uuids(self):"},{"line_number":687,"context_line":"        uuids \u003d set()"},{"line_number":688,"context_line":"        for domain_id in self.list_instance_ids():"},{"line_number":689,"context_line":"            try:"},{"line_number":690,"context_line":"                # We skip domains with ID 0 (hypervisors)."},{"line_number":691,"context_line":"                if domain_id !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2Fos%3D","line":688,"in_reply_to":"AAAAPX%2F%2F%2FuE%3D","updated":"2013-06-04 08:44:59.000000000","message":"I think adding this usage is ok - it will be trivial to replace this call, if we ever get around to removing that method.","commit_id":"c93c8daba1b19df4ba1cdbac2568aa5c6b261389"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"a16c3b836f2444171968ac144afb235ba3af5f44","unresolved":false,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        return names"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def list_instance_uuids(self):"},{"line_number":687,"context_line":"        uuids \u003d set()"},{"line_number":688,"context_line":"        for domain_id in self.list_instance_ids():"},{"line_number":689,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F8iQ%3D","line":686,"updated":"2013-06-05 15:08:15.000000000","message":"Maybe this should have a docstring that specifies that it returns a set, since \"list\" in the method name sort of implies that it returns a list.","commit_id":"dc428eb7a8bc048999b1ec918a958aca768b4664"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"a6cad848618bc03a4bd7aea5ce3587801d5280b4","unresolved":false,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        return names"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def list_instance_uuids(self):"},{"line_number":687,"context_line":"        uuids \u003d set()"},{"line_number":688,"context_line":"        for domain_id in self.list_instance_ids():"},{"line_number":689,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F0KY%3D","line":686,"in_reply_to":"AAAAPX%2F%2F8iQ%3D","updated":"2013-06-09 12:39:56.000000000","message":"Or maybe it better to convert to list before returning.","commit_id":"dc428eb7a8bc048999b1ec918a958aca768b4664"}]}