)]}'
{"api-ref/ext/rest_parameters.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ba248e8c720d61a8b91ecc0deded2b0f492dca7","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    headers \u003d [\"Name\", \"In\", \"Type\", \"Description\"]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def load_param_file(self, fpath):"},{"line_number":141,"context_line":"        global YAML_CACHE"},{"line_number":142,"context_line":"        if fpath in YAML_CACHE:"},{"line_number":143,"context_line":"            return YAML_CACHE[fpath]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_fc4ff067","line":140,"updated":"2016-05-13 12:28:40.000000000","message":"Nit: maybe this should be _load_param_file?","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3143a0e9bee4d646b50b99c9c6b330b30b3e932e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    headers \u003d [\"Name\", \"In\", \"Type\", \"Description\"]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def load_param_file(self, fpath):"},{"line_number":141,"context_line":"        global YAML_CACHE"},{"line_number":142,"context_line":"        if fpath in YAML_CACHE:"},{"line_number":143,"context_line":"            return YAML_CACHE[fpath]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_7c84a0b0","line":140,"in_reply_to":"dab17558_fc4ff067","updated":"2016-05-13 12:33:58.000000000","message":"Done","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ba248e8c720d61a8b91ecc0deded2b0f492dca7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            with open(fpath, \u0027r\u0027) as stream:"},{"line_number":148,"context_line":"                lookup \u003d ordered_load(stream)"},{"line_number":149,"context_line":"                self._check_yaml_sorting(fpath, lookup)"},{"line_number":150,"context_line":"                # print lookup"},{"line_number":151,"context_line":"        except IOError:"},{"line_number":152,"context_line":"            self.env.warn("},{"line_number":153,"context_line":"                self.env.docname,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_01340df9","line":150,"range":{"start_line":150,"start_character":16,"end_line":150,"end_character":30},"updated":"2016-05-13 12:28:40.000000000","message":"Nit: did you mean to keep that here?","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3143a0e9bee4d646b50b99c9c6b330b30b3e932e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            with open(fpath, \u0027r\u0027) as stream:"},{"line_number":148,"context_line":"                lookup \u003d ordered_load(stream)"},{"line_number":149,"context_line":"                self._check_yaml_sorting(fpath, lookup)"},{"line_number":150,"context_line":"                # print lookup"},{"line_number":151,"context_line":"        except IOError:"},{"line_number":152,"context_line":"            self.env.warn("},{"line_number":153,"context_line":"                self.env.docname,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_3ca2184c","line":150,"range":{"start_line":150,"start_character":16,"end_line":150,"end_character":30},"in_reply_to":"dab17558_01340df9","updated":"2016-05-13 12:33:58.000000000","message":"Done","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ba248e8c720d61a8b91ecc0deded2b0f492dca7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def _check_yaml_sorting(self, fpath, yaml_data):"},{"line_number":164,"context_line":"        \"\"\"check yaml sorting"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        Assuming we got an ordered dict, we"},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        sections \u003d {\"header\": 1, \"path\": 2, \"query\": 3, \"body\": 4}"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e106291f","line":166,"range":{"start_line":166,"start_character":41,"end_line":166,"end_character":43},"updated":"2016-05-13 12:28:40.000000000","message":"nit: I think you were half way through something here?","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3143a0e9bee4d646b50b99c9c6b330b30b3e932e","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def _check_yaml_sorting(self, fpath, yaml_data):"},{"line_number":164,"context_line":"        \"\"\"check yaml sorting"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        Assuming we got an ordered dict, we"},{"line_number":167,"context_line":"        \"\"\""},{"line_number":168,"context_line":"        sections \u003d {\"header\": 1, \"path\": 2, \"query\": 3, \"body\": 4}"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_fc97f0e8","line":166,"range":{"start_line":166,"start_character":41,"end_line":166,"end_character":43},"in_reply_to":"dab17558_e106291f","updated":"2016-05-13 12:33:58.000000000","message":"Done","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4ba248e8c720d61a8b91ecc0deded2b0f492dca7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            # ensure that sections only go up"},{"line_number":176,"context_line":"            current_section \u003d value[\u0027in\u0027]"},{"line_number":177,"context_line":"            last_section \u003d last[1][\u0027in\u0027]"},{"line_number":178,"context_line":"            if sections[current_section] \u003c sections[last_section]:"},{"line_number":179,"context_line":"                self.app.info("},{"line_number":180,"context_line":"                    \"Section out of order. All parameters in section ``%s`` \""},{"line_number":181,"context_line":"                    \"should be after section ``%s``. (see ``%s``)\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5cca7ca2","line":178,"updated":"2016-05-13 12:28:40.000000000","message":"Nit: Did you want to check if the current_section is in sections, to avoid a key error?","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3143a0e9bee4d646b50b99c9c6b330b30b3e932e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            # ensure that sections only go up"},{"line_number":176,"context_line":"            current_section \u003d value[\u0027in\u0027]"},{"line_number":177,"context_line":"            last_section \u003d last[1][\u0027in\u0027]"},{"line_number":178,"context_line":"            if sections[current_section] \u003c sections[last_section]:"},{"line_number":179,"context_line":"                self.app.info("},{"line_number":180,"context_line":"                    \"Section out of order. All parameters in section ``%s`` \""},{"line_number":181,"context_line":"                    \"should be after section ``%s``. (see ``%s``)\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_bcf72858","line":178,"in_reply_to":"dab17558_5cca7ca2","updated":"2016-05-13 12:33:58.000000000","message":"I think the fatal error is probably ok at this point.","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4a24c42b7e7e6a39f215844a07267b37f4b84eb1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            # ensure that sections only go up"},{"line_number":176,"context_line":"            current_section \u003d value[\u0027in\u0027]"},{"line_number":177,"context_line":"            last_section \u003d last[1][\u0027in\u0027]"},{"line_number":178,"context_line":"            if sections[current_section] \u003c sections[last_section]:"},{"line_number":179,"context_line":"                self.app.info("},{"line_number":180,"context_line":"                    \"Section out of order. All parameters in section ``%s`` \""},{"line_number":181,"context_line":"                    \"should be after section ``%s``. (see ``%s``)\" % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_37b7d3f6","line":178,"in_reply_to":"dab17558_bcf72858","updated":"2016-05-13 12:42:35.000000000","message":"yeah, true.","commit_id":"cbaa2d971a171fb53131f313c946d860d81f4912"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"77bd212529445fee5c7300db49c38f399f5338f2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                        last_section,"},{"line_number":188,"context_line":"                        current_section,"},{"line_number":189,"context_line":"                        last[0]))"},{"line_number":190,"context_line":"            if (sections[value[\u0027in\u0027]] \u003d\u003d sections[last[1][\u0027in\u0027]] and"},{"line_number":191,"context_line":"                key.lower() \u003c last[0].lower()):"},{"line_number":192,"context_line":"                self.app.info("},{"line_number":193,"context_line":"                    \"Parameters out of order ``%s`` should be after ``%s``\" % ("}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_7d76593f","line":190,"range":{"start_line":190,"start_character":12,"end_line":190,"end_character":14},"updated":"2016-05-13 13:40:15.000000000","message":"elif?","commit_id":"1f67ab311422234335cda0e21e74186524617904"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1cc5553587c1373a63c0eaea8133fd7e1512c3ab","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                        last_section,"},{"line_number":188,"context_line":"                        current_section,"},{"line_number":189,"context_line":"                        last[0]))"},{"line_number":190,"context_line":"            if (sections[value[\u0027in\u0027]] \u003d\u003d sections[last[1][\u0027in\u0027]] and"},{"line_number":191,"context_line":"                key.lower() \u003c last[0].lower()):"},{"line_number":192,"context_line":"                self.app.info("},{"line_number":193,"context_line":"                    \"Parameters out of order ``%s`` should be after ``%s``\" % ("}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_d9a030a8","line":190,"range":{"start_line":190,"start_character":12,"end_line":190,"end_character":14},"in_reply_to":"dab17558_7d76593f","updated":"2016-05-13 16:08:37.000000000","message":"it could be, but the conditionals map fine as is as well","commit_id":"1f67ab311422234335cda0e21e74186524617904"}]}