)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d5a7d9f2e74b4d10cef13ba89a119e894b81cfab","unresolved":false,"context_lines":[{"line_number":11,"context_line":"routines for use later). As such, this removes the zeroing behavior of the"},{"line_number":12,"context_line":"ComputeNode legacy resource fields as well, since we can no longer do a"},{"line_number":13,"context_line":"join of the compute_nodes and inventory tables. Thus, we continue to"},{"line_number":14,"context_line":"update both the legacy compute node table columns and the inventory"},{"line_number":15,"context_line":"information in the API database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related to blueprint generic-resource-pools"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"bab6814e_048cff7d","line":15,"range":{"start_line":14,"start_character":50,"end_line":15,"end_character":32},"updated":"2016-05-25 13:34:28.000000000","message":"that\u0027s not true yet with that patch, right? I mean, we\u0027re neither creating nor updating the inventories yet, but within the next change... That\u0027s a nit tho...","commit_id":"dac078b9a914d66407a0460621ece27b796d6907"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1b4498bc0710932eb9c2b43dd09cf4a03157d555","unresolved":false,"context_lines":[{"line_number":11,"context_line":"routines for use later). As such, this removes the zeroing behavior of the"},{"line_number":12,"context_line":"ComputeNode legacy resource fields as well, since we can no longer do a"},{"line_number":13,"context_line":"join of the compute_nodes and inventory tables. Thus, we continue to"},{"line_number":14,"context_line":"update both the legacy compute node table columns and the inventory"},{"line_number":15,"context_line":"information in the API database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related to blueprint generic-resource-pools"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"bab6814e_04a99f7b","line":15,"range":{"start_line":14,"start_character":50,"end_line":15,"end_character":32},"in_reply_to":"bab6814e_048cff7d","updated":"2016-05-25 13:39:04.000000000","message":"Yeah, I split that one from this one. I can revise this if I have to rebase.","commit_id":"dac078b9a914d66407a0460621ece27b796d6907"}],"nova/objects/compute_node.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"fe833edeeae3738940fe87efecf8a01e7781fd71","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        self._convert_pci_stats_to_db_format(updates)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if self._should_manage_inventory():"},{"line_number":422,"context_line":"            self._create_inventory(updates)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        db_compute \u003d db.compute_node_create(self._context, updates)"},{"line_number":425,"context_line":"        # NOTE(danms): compute_node_create() operates on (and returns) the"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_ac5ca37d","side":"PARENT","line":422,"updated":"2016-05-21 20:04:00.000000000","message":"I presume that a future patch (from me I think...) should have the resource tracker setting the Inventory records appropriately in Newton by manually calling something like nova.objects.ResourceProvider.update_inventory() or similar. Please verify that is also your understanding.","commit_id":"007a3a35413e549442644c60e1a62d9fdda382e5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"854e7d532cbf299ffaa7e9a7f315754b557c16b2","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        self._convert_pci_stats_to_db_format(updates)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if self._should_manage_inventory():"},{"line_number":422,"context_line":"            self._create_inventory(updates)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        db_compute \u003d db.compute_node_create(self._context, updates)"},{"line_number":425,"context_line":"        # NOTE(danms): compute_node_create() operates on (and returns) the"}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_ec522b66","side":"PARENT","line":422,"updated":"2016-05-21 20:04:53.000000000","message":"Never mind, you\u0027re doing just that on the next patch :)","commit_id":"007a3a35413e549442644c60e1a62d9fdda382e5"},{"author":{"_account_id":15648,"name":"Yingxin","email":"yingxin.cheng@intel.com","username":"Yingxin"},"change_message_id":"c9b007584f0cee435c3a435e91a7df441396f20a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                pools \u003d jsonutils.dumps(pools.obj_to_primitive())"},{"line_number":298,"context_line":"            updates[\u0027pci_stats\u0027] \u003d pools"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    def _should_manage_inventory(self):"},{"line_number":301,"context_line":"        related_binaries \u003d [\u0027nova-api\u0027, \u0027nova-conductor\u0027, \u0027nova-scheduler\u0027]"},{"line_number":302,"context_line":"        required_version \u003d 10"},{"line_number":303,"context_line":"        min_ver \u003d objects.Service.get_minimum_version_multi(self._context,"},{"line_number":304,"context_line":"                                                            related_binaries)"},{"line_number":305,"context_line":"        return min_ver \u003e\u003d required_version and self.memory_mb !\u003d 0"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def update_inventory(self):"},{"line_number":308,"context_line":"        \"\"\"Update inventory records from legacy model values.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"bab6814e_5ff154cc","line":305,"range":{"start_line":300,"start_character":4,"end_line":305,"end_character":66},"updated":"2016-05-22 06:54:56.000000000","message":"Suppose this method should be removed.","commit_id":"4f984b5f0856795441584d0f49b5810057cda7f9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b0ca5bfc4423100462501392abc297e03847471a","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"            if key in self.obj_what_changed():"},{"line_number":322,"context_line":"                inventory.total \u003d getattr(self, key)"},{"line_number":323,"context_line":"                inventory.save()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        return True"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_eebda6d8","line":323,"updated":"2016-05-24 10:32:50.000000000","message":"do we need a migration for the existing stored inventories or, as I suppose, are we assuming that the above will just recreate the entries in the API DB synchronously ?","commit_id":"dac078b9a914d66407a0460621ece27b796d6907"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e03c8efbfa70f33b20f693e115f7b42905699b11","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"            if key in self.obj_what_changed():"},{"line_number":322,"context_line":"                inventory.total \u003d getattr(self, key)"},{"line_number":323,"context_line":"                inventory.save()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        return True"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_e141ed3a","line":323,"in_reply_to":"bab6814e_d3e670e7","updated":"2016-05-25 13:19:26.000000000","message":"Okay then...","commit_id":"dac078b9a914d66407a0460621ece27b796d6907"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5c59475cfd0580a039a694a8c2acb628360c466f","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":"            if key in self.obj_what_changed():"},{"line_number":322,"context_line":"                inventory.total \u003d getattr(self, key)"},{"line_number":323,"context_line":"                inventory.save()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        return True"},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"bab6814e_d3e670e7","line":323,"in_reply_to":"bab6814e_eebda6d8","updated":"2016-05-24 16:22:43.000000000","message":"We don\u0027t because the compute nodes will just create the inventories as soon as they run their next resource update. The inventories we have been creating (for a couple weeks) in the old database were never needed/used so no point in migrating them.","commit_id":"dac078b9a914d66407a0460621ece27b796d6907"}]}