)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"f6ac3c95d064d289366399a67748e720def00b3c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        info \u003d self.conn.get_info({\u0027uuid\u0027: \u0027fake-uuid\u0027})"},{"line_number":213,"context_line":"        self._check_vm_info(info, power_state.RUNNING)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def test_snapshot(self):"},{"line_number":216,"context_line":"        expected_calls \u003d ["},{"line_number":217,"context_line":"            {\u0027args\u0027: (),"},{"line_number":218,"context_line":"             \u0027kwargs\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2F2v8%3D","line":215,"updated":"2013-06-07 13:35:49.000000000","message":"I would like to see a test where the lookup by uuid fails and the code falls back to lookup by name, so that we go through all the code paths you changed.","commit_id":"51d465c3d89b57a292e0e347171339202ca8b04c"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f1b22a5af631c4044438820761a7d92c895b48af","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    for vm in vms:"},{"line_number":507,"context_line":"        if vm.propSet[0].val \u003d\u003d instance_uuid:"},{"line_number":508,"context_line":"            return vm.obj"},{"line_number":509,"context_line":"    return None"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"def get_cluster_ref_from_name(session, cluster_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F9x8%3D","line":509,"updated":"2013-06-05 00:43:05.000000000","message":"unneeded","commit_id":"bbaab6e69a1bbd9a151ad470bdc43aa7b32222bc"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"f8283e70093ec823d2acf141fcb201008b6336d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       vif_infos, os_type\u003d\"otherGuest\"):"},{"line_number":48,"context_line":"    \"\"\"Builds the VM Create spec.\"\"\""},{"line_number":49,"context_line":"    config_spec \u003d client_factory.create(\u0027ns0:VirtualMachineConfigSpec\u0027)"},{"line_number":50,"context_line":"    config_spec.name \u003d instance[\u0027uuid\u0027]"},{"line_number":51,"context_line":"    config_spec.guestId \u003d os_type"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    vm_file_info \u003d client_factory.create(\u0027ns0:VirtualMachineFileInfo\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2FuJ4%3D","line":50,"updated":"2013-06-11 23:13:32.000000000","message":"Okay, I see. This does change the instance name. This is good then.","commit_id":"5dfe899cf2c0639bf04060404bbf1b1ed2a58b10"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f1b22a5af631c4044438820761a7d92c895b48af","unresolved":false,"context_lines":[{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"    def get_info(self, instance):"},{"line_number":1098,"context_line":"        \"\"\"Return data about the VM instance.\"\"\""},{"line_number":1099,"context_line":"        print \"*\" * 50"},{"line_number":1100,"context_line":"        print instance"},{"line_number":1101,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":1102,"context_line":"        if vm_ref is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2F9x4%3D","line":1099,"updated":"2013-06-05 00:43:05.000000000","message":"whoops","commit_id":"bbaab6e69a1bbd9a151ad470bdc43aa7b32222bc"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"0f98e4fb0a3e945660d37436939c85815d64c24f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            LOG.debug(_(\"Created VM on the ESX host\"), instance\u003dinstance)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        _execute_create_vm()"},{"line_number":206,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":207,"context_line":"        if not vm_ref:"},{"line_number":208,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session,"},{"line_number":209,"context_line":"                                                 instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F7iA%3D","line":206,"updated":"2013-06-05 20:15:05.000000000","message":"Is falling back from uuid to name safe?","commit_id":"e248ba8fffd83d156c6b797c007160d32ade7db7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8d228567f87cd7e52f2591273cafcb7f5ad91c1a","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":768,"context_line":"        if vm_ref is None:"},{"line_number":769,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session,"},{"line_number":770,"context_line":"                                                instance[\u0027name\u0027])"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        if vm_ref is None:"},{"line_number":773,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F3eQ%3D","line":770,"updated":"2013-06-07 03:56:05.000000000","message":"nit: it would be nice if the parms for the lines you chanced lined up like it does on 681","commit_id":"907af9e1cf265e029374e6f694f271217480aba5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8d228567f87cd7e52f2591273cafcb7f5ad91c1a","unresolved":false,"context_lines":[{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def get_info(self, instance):"},{"line_number":1100,"context_line":"        \"\"\"Return data about the VM instance.\"\"\""},{"line_number":1101,"context_line":"        print \"*\" * 50"},{"line_number":1102,"context_line":"        print instance"},{"line_number":1103,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":1104,"context_line":"        if vm_ref is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2F3eM%3D","line":1101,"updated":"2013-06-07 03:56:05.000000000","message":"whoops","commit_id":"907af9e1cf265e029374e6f694f271217480aba5"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"e2d17df05ed1008b973608b22492860a57526432","unresolved":false,"context_lines":[{"line_number":943,"context_line":"                                       step\u003d0,"},{"line_number":944,"context_line":"                                       total_steps\u003dRESIZE_TOTAL_STEPS)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":947,"context_line":"        if vm_ref is None:"},{"line_number":948,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session,"},{"line_number":949,"context_line":"                instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2FuJQ%3D","line":946,"updated":"2013-06-11 23:16:32.000000000","message":"This is a lot of repetition. Couldn\u0027t you do a single method get_vm_ref_for_instance(self._session, instance)","commit_id":"5dfe899cf2c0639bf04060404bbf1b1ed2a58b10"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"94b5c69a998ae0cb364f8e0cf80c3d58d341092c","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"        vm_ref \u003d vm_util.get_vm_ref_from_uuid(self._session, instance[\u0027uuid\u0027])"},{"line_number":1243,"context_line":"        if vm_ref is None:"},{"line_number":1244,"context_line":"            vm_ref \u003d vm_util.get_vm_ref_from_name(self._session,"},{"line_number":1245,"context_line":"                                                instance[\u0027name\u0027])"},{"line_number":1246,"context_line":""},{"line_number":1247,"context_line":"        if vm_ref is None:"},{"line_number":1248,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2Fwzw%3D","line":1245,"updated":"2013-06-11 05:05:40.000000000","message":"i wish all these aligned :/","commit_id":"5dfe899cf2c0639bf04060404bbf1b1ed2a58b10"}]}
