)]}'
{"nova/conf/glance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                     \u0027via the direct_url.  Currently supported schemes: \u0027"},{"line_number":43,"context_line":"                     \u0027[file].\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":45,"context_line":"               default\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_39d4c545","line":45,"updated":"2016-05-19 17:31:57.000000000","message":"nit: alignment","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                     \u0027[file].\u0027),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":45,"context_line":"               default\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Require Nova to perform signature verification on \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b9e39504","line":46,"updated":"2016-05-19 17:31:57.000000000","message":"If we\u0027re adding a new option, it would be good to follow the new config option help text template we\u0027ve been using:\n\nhttp://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/centralize-config-options.html#quality-view\n\nYou can see it used elsewhere, e.g.:\n\nhttps://github.com/openstack/nova/blob/2811ff43aff053583ac8ed4bdbea5e3f6b244acf/nova/conf/compute.py#L289-L310\n\nI won\u0027t -1 over this however since it should be a short-lived config option. But it would be good I think to note that we don\u0027t yet support glance v2, unless we really just wait to land this change, and the entire series, until we see it all working with the top-level job that disables glance v1 and sets this option to False.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"972d9f73c78a349d597c7883d82b2ca7c219232e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    None"},{"line_number":65,"context_line":"\"\"\"),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":67,"context_line":"                default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d\u0027Require Nova to perform signature verification on \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_1cfd8f3b","line":65,"updated":"2016-06-03 11:18:47.000000000","message":"I think we agreed to introduce this as deprecated off the bat to signal that this is going away as soon as we get everything wired up.\n\nLet\u0027s do that in this patch.","commit_id":"7cc097b5d7df817a6937dd5e8001253c42350288"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62bc3b534dd89b3cadc608074521e84ba9274cee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    None"},{"line_number":65,"context_line":"\"\"\"),"},{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":67,"context_line":"                default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d\u0027Require Nova to perform signature verification on \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_e5cf4bb1","line":65,"in_reply_to":"9abb7d3a_1cfd8f3b","updated":"2016-06-03 13:30:47.000000000","message":"I know that\u0027s what we said at the summit, but it seems odd to make it deprecated at the bottom of the series since there isn\u0027t a working alternative if you get this doing CD and think, I don\u0027t want to be using deprecated options, so I\u0027ll set it to False (and I know I already have glance v2 available in my deployment).\n\nSo I was thinking we\u0027d introduce the option and then deprecate it at the end of the series.\n\nUltimately it\u0027s probably fine either way - if it\u0027s not deprecated now, there isn\u0027t a working alternative if you set it to False, it\u0027ll just fail, so we\u0027re shipping it as broken.\n\n--\n\nOr we just -2 this bottom change as a pin and then lift it when the series is all ready to go and we\u0027ve tested it with the v2-only job at the top change.","commit_id":"7cc097b5d7df817a6937dd5e8001253c42350288"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d73c2af26bed2ba7d65dba2838ca1f43b5cd098","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Services that use this:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ``nova-api``"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_b8060683","line":60,"updated":"2016-06-03 13:44:40.000000000","message":"I\u0027m pretty sure that this is also used in nova-compute, I\u0027m checking.","commit_id":"139df04d30fd0a9992e571193e57e67e2c89b7c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c749b5ce42ac6e41b4d5a38e3902f2763500c587","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Services that use this:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ``nova-api``"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_fb7ec868","line":60,"in_reply_to":"9abb7d3a_18d112ce","updated":"2016-06-03 13:49:11.000000000","message":"Also nova-conductor:\n\nhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L152","commit_id":"139df04d30fd0a9992e571193e57e67e2c89b7c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bb55e3a388bf4894943937578ca5ec2f17f66d5","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Services that use this:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    ``nova-api``"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_18d112ce","line":60,"in_reply_to":"9abb7d3a_b8060683","updated":"2016-06-03 13:45:54.000000000","message":"Yeah, see image_api usage in the compute manager:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py","commit_id":"139df04d30fd0a9992e571193e57e67e2c89b7c1"}],"nova/image/glance.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"cc23d86f9fe0d39e0e2e9dd76886dc86dd50e0ca","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from oslo_config import cfg"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ac736db3","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":15},"updated":"2016-05-13 14:54:57.000000000","message":"May be add this here: https://github.com/openstack/nova/blob/master/nova/conf/glance.py ?","commit_id":"90b7e4e5253ee58948949d7bd2c04342e4adee3c"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"85c4c50ae08cda82ef4b52aab038f8a4a4da8938","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from oslo_config import cfg"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4da1ecf7","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":15},"in_reply_to":"dab17558_ac736db3","updated":"2016-05-16 06:36:48.000000000","message":"Nikhil, could you specify the line number in that link that you would like to be added?","commit_id":"90b7e4e5253ee58948949d7bd2c04342e4adee3c"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"73100cf477b8ea2e93bd648e124a049de8953b67","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ebaa5618","line":50,"updated":"2016-05-15 11:42:53.000000000","message":"What\u0027s the point of making it Str? It is a Bool param.","commit_id":"90b7e4e5253ee58948949d7bd2c04342e4adee3c"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"85c4c50ae08cda82ef4b52aab038f8a4a4da8938","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_cdaddcea","line":50,"in_reply_to":"dab17558_ebaa5618","updated":"2016-05-16 06:36:48.000000000","message":"Good catch Mike. It was one of those silly copy-paste errors :(","commit_id":"90b7e4e5253ee58948949d7bd2c04342e4adee3c"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"ed30711c6dd4e8337f0f28bde29ed2801048ba19","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_1c5cab24","line":51,"updated":"2016-05-18 10:50:31.000000000","message":"It\u0027s Bool opt. \u0027True\u0027 is a string.","commit_id":"e336ef6e87c9032f8ebbd73d908a7a5a0b1c204d"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"67d28519fa420b344624ad4712710e4bcf9d296d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_0cbbdac5","line":51,"in_reply_to":"bab6814e_1c5cab24","updated":"2016-05-18 11:40:35.000000000","message":"Done","commit_id":"e336ef6e87c9032f8ebbd73d908a7a5a0b1c204d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3a13e1a170de75544aa34bff232fcdaed90d4b0a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9cc53b5d","line":51,"in_reply_to":"bab6814e_1c5cab24","updated":"2016-05-18 10:53:37.000000000","message":"We also want this coming in as a deprecated option so we are free to remove it early.","commit_id":"e336ef6e87c9032f8ebbd73d908a7a5a0b1c204d"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"67d28519fa420b344624ad4712710e4bcf9d296d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"client_ver_opts \u003d ["},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027True\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Determines the default glance client version to use\u0027),"},{"line_number":53,"context_line":"           ]"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_2cb69edc","line":51,"in_reply_to":"bab6814e_9cc53b5d","updated":"2016-05-18 11:40:35.000000000","message":"Done","commit_id":"e336ef6e87c9032f8ebbd73d908a7a5a0b1c204d"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"4b0dd51cb3a80173a4803772a10251a8d87b6b2a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import objects"},{"line_number":45,"context_line":"from nova import signature_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_786e8aca","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":0},"updated":"2016-05-18 17:14:05.000000000","message":"Please remove the unnecessary line breaks.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import objects"},{"line_number":45,"context_line":"from nova import signature_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_39be85d4","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":0},"in_reply_to":"bab6814e_786e8aca","updated":"2016-05-19 17:31:57.000000000","message":"+1","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"supported_glance_versions \u003d (1, 2)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def generate_glance_url():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b99f154f","line":51,"updated":"2016-05-19 17:31:57.000000000","message":"Do we still need this? It\u0027s used for version discovery, but with a config option now we are hard-coding the glance API version to use, so it seems we shouldn\u0027t have to care about version discovery.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"6f50a6693bc50a27edf8df9b34f5dcc6a8429eda","unresolved":false,"context_lines":[{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"supported_glance_versions \u003d (1, 2)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def generate_glance_url():"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_762e3d44","line":51,"in_reply_to":"bab6814e_b99f154f","updated":"2016-05-20 07:18:09.000000000","message":"Hi Matt, I have another patch that completely reverts the glance discovery code. That patch removes this as well. You can find it here: https://review.openstack.org/#/c/315968/","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return glanceclient.Client(str(version), endpoint, **params)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def _determine_curr_major_version(endpoint):"},{"line_number":109,"context_line":"    \"\"\"Determines the current major version of the glance API in use"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    :returns Integer version number or None if unable to determine version"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_79ebedb0","line":108,"updated":"2016-05-19 17:31:57.000000000","message":"If this isn\u0027t used, let\u0027s remove it.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"6f50a6693bc50a27edf8df9b34f5dcc6a8429eda","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        return glanceclient.Client(str(version), endpoint, **params)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def _determine_curr_major_version(endpoint):"},{"line_number":109,"context_line":"    \"\"\"Determines the current major version of the glance API in use"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    :returns Integer version number or None if unable to determine version"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b6242560","line":108,"in_reply_to":"bab6814e_79ebedb0","updated":"2016-05-20 07:18:09.000000000","message":"https://review.openstack.org/#/c/315968/ same place where the entire patchset was reverted.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":21239,"name":"Alex Szarka","email":"szarka@inf.u-szeged.hu","username":"xavvior"},"change_message_id":"4b0dd51cb3a80173a4803772a10251a8d87b6b2a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\"Glance client wrapper class that implements retries.\"\"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def __init__(self, context\u003dNone, endpoint\u003dNone, version\u003d1):"},{"line_number":152,"context_line":"        if not CONF.glance.use_glance_v1:"},{"line_number":153,"context_line":"            version \u003d 2"},{"line_number":154,"context_line":"        if endpoint is not None:"},{"line_number":155,"context_line":"            self.client \u003d self._create_static_client(context,"},{"line_number":156,"context_line":"                                                     endpoint,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_41bc7205","line":153,"range":{"start_line":152,"start_character":8,"end_line":153,"end_character":23},"updated":"2016-05-18 17:14:05.000000000","message":"In conf/glance.py said: \"Determines the default glance client version to use\", but here constrain the version 2, if the use_glance_v1 is false. (Independently from version parameter)\nI think, this not nice.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"56e3e71bcde91868671e1aefa7a8005bee37ce34","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\"Glance client wrapper class that implements retries.\"\"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def __init__(self, context\u003dNone, endpoint\u003dNone, version\u003d1):"},{"line_number":152,"context_line":"        if not CONF.glance.use_glance_v1:"},{"line_number":153,"context_line":"            version \u003d 2"},{"line_number":154,"context_line":"        if endpoint is not None:"},{"line_number":155,"context_line":"            self.client \u003d self._create_static_client(context,"},{"line_number":156,"context_line":"                                                     endpoint,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_99e851b6","line":153,"range":{"start_line":152,"start_character":8,"end_line":153,"end_character":23},"in_reply_to":"bab6814e_41bc7205","updated":"2016-05-19 17:31:57.000000000","message":"So maybe drop the version\u003d1 kwarg here. There are really probably only two things that set this:\n\n1. Nothing, it\u0027s the default and really the only thing we support for the most part.\n\n2. The version discovery code in _determine_curr_major_version.\n\nAnd we could use the config option for both now.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"b49ac800aa091cab02edff960e0b53d4bbb505dd","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\"Glance client wrapper class that implements retries.\"\"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def __init__(self, context\u003dNone, endpoint\u003dNone, version\u003d1):"},{"line_number":152,"context_line":"        if not CONF.glance.use_glance_v1:"},{"line_number":153,"context_line":"            version \u003d 2"},{"line_number":154,"context_line":"        if endpoint is not None:"},{"line_number":155,"context_line":"            self.client \u003d self._create_static_client(context,"},{"line_number":156,"context_line":"                                                     endpoint,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_f2a23698","line":153,"range":{"start_line":152,"start_character":8,"end_line":153,"end_character":23},"in_reply_to":"bab6814e_76f0fd67","updated":"2016-05-20 08:27:17.000000000","message":"I think i understand it now, i guess the comments are around the dis-ambiguity of using this CONF parameter?\n\nSomething like \n\nif CONF.glance.use_glance_v1:\n     version \u003d 1\n\nWould create a problem here: https://github.com/openstack/nova/blob/2811ff43aff053583ac8ed4bdbea5e3f6b244acf/nova/image/glance.py#L268\n\nAbove is very ugly way of flipping the version.\nI will keep it as is for now and wait for your feedback.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"6f50a6693bc50a27edf8df9b34f5dcc6a8429eda","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\"Glance client wrapper class that implements retries.\"\"\""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def __init__(self, context\u003dNone, endpoint\u003dNone, version\u003d1):"},{"line_number":152,"context_line":"        if not CONF.glance.use_glance_v1:"},{"line_number":153,"context_line":"            version \u003d 2"},{"line_number":154,"context_line":"        if endpoint is not None:"},{"line_number":155,"context_line":"            self.client \u003d self._create_static_client(context,"},{"line_number":156,"context_line":"                                                     endpoint,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_76f0fd67","line":153,"range":{"start_line":152,"start_character":8,"end_line":153,"end_character":23},"in_reply_to":"bab6814e_99e851b6","updated":"2016-05-20 07:18:09.000000000","message":"You mean drop the kwarg and initialize the version variable in the else part of the IF block?  OR do you want a drill down into various other methods that are taking in the \u0027version\u0027 variable as a parameter? I am going to assume the first one and put a PS out.","commit_id":"cbfd0f6ba0ffd0a447c8d40dd92dd21692e16864"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7a3e47a36cfe7c126b897e465935c11ea71c609","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import objects"},{"line_number":45,"context_line":"from nova import signature_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_05ea4fac","line":47,"updated":"2016-06-03 13:33:42.000000000","message":"Please remove the unrelated whitespace change.","commit_id":"7cc097b5d7df817a6937dd5e8001253c42350288"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"82ad6bfc21669d8a5ccc8a00458f772523bea293","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import objects"},{"line_number":45,"context_line":"from nova import signature_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9abb7d3a_186e32c9","line":47,"updated":"2016-06-03 13:39:58.000000000","message":"Drop the unrelated whitespace change.","commit_id":"139df04d30fd0a9992e571193e57e67e2c89b7c1"}]}