)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f32107c761253a272122138938a886a5e3194f1a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"sure about moving to V2, we should be able to delete the code path"},{"line_number":24,"context_line":"related to V1 and in turn avoid the duplication."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Related to blueprint use-glance-v2-api"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I8fbb36530a2763aa779d51d8b027a00913f99afc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_51537e39","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":11},"updated":"2016-05-13 14:55:11.000000000","message":"Nice commit message. Pretty clear on the intent.\n\nI think this should be \"partially implements bp use-glance-v2-api\"","commit_id":"0cf1d92d5efb4adf2291268ca3d55dd7bd07943e"}],"nova/image/glance.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"49db4819d9be7f5089f30201f2c336cd23c5fb5c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova import objects"},{"line_number":45,"context_line":"from nova import signature_utils"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_dc3dc7de","side":"PARENT","line":47,"updated":"2016-06-03 11:24:22.000000000","message":"nit: please no unrelated white space changes.","commit_id":"7cc097b5d7df817a6937dd5e8001253c42350288"}],"nova/tests/unit/api/openstack/compute/test_image_size.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"784626ece5bf104b8f387bd17d22f94f43c97c71","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        super(ImageSizeTestV21, self).setUp()"},{"line_number":79,"context_line":"        self.stubs.Set(glance.GlanceImageService, \u0027show\u0027, fake_show)"},{"line_number":80,"context_line":"        self.stubs.Set(glance.GlanceImageService, \u0027detail\u0027, fake_detail)"},{"line_number":81,"context_line":"        self.stubs.Set(glance.GlanceImageServiceV2, \u0027show\u0027, fake_show)"},{"line_number":82,"context_line":"        self.stubs.Set(glance.GlanceImageServiceV2, \u0027detail\u0027, fake_detail)"},{"line_number":83,"context_line":"        self.flags(osapi_compute_extension\u003d[\u0027nova.api.openstack.compute\u0027"},{"line_number":84,"context_line":"                                            \u0027.contrib.image_size.Image_size\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_c71bd0c8","line":81,"updated":"2016-06-01 04:14:34.000000000","message":"Why add these two stubs here Mike? I think this patch should be clean with respect to having just splitting out the paths. We don\u0027t have implementations of any V2 APIs yet.","commit_id":"a2ccd565f947aa00f0033ec3525613fe3b7816cc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"49db4819d9be7f5089f30201f2c336cd23c5fb5c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        super(ImageSizeTestV21, self).setUp()"},{"line_number":79,"context_line":"        self.stubs.Set(glance.GlanceImageService, \u0027show\u0027, fake_show)"},{"line_number":80,"context_line":"        self.stubs.Set(glance.GlanceImageService, \u0027detail\u0027, fake_detail)"},{"line_number":81,"context_line":"        self.stubs.Set(glance.GlanceImageServiceV2, \u0027show\u0027, fake_show)"},{"line_number":82,"context_line":"        self.stubs.Set(glance.GlanceImageServiceV2, \u0027detail\u0027, fake_detail)"},{"line_number":83,"context_line":"        self.flags(osapi_compute_extension\u003d[\u0027nova.api.openstack.compute\u0027"},{"line_number":84,"context_line":"                                            \u0027.contrib.image_size.Image_size\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_5f18a975","line":81,"in_reply_to":"9abb7d3a_c71bd0c8","updated":"2016-06-03 11:24:22.000000000","message":"we should really do this with mock directly instead of stubs which is using mox, given this is new code.\n\nAlso, this is part of the reason the next patch fails because you can\u0027t stub a thing the base object doesn\u0027t have.\n\nSo I agree, we need to not do this too early here.","commit_id":"a2ccd565f947aa00f0033ec3525613fe3b7816cc"}]}