)]}'
{"nova/tests/unit/api/openstack/compute/test_floating_ips.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"df50823f3d93731c3c34e1d3485cc656dbe2fc01","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        response \u003d {\u0027floating_ips\u0027: [{"},{"line_number":374,"context_line":"            \u0027instance_id\u0027: FAKE_UUID,"},{"line_number":375,"context_line":"            \u0027ip\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":376,"context_line":"            \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":377,"context_line":"            \u0027fixed_ip\u0027: IPAddress(\u002710.0.0.1\u0027),"},{"line_number":378,"context_line":"            \u0027id\u0027: 1}, {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_89d5bf1c","line":375,"updated":"2016-06-10 15:51:36.000000000","message":"This was returning just a string before this change, and because this is the API, we need to make sure that return is the same way. so in the floating IP controller I would change it over to turn the IPAddress field into a string (just call to_primitive() on the IP in the controller where it builds this dict).","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"86fe3fc21f7e0168496c50d5981764b3f0dd8905","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        response \u003d {\u0027floating_ips\u0027: [{"},{"line_number":374,"context_line":"            \u0027instance_id\u0027: FAKE_UUID,"},{"line_number":375,"context_line":"            \u0027ip\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":376,"context_line":"            \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":377,"context_line":"            \u0027fixed_ip\u0027: IPAddress(\u002710.0.0.1\u0027),"},{"line_number":378,"context_line":"            \u0027id\u0027: 1}, {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a584175d","line":375,"in_reply_to":"7aa08908_89d5bf1c","updated":"2016-06-10 20:01:55.000000000","message":"I also modified other tests - switching from expecting \"10.10.10.10\" into IPAddress(\"10.10.10.10\").\n\nShould I make similar changes to those too?","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"5c997f58e8d5734750fb829624ce535c703f2573","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        response \u003d {\u0027floating_ips\u0027: [{"},{"line_number":374,"context_line":"            \u0027instance_id\u0027: FAKE_UUID,"},{"line_number":375,"context_line":"            \u0027ip\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":376,"context_line":"            \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":377,"context_line":"            \u0027fixed_ip\u0027: IPAddress(\u002710.0.0.1\u0027),"},{"line_number":378,"context_line":"            \u0027id\u0027: 1}, {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_bad838f0","line":375,"in_reply_to":"7aa08908_89d5bf1c","updated":"2016-06-14 15:16:41.000000000","message":"disregard the last thing i said :)\n\nI checked the test and there\u0027s a call being stubbed by the function in line 53. The reason why the expected value is different is because I changed it from returning a dict into an actual FloatingIP object. Thoughts?","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"eab4e7a90af9f55ac975e495529f68c708c5ebc5","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        response \u003d {\u0027floating_ips\u0027: [{"},{"line_number":374,"context_line":"            \u0027instance_id\u0027: FAKE_UUID,"},{"line_number":375,"context_line":"            \u0027ip\u0027: IPAddress(\u002710.10.10.10\u0027),"},{"line_number":376,"context_line":"            \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":377,"context_line":"            \u0027fixed_ip\u0027: IPAddress(\u002710.0.0.1\u0027),"},{"line_number":378,"context_line":"            \u0027id\u0027: 1}, {"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7cdb2250","line":375,"in_reply_to":"7aa08908_bad838f0","updated":"2016-06-15 19:51:11.000000000","message":"I would update the code in _translate_floating_ip_view() to convert the IPAddress into a dict by calling to_primitive on the floating ip\u0027s ip field.","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"86fe3fc21f7e0168496c50d5981764b3f0dd8905","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        self.assertEqual(res_dict[\u0027floating_ip\u0027][\u0027id\u0027], 1)"},{"line_number":456,"context_line":"        self.assertEqual(res_dict[\u0027floating_ip\u0027][\u0027ip\u0027],"},{"line_number":457,"context_line":"            IPAddress(\u002710.10.10.10\u0027))"},{"line_number":458,"context_line":"        self.assertEqual(res_dict[\u0027floating_ip\u0027][\u0027fixed_ip\u0027],"},{"line_number":459,"context_line":"            IPAddress(\u002710.0.0.1\u0027))"},{"line_number":460,"context_line":"        self.assertEqual(res_dict[\u0027floating_ip\u0027][\u0027instance_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_45961395","line":457,"updated":"2016-06-10 20:01:55.000000000","message":"like this","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"86fe3fc21f7e0168496c50d5981764b3f0dd8905","unresolved":false,"context_lines":[{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        ip \u003d res_dict[\u0027floating_ip\u0027]"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        expected \u003d {"},{"line_number":565,"context_line":"            \u0027id\u0027: 1,"},{"line_number":566,"context_line":"            \u0027instance_id\u0027: None,"},{"line_number":567,"context_line":"            \u0027ip\u0027: IPAddress(\"10.10.10.10\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_8590fb96","line":564,"updated":"2016-06-10 20:01:55.000000000","message":"and this","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"},{"author":{"_account_id":20411,"name":"Julian","email":"julian.sy@att.com","username":"syjulian"},"change_message_id":"86fe3fc21f7e0168496c50d5981764b3f0dd8905","unresolved":false,"context_lines":[{"line_number":739,"context_line":""},{"line_number":740,"context_line":"    def test_floating_ip_disassociate_auto_assigned(self):"},{"line_number":741,"context_line":"        def fake_get_floating_ip_addr_auto_assigned(self, context, address):"},{"line_number":742,"context_line":"            return objects.FloatingIP(id\u003d1, address\u003d\u002710.10.10.10\u0027, pool\u003d\u0027nova\u0027,"},{"line_number":743,"context_line":"            fixed_ip_id\u003d10, auto_assigned\u003d1)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        def get_instance_by_floating_ip_addr(self, context, address):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_a5eb7711","line":742,"updated":"2016-06-10 20:01:55.000000000","message":"and this","commit_id":"5f57d73aac39aadb4c0cd18246d3f577ae6674e2"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"670e13a680e3c998c8ab974e252df74c565c5909","unresolved":false,"context_lines":[{"line_number":2279,"context_line":"        api \u003d neutronapi.API()"},{"line_number":2280,"context_line":"        address \u003d self.fip_unassociated[\u0027floating_ip_address\u0027]"},{"line_number":2281,"context_line":"        fip_id \u003d self.fip_unassociated[\u0027id\u0027]"},{"line_number":2282,"context_line":"        floating_ip \u003d mock.Mock(address\u003daddress)"},{"line_number":2283,"context_line":""},{"line_number":2284,"context_line":"        self.moxed_client.list_floatingips(floating_ip_address\u003daddress).\\"},{"line_number":2285,"context_line":"            AndReturn({\u0027floatingips\u0027: [self.fip_unassociated]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_363ce7be","line":2282,"updated":"2016-06-03 13:57:27.000000000","message":"This should use a FloatingIP(address\u003daddress) object, because it\u0027s not very heavy to use objects, and we might as well \"mock\" it with exactly what it\u0027s going to be in a real scenario.","commit_id":"9cdb4ec0d0105d5478424d9a82e2d8ab76749160"}]}