)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"26744ac5cf97dc94770ce2a5ffb94a35e5f36312","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Config options: improve libvirt help text (1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds additional help text to the following"},{"line_number":10,"context_line":"subbet of options: use_usb_table, inject_password,"},{"line_number":11,"context_line":"inject_key, inject_partition, virt_type, connection_uri,"},{"line_number":12,"context_line":"disk_prefix, cpu_mode, cpu_model, rescue_image_id,"},{"line_number":13,"context_line":"rescue_kernel_id, rescue_ramdisk_id."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_248942cb","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"updated":"2016-06-16 19:41:17.000000000","message":"nit: subset","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae127185ccea66e17d85ac1093109b7186fb59bc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Config options: improve libvirt help text (1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds additional help text to the following"},{"line_number":10,"context_line":"subbet of options: use_usb_table, inject_password,"},{"line_number":11,"context_line":"inject_key, inject_partition, virt_type, connection_uri,"},{"line_number":12,"context_line":"disk_prefix, cpu_mode, cpu_model, rescue_image_id,"},{"line_number":13,"context_line":"rescue_kernel_id, rescue_ramdisk_id."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_fb2eb18a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":6},"in_reply_to":"7aa08908_248942cb","updated":"2016-06-17 00:57:27.000000000","message":"Done","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"}],"nova/conf/libvirt.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"61b87387edb4f61e006f8807ff931283a1dde2ed","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The ID of the image to boot from to rescue data from a corrupted instance."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If the rescue REST API operation doesn\u0027t provide an ID of an image to"},{"line_number":42,"context_line":"use, the image which is referenced by this ID is used instead. If this"},{"line_number":43,"context_line":"option is not set, the image from the instance is used instead."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_f3705fa6","line":42,"range":{"start_line":42,"start_character":54,"end_line":42,"end_character":61},"updated":"2016-05-31 21:33:19.000000000","message":"I don\u0027t think you need \"instead\" word in the sentence.","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"5ba587f7c76d9060bb3a0905befc3ad5145d6187","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The ID of the image to boot from to rescue data from a corrupted instance."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If the rescue REST API operation doesn\u0027t provide an ID of an image to"},{"line_number":42,"context_line":"use, the image which is referenced by this ID is used instead. If this"},{"line_number":43,"context_line":"option is not set, the image from the instance is used instead."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_56eaf4ac","line":42,"range":{"start_line":42,"start_character":54,"end_line":42,"end_character":61},"in_reply_to":"9abb7d3a_f3705fa6","updated":"2016-06-01 01:46:52.000000000","message":"Done","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"61b87387edb4f61e006f8807ff931283a1dde2ed","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If the rescue REST API operation doesn\u0027t provide an ID of an image to"},{"line_number":42,"context_line":"use, the image which is referenced by this ID is used instead. If this"},{"line_number":43,"context_line":"option is not set, the image from the instance is used instead."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_336787ea","line":43,"range":{"start_line":43,"start_character":55,"end_line":43,"end_character":62},"updated":"2016-05-31 21:33:19.000000000","message":"same as above","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"5ba587f7c76d9060bb3a0905befc3ad5145d6187","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"If the rescue REST API operation doesn\u0027t provide an ID of an image to"},{"line_number":42,"context_line":"use, the image which is referenced by this ID is used instead. If this"},{"line_number":43,"context_line":"option is not set, the image from the instance is used instead."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_76e578da","line":43,"range":{"start_line":43,"start_character":55,"end_line":43,"end_character":62},"in_reply_to":"9abb7d3a_336787ea","updated":"2016-06-01 01:46:52.000000000","message":"Done","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"61b87387edb4f61e006f8807ff931283a1dde2ed","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* An ID of an image or nothing. If it points to an *Amazon Machine"},{"line_number":48,"context_line":"  Image* (AMI), consider to set the config options ``rescue_kernel_id``"},{"line_number":49,"context_line":"  and ``rescue_ramdisk_id`` too. If nothing is set, the image of the instance"},{"line_number":50,"context_line":"  is used instead."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Services which consume this:"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_13a36301","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":17},"updated":"2016-05-31 21:33:19.000000000","message":"same as above.","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"5ba587f7c76d9060bb3a0905befc3ad5145d6187","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* An ID of an image or nothing. If it points to an *Amazon Machine"},{"line_number":48,"context_line":"  Image* (AMI), consider to set the config options ``rescue_kernel_id``"},{"line_number":49,"context_line":"  and ``rescue_ramdisk_id`` too. If nothing is set, the image of the instance"},{"line_number":50,"context_line":"  is used instead."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Services which consume this:"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_16e4ecde","line":50,"range":{"start_line":50,"start_character":10,"end_line":50,"end_character":17},"in_reply_to":"9abb7d3a_13a36301","updated":"2016-06-01 01:46:52.000000000","message":"Done","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"61b87387edb4f61e006f8807ff931283a1dde2ed","unresolved":false,"context_lines":[{"line_number":219,"context_line":"available on the host, the image will be locally mounted on the host as a"},{"line_number":220,"context_line":"fallback solution. If libguestfs is not able to determine the root partition"},{"line_number":221,"context_line":"(because there are more or less than one root partition) or cannot mount the"},{"line_number":222,"context_line":"file system it will result in an error and the instance won\u0027t be launched."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Possible values:"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_930113b2","line":222,"range":{"start_line":222,"start_character":65,"end_line":222,"end_character":73},"updated":"2016-05-31 21:33:19.000000000","message":"Do you mean launched or booted. In any case we should explain as what happens like some kind of error will be thrown?","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"5ba587f7c76d9060bb3a0905befc3ad5145d6187","unresolved":false,"context_lines":[{"line_number":219,"context_line":"available on the host, the image will be locally mounted on the host as a"},{"line_number":220,"context_line":"fallback solution. If libguestfs is not able to determine the root partition"},{"line_number":221,"context_line":"(because there are more or less than one root partition) or cannot mount the"},{"line_number":222,"context_line":"file system it will result in an error and the instance won\u0027t be launched."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Possible values:"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_36df700e","line":222,"range":{"start_line":222,"start_character":65,"end_line":222,"end_character":73},"in_reply_to":"9abb7d3a_930113b2","updated":"2016-06-01 01:46:52.000000000","message":"booted, will correct it soon.\nanyway, look like nova will throw only Nova Exception in case of guestfs error.\nhttps://github.com/openstack/nova/blob/master/nova/virt/disk/vfs/api.py#L66","commit_id":"5cd91260fa9d01cd39ee4e1efe58b863572314cb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6102fe050a7d347c0cabf8c0a2f3cfb83a631803","unresolved":false,"context_lines":[{"line_number":219,"context_line":"available on the host, the image will be locally mounted on the host as a"},{"line_number":220,"context_line":"fallback solution. If libguestfs is not able to determine the root partition"},{"line_number":221,"context_line":"(because there are more or less than one root partition) or cannot mount the"},{"line_number":222,"context_line":"file system it will result in an error and the instance won\u0027t be booted."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Possible values:"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a9015807","line":222,"range":{"start_line":222,"start_character":62,"end_line":222,"end_character":71},"updated":"2016-06-07 22:17:03.000000000","message":"nit: boot","commit_id":"db6b1a1bfe96635b6e7b2f71412b8517b61f641d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"26744ac5cf97dc94770ce2a5ffb94a35e5f36312","unresolved":false,"context_lines":[{"line_number":327,"context_line":"  commonly known device name prefixes for a virtualization type such as: sd,"},{"line_number":328,"context_line":"  xvd, uvd, vd."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"Services which consume this:"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"* ``nova-compute``"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"Related options:"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_a4c6d213","line":332,"range":{"start_line":330,"start_character":0,"end_line":332,"end_character":18},"updated":"2016-06-16 19:41:17.000000000","message":"You forgot to remove this section.","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae127185ccea66e17d85ac1093109b7186fb59bc","unresolved":false,"context_lines":[{"line_number":327,"context_line":"  commonly known device name prefixes for a virtualization type such as: sd,"},{"line_number":328,"context_line":"  xvd, uvd, vd."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"Services which consume this:"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"* ``nova-compute``"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"Related options:"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_9b568d04","line":332,"range":{"start_line":330,"start_character":0,"end_line":332,"end_character":18},"in_reply_to":"7aa08908_a4c6d213","updated":"2016-06-17 00:57:27.000000000","message":"Done","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"26744ac5cf97dc94770ce2a5ffb94a35e5f36312","unresolved":false,"context_lines":[{"line_number":356,"context_line":"* ``custom``: Use a named CPU model;"},{"line_number":357,"context_line":"* ``none``: Not set any CPU model."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Services which consume this:"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"* ``nova-compute``"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Related options:"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_044fe6be","line":361,"range":{"start_line":359,"start_character":0,"end_line":361,"end_character":18},"updated":"2016-06-16 19:41:17.000000000","message":"You forgot to remove this section.","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae127185ccea66e17d85ac1093109b7186fb59bc","unresolved":false,"context_lines":[{"line_number":356,"context_line":"* ``custom``: Use a named CPU model;"},{"line_number":357,"context_line":"* ``none``: Not set any CPU model."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Services which consume this:"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"* ``nova-compute``"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Related options:"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_db401538","line":361,"range":{"start_line":359,"start_character":0,"end_line":361,"end_character":18},"in_reply_to":"7aa08908_044fe6be","updated":"2016-06-17 00:57:27.000000000","message":"Done","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"26744ac5cf97dc94770ce2a5ffb94a35e5f36312","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"* The names listed in /usr/share/libvirt/cpu_map.xml"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Services which consume this:"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"* ``nova-compute``"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Related options:"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_e459fa8f","line":379,"range":{"start_line":377,"start_character":0,"end_line":379,"end_character":18},"updated":"2016-06-16 19:41:17.000000000","message":"You forgot to remove this section.","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae127185ccea66e17d85ac1093109b7186fb59bc","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"* The names listed in /usr/share/libvirt/cpu_map.xml"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Services which consume this:"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"* ``nova-compute``"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Related options:"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_bb3b89c7","line":379,"range":{"start_line":377,"start_character":0,"end_line":379,"end_character":18},"in_reply_to":"7aa08908_e459fa8f","updated":"2016-06-17 00:57:27.000000000","message":"Done","commit_id":"29453857ab82d08419dc40212e343fff1db8cfa8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"22ab4ab8534ecb0628cd7e11250db79f8bc4fb38","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Possible values:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* True: Allows the injection."},{"line_number":160,"context_line":"* False: Disallows the injection. Any via the REST API provided admin password"},{"line_number":161,"context_line":"  will be silently ignored."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Related options:"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_6fbdb201","line":161,"range":{"start_line":160,"start_character":34,"end_line":161,"end_character":26},"updated":"2016-07-06 11:13:06.000000000","message":"I think this is a bit miss-leading. This setting only really applies to create and rebuild.\n\nlib-virt implements set_admin_password API via the QEMU guest agent, so that works independent of this setting.","commit_id":"bebf7ff537c077621a1c10a72434da491d7c091c"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae36481af223741452d792cd48055749edd2de76","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Possible values:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"* True: Allows the injection."},{"line_number":160,"context_line":"* False: Disallows the injection. Any via the REST API provided admin password"},{"line_number":161,"context_line":"  will be silently ignored."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Related options:"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_dcfd546f","line":161,"range":{"start_line":160,"start_character":34,"end_line":161,"end_character":26},"in_reply_to":"1aa78d24_6fbdb201","updated":"2016-07-07 02:46:11.000000000","message":"Thank you John, so I will change the help text to \"Allow the injection of an admin password for instance at ``create`` and\n``rebuild`` process.\", is this clearer?","commit_id":"bebf7ff537c077621a1c10a72434da491d7c091c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"22ab4ab8534ecb0628cd7e11250db79f8bc4fb38","unresolved":false,"context_lines":[{"line_number":177,"context_line":"appended to the ``authorized_keys`` of that user. The SELinux context will"},{"line_number":178,"context_line":"be set if necessary. Be aware that the injection is *not* possible when the"},{"line_number":179,"context_line":"instance gets launched from a volume."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Possible values:"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* True: Allows the injection."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_8f0c5eee","line":180,"updated":"2016-07-06 11:13:06.000000000","message":"I think its worth noting this is about directly modifying the instance disk. This does not affect what cloud-init may do using data from config_drive or the metadata service.","commit_id":"bebf7ff537c077621a1c10a72434da491d7c091c"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ae36481af223741452d792cd48055749edd2de76","unresolved":false,"context_lines":[{"line_number":177,"context_line":"appended to the ``authorized_keys`` of that user. The SELinux context will"},{"line_number":178,"context_line":"be set if necessary. Be aware that the injection is *not* possible when the"},{"line_number":179,"context_line":"instance gets launched from a volume."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Possible values:"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* True: Allows the injection."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_7c31c059","line":180,"in_reply_to":"1aa78d24_8f0c5eee","updated":"2016-07-07 02:46:11.000000000","message":"Thanks, will add this at next patch","commit_id":"bebf7ff537c077621a1c10a72434da491d7c091c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04522b94439815f469bed319371030e8a1e96ccd","unresolved":false,"context_lines":[{"line_number":186,"context_line":"Possible values:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* True: Allows the injection."},{"line_number":189,"context_line":"* False: Disallows the injection. Any via the REST API provided SSH key"},{"line_number":190,"context_line":"  will be silently ignored."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Related options:"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_fe1245b3","line":190,"range":{"start_line":189,"start_character":34,"end_line":190,"end_character":27},"updated":"2016-08-09 11:36:22.000000000","message":"Thats not really true, cloud-init could inject via the metadata service.\n\nI would just drop this possible values section here, its clear from your description what true and false means.","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"fc7de52ee859d53f420ba28e66f456309a971705","unresolved":false,"context_lines":[{"line_number":186,"context_line":"Possible values:"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* True: Allows the injection."},{"line_number":189,"context_line":"* False: Disallows the injection. Any via the REST API provided SSH key"},{"line_number":190,"context_line":"  will be silently ignored."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Related options:"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_f90d163f","line":190,"range":{"start_line":189,"start_character":34,"end_line":190,"end_character":27},"in_reply_to":"9ad45d7e_fe1245b3","updated":"2016-08-10 02:33:52.000000000","message":"Done","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04522b94439815f469bed319371030e8a1e96ccd","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible values:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* -2 \u003d\u003e disable the injection of data. Provided injection data will be"},{"line_number":211,"context_line":"  silently ignored."},{"line_number":212,"context_line":"* -1 \u003d\u003e find the root partition with the file system to mount with libguestfs"},{"line_number":213,"context_line":"*  0 \u003d\u003e The image is not partitioned"},{"line_number":214,"context_line":"* \u003e0 \u003d\u003e The number of the partition to use for the injection"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_fe608537","line":211,"range":{"start_line":210,"start_character":39,"end_line":211,"end_character":19},"updated":"2016-08-09 11:36:22.000000000","message":"Not keen on how this is phrased, I would just drop that second sentence, as its a bit confusing when cloud-init might do the injection via configdrive.","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"fc7de52ee859d53f420ba28e66f456309a971705","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible values:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* -2 \u003d\u003e disable the injection of data. Provided injection data will be"},{"line_number":211,"context_line":"  silently ignored."},{"line_number":212,"context_line":"* -1 \u003d\u003e find the root partition with the file system to mount with libguestfs"},{"line_number":213,"context_line":"*  0 \u003d\u003e The image is not partitioned"},{"line_number":214,"context_line":"* \u003e0 \u003d\u003e The number of the partition to use for the injection"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_7d0d9136","line":211,"range":{"start_line":210,"start_character":39,"end_line":211,"end_character":19},"in_reply_to":"9ad45d7e_fe608537","updated":"2016-08-10 02:33:52.000000000","message":"Done","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"83ce281f12c9478aea89d5bb61dde81d830f5a12","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible values:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* -2 \u003d\u003e disable the injection of data. Provided injection data will be"},{"line_number":211,"context_line":"  silently ignored."},{"line_number":212,"context_line":"* -1 \u003d\u003e find the root partition with the file system to mount with libguestfs"},{"line_number":213,"context_line":"*  0 \u003d\u003e The image is not partitioned"},{"line_number":214,"context_line":"* \u003e0 \u003d\u003e The number of the partition to use for the injection"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Related options:"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e337e54a","line":214,"range":{"start_line":210,"start_character":0,"end_line":214,"end_character":60},"updated":"2016-07-20 20:02:06.000000000","message":"min\u003d-2 param in IntOpt would be nice :)","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04522b94439815f469bed319371030e8a1e96ccd","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible values:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* -2 \u003d\u003e disable the injection of data. Provided injection data will be"},{"line_number":211,"context_line":"  silently ignored."},{"line_number":212,"context_line":"* -1 \u003d\u003e find the root partition with the file system to mount with libguestfs"},{"line_number":213,"context_line":"*  0 \u003d\u003e The image is not partitioned"},{"line_number":214,"context_line":"* \u003e0 \u003d\u003e The number of the partition to use for the injection"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Related options:"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_3e0dfd90","line":214,"range":{"start_line":210,"start_character":0,"end_line":214,"end_character":60},"in_reply_to":"dada55a8_e337e54a","updated":"2016-08-09 11:36:22.000000000","message":"+1","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"fc7de52ee859d53f420ba28e66f456309a971705","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Possible values:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* -2 \u003d\u003e disable the injection of data. Provided injection data will be"},{"line_number":211,"context_line":"  silently ignored."},{"line_number":212,"context_line":"* -1 \u003d\u003e find the root partition with the file system to mount with libguestfs"},{"line_number":213,"context_line":"*  0 \u003d\u003e The image is not partitioned"},{"line_number":214,"context_line":"* \u003e0 \u003d\u003e The number of the partition to use for the injection"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"Related options:"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_fd19817a","line":214,"range":{"start_line":210,"start_character":0,"end_line":214,"end_character":60},"in_reply_to":"dada55a8_e337e54a","updated":"2016-08-10 02:33:52.000000000","message":"Done","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"04522b94439815f469bed319371030e8a1e96ccd","unresolved":false,"context_lines":[{"line_number":234,"context_line":"and/or SPICE is enabled. If the node doesn\u0027t support a graphical framebuffer,"},{"line_number":235,"context_line":"then it is valid to set this to False."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Possible values:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* ``True``: Enables the mouse in a VNC/SPICE session"},{"line_number":240,"context_line":"* ``False``: Disables the mouse cursor"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"Related options:"},{"line_number":243,"context_line":"* ``[vnc]enabled``: If VNC is enabled, ``use_usb_tablet`` will have an effect."}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_3ed21dd3","line":240,"range":{"start_line":237,"start_character":0,"end_line":240,"end_character":38},"updated":"2016-08-09 11:36:22.000000000","message":"We can drop this bit. Its not needed here.","commit_id":"8fd6c78af3a8e15760aac9fb715be2475226420f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"030ed1fab42c826f907c250dc764e1ae5faf2398","unresolved":false,"context_lines":[{"line_number":113,"context_line":"The choice of this type must match the underlying virtualization strategy"},{"line_number":114,"context_line":"you have chosen for this host."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* See the predefined set of case-sensitive values."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_c05cd827","line":118,"range":{"start_line":116,"start_character":0,"end_line":118,"end_character":50},"updated":"2016-08-15 16:40:01.000000000","message":"nit: Drop this","commit_id":"bb1609b6e2ca6c6e23ff4408fcef2a34c186db54"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c391a7126760cb559c884960a7e123e53dbd06aa","unresolved":false,"context_lines":[{"line_number":113,"context_line":"The choice of this type must match the underlying virtualization strategy"},{"line_number":114,"context_line":"you have chosen for this host."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* See the predefined set of case-sensitive values."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Related options:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* ``connection_uri``: depends on this"},{"line_number":123,"context_line":"* ``disk_prefix``: depends on this"},{"line_number":124,"context_line":"* ``cpu_mode``: depends on this"},{"line_number":125,"context_line":"* ``cpu_model``: depends on this"},{"line_number":126,"context_line":"\"\"\"),"},{"line_number":127,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":128,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_eb5d93ed","line":125,"range":{"start_line":116,"start_character":0,"end_line":125,"end_character":32},"updated":"2016-08-15 08:40:50.000000000","message":"nit: could be dropped IMO, you already specified in the OptGroup that this config option is the pivotal point.","commit_id":"bb1609b6e2ca6c6e23ff4408fcef2a34c186db54"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c391a7126760cb559c884960a7e123e53dbd06aa","unresolved":false,"context_lines":[{"line_number":233,"context_line":"* ``[spice]enabled`` + ``[spice].agent_enabled``: If SPICE is enabled and the"},{"line_number":234,"context_line":"  spice agent is disabled, the config value of ``use_usb_tablet`` will have"},{"line_number":235,"context_line":"  an effect."},{"line_number":236,"context_line":"\"\"\"),"},{"line_number":237,"context_line":"    cfg.StrOpt(\u0027live_migration_inbound_addr\u0027,"},{"line_number":238,"context_line":"               help\u003d\u0027Live migration target ip or hostname \u0027"},{"line_number":239,"context_line":"                    \u0027(if this option is set to None, which is the default, \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_4b79472f","line":236,"updated":"2016-08-15 08:40:50.000000000","message":"nit: I wouldn\u0027t spent time on already deprecated config options, but it doesn\u0027t hurt to have it here.","commit_id":"bb1609b6e2ca6c6e23ff4408fcef2a34c186db54"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"030ed1fab42c826f907c250dc764e1ae5faf2398","unresolved":false,"context_lines":[{"line_number":233,"context_line":"* ``[spice]enabled`` + ``[spice].agent_enabled``: If SPICE is enabled and the"},{"line_number":234,"context_line":"  spice agent is disabled, the config value of ``use_usb_tablet`` will have"},{"line_number":235,"context_line":"  an effect."},{"line_number":236,"context_line":"\"\"\"),"},{"line_number":237,"context_line":"    cfg.StrOpt(\u0027live_migration_inbound_addr\u0027,"},{"line_number":238,"context_line":"               help\u003d\u0027Live migration target ip or hostname \u0027"},{"line_number":239,"context_line":"                    \u0027(if this option is set to None, which is the default, \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_4060e8ce","line":236,"in_reply_to":"3ac371cc_4b79472f","updated":"2016-08-15 16:40:01.000000000","message":"+1","commit_id":"bb1609b6e2ca6c6e23ff4408fcef2a34c186db54"}]}