)]}'
{"nova/conf/spice.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":60,"context_line":"html5proxy_base_url_opt \u003d cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":61,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":62,"context_line":"        help\u003d\"\"\""},{"line_number":63,"context_line":"Location of the SPICE HTML5 console proxy. This is the"},{"line_number":64,"context_line":"URL an end user would use to connect to the"},{"line_number":65,"context_line":"`nova-spicehtml5proxy`` service. This service then does"},{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_fb96ea92","line":64,"range":{"start_line":63,"start_character":43,"end_line":64,"end_character":26},"updated":"2016-05-18 20:50:34.000000000","message":"nit: End user will use this URL","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":60,"context_line":"html5proxy_base_url_opt \u003d cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":61,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":62,"context_line":"        help\u003d\"\"\""},{"line_number":63,"context_line":"Location of the SPICE HTML5 console proxy. This is the"},{"line_number":64,"context_line":"URL an end user would use to connect to the"},{"line_number":65,"context_line":"`nova-spicehtml5proxy`` service. This service then does"},{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_40d7f34a","line":64,"range":{"start_line":63,"start_character":43,"end_line":64,"end_character":26},"in_reply_to":"bab6814e_fb96ea92","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        help\u003d\"\"\""},{"line_number":63,"context_line":"Location of the SPICE HTML5 console proxy. This is the"},{"line_number":64,"context_line":"URL an end user would use to connect to the"},{"line_number":65,"context_line":"`nova-spicehtml5proxy`` service. This service then does"},{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_7bd03a54","line":66,"range":{"start_line":65,"start_character":46,"end_line":66,"end_character":14},"updated":"2016-05-18 20:50:34.000000000","message":"nit: will forward request","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        help\u003d\"\"\""},{"line_number":63,"context_line":"Location of the SPICE HTML5 console proxy. This is the"},{"line_number":64,"context_line":"URL an end user would use to connect to the"},{"line_number":65,"context_line":"`nova-spicehtml5proxy`` service. This service then does"},{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_00ba0b0a","line":66,"range":{"start_line":65,"start_character":46,"end_line":66,"end_character":14},"in_reply_to":"bab6814e_7bd03a54","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_5b63b6b1","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":48},"updated":"2016-05-18 20:50:34.000000000","message":"nit: launched","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_7b379ab0","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":12},"updated":"2016-05-18 20:50:34.000000000","message":"nit: should be running","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_20546fc8","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":48},"in_reply_to":"bab6814e_5b63b6b1","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":66,"context_line":"the forwarding to the console of an instance."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy``"},{"line_number":69,"context_line":"needs to run. This service is typically executed on the controller node."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_80443b1b","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":12},"in_reply_to":"bab6814e_7b379ab0","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Related options:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* This option depends on the ``html5proxy_host`` and ``html5proxy_port``"},{"line_number":84,"context_line":"  options.  The access URL returned by the compute node must have the"},{"line_number":85,"context_line":"  host and port where the ``nova-spicehtml5proxy`` service is"},{"line_number":86,"context_line":"  listening."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_bbabc288","line":83,"range":{"start_line":83,"start_character":22,"end_line":83,"end_character":29},"updated":"2016-05-18 20:50:34.000000000","message":"on","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Related options:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* This option depends on the ``html5proxy_host`` and ``html5proxy_port``"},{"line_number":84,"context_line":"  options.  The access URL returned by the compute node must have the"},{"line_number":85,"context_line":"  host and port where the ``nova-spicehtml5proxy`` service is"},{"line_number":86,"context_line":"  listening."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_805b9bf5","line":83,"range":{"start_line":83,"start_character":22,"end_line":83,"end_character":29},"in_reply_to":"bab6814e_bbabc288","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        min\u003d1,"},{"line_number":115,"context_line":"        max\u003d65535,"},{"line_number":116,"context_line":"        help\u003d\"\"\""},{"line_number":117,"context_line":"Port on which the ``nova-spicehtml5proxy`` service listens for incoming"},{"line_number":118,"context_line":"requests."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9b87de0e","line":117,"range":{"start_line":117,"start_character":51,"end_line":117,"end_character":58},"updated":"2016-05-18 20:50:34.000000000","message":"listen","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        min\u003d1,"},{"line_number":115,"context_line":"        max\u003d65535,"},{"line_number":116,"context_line":"        help\u003d\"\"\""},{"line_number":117,"context_line":"Port on which the ``nova-spicehtml5proxy`` service listens for incoming"},{"line_number":118,"context_line":"requests."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_80127b07","line":117,"range":{"start_line":117,"start_character":51,"end_line":117,"end_character":58},"in_reply_to":"bab6814e_9b87de0e","updated":"2016-05-20 06:07:00.000000000","message":"I think this one is correct","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":136,"context_line":"server_listen_opt \u003d cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":137,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":138,"context_line":"        help\u003d\"\"\""},{"line_number":139,"context_line":"The  address on which the SPICE server running on the instances should"},{"line_number":140,"context_line":"listen."},{"line_number":141,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":142,"context_line":"node and connects"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_7bb67add","line":139,"range":{"start_line":139,"start_character":13,"end_line":139,"end_character":21},"updated":"2016-05-18 20:50:34.000000000","message":"nit: where","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":136,"context_line":"server_listen_opt \u003d cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":137,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":138,"context_line":"        help\u003d\"\"\""},{"line_number":139,"context_line":"The  address on which the SPICE server running on the instances should"},{"line_number":140,"context_line":"listen."},{"line_number":141,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":142,"context_line":"node and connects"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0045ebb1","line":139,"range":{"start_line":139,"start_character":13,"end_line":139,"end_character":21},"in_reply_to":"bab6814e_7bb67add","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"3046e7ed62388a83e20ed0815b45dc5ea1764289","unresolved":false,"context_lines":[{"line_number":159,"context_line":"server_proxyclient_address_opt \u003d cfg.StrOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":160,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":161,"context_line":"        help\u003d\"\"\""},{"line_number":162,"context_line":"The address to which the ``nova-spicehtml5proxy`` proxy client uses"},{"line_number":163,"context_line":"to connect to instance consoles."},{"line_number":164,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":165,"context_line":"node and connects over the private network to this address on the compute"},{"line_number":166,"context_line":"node(s)."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_fb26ea14","line":163,"range":{"start_line":162,"start_character":12,"end_line":163,"end_character":32},"updated":"2016-05-18 20:50:34.000000000","message":"used by ``nova-spicehtml5proxy`` client to connect to instance console.","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e13ceb1ac269b31ebc8eb6b71a78b2b485b95184","unresolved":false,"context_lines":[{"line_number":159,"context_line":"server_proxyclient_address_opt \u003d cfg.StrOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":160,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":161,"context_line":"        help\u003d\"\"\""},{"line_number":162,"context_line":"The address to which the ``nova-spicehtml5proxy`` proxy client uses"},{"line_number":163,"context_line":"to connect to instance consoles."},{"line_number":164,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":165,"context_line":"node and connects over the private network to this address on the compute"},{"line_number":166,"context_line":"node(s)."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c03e4327","line":163,"range":{"start_line":162,"start_character":12,"end_line":163,"end_character":32},"in_reply_to":"bab6814e_fb26ea14","updated":"2016-05-20 06:07:00.000000000","message":"Done","commit_id":"59c5c2019b2c5fb563904fcc6775559a79e7a2b9"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"409a0beebedad0446aa077a7cd68498c4ea6338c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"* This option depends on ``html5proxy_host`` and ``html5proxy_port`` options."},{"line_number":83,"context_line":"  The access URL returned by the compute node must have the host"},{"line_number":84,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_a6a7bbbb","line":81,"updated":"2016-05-20 15:55:40.000000000","message":"I was wondering If we should add ssl_only and cert in related options as it needs to be enabled if we are going to have HTTPS connection. I would like to know others thought on this.","commit_id":"4e8aefb8860c399d685b00fc32db5e3ae5741f64"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Must be a valid URL of the form:  ``http://host:port/spice_auto.html``"},{"line_number":65,"context_line":"  where host is the node running ``nova-spicehtml5proxy`` and the port is"},{"line_number":66,"context_line":"  typically 6082."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9b416d0e","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":19},"updated":"2016-06-11 06:51:55.000000000","message":"Please write out the default value of config option.","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c85e79b812fb0a4b4fa931b031196a6e73fd6b4c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Possible values:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Must be a valid URL of the form:  ``http://host:port/spice_auto.html``"},{"line_number":65,"context_line":"  where host is the node running ``nova-spicehtml5proxy`` and the port is"},{"line_number":66,"context_line":"  typically 6082."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_fcd03555","line":65,"range":{"start_line":64,"start_character":12,"end_line":65,"end_character":19},"in_reply_to":"7aa08908_9b416d0e","updated":"2016-06-13 16:45:42.000000000","message":"Done","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Possible values:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* Any valid interface IP address on the host."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Related options:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_7b44811a","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":20},"updated":"2016-06-11 06:51:55.000000000","message":"Please write out the default value of config option.","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c85e79b812fb0a4b4fa931b031196a6e73fd6b4c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Possible values:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"* Any valid interface IP address on the host."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Related options:"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9c4f7133","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":20},"in_reply_to":"7aa08908_7b44811a","updated":"2016-06-13 16:45:42.000000000","message":"Done","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Possible values:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Any valid port on the host."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Related options:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_db4bf529","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":19},"updated":"2016-06-11 06:51:55.000000000","message":"Please write out the default value of config option.","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c85e79b812fb0a4b4fa931b031196a6e73fd6b4c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Possible values:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* Any valid port on the host."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Related options:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3c23dd59","line":104,"range":{"start_line":104,"start_character":12,"end_line":104,"end_character":19},"in_reply_to":"7aa08908_db4bf529","updated":"2016-06-13 16:45:42.000000000","message":"Done","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Possible values:"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Any valid IP address on the compute node."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Related options:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_1b561dd2","line":124,"range":{"start_line":124,"start_character":14,"end_line":124,"end_character":25},"updated":"2016-06-11 06:51:55.000000000","message":"Please write out the default value of config option.","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c85e79b812fb0a4b4fa931b031196a6e73fd6b4c","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Possible values:"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"* Any valid IP address on the compute node."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Related options:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_fcbaf5df","line":124,"range":{"start_line":124,"start_character":14,"end_line":124,"end_character":25},"in_reply_to":"7aa08908_1b561dd2","updated":"2016-06-13 16:45:42.000000000","message":"Done","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Possible values:"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Any valid IP address on the compute node."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Related options:"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_fb5071d6","line":142,"range":{"start_line":142,"start_character":9,"end_line":142,"end_character":25},"updated":"2016-06-11 06:51:55.000000000","message":"Please write out the default value of config option.","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c85e79b812fb0a4b4fa931b031196a6e73fd6b4c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Possible values:"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"* Any valid IP address on the compute node."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Related options:"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5ccce988","line":142,"range":{"start_line":142,"start_character":9,"end_line":142,"end_character":25},"in_reply_to":"7aa08908_fb5071d6","updated":"2016-06-13 16:45:42.000000000","message":"Done","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"ea1cc3390f715100238db00f27f364c1ce99b063","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":154,"context_line":"        help\u003d\"\"\""},{"line_number":155,"context_line":"A keyboard layout which is supported by the underlying hypervisor on this"},{"line_number":156,"context_line":"node. This is usually an \u0027IETF language tag\u0027 (for example \u0027en-us\u0027). If you"},{"line_number":157,"context_line":"use QEMU as hypervisor, you should find the list of supported keyboard"},{"line_number":158,"context_line":"layouts at /usr/share/qemu/keymaps."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9b584dfc","line":156,"range":{"start_line":156,"start_character":9,"end_line":156,"end_character":19},"updated":"2016-06-11 06:51:55.000000000","message":"Missing section Possible values here","commit_id":"dffd6e69499b92cbaf0a66dc01a59c41c792a8c5"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* True or False (default)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Related options:"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_382e3b43","line":34,"updated":"2016-06-24 13:05:34.000000000","message":"Personally, I think we should drop this, and only add it for \"interesting\" cases:\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_description\n\nFor more reasons why, take a peak at:\nhttp://docs-draft.openstack.org/46/317046/4/check/gate-nova-docs/8a4591b//doc/build/html/sample_config.html","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* True or False (default)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Related options:"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_968230c7","line":34,"in_reply_to":"3aaa91ec_382e3b43","updated":"2016-06-30 12:29:53.000000000","message":"Done","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* VNC must be explicitly disabled to get access to the SPICE console. Set the"},{"line_number":39,"context_line":"  enabled option to False in the [vnc] section to disable the VNC console."},{"line_number":40,"context_line":"  If you used the deprecated vnc_enabled option in the [DEFAULT] section,"},{"line_number":41,"context_line":"  set it to False."},{"line_number":42,"context_line":"\"\"\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5844e719","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":18},"updated":"2016-06-24 13:05:34.000000000","message":"I don\u0027t think we want to add this here. It will be hard to maintain, i.e. spot it needs removing.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* VNC must be explicitly disabled to get access to the SPICE console. Set the"},{"line_number":39,"context_line":"  enabled option to False in the [vnc] section to disable the VNC console."},{"line_number":40,"context_line":"  If you used the deprecated vnc_enabled option in the [DEFAULT] section,"},{"line_number":41,"context_line":"  set it to False."},{"line_number":42,"context_line":"\"\"\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_b685acae","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":18},"in_reply_to":"3aaa91ec_5844e719","updated":"2016-06-30 12:29:53.000000000","message":"Done","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Possible values:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* True (default) or False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_61564ecf","line":52,"updated":"2016-06-24 13:05:34.000000000","message":"As above, actually I think we should drop most of these.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Possible values:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* True (default) or False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Related options:"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_d6af9829","line":52,"in_reply_to":"3aaa91ec_61564ecf","updated":"2016-06-30 12:29:53.000000000","message":"Done","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* This option depends on ``html5proxy_host`` and ``html5proxy_port`` options."},{"line_number":79,"context_line":"  The access URL returned by the compute node must have the host"},{"line_number":80,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":81,"context_line":"\"\"\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_c1fe22ad","line":80,"updated":"2016-06-24 13:05:34.000000000","message":"so its not clear how they are related. I guess the URL will over-write the host or port specific overrides?","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Possible values:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Any valid interface IP address on the host. Default is ``0.0.0.0``."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Related options:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_2191e647","line":92,"range":{"start_line":92,"start_character":22,"end_line":92,"end_character":32},"updated":"2016-06-24 13:05:34.000000000","message":"Does it also accept a hostname? just curious if it should be the IP type.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Possible values:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Any valid interface IP address on the host. Default is ``0.0.0.0``."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Related options:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_8396d749","line":92,"range":{"start_line":92,"start_character":22,"end_line":92,"end_character":32},"in_reply_to":"3aaa91ec_2191e647","updated":"2016-06-30 12:29:53.000000000","message":"My devstack keeps failing, I am unable to test it right now. As soon as I get past deployment issue I will test it and answer this question.\n\nI expect that hostname should work, but until I have a proof - can\u0027t confirm.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Any valid IP address on the compute node. Default is ``127.0.0.1``."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Related options:"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7c39d0d6","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":22},"updated":"2016-06-24 13:05:34.000000000","message":"I assume a hostname is also possible here? Its things the listening socket will bind to, I guess?","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Any valid IP address on the compute node. Default is ``127.0.0.1``."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Related options:"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_43a86f8c","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":22},"in_reply_to":"3aaa91ec_7c39d0d6","updated":"2016-06-30 12:29:53.000000000","message":"My devstack keeps failing, I am unable to test it right now. As soon as I get past deployment issue I will test it and answer this question.\n\nI expect that hostname should work, but until I have a proof - can\u0027t confirm.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c5a892e64e15444178769243ebc05c31eb5804bd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":162,"context_line":"        help\u003d\"\"\""},{"line_number":163,"context_line":"A keyboard layout which is supported by the underlying hypervisor on this"},{"line_number":164,"context_line":"node. This is usually an \u0027IETF language tag\u0027 (for example \u0027en-us\u0027). If you"},{"line_number":165,"context_line":"use QEMU as hypervisor, you should find the list of supported keyboard"},{"line_number":166,"context_line":"layouts at /usr/share/qemu/keymaps."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Possible values:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_01daea4b","line":166,"range":{"start_line":164,"start_character":6,"end_line":166,"end_character":35},"updated":"2016-06-24 13:05:34.000000000","message":"I think this the text we want under possible values.","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"dbd1eee85204b25c6c6c1acc227d732061dc3f64","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        default\u003d\u0027en-us\u0027,"},{"line_number":162,"context_line":"        help\u003d\"\"\""},{"line_number":163,"context_line":"A keyboard layout which is supported by the underlying hypervisor on this"},{"line_number":164,"context_line":"node. This is usually an \u0027IETF language tag\u0027 (for example \u0027en-us\u0027). If you"},{"line_number":165,"context_line":"use QEMU as hypervisor, you should find the list of supported keyboard"},{"line_number":166,"context_line":"layouts at /usr/share/qemu/keymaps."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Possible values:"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_194b135b","line":166,"range":{"start_line":164,"start_character":6,"end_line":166,"end_character":35},"in_reply_to":"3aaa91ec_01daea4b","updated":"2016-06-30 12:29:53.000000000","message":"Done","commit_id":"f61497fd343b4e721e4fe1e9d886af92c630859e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Must be a valid URL of the form:  ``http://host:port/spice_auto.html``"},{"line_number":59,"context_line":"  where host is the node running ``nova-spicehtml5proxy`` and the port is"},{"line_number":60,"context_line":"  typically 6082. Default is ``http://127.0.0.1:6082/spice_auto.html``."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d9d41921","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":71},"updated":"2016-07-01 10:04:19.000000000","message":"Drop this, as it duplicates line 47.","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Must be a valid URL of the form:  ``http://host:port/spice_auto.html``"},{"line_number":59,"context_line":"  where host is the node running ``nova-spicehtml5proxy`` and the port is"},{"line_number":60,"context_line":"  typically 6082. Default is ``http://127.0.0.1:6082/spice_auto.html``."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_802983e8","line":60,"range":{"start_line":60,"start_character":18,"end_line":60,"end_character":71},"in_reply_to":"3aaa91ec_d9d41921","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any valid interface IP address on the host. Default is ``0.0.0.0``."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_f9dd9541","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":69},"updated":"2016-07-01 10:04:19.000000000","message":"drop","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Possible values:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Any valid interface IP address on the host. Default is ``0.0.0.0``."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e065e744","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":69},"in_reply_to":"3aaa91ec_f9dd9541","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\"\"\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"html5proxy_port_opt \u003d cfg.IntOpt(\u0027html5proxy_port\u0027,"},{"line_number":89,"context_line":"        default\u003d6082,"},{"line_number":90,"context_line":"        min\u003d1,"},{"line_number":91,"context_line":"        max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_99c61166","line":88,"range":{"start_line":88,"start_character":22,"end_line":88,"end_character":51},"updated":"2016-07-01 10:04:19.000000000","message":"as a follow-up (and assuming it hasn\u0027t already be done), you should convert this to \u0027cfg.PortOpt\u0027","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\"\"\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"html5proxy_port_opt \u003d cfg.IntOpt(\u0027html5proxy_port\u0027,"},{"line_number":89,"context_line":"        default\u003d6082,"},{"line_number":90,"context_line":"        min\u003d1,"},{"line_number":91,"context_line":"        max\u003d65535,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_409e7b07","line":88,"range":{"start_line":88,"start_character":22,"end_line":88,"end_character":51},"in_reply_to":"3aaa91ec_99c61166","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Possible values:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Any valid port on the host (1-65535). Default is ``6082``."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Related options:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_79ea45d9","line":98,"range":{"start_line":98,"start_character":39,"end_line":98,"end_character":60},"updated":"2016-07-01 10:04:19.000000000","message":"drop","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Possible values:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Any valid port on the host (1-65535). Default is ``6082``."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Related options:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_20ea4f74","line":98,"range":{"start_line":98,"start_character":39,"end_line":98,"end_character":60},"in_reply_to":"3aaa91ec_79ea45d9","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* IP address to listen on. Default is ``127.0.0.1``."},{"line_number":119,"context_line":"\"\"\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_79988575","line":118,"range":{"start_line":118,"start_character":27,"end_line":118,"end_character":52},"updated":"2016-07-01 10:04:19.000000000","message":"Drop this","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e130c193de83c2d7231f0609e6d55b11259dffa0","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* IP address to listen on. Default is ``127.0.0.1``."},{"line_number":119,"context_line":"\"\"\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b7db4a4e","line":118,"updated":"2016-06-30 13:17:44.000000000","message":"So been reading up on listen addresses, lets just leave it as a string option for now, but I think we might want to deprecate hostnames, and move towards using an IpOpt, longer term.","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Possible values:"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* IP address to listen on. Default is ``127.0.0.1``."},{"line_number":119,"context_line":"\"\"\")"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_60ae172f","line":118,"range":{"start_line":118,"start_character":27,"end_line":118,"end_character":52},"in_reply_to":"3aaa91ec_79988575","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbdef97b3b048156077f9cf70840d29eb2255d5","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Any valid IP address on the compute node. Default is ``127.0.0.1``."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Related options:"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_d989b927","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":69},"updated":"2016-07-01 10:04:19.000000000","message":"Drop this","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab87eae8950c19789c8a7345278edc1be7b46b50","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Possible values:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"* Any valid IP address on the compute node. Default is ``127.0.0.1``."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Related options:"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_c0a9cb25","line":132,"range":{"start_line":132,"start_character":43,"end_line":132,"end_character":69},"in_reply_to":"3aaa91ec_d989b927","updated":"2016-07-07 14:24:44.000000000","message":"Done","commit_id":"29cc874ca0d52a462c350b873949526d49227873"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"70113033412984d5853263d349cc7744309d4292","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":63,"context_line":"        default\u003dFalse,"},{"line_number":64,"context_line":"        help\u003d\"\"\""},{"line_number":65,"context_line":"Enable SPICE related features."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Related options:"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_ff3d0ede","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":6},"updated":"2016-08-03 20:19:25.000000000","message":"Enable/Disable all?","commit_id":"988c683c0de4fc524abb87bf691bd3a9d1c80f09"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"61bd8d5971e0d6bdf29831b0a8de630b340b029f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        title\u003d\"SPICE console features\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"SPICE console feature allows you to connect to a guest virtual machine."},{"line_number":23,"context_line":"SPICE is a replacement for fairly limited VNC protocol."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_9aaf9929","line":23,"updated":"2016-08-10 10:17:24.000000000","message":"I think we need to state what is required to enable space. I think you must use the libvirt driver, spice.enabled\u003dTrue and vnc.enabled\u003dFalse.\n\nI think we should also mention that you are almost certainly will want to update the html5proxy_base_url and server_proxyclient_address conf options? Does that seem correct.","commit_id":"96807ab9580ab63b6e62d04306f53f90b07449de"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"61bd8d5971e0d6bdf29831b0a8de630b340b029f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Host on which the ``nova-spicehtml5proxy`` service listens for incoming"},{"line_number":31,"context_line":"requests."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Possible values:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Any valid interface IP address on the host."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Related options:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_fd320ff1","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":45},"updated":"2016-08-10 10:17:24.000000000","message":"I think its actually any IP address or hostname, but best put that in the description really.","commit_id":"96807ab9580ab63b6e62d04306f53f90b07449de"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"61bd8d5971e0d6bdf29831b0a8de630b340b029f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Port on which the ``nova-spicehtml5proxy`` service listens for incoming"},{"line_number":47,"context_line":"requests."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Any valid port on the host (1-65535)."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Related options:"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_7d6c5fd0","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":39},"updated":"2016-08-10 10:17:24.000000000","message":"This seems redundant given the type. Lets drop it.","commit_id":"96807ab9580ab63b6e62d04306f53f90b07449de"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"61bd8d5971e0d6bdf29831b0a8de630b340b029f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":76,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":77,"context_line":"        help\u003d\"\"\""},{"line_number":78,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":79,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"},{"line_number":80,"context_line":"request to the console of an instance."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"In order to use SPICE console, the service ``nova-spicehtml5proxy`` should be"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_1d3e038c","line":79,"range":{"start_line":78,"start_character":43,"end_line":79,"end_character":47},"updated":"2016-08-10 10:17:24.000000000","message":"Hmm, so I guess we should be clear that this default is useless in any real deployment?","commit_id":"96807ab9580ab63b6e62d04306f53f90b07449de"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4b56bcad50e3f57df6f8d821dbc33a5ccad59430","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* spice.enabled set to True"},{"line_number":29,"context_line":"* vnc.enabled set to False"},{"line_number":30,"context_line":"* update html5proxy_base_url"},{"line_number":31,"context_line":"* update server_proxyclient_address"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_bb62e43b","line":31,"updated":"2016-08-12 08:24:32.000000000","message":"It would be great to validate these conditions at config read level e.g. \nif spice.enabled:\n   required(html5proxy_base_url)\nbut for this you need empty html5proxy_base_url defaut which is okay IMO.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e28279254e1c29411416eb6358daa5d165da8a22","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* spice.enabled set to True"},{"line_number":29,"context_line":"* vnc.enabled set to False"},{"line_number":30,"context_line":"* update html5proxy_base_url"},{"line_number":31,"context_line":"* update server_proxyclient_address"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_f720b14b","line":31,"in_reply_to":"9ad45d7e_371c2477","updated":"2016-08-15 20:34:08.000000000","message":"So - not changing it in this patch.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a93965c372fbe917b6236e7ccb084c7b3a8ca63f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* spice.enabled set to True"},{"line_number":29,"context_line":"* vnc.enabled set to False"},{"line_number":30,"context_line":"* update html5proxy_base_url"},{"line_number":31,"context_line":"* update server_proxyclient_address"},{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_371c2477","line":31,"in_reply_to":"9ad45d7e_bb62e43b","updated":"2016-08-12 18:34:54.000000000","message":"That shouldn\u0027t be part of this change though. This is a docs focused change. It will just fail in a odd way right now if you don\u0027t change these.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4b56bcad50e3f57df6f8d821dbc33a5ccad59430","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027html5proxy_host\u0027,"},{"line_number":36,"context_line":"        default\u003d\u00270.0.0.0\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"IP address or a hostname on which the ``nova-spicehtml5proxy`` service"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_7b8fcc74","line":35,"updated":"2016-08-12 08:24:32.000000000","message":"Can be cfg.HostnameOpt which fits for ip and host name.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e28279254e1c29411416eb6358daa5d165da8a22","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027html5proxy_host\u0027,"},{"line_number":36,"context_line":"        default\u003d\u00270.0.0.0\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"IP address or a hostname on which the ``nova-spicehtml5proxy`` service"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_17ef4de9","line":35,"in_reply_to":"3ac371cc_7fb0418c","updated":"2016-08-15 20:34:08.000000000","message":"John - didn\u0027t you say last week that it would be perfect to get rid of hostnames? Perhaps it would be better to change it to IPOpt and do not mention hostname in help text?","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"9ed4a08b919439bddb593e2e256165f24b717aae","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027html5proxy_host\u0027,"},{"line_number":36,"context_line":"        default\u003d\u00270.0.0.0\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"IP address or a hostname on which the ``nova-spicehtml5proxy`` service"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_7fb0418c","line":35,"in_reply_to":"9ad45d7e_720d0a37","updated":"2016-08-15 07:10:14.000000000","message":"I\u0027m not strong on it but, by definition, hostname pattern allows numbers and dots so IPs are kind of subclass of hosts, aren\u0027t they?","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a93965c372fbe917b6236e7ccb084c7b3a8ca63f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\"\"\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"CLI_OPTS \u003d ["},{"line_number":35,"context_line":"    cfg.StrOpt(\u0027html5proxy_host\u0027,"},{"line_number":36,"context_line":"        default\u003d\u00270.0.0.0\u0027,"},{"line_number":37,"context_line":"        help\u003d\"\"\""},{"line_number":38,"context_line":"IP address or a hostname on which the ``nova-spicehtml5proxy`` service"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_720d0a37","line":35,"in_reply_to":"9ad45d7e_7b8fcc74","updated":"2016-08-12 18:34:54.000000000","message":"The docs claim it doesn\u0027t allow IPs:\nhttp://docs.openstack.org/developer/oslo.config/types.html#oslo_config.types.Hostname\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L675","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4b56bcad50e3f57df6f8d821dbc33a5ccad59430","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        default\u003dTrue,"},{"line_number":74,"context_line":"        help\u003d\u0027Enable the SPICE guest agent support on the instances.\u0027),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":76,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":77,"context_line":"        help\u003d\"\"\""},{"line_number":78,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":79,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_9ba600bf","line":76,"updated":"2016-08-12 08:24:32.000000000","message":"cfg.URIOpt would work like a charm for this case.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a93965c372fbe917b6236e7ccb084c7b3a8ca63f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        default\u003dTrue,"},{"line_number":74,"context_line":"        help\u003d\u0027Enable the SPICE guest agent support on the instances.\u0027),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":76,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":77,"context_line":"        help\u003d\"\"\""},{"line_number":78,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":79,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_522566ac","line":76,"in_reply_to":"9ad45d7e_9ba600bf","updated":"2016-08-12 18:34:54.000000000","message":"+1","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e28279254e1c29411416eb6358daa5d165da8a22","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        default\u003dTrue,"},{"line_number":74,"context_line":"        help\u003d\u0027Enable the SPICE guest agent support on the instances.\u0027),"},{"line_number":75,"context_line":"    cfg.StrOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":76,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":77,"context_line":"        help\u003d\"\"\""},{"line_number":78,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":79,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_d7cbf570","line":76,"in_reply_to":"9ad45d7e_9ba600bf","updated":"2016-08-15 20:34:08.000000000","message":"Done","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4b56bcad50e3f57df6f8d821dbc33a5ccad59430","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."},{"line_number":102,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_3ba6f4ad","line":99,"updated":"2016-08-12 08:24:32.000000000","message":"also can be hostname","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a93965c372fbe917b6236e7ccb084c7b3a8ca63f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."},{"line_number":102,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_d23956da","line":99,"in_reply_to":"9ad45d7e_3ba6f4ad","updated":"2016-08-12 18:34:54.000000000","message":"-1 as above.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e28279254e1c29411416eb6358daa5d165da8a22","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."},{"line_number":102,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_f7d1d1fc","line":99,"in_reply_to":"9ad45d7e_d23956da","updated":"2016-08-15 20:34:08.000000000","message":"Changing type to IPOpt","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"4b56bcad50e3f57df6f8d821dbc33a5ccad59430","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* IP address to listen on."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":112,"context_line":"        help\u003d\"\"\""},{"line_number":113,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"},{"line_number":114,"context_line":"console. Typically, the ``nova-spicehtml5proxy`` proxy client runs on the"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_9bbba0c3","line":111,"updated":"2016-08-12 08:24:32.000000000","message":"the same","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e28279254e1c29411416eb6358daa5d165da8a22","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* IP address to listen on."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":112,"context_line":"        help\u003d\"\"\""},{"line_number":113,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"},{"line_number":114,"context_line":"console. Typically, the ``nova-spicehtml5proxy`` proxy client runs on the"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_17d90d22","line":111,"in_reply_to":"9ad45d7e_9256be04","updated":"2016-08-15 20:34:08.000000000","message":"Changing type to IPOpt","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a93965c372fbe917b6236e7ccb084c7b3a8ca63f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"* IP address to listen on."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":112,"context_line":"        help\u003d\"\"\""},{"line_number":113,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"},{"line_number":114,"context_line":"console. Typically, the ``nova-spicehtml5proxy`` proxy client runs on the"}],"source_content_type":"text/x-python","patch_set":15,"id":"9ad45d7e_9256be04","line":111,"in_reply_to":"9ad45d7e_9bbba0c3","updated":"2016-08-12 18:34:54.000000000","message":"-1 as above.","commit_id":"258901f614a7f99e654e59fa70bb5a242359e16e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"229a3408bc01fd248bd6c675e11c9130f59c1323","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_config import cfg"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"GROUP_NAME \u003d \u0027spice\u0027"},{"line_number":19,"context_line":"spice_opt_group \u003d cfg.OptGroup(GROUP_NAME,"},{"line_number":20,"context_line":"        title\u003d\"SPICE console features\","},{"line_number":21,"context_line":"        help\u003d\"\"\""},{"line_number":22,"context_line":"SPICE console feature allows you to connect to a guest virtual machine."}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_aec03451","line":19,"range":{"start_line":19,"start_character":31,"end_line":19,"end_character":41},"updated":"2016-08-17 15:55:08.000000000","message":"nit: I don\u0027t see any reason not to hardcode \u0027spice\u0027 in here","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"229a3408bc01fd248bd6c675e11c9130f59c1323","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Related options:"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* This option depends on the ``html5proxy_base_url`` option."},{"line_number":56,"context_line":"  The ``nova-spicehtml5proxy`` service must be listening on"},{"line_number":57,"context_line":"  a port that is accessible from the HTML5 client."},{"line_number":58,"context_line":"\"\"\")"},{"line_number":59,"context_line":"]"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_aecdd432","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":50},"updated":"2016-08-17 15:55:08.000000000","message":"super nit: It annoys me that this is wrapped differently to the line above, even though they\u0027re essentially the same thing :)","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1ce15fdb8a2e3119c46f0d6870fc4afe4116a166","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  The access URL returned by the compute node must have the host"},{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.IPOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_5a63acb1","line":98,"range":{"start_line":98,"start_character":15,"end_line":98,"end_character":28},"updated":"2016-08-15 20:01:19.000000000","message":"Could this be a hostname as well or only IP?","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"229a3408bc01fd248bd6c675e11c9130f59c1323","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  The access URL returned by the compute node must have the host"},{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.IPOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_0ecfc829","line":98,"range":{"start_line":98,"start_character":15,"end_line":98,"end_character":28},"in_reply_to":"3ac371cc_5a63acb1","updated":"2016-08-17 15:55:08.000000000","message":"+1","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"e33b2e382ea9752efe8bf79cc6a0bb8a2496b55b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  The access URL returned by the compute node must have the host"},{"line_number":96,"context_line":"  and port where the ``nova-spicehtml5proxy`` service is listening."},{"line_number":97,"context_line":"\"\"\"),"},{"line_number":98,"context_line":"    cfg.IPOpt(\u0027server_listen\u0027,"},{"line_number":99,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":100,"context_line":"        help\u003d\"\"\""},{"line_number":101,"context_line":"The  address where the SPICE server running on the instances should listen."}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_6d6b8d86","line":98,"range":{"start_line":98,"start_character":15,"end_line":98,"end_character":28},"in_reply_to":"3ac371cc_5a63acb1","updated":"2016-08-18 17:42:28.000000000","message":"This should be a Stropt, otherwise it will break for hostname","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"229a3408bc01fd248bd6c675e11c9130f59c1323","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* IP address to listen on."},{"line_number":109,"context_line":"\"\"\"),"},{"line_number":110,"context_line":"    cfg.IPOpt(\u0027server_proxyclient_address\u0027,"},{"line_number":111,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":112,"context_line":"        help\u003d\"\"\""},{"line_number":113,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_0ee6a8af","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":13},"updated":"2016-08-17 15:55:08.000000000","message":"same story here","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"e51ff8d4a09165a027a72741b0a73b8c04af5bd1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    conf.register_opts(ALL_OPTS, group\u003dspice_opt_group)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def register_cli_opts(conf):"},{"line_number":149,"context_line":"    conf.register_cli_opts(CLI_OPTS, group\u003dspice_opt_group)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_620e288d","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":59},"updated":"2016-08-18 07:11:30.000000000","message":"https://wiki.openstack.org/wiki/ConfigOptionsConsistency\nAs per wiki[1], there should be only One register_opts call per group, to match list_opts.Since you have extended the list what is the need to register opts twice ?","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"ebd050829dd9993d9712bd3710e7a2c66fc2509a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    conf.register_opts(ALL_OPTS, group\u003dspice_opt_group)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"def register_cli_opts(conf):"},{"line_number":149,"context_line":"    conf.register_cli_opts(CLI_OPTS, group\u003dspice_opt_group)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"def list_opts():"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_c3239e54","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":59},"in_reply_to":"3ac371cc_620e288d","updated":"2016-08-18 08:04:47.000000000","message":"Sorry didn\u0027t notice it was cli_opts. Apologies for the confusion","commit_id":"62bc6795c33503b7407b92c0bbb123576398cca9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad42a9d8b96a0985e5fbfac59d6552272ab5f289","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""},{"line_number":77,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":78,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"},{"line_number":79,"context_line":"request to the console of an instance."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_76dcbb12","line":77,"range":{"start_line":77,"start_character":42,"end_line":77,"end_character":43},"updated":"2016-09-23 14:11:03.000000000","message":"line break here","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab70a11f257b4041123e4e14e09931c6540cd8f1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""},{"line_number":77,"context_line":"Location of the SPICE HTML5 console proxy. End user would use this URL to"},{"line_number":78,"context_line":"connect to the `nova-spicehtml5proxy`` service. This service will forward"},{"line_number":79,"context_line":"request to the console of an instance."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_5a18781e","line":77,"range":{"start_line":77,"start_character":42,"end_line":77,"end_character":43},"in_reply_to":"5a8bc5a2_76dcbb12","updated":"2016-09-26 13:02:44.000000000","message":"Done","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad42a9d8b96a0985e5fbfac59d6552272ab5f289","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":98,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"The  address where the SPICE server running on the instances should listen."},{"line_number":101,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":102,"context_line":"node and connects over the private network to this address on the compute"},{"line_number":103,"context_line":"node(s)."}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_f6fe0b6a","line":100,"updated":"2016-09-23 14:11:03.000000000","message":"line breaks here","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab70a11f257b4041123e4e14e09931c6540cd8f1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    cfg.StrOpt(\u0027server_listen\u0027,"},{"line_number":98,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":99,"context_line":"        help\u003d\"\"\""},{"line_number":100,"context_line":"The  address where the SPICE server running on the instances should listen."},{"line_number":101,"context_line":"Typically, the ``nova-spicehtml5proxy`` proxy client runs on the controller"},{"line_number":102,"context_line":"node and connects over the private network to this address on the compute"},{"line_number":103,"context_line":"node(s)."}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_3a12cc57","line":100,"in_reply_to":"5a8bc5a2_f6fe0b6a","updated":"2016-09-26 13:02:44.000000000","message":"Done","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ad42a9d8b96a0985e5fbfac59d6552272ab5f289","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":111,"context_line":"        help\u003d\"\"\""},{"line_number":112,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"},{"line_number":113,"context_line":"console. Typically, the ``nova-spicehtml5proxy`` proxy client runs on the"},{"line_number":114,"context_line":"controller node and connects over the private network to this address on the"},{"line_number":115,"context_line":"compute node(s)."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_96eea7b2","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":9},"updated":"2016-09-23 14:11:03.000000000","message":"Line breaks here","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ab70a11f257b4041123e4e14e09931c6540cd8f1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        default\u003d\u0027127.0.0.1\u0027,"},{"line_number":111,"context_line":"        help\u003d\"\"\""},{"line_number":112,"context_line":"The address used by ``nova-spicehtml5proxy`` client to connect to instance"},{"line_number":113,"context_line":"console. Typically, the ``nova-spicehtml5proxy`` proxy client runs on the"},{"line_number":114,"context_line":"controller node and connects over the private network to this address on the"},{"line_number":115,"context_line":"compute node(s)."},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5a8bc5a2_5a1b1873","line":113,"range":{"start_line":113,"start_character":8,"end_line":113,"end_character":9},"in_reply_to":"5a8bc5a2_96eea7b2","updated":"2016-09-26 13:02:44.000000000","message":"Done","commit_id":"d4bfd01175fcde5ca52df938536edf7b018d3630"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f88b1e01d1c53170806cb9b8c8550edb10839d61","unresolved":false,"context_lines":[{"line_number":70,"context_line":"\"\"\"),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":72,"context_line":"        default\u003dTrue,"},{"line_number":73,"context_line":"        help\u003d\u0027Enable the SPICE guest agent support on the instances.\u0027),"},{"line_number":74,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa6399be_9949bb8e","line":73,"updated":"2016-10-11 12:46:32.000000000","message":"You\u0027ve missed updating of this option text.","commit_id":"469a11fe3c6b569620d224f3c901b59d79d65932"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d7d8ae655a36fccf5d2252014c6f99a226ada8da","unresolved":false,"context_lines":[{"line_number":70,"context_line":"\"\"\"),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":72,"context_line":"        default\u003dTrue,"},{"line_number":73,"context_line":"        help\u003d\u0027Enable the SPICE guest agent support on the instances.\u0027),"},{"line_number":74,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":75,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"},{"line_number":76,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":21,"id":"ba5da102_c1fbb179","line":73,"in_reply_to":"fa6399be_9949bb8e","updated":"2016-11-02 11:53:42.000000000","message":"True, thanks!","commit_id":"469a11fe3c6b569620d224f3c901b59d79d65932"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"545e805a21b6d8baf17ab4b031531be820373cf7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  match it rather than letterboxing."},{"line_number":84,"context_line":"* Better mouse integration - The mouse can be captured and released without"},{"line_number":85,"context_line":"  needing to click inside the console or press keys to release it. The"},{"line_number":86,"context_line":"  performance of mouse movement is also improved."},{"line_number":87,"context_line":"\"\"\"),"},{"line_number":88,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":89,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba5da102_71ae21e7","line":86,"updated":"2016-11-02 17:28:01.000000000","message":"Is there ever a good reason to set this to False? If not, why have the option at all?","commit_id":"a873375963a32934c3185703a94f1617b9271c7d"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1a22d7e6ad7b36ecac677bd1e19b6abf4b76f14d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  match it rather than letterboxing."},{"line_number":84,"context_line":"* Better mouse integration - The mouse can be captured and released without"},{"line_number":85,"context_line":"  needing to click inside the console or press keys to release it. The"},{"line_number":86,"context_line":"  performance of mouse movement is also improved."},{"line_number":87,"context_line":"\"\"\"),"},{"line_number":88,"context_line":"    cfg.URIOpt(\u0027html5proxy_base_url\u0027,"},{"line_number":89,"context_line":"        default\u003d\u0027http://127.0.0.1:6082/spice_auto.html\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba5da102_d12c4d04","line":86,"in_reply_to":"ba5da102_71ae21e7","updated":"2016-11-02 17:35:23.000000000","message":"It is possible to have both VNC and SPICE enabled for a guest at the same time. If you enable the guest agent for SPICE, then you\u0027ll loose mouse interaction for VNC.  So if you have both VNC \u0026 SPICE enabled, you\u0027ll want this turned off.","commit_id":"a873375963a32934c3185703a94f1617b9271c7d"}]}