)]}'
{"nova/objects/service.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"13527f2895c250468fb7ea663f5d4fa09bccafa4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    # Version 11: Removed migration_id from live_migration_force_complete"},{"line_number":77,"context_line":"    {\u0027compute_rpc\u0027: \u00274.12\u0027},"},{"line_number":78,"context_line":"    # Version 12: Compute node conversion to Inventories in the API database"},{"line_number":79,"context_line":"    {\u0027compute_rpc\u0027: \u00274.12\u0027},"},{"line_number":80,"context_line":")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_6cf47b5a","line":79,"updated":"2016-05-21 20:11:51.000000000","message":"This doesn\u0027t get updated to \u00274.13\u0027 because there\u0027s no change in RPC API version, just a change in the ComputeNode version that we need to be able to track via service_get_min_version() right?","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f303dec369334edb177e0f7234c988046f7d33b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    # Version 11: Removed migration_id from live_migration_force_complete"},{"line_number":77,"context_line":"    {\u0027compute_rpc\u0027: \u00274.12\u0027},"},{"line_number":78,"context_line":"    # Version 12: Compute node conversion to Inventories in the API database"},{"line_number":79,"context_line":"    {\u0027compute_rpc\u0027: \u00274.12\u0027},"},{"line_number":80,"context_line":")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_8fd40aec","line":79,"in_reply_to":"bab6814e_6cf47b5a","updated":"2016-05-23 14:03:50.000000000","message":"Yes","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":15648,"name":"Yingxin","email":"yingxin.cheng@intel.com","username":"Yingxin"},"change_message_id":"34e9742c67c0325c5dff0dd5d269d1f02bd00476","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        required_version \u003d 12"},{"line_number":29,"context_line":"        min_version \u003d objects.Service.get_minimum_version_multi("},{"line_number":30,"context_line":"            compute_node._context, related_binaries)"},{"line_number":31,"context_line":"        if min_version \u003e required_version:"},{"line_number":32,"context_line":"            if not compute_node.update_inventory():"},{"line_number":33,"context_line":"                compute_node.create_inventory"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_bfade09c","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":24},"updated":"2016-05-22 07:01:34.000000000","message":"Is this \"\u003e\u003d\" ?","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0f303dec369334edb177e0f7234c988046f7d33b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        required_version \u003d 12"},{"line_number":29,"context_line":"        min_version \u003d objects.Service.get_minimum_version_multi("},{"line_number":30,"context_line":"            compute_node._context, related_binaries)"},{"line_number":31,"context_line":"        if min_version \u003e required_version:"},{"line_number":32,"context_line":"            if not compute_node.update_inventory():"},{"line_number":33,"context_line":"                compute_node.create_inventory"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_af43cead","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":24},"in_reply_to":"bab6814e_bfade09c","updated":"2016-05-23 14:03:50.000000000","message":"Should be, yeah :)","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5aa734eb13d2c49ed0b8b1e5bc93b47c03cb0932","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            compute_node._context, related_binaries)"},{"line_number":31,"context_line":"        if min_version \u003e required_version:"},{"line_number":32,"context_line":"            if not compute_node.update_inventory():"},{"line_number":33,"context_line":"                compute_node.create_inventory"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        compute_node.save()"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_63e656b1","line":33,"updated":"2016-05-20 22:00:47.000000000","message":"Oopsie.","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eefd7e6100b9295a15d36ea4ff698e5bd627f1d8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        required_version \u003d 12"},{"line_number":29,"context_line":"        min_version \u003d objects.Service.get_minimum_version_multi("},{"line_number":30,"context_line":"            compute_node._context, related_binaries)"},{"line_number":31,"context_line":"        if min_version \u003e\u003d required_version:"},{"line_number":32,"context_line":"            if not compute_node.update_inventory():"},{"line_number":33,"context_line":"                compute_node.create_inventory()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_be286c34","line":31,"updated":"2016-05-26 11:03:42.000000000","message":"that just means the inventories will be updated/created when all the API/conductor/scheduler and the running compute node will of them be Newton... I\u0027m fine with that, given we only support that (and compute nodes being Mitaka).","commit_id":"d6d6262174145c20b4f9bc458f93a6ae8b5bbca8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e03aa012098826095f2c81a828b97c053f61e8f1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        required_version \u003d 12"},{"line_number":29,"context_line":"        min_version \u003d objects.Service.get_minimum_version_multi("},{"line_number":30,"context_line":"            compute_node._context, related_binaries)"},{"line_number":31,"context_line":"        if min_version \u003e\u003d required_version:"},{"line_number":32,"context_line":"            if not compute_node.update_inventory():"},{"line_number":33,"context_line":"                compute_node.create_inventory()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_8303890f","line":31,"in_reply_to":"bab6814e_be286c34","updated":"2016-05-26 13:46:17.000000000","message":"Ah, you\u0027re right I could remove this now. I probably should actually so that we don\u0027t end up with the extra check each time for no reason. Good call.","commit_id":"d6d6262174145c20b4f9bc458f93a6ae8b5bbca8"}],"nova/tests/unit/scheduler/test_client.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"13527f2895c250468fb7ea663f5d4fa09bccafa4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"              \"count\": 1,"},{"line_number":49,"context_line":"              \"a\": \"b\"}])"},{"line_number":50,"context_line":"        self.client.update_resource_stats(cn)"},{"line_number":51,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class SchedulerQueryClientTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_cce767aa","line":51,"updated":"2016-05-21 20:11:51.000000000","message":"Obviously, you will want to erify that a call to objects.ComputeNode.create_inventory() is called when the version is \u003e 12.","commit_id":"99c15fc8ff6351374780fd44d7182fe22f9ef141"}]}