)]}'
{"nova/conf/barbican.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e80a1e1c06a6519d53089b2551b802a101c44ca3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":32,"context_line":"                help\u003d\"\"\""},{"line_number":33,"context_line":"*DEPRECATED*"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_6e9cccc0","line":31,"range":{"start_line":31,"start_character":79,"end_line":31,"end_character":85},"updated":"2016-05-19 15:16:20.000000000","message":"Line too long","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"dc33ea2acd0f6772623b8c8d268710412b61bf73","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":32,"context_line":"                help\u003d\"\"\""},{"line_number":33,"context_line":"*DEPRECATED*"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_253bf69d","line":31,"range":{"start_line":31,"start_character":79,"end_line":31,"end_character":85},"in_reply_to":"bab6814e_6e9cccc0","updated":"2016-05-19 18:52:06.000000000","message":"Done","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e80a1e1c06a6519d53089b2551b802a101c44ca3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\"endpoint_template\","},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":52,"context_line":"               help\u003d\"\"\""},{"line_number":53,"context_line":"*DEPRECATED*"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_aea6b40d","line":51,"range":{"start_line":51,"start_character":77,"end_line":51,"end_character":84},"updated":"2016-05-19 15:16:20.000000000","message":"Line too long","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"dc33ea2acd0f6772623b8c8d268710412b61bf73","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\"\"\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\"endpoint_template\","},{"line_number":50,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"               deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":52,"context_line":"               help\u003d\"\"\""},{"line_number":53,"context_line":"*DEPRECATED*"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8542a20e","line":51,"range":{"start_line":51,"start_character":77,"end_line":51,"end_character":84},"in_reply_to":"bab6814e_aea6b40d","updated":"2016-05-19 18:52:06.000000000","message":"Done","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e80a1e1c06a6519d53089b2551b802a101c44ca3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\"\"\"),"},{"line_number":69,"context_line":"    cfg.StrOpt(\"os_region_name\","},{"line_number":70,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":71,"context_line":"               deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":72,"context_line":"               help\u003d\"\"\""},{"line_number":73,"context_line":"*DEPRECATED*"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8ea930e2","line":71,"range":{"start_line":71,"start_character":74,"end_line":71,"end_character":82},"updated":"2016-05-19 15:16:20.000000000","message":"Line too long","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"dc33ea2acd0f6772623b8c8d268710412b61bf73","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\"\"\"),"},{"line_number":69,"context_line":"    cfg.StrOpt(\"os_region_name\","},{"line_number":70,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":71,"context_line":"               deprecated_reason\u003d\"This option have been moved to Castellan library\","},{"line_number":72,"context_line":"               help\u003d\"\"\""},{"line_number":73,"context_line":"*DEPRECATED*"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_c54caa44","line":71,"range":{"start_line":71,"start_character":74,"end_line":71,"end_character":82},"in_reply_to":"bab6814e_8ea930e2","updated":"2016-05-19 18:52:06.000000000","message":"Done","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"db19868f9900c7d9d4d3ff6980b91ef1e100b616","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def list_opts():"},{"line_number":100,"context_line":"    return {"},{"line_number":101,"context_line":"        #castellan_opts.list_opts()"},{"line_number":102,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":103,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ae0a341f","line":101,"updated":"2016-05-19 15:14:02.000000000","message":"If all the above options are deprecated and will be soon removed, is there a real need to keep service bridge code?","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"dc33ea2acd0f6772623b8c8d268710412b61bf73","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def list_opts():"},{"line_number":100,"context_line":"    return {"},{"line_number":101,"context_line":"        #castellan_opts.list_opts()"},{"line_number":102,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":103,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_056eb294","line":101,"in_reply_to":"bab6814e_ae0a341f","updated":"2016-05-19 18:52:06.000000000","message":"Yes, It has to be deprecated for Newton and only then can be deleted in following release","commit_id":"d32876091bc29a5369bd75201747223e0506dc0b"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a84ebf6af24b98ba0bac0c2a0b32a93bd6ed6848","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# All barbican related code and options have been moved to"},{"line_number":20,"context_line":"# a separate library Catellan. Deprecating these option for"},{"line_number":21,"context_line":"# Newton. These will be deleted post Newton"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"barbican_group \u003d cfg.OptGroup("}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_c3759198","line":20,"updated":"2016-05-20 15:34:37.000000000","message":"nit: Catellan -\u003e Castellan","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2b7f4e21856b5ee8863e8d49886c60a901d6c5fd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":38,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_e9e25d2e","line":38,"range":{"start_line":37,"start_character":9,"end_line":38,"end_character":45},"updated":"2016-05-20 00:17:19.000000000","message":"IMO this one should be in \u0027possible values\u0027 section.","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a84ebf6af24b98ba0bac0c2a0b32a93bd6ed6848","unresolved":false,"context_lines":[{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":38,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_a3d68d4c","line":38,"range":{"start_line":37,"start_character":9,"end_line":38,"end_character":45},"in_reply_to":"bab6814e_56ae80e6","updated":"2016-05-20 15:34:37.000000000","message":"+1 for leaving as is in the \u0027format\u0027 section","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"be9dde35cd3071489b2a1abdcd62e0bd376416ec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":38,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_56ae80e6","line":38,"range":{"start_line":37,"start_character":9,"end_line":38,"end_character":45},"in_reply_to":"bab6814e_e9e25d2e","updated":"2016-05-20 15:05:13.000000000","message":"This is just the syntax not actual values. I think it belongs here.","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2b7f4e21856b5ee8863e8d49886c60a901d6c5fd","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Override service catalog lookup with template for"},{"line_number":58,"context_line":"barbican endpoint e.g."},{"line_number":59,"context_line":"http://localhost:9311/v1/%(project_id)s"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Possible values:"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_29d7454c","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":39},"updated":"2016-05-20 00:17:19.000000000","message":"Same as above.","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"be9dde35cd3071489b2a1abdcd62e0bd376416ec","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Override service catalog lookup with template for"},{"line_number":58,"context_line":"barbican endpoint e.g."},{"line_number":59,"context_line":"http://localhost:9311/v1/%(project_id)s"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Possible values:"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_961588e6","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":39},"in_reply_to":"bab6814e_29d7454c","updated":"2016-05-20 15:05:13.000000000","message":"I think this is again an example of how this option is used and it belongs in help text. BTW these options are deprecated so I thought not to spend anymore time on text of these. Main motive is to deprecate these.","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a84ebf6af24b98ba0bac0c2a0b32a93bd6ed6848","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Override service catalog lookup with template for"},{"line_number":58,"context_line":"barbican endpoint e.g."},{"line_number":59,"context_line":"http://localhost:9311/v1/%(project_id)s"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Possible values:"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_835389e1","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":39},"in_reply_to":"bab6814e_961588e6","updated":"2016-05-20 15:34:37.000000000","message":"+1 for leaving as is in the \u0027format\u0027 section","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2b7f4e21856b5ee8863e8d49886c60a901d6c5fd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Region name of this node"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Possible values:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Services that use this:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_895631cc","line":81,"updated":"2016-05-20 00:17:19.000000000","message":"String + basic info","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"a84ebf6af24b98ba0bac0c2a0b32a93bd6ed6848","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def list_opts():"},{"line_number":103,"context_line":"    return {"},{"line_number":104,"context_line":"        \"DEFAULT\": castellan_opts.list_opts(),"},{"line_number":105,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":106,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_63b4a534","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":16},"updated":"2016-05-20 15:34:37.000000000","message":"I think this should be \"key_manager\" instead?","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"63810a623f1b7e030db280e60bad74d456a7988a","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def list_opts():"},{"line_number":103,"context_line":"    return {"},{"line_number":104,"context_line":"        \"DEFAULT\": castellan_opts.list_opts(),"},{"line_number":105,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":106,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_82aff828","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":16},"in_reply_to":"bab6814e_63b4a534","updated":"2016-05-20 20:29:20.000000000","message":"Done","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6ec8c5b5d95fb7503e451d73ec9a6ae29da6803c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def list_opts():"},{"line_number":103,"context_line":"    return {"},{"line_number":104,"context_line":"        \"DEFAULT\": castellan_opts.list_opts(),"},{"line_number":105,"context_line":"        barbican_group.name: barbican_opts"},{"line_number":106,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_b2537116","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":16},"in_reply_to":"bab6814e_63b4a534","updated":"2016-05-20 17:08:46.000000000","message":"We already have another file in conf \"key_manager\", eventually that will also go away as that is part of Castellan as well. Maybe I should name this as \"Castellan_barbican\"?","commit_id":"77cfe60409fe00dd155c2abd5c4b4ea4a1343a2f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a96a8336c1e0b97d81130f7051c32d351798199e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    opts \u003d [(barbican_group.name, barbican_opts)]"},{"line_number":104,"context_line":"    return opts + castellan_opts.list_opts()"},{"line_number":105,"context_line":"    # Post Newton delete code block from above and comment in line below"},{"line_number":106,"context_line":"    #return castellan_opts.list_opts()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_a8188876","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":38},"updated":"2016-05-25 01:46:48.000000000","message":"pep8 will throw error here:\n- no new line at the end of file.\n- should be \u0027# return\u0027 instead of \u0027#return\u0027","commit_id":"740c7a4dee1e3d72e43255af80f09cd053a82daf"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"34b5da61051292e45a04a1b9c370ffbcacdcd6b9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    opts \u003d [(barbican_group.name, barbican_opts)]"},{"line_number":104,"context_line":"    return opts + castellan_opts.list_opts()"},{"line_number":105,"context_line":"    # Post Newton delete code block from above and comment in line below"},{"line_number":106,"context_line":"    #return castellan_opts.list_opts()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_39b965cc","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":38},"in_reply_to":"bab6814e_a8188876","updated":"2016-05-25 14:52:09.000000000","message":"Thanks for the review. I got excited after fixing other issue and did not run pep8 before pushing my change. Uploading another patch.","commit_id":"740c7a4dee1e3d72e43255af80f09cd053a82daf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3cea9634d1a0a77220e45b27c31e9e14176bf789","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Newton. These will be deleted post Newton"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"barbican_group \u003d cfg.OptGroup("},{"line_number":24,"context_line":"    \u0027barbican_deprecated\u0027,"},{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_2c1621f1","line":24,"updated":"2016-06-07 18:55:29.000000000","message":"Is it not possible to deprecate a whole group? Renaming the group would be an upgrade impact right? Shouldn\u0027t the help text should explain that it\u0027s deprecated along with each option in the group?","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"86097b0d3283a3f572670179b063b3b7c27fb13f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Newton. These will be deleted post Newton"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"barbican_group \u003d cfg.OptGroup("},{"line_number":24,"context_line":"    \u0027barbican_deprecated\u0027,"},{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_930bed8d","line":24,"in_reply_to":"7aa08908_2c1621f1","updated":"2016-06-07 21:50:44.000000000","message":"I looked for an option in oslo.config before making this change to deprecate group but couldn\u0027t find any. That is why i opted for this. \nNo because we still have a group name barbican in Castellan. And if I don\u0027t rename this group it will get removed as duplicate by oslo.config and I figure we don\u0027t want that.\nThere is no help text option for group.","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"78c6a22d9f27037a5dc14598ff0ec580c4411ccc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Newton. These will be deleted post Newton"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"barbican_group \u003d cfg.OptGroup("},{"line_number":24,"context_line":"    \u0027barbican_deprecated\u0027,"},{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_e4234554","line":24,"in_reply_to":"7aa08908_3e2f2340","updated":"2016-06-08 17:16:16.000000000","message":"actually, just drop the group, its already defined inside Castilian, and you can register these using the group string instead (i.e. just pick up what castilian defines the group to be).\n\nThe group is not going away here, just these options. So this seems fine.","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"042fc0315a00f8f76bbe045734618526cfcfe612","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Newton. These will be deleted post Newton"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"barbican_group \u003d cfg.OptGroup("},{"line_number":24,"context_line":"    \u0027barbican_deprecated\u0027,"},{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_3e2f2340","line":24,"in_reply_to":"7aa08908_930bed8d","updated":"2016-06-08 16:05:50.000000000","message":"lets not change the name.\n\nthe group just goes away once all the options in the group are deleted.","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3cea9634d1a0a77220e45b27c31e9e14176bf789","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["},{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_ace051fb","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":17},"updated":"2016-06-07 18:55:29.000000000","message":"Why change all of the single quotes to double quotes?","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"86097b0d3283a3f572670179b063b3b7c27fb13f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    title\u003d\u0027Barbican deprecated options\u0027)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"barbican_opts \u003d ["},{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_d35d757a","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":17},"in_reply_to":"7aa08908_ace051fb","updated":"2016-06-07 21:50:44.000000000","message":"Well when document is compiled both single and double quotes are removed. I am just following patches from Ed Leafe as he is changing single quotes to double for strings. I should change these on group as well. https://review.openstack.org/#/c/275423/","commit_id":"5143a85d7e0c3051389126336c54272fb7e1e171"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f457306b743c6eff7c6629c837213192410da57e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_2c4e72c1","line":34,"updated":"2016-06-10 08:46:29.000000000","message":"I think we should remove the * and just put this at the first bit of the help text.","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6190380455e5cf35b075e85cdab91db08555e4c0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_6696d695","line":34,"in_reply_to":"7aa08908_2c4e72c1","updated":"2016-06-10 08:56:28.000000000","message":"yeah, the appear here double:\nhttp://docs-draft.openstack.org/84/317684/10/check/gate-nova-docs/e029219//doc/build/html/sample_config.html","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"*DEPRECATED*"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_5ded59b6","line":34,"in_reply_to":"7aa08908_6696d695","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"42e50f7b9dedd3790db7a987bd46fde0d6dc70f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Services that use this:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_4a776602","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":25},"updated":"2016-06-10 06:27:42.000000000","message":"Need to remove this section based on https://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f457306b743c6eff7c6629c837213192410da57e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Services that use this:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_8c5e8674","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":25},"in_reply_to":"7aa08908_4a776602","updated":"2016-06-10 08:46:29.000000000","message":"+1 all these.","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Services that use this:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_9d2d0100","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":25},"in_reply_to":"7aa08908_4a776602","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Services that use this:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_3d3fad26","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":25},"in_reply_to":"7aa08908_8c5e8674","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"42e50f7b9dedd3790db7a987bd46fde0d6dc70f5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* Possible values:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Services that use this:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_ca599690","line":64,"range":{"start_line":64,"start_character":1,"end_line":64,"end_character":25},"updated":"2016-06-10 06:27:42.000000000","message":"Need to remove this section based on https://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* Possible values:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Services that use this:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_7d4935d0","line":64,"range":{"start_line":64,"start_character":1,"end_line":64,"end_character":25},"in_reply_to":"7aa08908_ca599690","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"42e50f7b9dedd3790db7a987bd46fde0d6dc70f5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"* Possible values:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Services that use this:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_aa5eca73","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":25},"updated":"2016-06-10 06:27:42.000000000","message":"Need to remove this section based on https://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"* Possible values:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"* Services that use this:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_bd11ddb1","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":25},"in_reply_to":"7aa08908_aa5eca73","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f457306b743c6eff7c6629c837213192410da57e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    return opts"},{"line_number":116,"context_line":"    # raj_singh: Todo: Post Newton delete code block from above and comment in"},{"line_number":117,"context_line":"    # line below"},{"line_number":118,"context_line":"    # return castellan_opts.list_opts()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_ec6c6a38","line":118,"updated":"2016-06-10 08:46:29.000000000","message":"Nit: I think its fine to leave out this line, just say can directly return list_opts()","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"098c0eacdeaff9e9b21ab021f0b61b265462237e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    return opts"},{"line_number":116,"context_line":"    # raj_singh: Todo: Post Newton delete code block from above and comment in"},{"line_number":117,"context_line":"    # line below"},{"line_number":118,"context_line":"    # return castellan_opts.list_opts()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_9d14e19f","line":118,"in_reply_to":"7aa08908_ec6c6a38","updated":"2016-06-10 14:54:12.000000000","message":"Done","commit_id":"3815b8d35ae2da46e7847889ad7bb7610fbc345e"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"192bd2e35c50a393739da74dbe4fdb1c0ec879f3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"DEPRECATED"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_cfd22434","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":10},"updated":"2016-06-10 17:23:25.000000000","message":"In the resulting conf file, DEPRECATED shows up twice because it is also auto-generated from the deprecated flag, maybe this should be removed?\n\nhttp://docs-draft.openstack.org/84/317684/11/check/gate-nova-docs/421fa5e//doc/build/html/sample_config.html","commit_id":"d3148b8ddb7b3f9965ffc04378787f16696cc3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"9162de6b738be81d9e4796ce7ef0a49be82a9300","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"DEPRECATED"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Info to match when looking for barbican in the service"},{"line_number":37,"context_line":"catalog. Format is: separated values of the form:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aa08908_aa334612","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":10},"in_reply_to":"7aa08908_cfd22434","updated":"2016-06-10 18:27:02.000000000","message":"Yes looks like it. I am going to remove it and see how it looks. Somehow duplicate does not appear on my local tests","commit_id":"d3148b8ddb7b3f9965ffc04378787f16696cc3bb"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"fd9a3759e222b4d40be2c5940d9df78ae1f75b2e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_af7231ab","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":75},"updated":"2016-06-21 14:29:39.000000000","message":"-\u003e This option has been moved to the Castellan\n\n(same comment for duplicates below)","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8bfd884db18ec1e33999ce344cfd75183097611f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_31a5d846","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":75},"in_reply_to":"3aaa91ec_4418bd84","updated":"2016-06-29 16:32:53.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fdb641d2b8780c315acb3b55072f1ca88e45dc5e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_4418bd84","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":75},"in_reply_to":"5a9d85d2_af7231ab","updated":"2016-06-29 10:18:44.000000000","message":"+1","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8bfd884db18ec1e33999ce344cfd75183097611f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to Castellan \""},{"line_number":32,"context_line":"                                  \"library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_f1aeb02c","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":75},"in_reply_to":"5a9d85d2_af7231ab","updated":"2016-06-29 16:32:53.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fdb641d2b8780c315acb3b55072f1ca88e45dc5e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Info to match when looking for barbican in the service"},{"line_number":35,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":36,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Related options:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    None"},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":"    cfg.StrOpt(\"endpoint_template\","},{"line_number":46,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_1729c589","line":43,"range":{"start_line":37,"start_character":0,"end_line":43,"end_character":8},"updated":"2016-06-29 10:18:44.000000000","message":"we should drop all these now, and the ones below.","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8bfd884db18ec1e33999ce344cfd75183097611f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Info to match when looking for barbican in the service"},{"line_number":35,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":36,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Possible values:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Related options:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    None"},{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":"    cfg.StrOpt(\"endpoint_template\","},{"line_number":46,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_91648c22","line":43,"range":{"start_line":37,"start_character":0,"end_line":43,"end_character":8},"in_reply_to":"3aaa91ec_1729c589","updated":"2016-06-29 16:32:53.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"fd9a3759e222b4d40be2c5940d9df78ae1f75b2e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def register_opts(conf):"},{"line_number":79,"context_line":"    castellan_opts.set_defaults(conf)"},{"line_number":80,"context_line":"    # raj_singh: Todo: Code block below is deprecated and will be removed"},{"line_number":81,"context_line":"    # post Newton"},{"line_number":82,"context_line":"    conf.register_group(barbican_group)"},{"line_number":83,"context_line":"    conf.register_opts(barbican_opts, group\u003dbarbican_group)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_efc0b97e","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":22},"updated":"2016-06-21 14:29:39.000000000","message":"-\u003e TODO(raj_singh):\n\n(same comment for duplicates below)","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8bfd884db18ec1e33999ce344cfd75183097611f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def register_opts(conf):"},{"line_number":79,"context_line":"    castellan_opts.set_defaults(conf)"},{"line_number":80,"context_line":"    # raj_singh: Todo: Code block below is deprecated and will be removed"},{"line_number":81,"context_line":"    # post Newton"},{"line_number":82,"context_line":"    conf.register_group(barbican_group)"},{"line_number":83,"context_line":"    conf.register_opts(barbican_opts, group\u003dbarbican_group)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_517fc4aa","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":22},"in_reply_to":"3aaa91ec_241bf181","updated":"2016-06-29 16:32:53.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fdb641d2b8780c315acb3b55072f1ca88e45dc5e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def register_opts(conf):"},{"line_number":79,"context_line":"    castellan_opts.set_defaults(conf)"},{"line_number":80,"context_line":"    # raj_singh: Todo: Code block below is deprecated and will be removed"},{"line_number":81,"context_line":"    # post Newton"},{"line_number":82,"context_line":"    conf.register_group(barbican_group)"},{"line_number":83,"context_line":"    conf.register_opts(barbican_opts, group\u003dbarbican_group)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_241bf181","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":22},"in_reply_to":"5a9d85d2_efc0b97e","updated":"2016-06-29 10:18:44.000000000","message":"+1","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"8bfd884db18ec1e33999ce344cfd75183097611f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def register_opts(conf):"},{"line_number":79,"context_line":"    castellan_opts.set_defaults(conf)"},{"line_number":80,"context_line":"    # raj_singh: Todo: Code block below is deprecated and will be removed"},{"line_number":81,"context_line":"    # post Newton"},{"line_number":82,"context_line":"    conf.register_group(barbican_group)"},{"line_number":83,"context_line":"    conf.register_opts(barbican_opts, group\u003dbarbican_group)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_716920f9","line":80,"range":{"start_line":80,"start_character":6,"end_line":80,"end_character":22},"in_reply_to":"5a9d85d2_efc0b97e","updated":"2016-06-29 16:32:53.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1720654227e5d9d1d018f3931732f3b81ce841af","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to the\""},{"line_number":32,"context_line":"                                  \"Castellan library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a3d68d4c","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":70},"updated":"2016-07-20 19:58:13.000000000","message":"Formatting nit: if there is no space at the end, this param will look like this in doc: This option have been moved to theCastellan library\n\nThis is also the case in other places so apply this comment in other options as well.","commit_id":"359c3c45df1586da854f079e6ef0536dcb412a6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"79187dcc0bb873c1f1e9f31ba93d4cf4ce93420f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     cfg.StrOpt(\"catalog_info\","},{"line_number":29,"context_line":"                default\u003d\"key-manager:barbican:public\","},{"line_number":30,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":31,"context_line":"                deprecated_reason\u003d\"This option have been moved to the\""},{"line_number":32,"context_line":"                                  \"Castellan library\","},{"line_number":33,"context_line":"                help\u003d\"\"\""},{"line_number":34,"context_line":"Info to match when looking for barbican in the service"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_5eaca39e","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":70},"in_reply_to":"dada55a8_a3d68d4c","updated":"2016-07-27 12:30:02.000000000","message":"+1","commit_id":"359c3c45df1586da854f079e6ef0536dcb412a6d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1720654227e5d9d1d018f3931732f3b81ce841af","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":49,"context_line":"               deprecated_reason\u003d\"This option have been moved to the\""},{"line_number":50,"context_line":"                                 \"Castellan library\","},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"Region name of this node"},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_2371fd76","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":5},"updated":"2016-07-20 19:58:13.000000000","message":"Nit: this can be one line.","commit_id":"359c3c45df1586da854f079e6ef0536dcb412a6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"79187dcc0bb873c1f1e9f31ba93d4cf4ce93420f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":49,"context_line":"               deprecated_reason\u003d\"This option have been moved to the\""},{"line_number":50,"context_line":"                                 \"Castellan library\","},{"line_number":51,"context_line":"               help\u003d\"\"\""},{"line_number":52,"context_line":"Region name of this node"},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_3e8a8f1b","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":5},"in_reply_to":"dada55a8_2371fd76","updated":"2016-07-27 12:30:02.000000000","message":"-1 we should be consistent with the intent.","commit_id":"359c3c45df1586da854f079e6ef0536dcb412a6d"}],"releasenotes/notes/deprecate-barbican-config-options-68ae65643ac41e2f.yaml":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"fd9a3759e222b4d40be2c5940d9df78ae1f75b2e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - All barbican config options in Nova are now"},{"line_number":4,"context_line":"    deprecated and may be removed as early as 15.0.0"},{"line_number":5,"context_line":"    release. All these options are moved to Castellan"},{"line_number":6,"context_line":"    library."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a9d85d2_af2a312a","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":23},"updated":"2016-06-21 14:29:39.000000000","message":"-\u003e All of these","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"fd9a3759e222b4d40be2c5940d9df78ae1f75b2e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - All barbican config options in Nova are now"},{"line_number":4,"context_line":"    deprecated and may be removed as early as 15.0.0"},{"line_number":5,"context_line":"    release. All these options are moved to Castellan"},{"line_number":6,"context_line":"    library."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5a9d85d2_2f0001aa","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":53},"updated":"2016-06-21 14:29:39.000000000","message":"-\u003e to the Castellan","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"60fc9babd173cd3c803961640f090ddce6849837","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - All barbican config options in Nova are now"},{"line_number":4,"context_line":"    deprecated and may be removed as early as 15.0.0"},{"line_number":5,"context_line":"    release. All these options are moved to Castellan"},{"line_number":6,"context_line":"    library."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_14fb6ac2","line":5,"range":{"start_line":5,"start_character":41,"end_line":5,"end_character":53},"in_reply_to":"5a9d85d2_2f0001aa","updated":"2016-06-29 16:37:54.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"60fc9babd173cd3c803961640f090ddce6849837","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - All barbican config options in Nova are now"},{"line_number":4,"context_line":"    deprecated and may be removed as early as 15.0.0"},{"line_number":5,"context_line":"    release. All these options are moved to Castellan"},{"line_number":6,"context_line":"    library."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3aaa91ec_f4f7bed0","line":5,"range":{"start_line":5,"start_character":13,"end_line":5,"end_character":23},"in_reply_to":"5a9d85d2_af2a312a","updated":"2016-06-29 16:37:54.000000000","message":"Done","commit_id":"ae0da752529bdedb19fda5d285110788eca085ec"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1720654227e5d9d1d018f3931732f3b81ce841af","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - All barbican config options in Nova are now"},{"line_number":4,"context_line":"    deprecated and may be removed as early as 15.0.0"},{"line_number":5,"context_line":"    release. All of these options are moved to the "},{"line_number":6,"context_line":"    Castellan library."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"dada55a8_23f8ddc2","line":5,"range":{"start_line":5,"start_character":50,"end_line":5,"end_character":51},"updated":"2016-07-20 19:58:13.000000000","message":"A sin! :D","commit_id":"359c3c45df1586da854f079e6ef0536dcb412a6d"}]}