)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c9f39fd1baeae5c0fb60318595c3734ad84f54e8","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                                  disk_name))"},{"line_number":1026,"context_line":"        self.resolve_driver_format()"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"},{"line_number":1029,"context_line":"        filename \u003d os.path.split(base)[-1]"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        @utils.synchronized(filename, external\u003dTrue, lock_path\u003dself.lock_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9abb7d3a_d480338e","line":1028,"updated":"2016-06-02 15:50:20.000000000","message":"Can\u0027t you refactor this to use the new methods below and remove all the duplicated code? It would be nice to prove that the new methods work here by using them in this method, even if you\u0027re going to remove it at the end of the series.\n\nOtherwise, we don\u0027t get validation that the new stuff (really) works until later when we start using it. It would be a lot better to avoid a bit inflate/deflate operation if we can help it, IMHO.","commit_id":"76195e7cae58d5dd3a448d49c95455ff99bd7577"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"0b97fdb4002e3a14e23eca528be1ec1d8b142e9f","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                                  disk_name))"},{"line_number":1026,"context_line":"        self.resolve_driver_format()"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"},{"line_number":1029,"context_line":"        filename \u003d os.path.split(base)[-1]"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        @utils.synchronized(filename, external\u003dTrue, lock_path\u003dself.lock_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9abb7d3a_4791169a","line":1028,"in_reply_to":"9abb7d3a_2b303d9e","updated":"2016-06-03 13:31:12.000000000","message":"I refactored some of the trivial stuff out of the to-be-deleted code, but that\u0027s about all I can do without also changing the driver code since this isn\u0027t a straight forward refactor (the responsibilities/boundaries have changed).","commit_id":"76195e7cae58d5dd3a448d49c95455ff99bd7577"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c4d788cad52b7cec41212b114f86da9b42bc8b10","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                                  disk_name))"},{"line_number":1026,"context_line":"        self.resolve_driver_format()"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    def create_image(self, prepare_template, base, size, *args, **kwargs):"},{"line_number":1029,"context_line":"        filename \u003d os.path.split(base)[-1]"},{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"        @utils.synchronized(filename, external\u003dTrue, lock_path\u003dself.lock_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9abb7d3a_2b303d9e","line":1028,"in_reply_to":"9abb7d3a_d480338e","updated":"2016-06-02 16:10:54.000000000","message":"Sure, I can do that for some of the trivial helpers, but not for some of the big picture stuff b/c of the way it cuts across cache/driver/backend.\n\nLike you, I would prefer the added confidence. I had been making sure not to touch the old code b/c I thought that\u0027s what the reviewers would prefer. Happy to hear I can go ahead and make changes to it though.\n\nThanks for the review!","commit_id":"76195e7cae58d5dd3a448d49c95455ff99bd7577"}]}