)]}'
{"nova/conf/network.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"4ebb4f0c3a27114f3dd38d26edda9002b3022af4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"nova-network, it is also used by libvirt and xenapi for the bridge interface"},{"line_number":134,"context_line":"name."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Please note that this setting will be ignored n nova-\u003dnetwork if the"},{"line_number":137,"context_line":"configuration option for `network_manager` is not set to the default of"},{"line_number":138,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_96d773be","line":136,"range":{"start_line":136,"start_character":46,"end_line":136,"end_character":61},"updated":"2016-05-19 20:55:56.000000000","message":"is this intended or typo?","commit_id":"ecf932ef3419c8c9fd8423445c6800e158776b31"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"9233c3e0c614ac039fb8640455361f7b51ec47f4","unresolved":false,"context_lines":[{"line_number":133,"context_line":"nova-network, it is also used by libvirt and xenapi for the bridge interface"},{"line_number":134,"context_line":"name."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Please note that this setting will be ignored n nova-\u003dnetwork if the"},{"line_number":137,"context_line":"configuration option for `network_manager` is not set to the default of"},{"line_number":138,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_e77a32b9","line":136,"range":{"start_line":136,"start_character":46,"end_line":136,"end_character":61},"in_reply_to":"7aa08908_edeb33da","updated":"2016-06-14 12:30:52.000000000","message":"Oh, picky picky.\n\n:)","commit_id":"ecf932ef3419c8c9fd8423445c6800e158776b31"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0758ad844890d9b0f1ac980625b01303946088bb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"nova-network, it is also used by libvirt and xenapi for the bridge interface"},{"line_number":134,"context_line":"name."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Please note that this setting will be ignored n nova-\u003dnetwork if the"},{"line_number":137,"context_line":"configuration option for `network_manager` is not set to the default of"},{"line_number":138,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_edeb33da","line":136,"range":{"start_line":136,"start_character":46,"end_line":136,"end_character":61},"in_reply_to":"bab6814e_96d773be","updated":"2016-06-08 15:31:36.000000000","message":"yeah, this seems wrong.","commit_id":"ecf932ef3419c8c9fd8423445c6800e158776b31"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d365d0282c96813c322fbf1d518a7494bbe1b0e1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    True, False (default)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Services that use this:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4e17daa2","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":38},"updated":"2016-06-14 14:24:22.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4e57652fd9647ce0ce4dd4222b22b50385a525d5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    True, False (default)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Services that use this:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_87d56344","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"7aa08908_1b43d66d","updated":"2016-06-17 18:16:38.000000000","message":"OK, since the whole patch series precedes this consistency change, I\u0027ll edit those patches, since as John points out, they would have to be merged first, and it seems wrong to merge an edit that we want to delete.","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8bb4624b18d9baad1e092aa2a55b56495f0ad6f4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    True, False (default)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Services that use this:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_52e57bda","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"7aa08908_4e17daa2","updated":"2016-06-15 15:51:07.000000000","message":"That is out-of-scope for this patch. Removing code for the consistency stuff should be in a separate patch.","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8d25b19844e8bbdb05d3ee03969ba0a8f2ce8c5e","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    True, False (default)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Services that use this:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1b43d66d","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"7aa08908_52e57bda","updated":"2016-06-16 15:39:05.000000000","message":"If the scope of patch is to improve a text message, then removing redundant lines seems in scope for me. If we can add, we can also remove :)\n\nConsistency is one thing, and the growing number of reviews is other. Consistency is good, but maybe this time it just sacrifices too much time on review queue just because of one supposedly inconsistent nit :)","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ff8c109e38533da938de4fe65fd68312dc0ca3a4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    True, False (default)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Services that use this:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Related options:"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_41d3b9d5","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":38},"in_reply_to":"7aa08908_52e57bda","updated":"2016-06-16 12:47:30.000000000","message":"to me it seems wrong to merge an edit to a section we really want to delete.","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d365d0282c96813c322fbf1d518a7494bbe1b0e1","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Any valid virtual interface name, such as \u0027eth0\u0027"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* Services that use this:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Related options:"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6e7bb6f5","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":38},"updated":"2016-06-14 14:24:22.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d365d0282c96813c322fbf1d518a7494bbe1b0e1","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    Any valid virtual interface name, such as \u0027eth0\u0027"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"* Services that use this:"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    ``nova-network``, ``nova-compute``"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Related options:"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ce6aaa19","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":38},"updated":"2016-06-14 14:24:22.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"cfc0ebeb9c7f871cf7d57dbca3e35880e129bc0e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"2d16436940002da27ff23413a8aa00df9e70fbc4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"nova-network, it is also used by the vmware and xenapi virt drivers to control"},{"line_number":62,"context_line":"whether network information is injected into a VM."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Possible values:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    True, False (default)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* Related options:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_5ce27b30","line":66,"range":{"start_line":64,"start_character":0,"end_line":66,"end_character":25},"updated":"2016-06-28 16:09:18.000000000","message":"If you get to raise another patch then drop this section as default value is already in the doc (flat_injected \u003d false). And being a boolean it is obvious other value could be only TRUE.\nhttp://docs-draft.openstack.org/26/318726/4/check/gate-nova-docs/49629c4//doc/build/html/sample_config.html","commit_id":"d4235d53f65e150b808874e3d9447dc47dae6447"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2160c8e71655a69af2a2bd47e7f0d332d7614b71","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Related options:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    ``use_neutron``"},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt(\"flat_interface\","},{"line_number":76,"context_line":"            help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_0d28b1e1","line":73,"updated":"2016-07-05 13:03:32.000000000","message":"should we not drop this now?","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3892fc3f2a6d9c1ac117adb7f827e892f5ae62de","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Related options:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    ``use_neutron``"},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.StrOpt(\"flat_interface\","},{"line_number":76,"context_line":"            help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d903fd40","line":73,"in_reply_to":"1aa78d24_0d28b1e1","updated":"2016-07-05 16:40:03.000000000","message":"Done","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2160c8e71655a69af2a2bd47e7f0d332d7614b71","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* Related options:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    ``use_neutron``"},{"line_number":88,"context_line":"\"\"\"),"},{"line_number":89,"context_line":"    cfg.IntOpt(\"vlan_start\","},{"line_number":90,"context_line":"            default\u003d100,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_8d7ae1ef","line":87,"updated":"2016-07-05 13:03:32.000000000","message":"should we not drop this now?","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3892fc3f2a6d9c1ac117adb7f827e892f5ae62de","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"* Related options:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    ``use_neutron``"},{"line_number":88,"context_line":"\"\"\"),"},{"line_number":89,"context_line":"    cfg.IntOpt(\"vlan_start\","},{"line_number":90,"context_line":"            default\u003d100,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_b9fef135","line":87,"in_reply_to":"1aa78d24_8d7ae1ef","updated":"2016-07-05 16:40:03.000000000","message":"Done","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2160c8e71655a69af2a2bd47e7f0d332d7614b71","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Related options:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    ``use_neutron``"},{"line_number":130,"context_line":"\"\"\"),"},{"line_number":131,"context_line":"    cfg.IntOpt(\"num_networks\","},{"line_number":132,"context_line":"            default\u003d1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_cd84e9d5","line":129,"updated":"2016-07-05 13:03:32.000000000","message":"as above","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3892fc3f2a6d9c1ac117adb7f827e892f5ae62de","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Related options:"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    ``use_neutron``"},{"line_number":130,"context_line":"\"\"\"),"},{"line_number":131,"context_line":"    cfg.IntOpt(\"num_networks\","},{"line_number":132,"context_line":"            default\u003d1,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_19fe2537","line":129,"in_reply_to":"1aa78d24_cd84e9d5","updated":"2016-07-05 16:40:03.000000000","message":"Done","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2160c8e71655a69af2a2bd47e7f0d332d7614b71","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* Related options:"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    ``network_manager``, ``use_neutron``, ``vpn_start``"},{"line_number":171,"context_line":"\"\"\"),"},{"line_number":172,"context_line":"    cfg.IntOpt(\"vpn_start\","},{"line_number":173,"context_line":"            default\u003d1000,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_8dc82124","line":170,"updated":"2016-07-05 13:03:32.000000000","message":"Nit: probably better if this were in the previous change, but its a nit.","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3892fc3f2a6d9c1ac117adb7f827e892f5ae62de","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"* Related options:"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    ``network_manager``, ``use_neutron``, ``vpn_start``"},{"line_number":171,"context_line":"\"\"\"),"},{"line_number":172,"context_line":"    cfg.IntOpt(\"vpn_start\","},{"line_number":173,"context_line":"            default\u003d1000,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_59054d78","line":170,"in_reply_to":"1aa78d24_8dc82124","updated":"2016-07-05 16:40:03.000000000","message":"Well, since I\u0027m respinning them all, I\u0027ll move it.","commit_id":"e0bd524392fb95f9a79d0e82f8b52ace5bd3044b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e641aee8e794d4162ab6eec5d7fde14da3b45503","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    ``use_neutron``"},{"line_number":62,"context_line":"\"\"\"),"},{"line_number":63,"context_line":"    cfg.BoolOpt(\"flat_injected\","},{"line_number":64,"context_line":"            default\u003dFalse,"},{"line_number":65,"context_line":"            help\u003d\"\"\""},{"line_number":66,"context_line":"This option determines whether the network setup information is injected into"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_54574357","line":63,"updated":"2016-07-22 01:39:53.000000000","message":"This is also set in the network object in the vif model for neutron:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n1948\n\nBut I\u0027m not sure if that\u0027s necessary or not, or what\u0027s using it in the case of neutron.","commit_id":"f97ddf091eb1b41a5c4487766783a2a4c3c66120"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e641aee8e794d4162ab6eec5d7fde14da3b45503","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            help\u003d\"\"\""},{"line_number":73,"context_line":"This option is the name of the virtual interface of the VM on which the bridge"},{"line_number":74,"context_line":"will be built. While it was originally designed to be used only by"},{"line_number":75,"context_line":"nova-network, it is also used by libvirt for the bridge interface name."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_54b3c397","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":70},"updated":"2016-07-22 01:39:53.000000000","message":"\"if a bridge_interface is not defined on the network that virtual interfaces will be plugged into.\"\n\nBy looking at:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/vif.py#n488\n\nBut I\u0027m not seeing what\u0027s setting bridge_interface in the network model meta, it doesn\u0027t look like that happens for neutron anyway - they do set a bridge value though. Looks like bridge_interface is only set on n-net networks, but I wonder if bridge is the same thing for neutron and if so, why isn\u0027t it used in nova/virt/libvirt/vif.py?\n\nSince danpb is working on os-vif, we might want him to review this.","commit_id":"f97ddf091eb1b41a5c4487766783a2a4c3c66120"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b7bf90c48945c5a953832f4a0c5dad3cb57e618b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            help\u003d\"\"\""},{"line_number":73,"context_line":"This option is the name of the virtual interface of the VM on which the bridge"},{"line_number":74,"context_line":"will be built. While it was originally designed to be used only by"},{"line_number":75,"context_line":"nova-network, it is also used by libvirt for the bridge interface name."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_1dab23d8","line":75,"range":{"start_line":75,"start_character":14,"end_line":75,"end_character":70},"in_reply_to":"dada55a8_54b3c397","updated":"2016-07-22 08:12:53.000000000","message":"The vif_plug_linux_bridge plugin for os-vif has a \u0027flat_interface\u0027 config parameter name, so we maintain this current logic. It would be nice to guarantee that bridge_interface is set in the network model by n-net \u0026 neutron though","commit_id":"f97ddf091eb1b41a5c4487766783a2a4c3c66120"}]}