)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"49950e92eac6d3f9f37c572ab70621052b7c1a08","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def create_from_func(self, context, func, cache_name, size,"},{"line_number":113,"context_line":"                         fallback_from_host\u003dNone):"},{"line_number":114,"context_line":"        \"\"\"Create a disk from the output of a function. Used to create"},{"line_number":115,"context_line":"        ephemeral and swap disks."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :context: The current request context."},{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_17d1e1cd","line":115,"updated":"2016-05-25 11:28:14.000000000","message":"Which function will be used to create \u0027config drive\u0027 disk?","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"3ff44aea8f1e924d6bf8d2c3ba759385bcb7e2a4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def create_from_func(self, context, func, cache_name, size,"},{"line_number":113,"context_line":"                         fallback_from_host\u003dNone):"},{"line_number":114,"context_line":"        \"\"\"Create a disk from the output of a function. Used to create"},{"line_number":115,"context_line":"        ephemeral and swap disks."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        :context: The current request context."},{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_c57687a2","line":115,"in_reply_to":"bab6814e_17d1e1cd","updated":"2016-06-03 13:28:13.000000000","message":"It will continue to use the existing import_file code path for now, but the goal is for it to use create_from_func eventually (out of scope for now, I suspect).","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"49950e92eac6d3f9f37c572ab70621052b7c1a08","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :context: The current request context."},{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"},{"line_number":119,"context_line":"               to the given path."},{"line_number":120,"context_line":"        :cache_name: A name which can be used as a cache key for the output."},{"line_number":121,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":122,"context_line":"        :fallback_from_host: A compute host to side-load the output from."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_5589a1c9","line":120,"updated":"2016-05-25 11:28:14.000000000","message":"\u0027for the output\u0027 of what?","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cedc0074a496b0e56160d125e1edeba21e27a53","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        :context: The current request context."},{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"},{"line_number":119,"context_line":"               to the given path."},{"line_number":120,"context_line":"        :cache_name: A name which can be used as a cache key for the output."},{"line_number":121,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":122,"context_line":"        :fallback_from_host: A compute host to side-load the output from."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_e3e3f131","line":120,"in_reply_to":"bab6814e_5589a1c9","updated":"2016-06-02 20:29:28.000000000","message":"Changed to: \u0027the output of the given function\u0027. Do let me know if you think it\u0027s still not clear enough.","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"49950e92eac6d3f9f37c572ab70621052b7c1a08","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"},{"line_number":119,"context_line":"               to the given path."},{"line_number":120,"context_line":"        :cache_name: A name which can be used as a cache key for the output."},{"line_number":121,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":122,"context_line":"        :fallback_from_host: A compute host to side-load the output from."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_260e7532","line":121,"updated":"2016-05-25 11:28:14.000000000","message":"What is expected beharior, if the size is greater or lesser than size of \u0027output\u0027 created by the func?","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cedc0074a496b0e56160d125e1edeba21e27a53","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        :func: A function, taking a path argument, which will write data"},{"line_number":119,"context_line":"               to the given path."},{"line_number":120,"context_line":"        :cache_name: A name which can be used as a cache key for the output."},{"line_number":121,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":122,"context_line":"        :fallback_from_host: A compute host to side-load the output from."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_238cd934","line":121,"in_reply_to":"bab6814e_260e7532","updated":"2016-06-02 20:29:28.000000000","message":"Great question – I also wondered this.\n\nI believe mdbooth expects the caller to provide a sane size value wrt the function output, but I\u0027ll check with him.\n\nCurrently, no additional verification is done on the size value at this point. And both verify_base_size and resizing only happens in the create_from_image case (not the create_from_func case).","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"49950e92eac6d3f9f37c572ab70621052b7c1a08","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :context: The current request context."},{"line_number":133,"context_line":"        :image_id: The image_id of the image to be fetched."},{"line_number":134,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":135,"context_line":"        :fallback_from_host: A compute host to side-load the image from"},{"line_number":136,"context_line":"                             if it is no longer in glance."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_e6462d7a","line":134,"updated":"2016-05-25 11:28:14.000000000","message":"The same question about behavior.","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cedc0074a496b0e56160d125e1edeba21e27a53","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :context: The current request context."},{"line_number":133,"context_line":"        :image_id: The image_id of the image to be fetched."},{"line_number":134,"context_line":"        :size: The size of the disk to create, in bytes."},{"line_number":135,"context_line":"        :fallback_from_host: A compute host to side-load the image from"},{"line_number":136,"context_line":"                             if it is no longer in glance."},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_03fc353d","line":134,"in_reply_to":"bab6814e_e6462d7a","updated":"2016-06-02 20:29:28.000000000","message":"Nothing happens if the two sizes are equal. A smaller size will result in a FlavorDiskSmallerThanImage exception, and a larger size will results in a backend specific resize.","commit_id":"0182de23a91e8e4b805684a6e5eb7c0a5b16300f"}]}