)]}'
{"nova/objects/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a06e0c651ea1b9e61d43c6da3cf737d9c797187f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \u0027created_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":181,"context_line":"        \u0027updated_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":182,"context_line":"        \u0027deleted_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":183,"context_line":"        \u0027deleted\u0027: int,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F4JQ%3D","line":183,"updated":"2013-06-06 21:57:41.000000000","message":"Why not a bool?","commit_id":"15fe833f5fb8d847a21061d802d194a74cf3d0ad"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8dc782f4254a4f1df7b0a3901b9d560b6f17c5c1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \u0027created_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":181,"context_line":"        \u0027updated_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":182,"context_line":"        \u0027deleted_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":183,"context_line":"        \u0027deleted\u0027: int,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F2Jw%3D","line":183,"in_reply_to":"AAAAPX%2F%2F2KI%3D","updated":"2013-06-07 17:41:31.000000000","message":"And what for models, that have deleted with type String?","commit_id":"15fe833f5fb8d847a21061d802d194a74cf3d0ad"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c052b8f37f20dcf07ecaf6d3aedbab4b7a703944","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \u0027created_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":181,"context_line":"        \u0027updated_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":182,"context_line":"        \u0027deleted_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":183,"context_line":"        \u0027deleted\u0027: int,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F2I8%3D","line":183,"in_reply_to":"AAAAPX%2F%2F2KI%3D","updated":"2013-06-07 17:46:47.000000000","message":"It\u0027s just an int and that field type is already tested, so I don\u0027t think it\u0027s necessarily worth another spin. All the objects patches are behind this one. If I respin, I can make sure that there\u0027s something that just verifies that it\u0027s there in the base class.","commit_id":"15fe833f5fb8d847a21061d802d194a74cf3d0ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2cf88a15c6bffdacc95d5c93b0813839d15d8365","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \u0027created_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":181,"context_line":"        \u0027updated_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":182,"context_line":"        \u0027deleted_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":183,"context_line":"        \u0027deleted\u0027: int,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F2KI%3D","line":183,"in_reply_to":"AAAAPX%2F%2F4Ik%3D","updated":"2013-06-07 17:38:07.000000000","message":"OK, is it asking too much to add a test case in this patch for the case that deleted \u003d 1?  The tests are covering deleted \u003d 0.","commit_id":"15fe833f5fb8d847a21061d802d194a74cf3d0ad"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"a4c7eff2ecaa8b04f36f81d603e1d4adbfd33a3c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        \u0027created_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":181,"context_line":"        \u0027updated_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":182,"context_line":"        \u0027deleted_at\u0027: obj_utils.datetime_or_str_or_none,"},{"line_number":183,"context_line":"        \u0027deleted\u0027: int,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F4Ik%3D","line":183,"in_reply_to":"AAAAPX%2F%2F4JQ%3D","updated":"2013-06-06 22:00:00.000000000","message":"It used to be a bool, but it was changed to an int so it can match the type of our DB key fields and make some operations more efficient.","commit_id":"15fe833f5fb8d847a21061d802d194a74cf3d0ad"}],"nova/tests/objects/test_instance.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"e97375236b64de74d55e2016751f44037d0ada99","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        db.instance_get_by_uuid(ctxt, fake_uuid, []).AndReturn(fake_inst)"},{"line_number":185,"context_line":"        self.mox.ReplayAll()"},{"line_number":186,"context_line":"        inst \u003d instance.Instance.get_by_uuid(ctxt, fake_uuid)"},{"line_number":187,"context_line":"        # NOTE(danms): Make sure it\u0027s actually a bool"},{"line_number":188,"context_line":"        self.assertEqual(inst.deleted, True)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fzes%3D","line":187,"updated":"2013-06-10 09:06:49.000000000","message":"why don\u0027t you use something like `self.assertTrue(isinstance(inst.deleted, bool))` here?","commit_id":"91ac85ce82bc6d050b1152dd7af8851b43b01ea5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1592c0c06de00e185bc936c3cc5882a23ee1ca12","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        db.instance_get_by_uuid(ctxt, fake_uuid, []).AndReturn(fake_inst)"},{"line_number":185,"context_line":"        self.mox.ReplayAll()"},{"line_number":186,"context_line":"        inst \u003d instance.Instance.get_by_uuid(ctxt, fake_uuid)"},{"line_number":187,"context_line":"        # NOTE(danms): Make sure it\u0027s actually a bool"},{"line_number":188,"context_line":"        self.assertEqual(inst.deleted, True)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FzGw%3D","line":187,"in_reply_to":"AAAAPX%2F%2Fzes%3D","updated":"2013-06-10 13:34:01.000000000","message":"Like the comment says, I want to make sure that it *is* true, not just equates to true. Since the value is and should be cast to a boolean, checking that it \"is True\" verifies this fact.","commit_id":"91ac85ce82bc6d050b1152dd7af8851b43b01ea5"}]}