)]}'
{"nova/conf/notifications.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"28ee729e3bafeb6d5f263afac65720518d551c6e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    cfg.StrOpt(\u0027notify_on_state_change\u0027,"},{"line_number":21,"context_line":"            choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":22,"context_line":"            help\u003d\"\"\""},{"line_number":23,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":24,"context_line":"changes. Valid values are None for no notifications, \"vm_state\" for"},{"line_number":25,"context_line":"notifications on VM state changes, or \"vm_and_task_state\" for notifications"},{"line_number":26,"context_line":"on VM and task state changes."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_ee0b5622","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":7},"updated":"2016-05-31 21:48:35.000000000","message":"I feel this can be refactored for better documentation. This sentence just seems like a one liner instruction.","commit_id":"a725b6fbfb73e375dc2ba4b16ef62167ef9cb128"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"28ee729e3bafeb6d5f263afac65720518d551c6e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":22,"context_line":"            help\u003d\"\"\""},{"line_number":23,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":24,"context_line":"changes. Valid values are None for no notifications, \"vm_state\" for"},{"line_number":25,"context_line":"notifications on VM state changes, or \"vm_and_task_state\" for notifications"},{"line_number":26,"context_line":"on VM and task state changes."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Possible values:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_13424368","line":26,"range":{"start_line":24,"start_character":9,"end_line":26,"end_character":28},"updated":"2016-05-31 21:48:35.000000000","message":"This belongs in Possible values section and is redundant.","commit_id":"a725b6fbfb73e375dc2ba4b16ef62167ef9cb128"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"366d712d76eeab0160a8d6e5f3ee090cd05d114a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* None - no notifications"},{"line_number":31,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":32,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Services that use this:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_cb5f580d","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":48},"updated":"2016-05-26 18:10:19.000000000","message":"nit: Can we list one of vm state just as an example?","commit_id":"a725b6fbfb73e375dc2ba4b16ef62167ef9cb128"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"00063c4b16af2555d39b394188c442a5ae1d5e89","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Possible values:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* String with valid IP address. Default is IPv4 address of this host."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Services that use this:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_a5abb688","line":91,"updated":"2016-05-27 19:26:11.000000000","message":"IP address is the only possible value here? Can it be node name or valid FQDN as well?","commit_id":"a725b6fbfb73e375dc2ba4b16ef62167ef9cb128"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ad8339049b82729de0de1ed566cde9ea439a5f32","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Possible values:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* None - no notifications"},{"line_number":33,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":34,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1dd6a327","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":25},"updated":"2016-06-08 19:11:17.000000000","message":"Is this set to None by default?  Otherwise seems fine.","commit_id":"b7766e45252ba9ca591d1191dba33c22dc98e60d"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"108920444adc48248cf68cf14e57515fb48dd957","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":34,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Services that use this:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* None"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Related options:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ac589f57","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":6},"updated":"2016-06-10 09:46:36.000000000","message":"Drop all these in another options due to https://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"b7766e45252ba9ca591d1191dba33c22dc98e60d"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"16e788e76f498b3d5539aa9fe16d77e78b1082ed","unresolved":false,"context_lines":[{"line_number":69,"context_line":"* \"ERROR\""},{"line_number":70,"context_line":"* \"CRITICAL\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Services that use this:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* None"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Related options:"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9b9fc65e","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":6},"updated":"2016-06-10 16:11:57.000000000","message":"Need to drop this section from all conf file","commit_id":"2c7b4cff58d7f047fe0a2b89b262d36d1d3ea451"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"16e788e76f498b3d5539aa9fe16d77e78b1082ed","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"* String with valid IP address. Default is IPv4 address of this host."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Services that use this:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* ``None``"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Related options:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5b7c3e20","line":92,"range":{"start_line":90,"start_character":0,"end_line":92,"end_character":10},"updated":"2016-06-10 16:11:57.000000000","message":"same","commit_id":"2c7b4cff58d7f047fe0a2b89b262d36d1d3ea451"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"f244f2e5ad48531e03a131850c1ac403c8296510","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Possible values:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* None - no notifications"},{"line_number":34,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":35,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_1be8dd0f","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":25},"updated":"2016-06-11 06:47:20.000000000","message":"Notify the default value here","commit_id":"cdd6bae957dfe3b2a0ed8d703565a6cf4366729a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"669600c49076ddc2b544fdaa70f2028c8bb0287c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Possible values:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* None - no notifications"},{"line_number":34,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":35,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_5c3869d3","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":25},"in_reply_to":"7aa08908_1be8dd0f","updated":"2016-06-13 16:32:38.000000000","message":"Done","commit_id":"cdd6bae957dfe3b2a0ed8d703565a6cf4366729a"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"f244f2e5ad48531e03a131850c1ac403c8296510","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Possible values:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* \"INFO\""},{"line_number":68,"context_line":"* \"DEBUG\""},{"line_number":69,"context_line":"* \"WARN\""},{"line_number":70,"context_line":"* \"ERROR\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_5bd0a553","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":8},"updated":"2016-06-11 06:47:20.000000000","message":"notify the default value here","commit_id":"cdd6bae957dfe3b2a0ed8d703565a6cf4366729a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"669600c49076ddc2b544fdaa70f2028c8bb0287c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Possible values:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* \"INFO\""},{"line_number":68,"context_line":"* \"DEBUG\""},{"line_number":69,"context_line":"* \"WARN\""},{"line_number":70,"context_line":"* \"ERROR\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_bc318def","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":8},"in_reply_to":"7aa08908_5bd0a553","updated":"2016-06-13 16:32:38.000000000","message":"Done","commit_id":"cdd6bae957dfe3b2a0ed8d703565a6cf4366729a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52a3d92e2695299d437612d8c907b495cb0d4e55","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* None - no notifications (default)"},{"line_number":35,"context_line":"* \"vm_state\" - notifications on VM state changes"},{"line_number":36,"context_line":"* \"vm_and_task_state\" - notifications on VM and task state changes"},{"line_number":37,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_1956a1cd","line":34,"range":{"start_line":34,"start_character":25,"end_line":34,"end_character":35},"updated":"2016-07-01 10:01:27.000000000","message":"drop this","commit_id":"cc4ee7bab9638042df1198768378ad335b71d391"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52a3d92e2695299d437612d8c907b495cb0d4e55","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"Default notification level for outgoing notifications."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Possible values:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* \"INFO\" (default)"},{"line_number":57,"context_line":"* \"DEBUG\""},{"line_number":58,"context_line":"* \"WARN\""},{"line_number":59,"context_line":"* \"ERROR\""},{"line_number":60,"context_line":"* \"CRITICAL\""},{"line_number":61,"context_line":"\"\"\"),"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_d93899a2","line":60,"range":{"start_line":54,"start_character":0,"end_line":60,"end_character":12},"updated":"2016-07-01 10:01:27.000000000","message":"Drop this as we can already extract this from \"CHOICES\". If this doesn\u0027t appear in \u0027nova.conf\u0027 then \u0027oslo.config\u0027 should be changed to fix this.","commit_id":"cc4ee7bab9638042df1198768378ad335b71d391"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52a3d92e2695299d437612d8c907b495cb0d4e55","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027default_publisher_id\u0027,"},{"line_number":65,"context_line":"        default\u003dnetutils.get_my_ipv4(),"},{"line_number":66,"context_line":"        help\u003d\"\"\""},{"line_number":67,"context_line":"Default publisher_id for outgoing notifications."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_594dc93c","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":48},"updated":"2016-07-01 10:01:27.000000000","message":"What is the \u0027published_id\u0027 and why would I want to configure it?","commit_id":"cc4ee7bab9638042df1198768378ad335b71d391"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"52a3d92e2695299d437612d8c907b495cb0d4e55","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* String with valid IP address. Default is IPv4 address of this host."},{"line_number":72,"context_line":"\"\"\"),"},{"line_number":73,"context_line":"]"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_d95ff9e2","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":69},"updated":"2016-07-01 10:01:27.000000000","message":"This is a helpful default, seeing as we haven\u0027t hardcoded this.","commit_id":"cc4ee7bab9638042df1198768378ad335b71d391"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7aee46e8f5fef204fe06a59c58b5a6d3d8809513","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \u0027default_notification_level\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_227820c4","line":42,"updated":"2016-07-25 16:27:32.000000000","message":"I feel like this should be a triple quote string if some of them are in this file. Its a nit though.","commit_id":"9d64952d32c59266ec27938898630cba541979c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7dbfe91f85704abe596bc6f1003111b84613626","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027notify_api_faults\u0027,"},{"line_number":40,"context_line":"        default\u003dFalse,"},{"line_number":41,"context_line":"        help\u003d\"If set, send api.fault notifications on caught exceptions in \""},{"line_number":42,"context_line":"             \"the API service.\"),"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cfg.StrOpt("},{"line_number":45,"context_line":"        \u0027default_notification_level\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_dc3d7b2c","line":42,"in_reply_to":"dada55a8_227820c4","updated":"2016-07-26 11:46:50.000000000","message":"+1","commit_id":"9d64952d32c59266ec27938898630cba541979c2"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"7aee46e8f5fef204fe06a59c58b5a6d3d8809513","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":46,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":47,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027,"},{"line_number":48,"context_line":"                 \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":49,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_421c34c1","line":48,"updated":"2016-07-25 16:27:32.000000000","message":"Why wrap this line? Although that\u0027s a nit.","commit_id":"9d64952d32c59266ec27938898630cba541979c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7dbfe91f85704abe596bc6f1003111b84613626","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        \u0027default_notification_level\u0027,"},{"line_number":46,"context_line":"        default\u003d\u0027INFO\u0027,"},{"line_number":47,"context_line":"        choices\u003d(\u0027DEBUG\u0027, \u0027INFO\u0027, \u0027WARN\u0027,"},{"line_number":48,"context_line":"                 \u0027ERROR\u0027, \u0027CRITICAL\u0027),"},{"line_number":49,"context_line":"        help\u003d\"Default notification level for outgoing notifications.\"),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_1c4433b5","line":48,"in_reply_to":"dada55a8_421c34c1","updated":"2016-07-26 11:46:50.000000000","message":"+1","commit_id":"9d64952d32c59266ec27938898630cba541979c2"}]}