)]}'
{"nova/conf/novnc.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d3211705af2296ef4dd659600c4488b4821c64ac","unresolved":false,"context_lines":[{"line_number":119,"context_line":"* None"},{"line_number":120,"context_line":"\"\"\"),"},{"line_number":121,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":123,"context_line":"               help\u003d\"\"\""},{"line_number":124,"context_line":"Run webserver on same port. Serve files from DIR."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_edcc4563","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":46},"updated":"2016-06-10 19:13:54.000000000","message":"This variable default value is invalid for novnc and is not used at all by spice : https://github.com/openstack/nova/blob/master/nova/cmd/spicehtml5proxy.py and also I think that default should be /usr/share/novnc.\nWill change it in next patch.","commit_id":"f06fc512be319e354cda6773d07190909d79cdaa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"402fe653f6666bbc47271a52900cc83fbfa5367b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":123,"context_line":"               help\u003d\"\"\""},{"line_number":124,"context_line":"Run webserver on same port. Serve files from DIR."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Possible values:"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ccb5a77e","line":124,"updated":"2016-05-21 20:19:34.000000000","message":"The above help text isn\u0027t very good :) What is the value of the config option exactly? What does running a webserver on same (same as what exactly?) port have to do with a directory/filepath value?","commit_id":"f06fc512be319e354cda6773d07190909d79cdaa"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"d40ef8dbe2fc5c1a181924e245b163ff0077d396","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* String with valid path"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Related options:"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_bacd7fb9","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":24},"updated":"2016-06-16 03:34:08.000000000","message":"Missing the default value here.","commit_id":"aced2249bf572f37aefe0543b4a62e4e665c77e8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e857098d57e100d9eb8be57df3497feab8baafd","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* String with valid path"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Related options:"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_aaa7c309","line":79,"range":{"start_line":79,"start_character":14,"end_line":79,"end_character":24},"in_reply_to":"7aa08908_bacd7fb9","updated":"2016-06-16 17:25:43.000000000","message":"Done","commit_id":"aced2249bf572f37aefe0543b4a62e4e665c77e8"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"d40ef8dbe2fc5c1a181924e245b163ff0077d396","unresolved":false,"context_lines":[{"line_number":95,"context_line":"* None"},{"line_number":96,"context_line":"\"\"\"),"},{"line_number":97,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":98,"context_line":"               default\u003d\u0027/usr/share/novnc\u0027,"},{"line_number":99,"context_line":"               help\u003d\"\"\""},{"line_number":100,"context_line":"Path to directory with content which will be served by a web server."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_9a0363be","line":98,"range":{"start_line":98,"start_character":35,"end_line":98,"end_character":40},"updated":"2016-06-16 03:34:08.000000000","message":"Changing the default value here will make the py27 unit test failure. I think you should leave it as original.","commit_id":"aced2249bf572f37aefe0543b4a62e4e665c77e8"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e857098d57e100d9eb8be57df3497feab8baafd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"* None"},{"line_number":96,"context_line":"\"\"\"),"},{"line_number":97,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":98,"context_line":"               default\u003d\u0027/usr/share/novnc\u0027,"},{"line_number":99,"context_line":"               help\u003d\"\"\""},{"line_number":100,"context_line":"Path to directory with content which will be served by a web server."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0aaff7e3","line":98,"range":{"start_line":98,"start_character":35,"end_line":98,"end_character":40},"in_reply_to":"7aa08908_9a0363be","updated":"2016-06-16 17:25:43.000000000","message":"Done","commit_id":"aced2249bf572f37aefe0543b4a62e4e665c77e8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"6504639d9e3ad6f1e2373d0fb6a65f4c52772936","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Possible values:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* String with valid path. Default is \u0027/usr/share/novnc\u0027."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Related options:"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0b08a72c","line":104,"range":{"start_line":104,"start_character":38,"end_line":104,"end_character":54},"updated":"2016-06-22 22:29:17.000000000","message":"Inconsistency between the default value.","commit_id":"f60d4b4012cfd92dff78325faa2c81631a2ec618"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9292dce74270ed9d95ad8e9a3ad4407d81dc7e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"novnc_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027record\u0027,"},{"line_number":20,"context_line":"               help\u003d\"\"\""},{"line_number":21,"context_line":"This is the filename that will be used for storing websocket frames received"},{"line_number":22,"context_line":"and sent by a proxy service (like VNC, spice, serial) running on this host."},{"line_number":23,"context_line":"If this is not set (default), no recording will be done."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_fe129b5f","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":12},"updated":"2016-07-01 09:58:35.000000000","message":"s/This is the/Configure the/","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"95252b1e82c2e858d94a1ebd393ed89e0b1dc7de","unresolved":false,"context_lines":[{"line_number":18,"context_line":"novnc_opts \u003d ["},{"line_number":19,"context_line":"    cfg.StrOpt(\u0027record\u0027,"},{"line_number":20,"context_line":"               help\u003d\"\"\""},{"line_number":21,"context_line":"This is the filename that will be used for storing websocket frames received"},{"line_number":22,"context_line":"and sent by a proxy service (like VNC, spice, serial) running on this host."},{"line_number":23,"context_line":"If this is not set (default), no recording will be done."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_1355cbf9","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":12},"in_reply_to":"3aaa91ec_fe129b5f","updated":"2016-07-01 15:31:41.000000000","message":"Done","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9292dce74270ed9d95ad8e9a3ad4407d81dc7e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"               help\u003d\"\"\""},{"line_number":21,"context_line":"This is the filename that will be used for storing websocket frames received"},{"line_number":22,"context_line":"and sent by a proxy service (like VNC, spice, serial) running on this host."},{"line_number":23,"context_line":"If this is not set (default), no recording will be done."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_7effcb01","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":28},"updated":"2016-07-01 09:58:35.000000000","message":"Remove this as part of this rework","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"95252b1e82c2e858d94a1ebd393ed89e0b1dc7de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"               help\u003d\"\"\""},{"line_number":21,"context_line":"This is the filename that will be used for storing websocket frames received"},{"line_number":22,"context_line":"and sent by a proxy service (like VNC, spice, serial) running on this host."},{"line_number":23,"context_line":"If this is not set (default), no recording will be done."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Possible values:"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f3591f37","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":28},"in_reply_to":"3aaa91ec_7effcb01","updated":"2016-07-01 15:31:41.000000000","message":"Done","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9292dce74270ed9d95ad8e9a3ad4407d81dc7e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"\"\""},{"line_number":32,"context_line":"Become a daemon (background process)."},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_39371de4","line":33,"range":{"start_line":31,"start_character":21,"end_line":33,"end_character":3},"updated":"2016-07-01 09:58:35.000000000","message":"This is unnecessary, seeing as you haven\u0027t actually added any more text :) Go expand the description of this option, else revert to the previous verson","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"95252b1e82c2e858d94a1ebd393ed89e0b1dc7de","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"\"\""},{"line_number":32,"context_line":"Become a daemon (background process)."},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d329833c","line":33,"range":{"start_line":31,"start_character":21,"end_line":33,"end_character":3},"in_reply_to":"3aaa91ec_39371de4","updated":"2016-07-01 15:31:41.000000000","message":"I had no idea how to expand this message as it seems to be self-descriptive enough.","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"164f7daf435c2f94aa783b433d5d47f6cc6f2bce","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"\"\""},{"line_number":32,"context_line":"Become a daemon (background process)."},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_b2582458","line":33,"range":{"start_line":31,"start_character":21,"end_line":33,"end_character":3},"in_reply_to":"3aaa91ec_73440fb7","updated":"2016-07-03 21:04:29.000000000","message":"Ah, ok, got it.","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"efdcb4103ef54590adc1524b024cb6365349a605","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\"\"\"),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                help\u003d\"\"\""},{"line_number":32,"context_line":"Become a daemon (background process)."},{"line_number":33,"context_line":"\"\"\"),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_73440fb7","line":33,"range":{"start_line":31,"start_character":21,"end_line":33,"end_character":3},"in_reply_to":"3aaa91ec_d329833c","updated":"2016-07-01 15:34:40.000000000","message":"In that case, don\u0027t bother using a multi-line string (i.e. triple quotes) - the existing format is just fine :) Same for all of below.","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9292dce74270ed9d95ad8e9a3ad4407d81dc7e","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* String with valid path. Default is ``self.pem``."},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":54,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_9e56f727","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":50},"updated":"2016-07-01 09:58:35.000000000","message":"drop this (it\u0027s already stated on line 45 :))","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"95252b1e82c2e858d94a1ebd393ed89e0b1dc7de","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* String with valid path. Default is ``self.pem``."},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027key\u0027,"},{"line_number":54,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_3363a7df","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":50},"in_reply_to":"3aaa91ec_9e56f727","updated":"2016-07-01 15:31:41.000000000","message":"Done","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e9292dce74270ed9d95ad8e9a3ad4407d81dc7e","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Possible values:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* String with valid path. Default is \u0027/usr/share/novnc\u0027."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":"]"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_be35b3f7","line":68,"range":{"start_line":68,"start_character":26,"end_line":68,"end_character":56},"updated":"2016-07-01 09:58:35.000000000","message":"Drop this","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"95252b1e82c2e858d94a1ebd393ed89e0b1dc7de","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Possible values:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* String with valid path. Default is \u0027/usr/share/novnc\u0027."},{"line_number":69,"context_line":"\"\"\"),"},{"line_number":70,"context_line":"]"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d385030b","line":68,"range":{"start_line":68,"start_character":26,"end_line":68,"end_character":56},"in_reply_to":"3aaa91ec_be35b3f7","updated":"2016-07-01 15:31:41.000000000","message":"Done","commit_id":"63be565c95ad874712971c750c57fc41c069cd6b"}]}