)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04782832af5251189838da9a5dabee993e3502d1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"New service disabled due to config option\""},{"line_number":17,"context_line":"when a new service is added and \"enable_new_services\u003dFalse\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1417027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I52dd763cf1b58ba3ff56fe97f37eca18c915681d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_00fe39ad","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"updated":"2016-05-23 09:52:09.000000000","message":"I\u0027m not sure if this is necessary. Using \"DocImpact\" means that one of the manuals needs to be updated and I cannot think of one. Could you elaborate this a little?","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"4df853ed38989575002c9937d45cc9b5d1aaed3a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"New service disabled due to config option\""},{"line_number":17,"context_line":"when a new service is added and \"enable_new_services\u003dFalse\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1417027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I52dd763cf1b58ba3ff56fe97f37eca18c915681d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_0e7f83e0","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"bab6814e_00fe39ad","updated":"2016-05-23 12:22:28.000000000","message":"Since there isn\u0027t any disable reason now, the idea was to document the change. But I agree that is not a requirement.","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"700510c294f6d7b8276725e63b7b726dba9b7f43","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"New service disabled due to config option\""},{"line_number":17,"context_line":"when a new service is added and \"enable_new_services\u003dFalse\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1417027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I52dd763cf1b58ba3ff56fe97f37eca18c915681d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_c971f50d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"bab6814e_0e7f83e0","updated":"2016-05-23 12:32:11.000000000","message":"Leaving a \"DocImpact\" in a commit message creates a bug report in Nova [1] and right now I wouldn\u0027t know what to do with the bug report. I tend to think that it would be better to remove this flag.\n\nReferences:\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088382.html","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d1bd56dde92e520d1dbd43a05daa65d2815d9dbc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"New service disabled due to config option\""},{"line_number":17,"context_line":"when a new service is added and \"enable_new_services\u003dFalse\"."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1417027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I52dd763cf1b58ba3ff56fe97f37eca18c915681d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_89008d35","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"bab6814e_c971f50d","updated":"2016-05-23 12:33:10.000000000","message":"Whops, commented on the wrong ps. Thanks for the update in PS 2!","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04782832af5251189838da9a5dabee993e3502d1","unresolved":false,"context_lines":[{"line_number":533,"context_line":"    service_ref \u003d models.Service()"},{"line_number":534,"context_line":"    service_ref.update(values)"},{"line_number":535,"context_line":"    if not CONF.enable_new_services:"},{"line_number":536,"context_line":"        msg \u003d _(\"New service disabled due to config option\")"},{"line_number":537,"context_line":"        service_ref.disabled \u003d True"},{"line_number":538,"context_line":"        service_ref.disabled_reason \u003d msg"},{"line_number":539,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4064c1b7","line":536,"range":{"start_line":536,"start_character":52,"end_line":536,"end_character":58},"updated":"2016-05-23 09:52:09.000000000","message":"nit: A punctuation character at then end would be nice.","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"4df853ed38989575002c9937d45cc9b5d1aaed3a","unresolved":false,"context_lines":[{"line_number":533,"context_line":"    service_ref \u003d models.Service()"},{"line_number":534,"context_line":"    service_ref.update(values)"},{"line_number":535,"context_line":"    if not CONF.enable_new_services:"},{"line_number":536,"context_line":"        msg \u003d _(\"New service disabled due to config option\")"},{"line_number":537,"context_line":"        service_ref.disabled \u003d True"},{"line_number":538,"context_line":"        service_ref.disabled_reason \u003d msg"},{"line_number":539,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6e11ef5c","line":536,"range":{"start_line":536,"start_character":52,"end_line":536,"end_character":58},"in_reply_to":"bab6814e_4064c1b7","updated":"2016-05-23 12:22:28.000000000","message":"indeed.","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"}],"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"6d0505401ecfcbd0b61dcd69ff0c8b6e0d26e4e7","unresolved":false,"context_lines":[{"line_number":3346,"context_line":"    def test_service_create_disabled_reason(self):"},{"line_number":3347,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":3348,"context_line":"        service \u003d self._create_service({})"},{"line_number":3349,"context_line":"        msg \u003d \"New service disabled due to config option\""},{"line_number":3350,"context_line":"        self.assertEqual(msg, service[\u0027disabled_reason\u0027])"},{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"    def test_service_destroy(self):"},{"line_number":3353,"context_line":"        service1 \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_5a0e69e5","line":3350,"range":{"start_line":3349,"start_character":0,"end_line":3350,"end_character":57},"updated":"2016-05-23 11:16:37.000000000","message":"I think that this message test code should be just add to test_service_create_disabled.","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":2033,"name":"Belmiro Moreira","email":"moreira.belmiro.email.lists@gmail.com","username":"moreira-belmiro-email-lists"},"change_message_id":"4df853ed38989575002c9937d45cc9b5d1aaed3a","unresolved":false,"context_lines":[{"line_number":3346,"context_line":"    def test_service_create_disabled_reason(self):"},{"line_number":3347,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":3348,"context_line":"        service \u003d self._create_service({})"},{"line_number":3349,"context_line":"        msg \u003d \"New service disabled due to config option\""},{"line_number":3350,"context_line":"        self.assertEqual(msg, service[\u0027disabled_reason\u0027])"},{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"    def test_service_destroy(self):"},{"line_number":3353,"context_line":"        service1 \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4e3d0bdc","line":3350,"range":{"start_line":3349,"start_character":0,"end_line":3350,"end_character":57},"in_reply_to":"bab6814e_5a0e69e5","updated":"2016-05-23 12:22:28.000000000","message":"The message is not configurable, so we can\u0027t use a different one.","commit_id":"fb0363a6dc9cd8f6c271c6d6750a7dd27edf5595"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a496033f6ace04281f55c1c1534b69d62d0f2fa6","unresolved":false,"context_lines":[{"line_number":3347,"context_line":"        self.flags(enable_new_services\u003dFalse)"},{"line_number":3348,"context_line":"        service \u003d self._create_service({})"},{"line_number":3349,"context_line":"        msg \u003d \"New service disabled due to config option.\""},{"line_number":3350,"context_line":"        self.assertEqual(msg, service[\u0027disabled_reason\u0027])"},{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"    def test_service_destroy(self):"},{"line_number":3353,"context_line":"        service1 \u003d self._create_service({})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_5929429a","line":3350,"updated":"2016-06-09 09:28:11.000000000","message":"Nit: its tempting to roll this into the above test, but I like this having a separate reason to fail.","commit_id":"4eb95a1b897505fb4e4ec17541eeebb79e7217a8"}]}