)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a1088564ac5ee95e7fb158cce3bf273f8fafd3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Garbutt \u003cjohn.garbutt@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-06 15:00:06 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove auto_config_disk config check during resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This check was introduced be the following change:"},{"line_number":10,"context_line":"7c5c8a743c21733120c85fdefb84b4357f5848d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5ZI%3D","line":7,"updated":"2013-06-06 15:08:05.000000000","message":"should be auto_disk_config, oops","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"86f18d6522cfb58252c3eb3d7ebb5ad5de62bdab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove auto_config_disk config check during resize"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This check was introduced be the following change:"},{"line_number":10,"context_line":"7c5c8a743c21733120c85fdefb84b4357f5848d0"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is an alternative fix to ensure resize down"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5hw%3D","line":9,"updated":"2013-06-06 14:54:48.000000000","message":"s/be/by/","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":10,"context_line":"7c5c8a743c21733120c85fdefb84b4357f5848d0"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is an alternative fix to ensure resize down"},{"line_number":13,"context_line":"does not processed if the disk cannot be resized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note the failure now registers and instance action"},{"line_number":16,"context_line":"and does not leave the VM in an error state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5ak%3D","line":13,"updated":"2013-06-06 15:09:30.000000000","message":"is not processed?","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This is an alternative fix to ensure resize down"},{"line_number":13,"context_line":"does not processed if the disk cannot be resized."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note the failure now registers and instance action"},{"line_number":16,"context_line":"and does not leave the VM in an error state."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In addtion, this keeps the behaviour that a failure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5ag%3D","line":15,"updated":"2013-06-06 15:09:30.000000000","message":"an instance action","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"86f18d6522cfb58252c3eb3d7ebb5ad5de62bdab","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Note the failure now registers and instance action"},{"line_number":16,"context_line":"and does not leave the VM in an error state."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In addtion, this keeps the behaviour that a failure"},{"line_number":19,"context_line":"to resize up and instance during spawn will not"},{"line_number":20,"context_line":"cause the opertion to fail and put the VM into error."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5hg%3D","line":18,"updated":"2013-06-06 14:54:48.000000000","message":"s/addtion/addition/","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In addtion, this keeps the behaviour that a failure"},{"line_number":19,"context_line":"to resize up and instance during spawn will not"},{"line_number":20,"context_line":"cause the opertion to fail and put the VM into error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"fixes bug 1188135"},{"line_number":23,"context_line":"fixes bug 1187934"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5ac%3D","line":20,"updated":"2013-06-06 15:09:30.000000000","message":"operation :)","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c87343a2fc0d46b586fb8bcb792d9cefea672e7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"to resize up and instance during spawn will not"},{"line_number":20,"context_line":"cause the opertion to fail and put the VM into error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"fixes bug 1188135"},{"line_number":23,"context_line":"fixes bug 1187934"},{"line_number":24,"context_line":"fixes bug 1081225"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAPX%2F%2F5AA%3D","line":22,"updated":"2013-06-06 16:59:22.000000000","message":"Done all the above.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"}],"nova/tests/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":1519,"context_line":"                              network_info, image_meta, resize_instance\u003dFalse)"},{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1522,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1523,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1524,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1525,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5aE%3D","line":1522,"updated":"2013-06-06 15:09:30.000000000","message":"s/partions/partitions/g","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"86f18d6522cfb58252c3eb3d7ebb5ad5de62bdab","unresolved":false,"context_lines":[{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1522,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1523,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1524,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1525,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"},{"line_number":1526,"context_line":"        instance \u003d db.instance_create(self.context, instance_values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5ck%3D","line":1523,"updated":"2013-06-06 14:54:48.000000000","message":"This comment is irrelevant in this test.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a1088564ac5ee95e7fb158cce3bf273f8fafd3b","unresolved":false,"context_lines":[{"line_number":1520,"context_line":""},{"line_number":1521,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1522,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1523,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1524,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1525,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"},{"line_number":1526,"context_line":"        instance \u003d db.instance_create(self.context, instance_values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5aA%3D","line":1523,"in_reply_to":"AAAAPX%2F%2F5ck%3D","updated":"2013-06-06 15:08:05.000000000","message":"oops, will fix that.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"86f18d6522cfb58252c3eb3d7ebb5ad5de62bdab","unresolved":false,"context_lines":[{"line_number":1539,"context_line":"                          \u0027127.0.0.1\u0027, instance_type, None)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1542,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1543,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1544,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1545,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5cg%3D","line":1542,"updated":"2013-06-06 14:54:48.000000000","message":"I might be seeing things but this test looks exactly the same to me as the one above.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c87343a2fc0d46b586fb8bcb792d9cefea672e7","unresolved":false,"context_lines":[{"line_number":1539,"context_line":"                          \u0027127.0.0.1\u0027, instance_type, None)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1542,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1543,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1544,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1545,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F4%2F4%3D","line":1542,"in_reply_to":"AAAAPX%2F%2F5aM%3D","updated":"2013-06-06 16:59:22.000000000","message":"oops, fixed.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":1539,"context_line":"                          \u0027127.0.0.1\u0027, instance_type, None)"},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"    @stub_vm_utils_with_vdi_attached_here"},{"line_number":1542,"context_line":"    def test_migrate_too_many_partions_no_resize_down(self):"},{"line_number":1543,"context_line":"        # Resize down should fail when auto_disk_config not set."},{"line_number":1544,"context_line":"        instance_values \u003d self.instance_values"},{"line_number":1545,"context_line":"        instance_values[\u0027root_gb\u0027] \u003d 40"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5aM%3D","line":1542,"in_reply_to":"AAAAPX%2F%2F5cg%3D","updated":"2013-06-06 15:09:30.000000000","message":"The fake_get_partitions below is different; but isn\u0027t it a problem if the name of the method is the same?","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a1088564ac5ee95e7fb158cce3bf273f8fafd3b","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"        conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        def fake_get_partitions(partition):"},{"line_number":1552,"context_line":"            return [(1, 2, 3, \"ext2\")]"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"        self.stubs.Set(vm_utils, \u0027_get_partitions\u0027, fake_get_partitions)"},{"line_number":1555,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5aI%3D","line":1552,"updated":"2013-06-06 15:08:05.000000000","message":"This tests the other exception clause, the file type.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            new_sectors \u003d new_gb * 1024 * 1024 * 1024 / SECTOR_SIZE"},{"line_number":808,"context_line":"            _resize_part_and_fs(dev, start, old_sectors, new_sectors)"},{"line_number":809,"context_line":"        else:"},{"line_number":810,"context_line":"            reason \u003d _(\u0027To resize the disk, it must be either an ext3 or \u0027"},{"line_number":811,"context_line":"                       \u0027ext4 filesystem, not: %s\u0027)"},{"line_number":812,"context_line":"            raise exception.ResizeError(reason\u003dreason % ptype)"},{"line_number":813,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5ZU%3D","line":810,"updated":"2013-06-06 15:09:30.000000000","message":"Best not to have the partition types in the message - otherwise if someone adds a new supported ptype then the message will get long.  I\u0027d just say \"%s: Unsupported partition type\"","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c87343a2fc0d46b586fb8bcb792d9cefea672e7","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            new_sectors \u003d new_gb * 1024 * 1024 * 1024 / SECTOR_SIZE"},{"line_number":808,"context_line":"            _resize_part_and_fs(dev, start, old_sectors, new_sectors)"},{"line_number":809,"context_line":"        else:"},{"line_number":810,"context_line":"            reason \u003d _(\u0027To resize the disk, it must be either an ext3 or \u0027"},{"line_number":811,"context_line":"                       \u0027ext4 filesystem, not: %s\u0027)"},{"line_number":812,"context_line":"            raise exception.ResizeError(reason\u003dreason % ptype)"},{"line_number":813,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5Ck%3D","line":810,"in_reply_to":"AAAAPX%2F%2F5ZU%3D","updated":"2013-06-06 16:59:22.000000000","message":"Good call.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"6790feddaaed7c2f470d1c16f6bc55f5d3bebe33","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            raise exception.ResizeError(reason\u003dreason % ptype)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"def try_auto_configure_disk(session, vdi_ref, new_gb):"},{"line_number":816,"context_line":"    try:"},{"line_number":817,"context_line":"        _auto_configure_disk(session, vdi_ref, new_gb)"},{"line_number":818,"context_line":"    except exception.ResizeError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5Yc%3D","line":815,"updated":"2013-06-06 15:09:30.000000000","message":"Is the intention here that try_auto_configure_disk will not raise if the try failed? i.e. it\u0027ll fail silently from the callers perspective?","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c87343a2fc0d46b586fb8bcb792d9cefea672e7","unresolved":false,"context_lines":[{"line_number":812,"context_line":"            raise exception.ResizeError(reason\u003dreason % ptype)"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"def try_auto_configure_disk(session, vdi_ref, new_gb):"},{"line_number":816,"context_line":"    try:"},{"line_number":817,"context_line":"        _auto_configure_disk(session, vdi_ref, new_gb)"},{"line_number":818,"context_line":"    except exception.ResizeError as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5CY%3D","line":815,"in_reply_to":"AAAAPX%2F%2F5Yc%3D","updated":"2013-06-06 16:59:22.000000000","message":"Thats the idea, it should work as it did before.","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5a1088564ac5ee95e7fb158cce3bf273f8fafd3b","unresolved":false,"context_lines":[{"line_number":593,"context_line":"        else:"},{"line_number":594,"context_line":"            root_vdi \u003d vdis[\u0027root\u0027]"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            if instance[\u0027auto_disk_config\u0027]:"},{"line_number":597,"context_line":"                LOG.debug(_(\"Auto configuring disk, attempting to \""},{"line_number":598,"context_line":"                            \"resize partition...\"), instance\u003dinstance)"},{"line_number":599,"context_line":"                vm_utils.try_auto_configure_disk(self._session,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2F5Y0%3D","line":596,"updated":"2013-06-06 15:08:05.000000000","message":"we still use the setting during boot...","commit_id":"b074b58097930da6d68ee09745a765b9433410c2"}]}