)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ca724c048499022bd91d7661ad1fb01f7bae4a1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated config option volume_api_class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config option volume_api_class was deprecated in version 13.0.0,"},{"line_number":10,"context_line":"We can remove it in 14.0.0."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7841b016703a9cb5c0e783fe81a5cdcd7f4af9c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_c50a8325","line":9,"range":{"start_line":9,"start_character":14,"end_line":9,"end_character":30},"updated":"2016-05-23 09:45:55.000000000","message":"nit: \"network_api_class\" got deprecated with commit 6e8e322 too. Maybe remove that too (in a follow up patch).","commit_id":"5fdb531393a0a3da2d53925f4acb04186cfa4a85"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ca724c048499022bd91d7661ad1fb01f7bae4a1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Config option volume_api_class was deprecated in version 13.0.0,"},{"line_number":10,"context_line":"We can remove it in 14.0.0."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7841b016703a9cb5c0e783fe81a5cdcd7f4af9c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_25fc2f3d","line":11,"updated":"2016-05-23 09:45:55.000000000","message":"According to [1], the removal of a config option needs a reno file. Under [2] is an explanation how to create a \"reno\" file. That file should then be part of your patch.\n\n[1] http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed\n[2] [4] http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"5fdb531393a0a3da2d53925f4acb04186cfa4a85"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3d7aa5a12cc9b5b92e6102f177e0fc5d3b868d26","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def list_opts():"},{"line_number":28,"context_line":"    return ["},{"line_number":29,"context_line":"        (\u0027DEFAULT\u0027, nova.exception.exc_log_opts),"},{"line_number":30,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_36d1ccce","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":47},"updated":"2016-05-27 14:17:16.000000000","message":"The removal of this merged with commit c69afd454. When you rebase this change, just remove this file (\"nova/opts.py\") completely and remove the line \"namespace \u003d nova\" in the nova config generator file [1].\nDon\u0027t forget to mention this in the commit message.\n\nReferences:\nhttps://github.com/openstack/nova/blob/a1f74c7dba758b0ab28d746fa69d814e7a55c7bf/etc/nova/nova-config-generator.conf#L4-L4","commit_id":"5d76467392b65cd05f03eaf470e72f37fc346359"}],"nova/volume/__init__.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1ff2bde3ab682d7c58e546a0a17fc50f788482c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def API():"},{"line_number":21,"context_line":"    cls \u003d importutils.import_class(\u0027nova.volume.cinder.API\u0027)"},{"line_number":22,"context_line":"    return cls()"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_18588355","line":22,"updated":"2016-07-21 12:27:36.000000000","message":"This now ends up being a not entirely useful indirection for the 6 places this is called:\n\n  git grep \"volume.API()\"\n  nova/api/openstack/compute/volumes.py:        self.volume_api \u003d volume.API()\n  nova/api/openstack/compute/volumes.py:        self.volume_api \u003d volume.API()\n  nova/api/openstack/compute/volumes.py:        self.volume_api \u003d volume.API()\n  nova/compute/api.py:        self.volume_api \u003d volume_api or volume.API()\n  nova/compute/manager.py:        self.volume_api \u003d volume.API()\n  nova/virt/libvirt/driver.py:        self._volume_api \u003d volume.API()\n\nI think we should take the time now and just have them connect directly to the cinder class there so we can make this file entirely empty.","commit_id":"eddfe532bad6216af15856ee165fa425c287e712"}],"releasenotes/notes/remove_volume_api_class-a3c618228c89f57b.yaml":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9731c3fa4777b082a98e41de9dd28dcd32113051","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated volume_api_class config option has been"},{"line_number":4,"context_line":"    removed. We only have one sensible backend for it, so"},{"line_number":5,"context_line":"    don\u0027t need it anymore."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_ae575756","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":35},"updated":"2016-05-23 12:23:01.000000000","message":"nit: You can use restructured text syntax here, for example\n\n    ``volume_api_class``\n\nwill render then as monospace font in [1]\n\nReferences:\n[1] http://docs.openstack.org/releasenotes/nova/unreleased.html","commit_id":"f9ddac58b8d48c4b5b46635d795c716f8196c973"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"2536b4ff7d77b246cdc61083dee0350114fb9463","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated volume_api_class config option has been"},{"line_number":4,"context_line":"    removed. We only have one sensible backend for it, so"},{"line_number":5,"context_line":"    don\u0027t need it anymore."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_9b529033","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":35},"in_reply_to":"bab6814e_ae575756","updated":"2016-05-23 12:51:54.000000000","message":"Done","commit_id":"f9ddac58b8d48c4b5b46635d795c716f8196c973"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"2231a57db58f5bb3eb0987c91c6018e16472c556","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated ``volume_api_class`` config option has been"},{"line_number":4,"context_line":"    removed. We only have one sensible backend for it, so"},{"line_number":5,"context_line":"    don\u0027t need it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7aa08908_e054caca","line":5,"range":{"start_line":5,"start_character":3,"end_line":5,"end_character":25},"updated":"2016-06-08 19:29:59.000000000","message":"It this single quote going to cause problems?","commit_id":"3e3b0d01f17da719857e997cdb842bf4809596da"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a2ebb6d1a58128cbde965513f071a0d82dee9074","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The deprecated ``volume_api_class`` config option has been"},{"line_number":4,"context_line":"    removed. We only have one sensible backend for it, so"},{"line_number":5,"context_line":"    don\u0027t need it anymore."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_55161ef2","line":5,"range":{"start_line":5,"start_character":3,"end_line":5,"end_character":25},"in_reply_to":"7aa08908_e054caca","updated":"2016-06-27 12:49:40.000000000","message":"It passed the releasenote test job, so it\u0027s ok","commit_id":"3e3b0d01f17da719857e997cdb842bf4809596da"}]}