)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"872d20eee5bc6a850724702d4dadb98556f8c913","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecated security_group_api config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"UpgradeImpact: It was deprecated in version 13.0.0, and introduced new"},{"line_number":10,"context_line":"configuration option \u0027use_neutron\u0027 to provide a more coherent user"},{"line_number":11,"context_line":"experience. So let\u0027s use \u0027use_neutron\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1ac06dbe_a9ad678a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2016-08-19 14:52:44.000000000","message":"This isn\u0027t really necessary.","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"}],"nova/tests/functional/api_sample_tests/test_security_groups.py":[{"author":{"_account_id":23137,"name":"Sarah Ulmer","email":"Sarah.Ulmer@ibm.com","username":"sulmer"},"change_message_id":"2cca0719294b543c128425b104f394e74a3eb103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3ac371cc_c4e7f344","updated":"2016-08-18 20:14:28.000000000","message":"To get the functional tests working, you might need to set fixtures to neutron. Here\u0027s a different functional test doing this: https://github.com/openstack/nova/blob/33a50eace0f9ae487453135f6ff644e95d577293/nova/tests/functional/notification_sample_tests/test_instance.py#L25-L26","commit_id":"25aabb1203dcc2d303553e027f1be9e7795f1241"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"872d20eee5bc6a850724702d4dadb98556f8c913","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":66,"context_line":"        self.neutron \u003d fixtures.NeutronFixture(self)"},{"line_number":67,"context_line":"        self.useFixture(self.neutron)"},{"line_number":68,"context_line":"        super(SecurityGroupsJsonTest, self).setUp()"},{"line_number":69,"context_line":"        path \u003d \u0027nova.network.security_group.neutron_driver.SecurityGroupAPI.\u0027"},{"line_number":70,"context_line":"        self.stub_out(path + \u0027get\u0027, fake_get)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_0972bbe5","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":37},"updated":"2016-08-19 14:52:44.000000000","message":"Why is this needed? Using the use_neutron flag should be equivalent so I\u0027m not sure why we\u0027d need to start using this fixture, although it probably makes sense since that fixture is for using the neutron client from the nova.network.neutronv2.api module.","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"},{"author":{"_account_id":23137,"name":"Sarah Ulmer","email":"Sarah.Ulmer@ibm.com","username":"sulmer"},"change_message_id":"b1e65ad7353f0d884252ff61875c61c2308f9028","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":66,"context_line":"        self.neutron \u003d fixtures.NeutronFixture(self)"},{"line_number":67,"context_line":"        self.useFixture(self.neutron)"},{"line_number":68,"context_line":"        super(SecurityGroupsJsonTest, self).setUp()"},{"line_number":69,"context_line":"        path \u003d \u0027nova.network.security_group.neutron_driver.SecurityGroupAPI.\u0027"},{"line_number":70,"context_line":"        self.stub_out(path + \u0027get\u0027, fake_get)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_14e92b1b","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":37},"in_reply_to":"1ac06dbe_0972bbe5","updated":"2016-08-19 15:58:06.000000000","message":"A couple functional tests fail if it doesn\u0027t use a neutron fixture. Without it, I ran into authentication errors","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"}],"nova/tests/unit/network/test_config.py":[{"author":{"_account_id":23137,"name":"Sarah Ulmer","email":"Sarah.Ulmer@ibm.com","username":"sulmer"},"change_message_id":"ae4382748c903e4b3b5a50ddf6c95574877d3bd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ac371cc_e4b24be4","updated":"2016-08-17 16:18:51.000000000","message":"test_use_neutron and test_sg_neutron are running the same test. Should probably delete one of them","commit_id":"86f8169f23b97f5de89ef174dc2895f29bb5a5bb"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"9e748d9367c3545024e0e4a509556c4f194f2915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3ac371cc_6d93c2fa","in_reply_to":"3ac371cc_e4b24be4","updated":"2016-08-18 05:05:54.000000000","message":"Done","commit_id":"86f8169f23b97f5de89ef174dc2895f29bb5a5bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"872d20eee5bc6a850724702d4dadb98556f8c913","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            driver,"},{"line_number":46,"context_line":"            nova.network.security_group.neutron_driver.SecurityGroupAPI)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_dont_use_neutron(self):"},{"line_number":49,"context_line":"        self.flags(use_neutron\u003dFalse)"},{"line_number":50,"context_line":"        driver \u003d sgapi.get_openstack_security_group_driver()"},{"line_number":51,"context_line":"        self.assertIsInstance("}],"source_content_type":"text/x-python","patch_set":8,"id":"1ac06dbe_e425c6ae","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":29},"updated":"2016-08-19 14:52:44.000000000","message":"nit: we didn\u0027t really need to rename this IMO","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"efa8c2baa2524c3a1b83d197fe13bb565fd05a20","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class SecurityGroupAPIConfigTest(nova.test.NoDBTestCase):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_sg_neutron(self):"},{"line_number":42,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":43,"context_line":"        driver \u003d sgapi.get_openstack_security_group_driver()"},{"line_number":44,"context_line":"        self.assertIsInstance("}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_7035fd44","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":23},"updated":"2016-08-19 20:59:20.000000000","message":"nit: didn\u0027t need to rename this - gotta check the OCD at the door, I know it\u0027s hard. Cleanup stuff like this should be in a separate change if you really want it. Just FYI. The reason why we want small isolated changes is:\n\n1. reduce the chance of merge conflicts when this lands\n\n2. cleaner backports (for bug fixes)\n\n3. cleaner reverts","commit_id":"ab7d19fea233df769af1f23dc17dbb1a79c1b297"}],"releasenotes/notes/remove_security_group_api-6fefb1a355876e83.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"872d20eee5bc6a850724702d4dadb98556f8c913","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - List upgrade notes here, or remove this section."},{"line_number":4,"context_line":"  - Remove ``security_group_api`` configuration option. The correct"},{"line_number":5,"context_line":"    security_group_api option will be chosen based on the value of"},{"line_number":6,"context_line":"    ``use_neutron`` which provides a more coherent user experience."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_a44bce58","line":3,"updated":"2016-08-19 14:52:44.000000000","message":"This is boilerplate template, remove this.","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"872d20eee5bc6a850724702d4dadb98556f8c913","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - List upgrade notes here, or remove this section."},{"line_number":4,"context_line":"  - Remove ``security_group_api`` configuration option. The correct"},{"line_number":5,"context_line":"    security_group_api option will be chosen based on the value of"},{"line_number":6,"context_line":"    ``use_neutron`` which provides a more coherent user experience."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ac06dbe_c486ca64","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":10},"updated":"2016-08-19 14:52:44.000000000","message":"Either say \u0027Removed\u0027, or re-word this as something like,\n\n\"The deprecated ``security_group_api`` configuration option has been removed.\"","commit_id":"97025617f0b4b79dc02ac52dfccdad199870e7ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"efa8c2baa2524c3a1b83d197fe13bb565fd05a20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"--- upgrade:"},{"line_number":2,"context_line":"  - Removed the ``security_group_api`` configuration option that was deprecated"},{"line_number":3,"context_line":"    in Mitaka. The correct security_group_api option will be chosen based on"},{"line_number":4,"context_line":"    the value of ``use_neutron`` which provides a more coherent user experience."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_50ed618a","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":11},"updated":"2016-08-19 20:59:20.000000000","message":"This should be on the next line...probably messes up the formatting.","commit_id":"ab7d19fea233df769af1f23dc17dbb1a79c1b297"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4d0d5e48746af70b5e6885969a6665b343be6f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"--- upgrade:"},{"line_number":2,"context_line":"  - Removed the ``security_group_api`` configuration option that was deprecated"},{"line_number":3,"context_line":"    in Mitaka. The correct security_group_api option will be chosen based on"},{"line_number":4,"context_line":"    the value of ``use_neutron`` which provides a more coherent user experience."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1ac06dbe_5049e18a","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":11},"in_reply_to":"1ac06dbe_50ed618a","updated":"2016-08-19 21:01:14.000000000","message":"BTW, you can build release notes like this:\n\ntox -e releasenotes\n\nNote you have to have the release note change committed to build it because it builds them from the git history.","commit_id":"ab7d19fea233df769af1f23dc17dbb1a79c1b297"}]}