)]}'
{"nova/conf/database.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1542feaf0216f1ca278f610bd8ecddfa57b5ebde","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# TODO(markus_z): This should probably have a required\u003dTrue attribute"},{"line_number":49,"context_line":"connection_opt \u003d cfg.StrOpt(\u0027connection\u0027,"},{"line_number":50,"context_line":"        secret\u003dTrue,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The SQLAlchemy connection string to use to connect to the (master) Nova"},{"line_number":53,"context_line":"API  database."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_c43a37cd","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":19},"updated":"2016-06-20 17:06:15.000000000","message":"out of curiosity - what does secret param do?","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"970fca1fa2e0fe4ef72b7505a8d02b961dfa479b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# TODO(markus_z): This should probably have a required\u003dTrue attribute"},{"line_number":49,"context_line":"connection_opt \u003d cfg.StrOpt(\u0027connection\u0027,"},{"line_number":50,"context_line":"        secret\u003dTrue,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The SQLAlchemy connection string to use to connect to the (master) Nova"},{"line_number":53,"context_line":"API  database."}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_9fe4193c","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":19},"in_reply_to":"3aaa91ec_cf2da8a9","updated":"2016-08-08 14:13:09.000000000","message":"Yes, it obfuscates the value, see http://docs.openstack.org/developer/oslo.config/opts.html","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c28cd9b0572ddac6b40e8205de32a6526b1a6d33","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# TODO(markus_z): This should probably have a required\u003dTrue attribute"},{"line_number":49,"context_line":"connection_opt \u003d cfg.StrOpt(\u0027connection\u0027,"},{"line_number":50,"context_line":"        secret\u003dTrue,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The SQLAlchemy connection string to use to connect to the (master) Nova"},{"line_number":53,"context_line":"API  database."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_cf2da8a9","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":19},"in_reply_to":"5a9d85d2_c43a37cd","updated":"2016-06-24 13:37:20.000000000","message":"keeps it out of the logs, I think","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c28cd9b0572ddac6b40e8205de32a6526b1a6d33","unresolved":false,"context_lines":[{"line_number":49,"context_line":"connection_opt \u003d cfg.StrOpt(\u0027connection\u0027,"},{"line_number":50,"context_line":"        secret\u003dTrue,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The SQLAlchemy connection string to use to connect to the (master) Nova"},{"line_number":53,"context_line":"API  database."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"If you use a database setup which uses master-slave-replication, then this"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_124fd36b","line":52,"updated":"2016-06-24 13:37:20.000000000","message":"So these are all just a cut and paste from here:\nhttps://github.com/openstack/oslo.db/blob/master/oslo_db/options.py#L30\n\nIt would be great if we could do something better about cloning the options from there, or reusing the help text, etc.","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"970fca1fa2e0fe4ef72b7505a8d02b961dfa479b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"connection_opt \u003d cfg.StrOpt(\u0027connection\u0027,"},{"line_number":50,"context_line":"        secret\u003dTrue,"},{"line_number":51,"context_line":"        help\u003d\"\"\""},{"line_number":52,"context_line":"The SQLAlchemy connection string to use to connect to the (master) Nova"},{"line_number":53,"context_line":"API  database."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"If you use a database setup which uses master-slave-replication, then this"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_1fcf89b1","line":52,"in_reply_to":"3aaa91ec_124fd36b","updated":"2016-08-08 14:13:09.000000000","message":"The help texts will be reused in ps 2 with a possibility to append API DB specific help texts.","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1542feaf0216f1ca278f610bd8ecddfa57b5ebde","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* True: SQLite is in synchronous mode. The data is more durable but the"},{"line_number":74,"context_line":"  performance is slower than in asynchronous mode."},{"line_number":75,"context_line":"* False: SQLite is in asynchronous mode. The performance is better than in"},{"line_number":76,"context_line":"  synchronous mode but the data is less durable."},{"line_number":77,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_846e6fc7","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":50},"updated":"2016-06-20 17:06:15.000000000","message":"Mark as default","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b3a594fdbe24e50b6a1e93d112bce61fdb6878b","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* True: SQLite is in synchronous mode. The data is more durable but the"},{"line_number":74,"context_line":"  performance is slower than in asynchronous mode."},{"line_number":75,"context_line":"* False: SQLite is in asynchronous mode. The performance is better than in"},{"line_number":76,"context_line":"  synchronous mode but the data is less durable."},{"line_number":77,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5dd30060","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":50},"in_reply_to":"5a9d85d2_846e6fc7","updated":"2016-07-21 15:21:08.000000000","message":"Actually - don\u0027t. It is not needed.","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b3a594fdbe24e50b6a1e93d112bce61fdb6878b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    source: http://docs.sqlalchemy.org/en/latest/core/engines.html"},{"line_number":255,"context_line":"\"\"\")"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"api_db_opts \u003d [connection_opt,"},{"line_number":258,"context_line":"               sqlite_synchronous_opt,"},{"line_number":259,"context_line":"               slave_conn_opt,"},{"line_number":260,"context_line":"               mysql_sql_mode_opt,"},{"line_number":261,"context_line":"               idle_timeout_opt,"},{"line_number":262,"context_line":"               max_pool_size_opt,"},{"line_number":263,"context_line":"               max_retries_opt,"},{"line_number":264,"context_line":"               retry_interval_opt,"},{"line_number":265,"context_line":"               max_overflow_opt,"},{"line_number":266,"context_line":"               connection_debug_opt,"},{"line_number":267,"context_line":"               connection_trace_opt,"},{"line_number":268,"context_line":"               pool_timeout_opt,"},{"line_number":269,"context_line":"               ]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_5d0820da","line":269,"range":{"start_line":257,"start_character":0,"end_line":269,"end_character":16},"updated":"2016-07-21 15:21:08.000000000","message":"Create Opts in-list, instead of appending them as variables to list.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency#fix_opt_registration_consistency","commit_id":"45fde93094719a57e34887af5357626aac79d04d"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"970fca1fa2e0fe4ef72b7505a8d02b961dfa479b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    source: http://docs.sqlalchemy.org/en/latest/core/engines.html"},{"line_number":255,"context_line":"\"\"\")"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"api_db_opts \u003d [connection_opt,"},{"line_number":258,"context_line":"               sqlite_synchronous_opt,"},{"line_number":259,"context_line":"               slave_conn_opt,"},{"line_number":260,"context_line":"               mysql_sql_mode_opt,"},{"line_number":261,"context_line":"               idle_timeout_opt,"},{"line_number":262,"context_line":"               max_pool_size_opt,"},{"line_number":263,"context_line":"               max_retries_opt,"},{"line_number":264,"context_line":"               retry_interval_opt,"},{"line_number":265,"context_line":"               max_overflow_opt,"},{"line_number":266,"context_line":"               connection_debug_opt,"},{"line_number":267,"context_line":"               connection_trace_opt,"},{"line_number":268,"context_line":"               pool_timeout_opt,"},{"line_number":269,"context_line":"               ]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"def register_opts(conf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ff36f5b2","line":269,"range":{"start_line":257,"start_character":0,"end_line":269,"end_character":16},"in_reply_to":"dada55a8_5d0820da","updated":"2016-08-08 14:13:09.000000000","message":"Done","commit_id":"45fde93094719a57e34887af5357626aac79d04d"}]}