)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f9eaf1f607d7f310ca7eac7f285d8b4910e7c30","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cfg.IntOpt(\u0027reserved_host_disk_mb\u0027,"},{"line_number":84,"context_line":"               default\u003d0,"},{"line_number":85,"context_line":"               help\u003d\"\"\""},{"line_number":86,"context_line":"You can reserve host disk resources to make them always available to OpenStack."},{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_25ca446f","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":78},"updated":"2016-05-23 21:59:47.000000000","message":"maybe something along these lines \"Host disk resources can be reserved and not exposed to scheduler\"?Basically I don\u0027t like using \"You can\" in these sentences.","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cfg.IntOpt(\u0027reserved_host_disk_mb\u0027,"},{"line_number":84,"context_line":"               default\u003d0,"},{"line_number":85,"context_line":"               help\u003d\"\"\""},{"line_number":86,"context_line":"You can reserve host disk resources to make them always available to OpenStack."},{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_adec2f90","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":78},"in_reply_to":"bab6814e_25ca446f","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f9eaf1f607d7f310ca7eac7f285d8b4910e7c30","unresolved":false,"context_lines":[{"line_number":86,"context_line":"You can reserve host disk resources to make them always available to OpenStack."},{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_4a7677d9","line":89,"range":{"start_line":89,"start_character":60,"end_line":89,"end_character":74},"updated":"2016-05-23 21:59:47.000000000","message":"disk space","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":86,"context_line":"You can reserve host disk resources to make them always available to OpenStack."},{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_edfe3737","line":89,"range":{"start_line":89,"start_character":60,"end_line":89,"end_character":74},"in_reply_to":"bab6814e_4a7677d9","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f9eaf1f607d7f310ca7eac7f285d8b4910e7c30","unresolved":false,"context_lines":[{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ca48a78d","line":90,"range":{"start_line":90,"start_character":10,"end_line":90,"end_character":13},"updated":"2016-05-23 21:59:47.000000000","message":"that","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":87,"context_line":"The disk usage gets reported back to the scheduler from nova-compute"},{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_4dfca33e","line":90,"range":{"start_line":90,"start_character":10,"end_line":90,"end_character":13},"in_reply_to":"bab6814e_ca48a78d","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c21917acfa04bbfd1c8545accd02a2088b6e8389","unresolved":false,"context_lines":[{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  Any positive integer. The default is 0."}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_2bf7abf6","line":91,"updated":"2016-05-24 06:37:13.000000000","message":"I think this sentence should be refactored, besides the use of \"You can\", it is not easy to understand, we shoud get right to the point as Sarafraj exampled.","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":88,"context_line":"running on the compute nodes. To prevent the disk resources from being"},{"line_number":89,"context_line":"considered as available, you can use this option to reserve amount of disk"},{"line_number":90,"context_line":"in MB for the host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  Any positive integer. The default is 0."}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8d94cbe8","line":91,"in_reply_to":"bab6814e_2bf7abf6","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f9eaf1f607d7f310ca7eac7f285d8b4910e7c30","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"},{"line_number":106,"context_line":"               default\u003d512,"},{"line_number":107,"context_line":"               help\u003d\"\"\""},{"line_number":108,"context_line":"You can reserve host memory so that it is always available to OpenStack."},{"line_number":109,"context_line":"The host resources usage is reported back to the scheduler continously"},{"line_number":110,"context_line":"from nova-compute running on the compute node. To prevent the host"},{"line_number":111,"context_line":"memory from being considered as available, you can reserve amount of"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_a592b449","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":27},"updated":"2016-05-23 21:59:47.000000000","message":"Host memory can be reserved","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c21917acfa04bbfd1c8545accd02a2088b6e8389","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"},{"line_number":106,"context_line":"               default\u003d512,"},{"line_number":107,"context_line":"               help\u003d\"\"\""},{"line_number":108,"context_line":"You can reserve host memory so that it is always available to OpenStack."},{"line_number":109,"context_line":"The host resources usage is reported back to the scheduler continously"},{"line_number":110,"context_line":"from nova-compute running on the compute node. To prevent the host"},{"line_number":111,"context_line":"memory from being considered as available, you can reserve amount of"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_cb025fb4","line":108,"range":{"start_line":108,"start_character":27,"end_line":108,"end_character":71},"updated":"2016-05-24 06:37:13.000000000","message":"what do you mean by always available to OpenStack? same suggestion as above.","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"},{"line_number":106,"context_line":"               default\u003d512,"},{"line_number":107,"context_line":"               help\u003d\"\"\""},{"line_number":108,"context_line":"You can reserve host memory so that it is always available to OpenStack."},{"line_number":109,"context_line":"The host resources usage is reported back to the scheduler continously"},{"line_number":110,"context_line":"from nova-compute running on the compute node. To prevent the host"},{"line_number":111,"context_line":"memory from being considered as available, you can reserve amount of"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_6d99a71f","line":108,"range":{"start_line":108,"start_character":0,"end_line":108,"end_character":27},"in_reply_to":"bab6814e_a592b449","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7ef3d7d5bb1fcd9da38c1f3aa801accdfdb95b21","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"},{"line_number":106,"context_line":"               default\u003d512,"},{"line_number":107,"context_line":"               help\u003d\"\"\""},{"line_number":108,"context_line":"You can reserve host memory so that it is always available to OpenStack."},{"line_number":109,"context_line":"The host resources usage is reported back to the scheduler continously"},{"line_number":110,"context_line":"from nova-compute running on the compute node. To prevent the host"},{"line_number":111,"context_line":"memory from being considered as available, you can reserve amount of"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_cd9ed306","line":108,"range":{"start_line":108,"start_character":27,"end_line":108,"end_character":71},"in_reply_to":"bab6814e_cb025fb4","updated":"2016-05-24 15:58:15.000000000","message":"Done","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5f9eaf1f607d7f310ca7eac7f285d8b4910e7c30","unresolved":false,"context_lines":[{"line_number":132,"context_line":"This option abstracts out managing compute host stats to pluggable class."},{"line_number":133,"context_line":"This class manages and updates stats for the local compute host after"},{"line_number":134,"context_line":"an instance is changed. These configurable compute stats may be useful for"},{"line_number":135,"context_line":"a perticular scheduler implementation."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Possible values"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_65a9ec7b","line":135,"range":{"start_line":135,"start_character":2,"end_line":135,"end_character":12},"updated":"2016-05-23 21:59:47.000000000","message":"particular","commit_id":"9acb7f8696e2f59477d51d2798449a78b4e3b570"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6a54d2996b03c4cb6eeddf52445c7b2f59bd73c4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"This option is used to reserve disk resources to make them always"},{"line_number":87,"context_line":"available to host.The disk usage gets reported back to the scheduler from"},{"line_number":88,"context_line":"nova-compute running on the compute nodes. To prevent the disk resources"},{"line_number":89,"context_line":"from being considered as available, you can use this option to reserve"},{"line_number":90,"context_line":"disk space in MB for that host."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_c5519a64","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":70},"updated":"2016-05-27 19:35:59.000000000","message":"this option can be used to reserve","commit_id":"a06d9674774ed19646c816f1cec482a83f1ca82a"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6a54d2996b03c4cb6eeddf52445c7b2f59bd73c4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"This option is used to reserve memory so that it is always available to host"},{"line_number":109,"context_line":"processes.The host resources usage is reported back to the scheduler"},{"line_number":110,"context_line":"continously from nova-compute running on the compute node. To prevent the host"},{"line_number":111,"context_line":"memory from being considered as available, you can reserve amount of memory"},{"line_number":112,"context_line":"in MB for the host using this option."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_85edd28d","line":111,"range":{"start_line":111,"start_character":43,"end_line":111,"end_character":58},"updated":"2016-05-27 19:35:59.000000000","message":"same comment as above. Try to avoid words like \"you\", \"please\", \"sorry\" in user facing text.","commit_id":"a06d9674774ed19646c816f1cec482a83f1ca82a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"50069a09b8365207e21fe95d5170d6f2b8c7f280","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  Any positive integer. The default is 0."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Services which consumes this:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  ``nova-compute``"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Related options:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_041b9f1c","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":18},"updated":"2016-06-20 17:13:01.000000000","message":"This section is no longer required.","commit_id":"896a39db871ed3eb462dc4cd0778abde4dd65444"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"50069a09b8365207e21fe95d5170d6f2b8c7f280","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  Any positive integer. Default is 512."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Services which consumes this:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"  ``nova-compute``"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* Related options"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_e41773eb","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":18},"updated":"2016-06-20 17:13:01.000000000","message":"This section is no longer required.","commit_id":"896a39db871ed3eb462dc4cd0778abde4dd65444"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"50069a09b8365207e21fe95d5170d6f2b8c7f280","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    cfg.StrOpt(\u0027compute_stats_class\u0027,"},{"line_number":128,"context_line":"               default\u003d\u0027nova.compute.stats.Stats\u0027,"},{"line_number":129,"context_line":"               help\u003d\"\"\""},{"line_number":130,"context_line":"*DEPRECATED*"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"This option abstracts out managing compute host stats to pluggable class."},{"line_number":133,"context_line":"This class manages and updates stats for the local compute host after"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_84994f71","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":12},"updated":"2016-06-20 17:13:01.000000000","message":"If deprecated we should use a deprecated flag instead of note in help message. Delete this line - it results in:\n\n# DEPRECATED:\n# *DEPRECATED*\n\nin a doc.","commit_id":"896a39db871ed3eb462dc4cd0778abde4dd65444"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"50069a09b8365207e21fe95d5170d6f2b8c7f280","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"* Possible values"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  A string representing fully qualified class name."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Services which consumes this:"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_04f27fd2","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":51},"updated":"2016-06-20 17:13:01.000000000","message":"What about default value?","commit_id":"896a39db871ed3eb462dc4cd0778abde4dd65444"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"50069a09b8365207e21fe95d5170d6f2b8c7f280","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"  A string representing fully qualified class name."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"* Services which consumes this:"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":" ``nova-compute``"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"* Related options"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_44d3e738","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":17},"updated":"2016-06-20 17:13:01.000000000","message":"This section is no longer required.","commit_id":"896a39db871ed3eb462dc4cd0778abde4dd65444"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Possible values:"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  * Any positive integer. The default is 0."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Related options:"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_2bbc55ba","line":94,"range":{"start_line":94,"start_character":4,"end_line":94,"end_character":24},"updated":"2016-06-29 13:33:08.000000000","message":"Add min\u003d0 flag to IntOpt","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  * Any positive integer. The default is 0."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Related options:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  * None"},{"line_number":99,"context_line":"\"\"\"),"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_8bad8986","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":8},"updated":"2016-06-29 13:33:08.000000000","message":"Drop this section","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Possible values:"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  * Any positive integer. Default is 512."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Related options"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0bc23934","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":16},"updated":"2016-06-29 13:33:08.000000000","message":"Ditto","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Related options"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  * None"},{"line_number":117,"context_line":"\"\"\"),"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    cfg.StrOpt(\u0027compute_stats_class\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_4bde0112","line":116,"updated":"2016-06-29 13:33:08.000000000","message":"Ditto","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    cfg.StrOpt(\u0027compute_stats_class\u0027,"},{"line_number":120,"context_line":"               default\u003d\u0027nova.compute.stats.Stats\u0027,"},{"line_number":121,"context_line":"               help\u003d\"\"\""},{"line_number":122,"context_line":"*DEPRECATED*"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"This option abstracts out managing compute host stats to pluggable class."},{"line_number":125,"context_line":"This class manages and updates stats for the local compute host after"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_eb436dad","line":122,"range":{"start_line":122,"start_character":1,"end_line":122,"end_character":11},"updated":"2016-06-29 13:33:08.000000000","message":"Add deprecated flag and delete this line.","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9e22827f76ab99235ffa27adda3240f6690c5fc6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"  * nova.compute.stats.Stats (default) or"},{"line_number":132,"context_line":"    A string representing fully qualified class name."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Related options"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"  * None"},{"line_number":137,"context_line":"\"\"\","},{"line_number":138,"context_line":"deprecated_for_removal\u003dTrue),"},{"line_number":139,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_6be93db7","line":136,"range":{"start_line":134,"start_character":0,"end_line":136,"end_character":8},"updated":"2016-06-29 13:33:08.000000000","message":"Ditto","commit_id":"37c084ca0a33117c74d49c1cd1599bee7f46cdb0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cf4be7ef583525c7d264d3238274e060dd977434","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               default\u003d0,"},{"line_number":86,"context_line":"               help\u003d\"\"\""},{"line_number":87,"context_line":"This option is used to reserve disk resources to make them always"},{"line_number":88,"context_line":"available to host.The disk usage gets reported back to the scheduler from"},{"line_number":89,"context_line":"nova-compute running on the compute nodes. To prevent the disk resources"},{"line_number":90,"context_line":"from being considered as available, this option can be used to reserve"},{"line_number":91,"context_line":"disk space in MB for that host."}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b46b48f0","line":88,"range":{"start_line":88,"start_character":17,"end_line":88,"end_character":19},"updated":"2016-06-30 13:11:17.000000000","message":"Nit: missing a space here.","commit_id":"05de66f0339434aea8d90f10a61674242f56c01c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cf4be7ef583525c7d264d3238274e060dd977434","unresolved":false,"context_lines":[{"line_number":100,"context_line":"               default\u003d512,"},{"line_number":101,"context_line":"               help\u003d\"\"\""},{"line_number":102,"context_line":"This option is used to reserve memory so that it is always available to host"},{"line_number":103,"context_line":"processes.The host resources usage is reported back to the scheduler"},{"line_number":104,"context_line":"continously from nova-compute running on the compute node. To prevent the host"},{"line_number":105,"context_line":"memory from being considered as available, this option can be used to reserve"},{"line_number":106,"context_line":"amount of memory in MB for the host."}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_147b3cbf","line":103,"range":{"start_line":103,"start_character":9,"end_line":103,"end_character":12},"updated":"2016-06-30 13:11:17.000000000","message":"Nit: missing a space","commit_id":"05de66f0339434aea8d90f10a61674242f56c01c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cf4be7ef583525c7d264d3238274e060dd977434","unresolved":false,"context_lines":[{"line_number":122,"context_line":"Possible values"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  * nova.compute.stats.Stats (default) or"},{"line_number":125,"context_line":"    A string representing fully qualified class name."},{"line_number":126,"context_line":"\"\"\"),"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_943c4ce2","line":125,"updated":"2016-06-30 13:11:17.000000000","message":"Nit: not sure we want to bother updating these deprecated ones, but this is OK.","commit_id":"05de66f0339434aea8d90f10a61674242f56c01c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"resource_tracker_opts \u003d ["},{"line_number":83,"context_line":"    cfg.IntOpt(\u0027reserved_host_disk_mb\u0027,"},{"line_number":84,"context_line":"               min\u003d0,"},{"line_number":85,"context_line":"               default\u003d0,"},{"line_number":86,"context_line":"               help\u003d\"\"\""},{"line_number":87,"context_line":"This option is used to reserve disk resources to make them always"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_bebe53d1","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":21},"updated":"2016-07-01 09:46:07.000000000","message":"You\u0027ve changed this opt: was this a bug or a feature? :) If people are using this, perhaps this needs a reno note?","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               min\u003d0,"},{"line_number":85,"context_line":"               default\u003d0,"},{"line_number":86,"context_line":"               help\u003d\"\"\""},{"line_number":87,"context_line":"This option is used to reserve disk resources to make them always"},{"line_number":88,"context_line":"available to host. The disk usage gets reported back to the scheduler from"},{"line_number":89,"context_line":"nova-compute running on the compute nodes. To prevent the disk resources"},{"line_number":90,"context_line":"from being considered as available, this option can be used to reserve"},{"line_number":91,"context_line":"disk space in MB for that host."}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_be865362","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":18},"updated":"2016-07-01 09:46:07.000000000","message":"The way this was worded previously was clearer. Consider breaking this into a summary and description, a lá git commit messages:\n\n    Amount of disk in MB to reserve for the host.\n\n    Reserve disk resource to ensure they are always available\n    to the host. The disk usage...","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Possible values:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Any positive integer. The default is 0."},{"line_number":96,"context_line":"\"\"\"),"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5ed00f1f","line":95,"range":{"start_line":95,"start_character":26,"end_line":95,"end_character":43},"updated":"2016-07-01 09:46:07.000000000","message":"Drop","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Possible values:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Any positive integer. The default is 0."},{"line_number":96,"context_line":"\"\"\"),"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    cfg.IntOpt(\u0027reserved_host_memory_mb\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5e976f47","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":25},"updated":"2016-07-01 09:46:07.000000000","message":"Maybe describe what those integers would correspond to?","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":99,"context_line":"               min\u003d0,"},{"line_number":100,"context_line":"               default\u003d512,"},{"line_number":101,"context_line":"               help\u003d\"\"\""},{"line_number":102,"context_line":"This option is used to reserve memory so that it is always available to host"},{"line_number":103,"context_line":"processes. The host resources usage is reported back to the scheduler"},{"line_number":104,"context_line":"continously from nova-compute running on the compute node. To prevent the host"},{"line_number":105,"context_line":"memory from being considered as available, this option can be used to reserve"},{"line_number":106,"context_line":"amount of memory in MB for the host."}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_9ebc3707","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":10},"updated":"2016-07-01 09:46:07.000000000","message":"Ditto","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Possible values:"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  * Any positive integer. Default is 512."},{"line_number":111,"context_line":"\"\"\"),"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    cfg.StrOpt(\u0027compute_stats_class\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_de899f27","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":25},"updated":"2016-07-01 09:46:07.000000000","message":"What do these integers correspond to?","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Possible values:"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  * Any positive integer. Default is 512."},{"line_number":111,"context_line":"\"\"\"),"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    cfg.StrOpt(\u0027compute_stats_class\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5edf6f68","line":110,"range":{"start_line":110,"start_character":25,"end_line":110,"end_character":41},"updated":"2016-07-01 09:46:07.000000000","message":"drop this - we can extract the default from the opt, meaning this is duplication","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":114,"context_line":"               default\u003d\u0027nova.compute.stats.Stats\u0027,"},{"line_number":115,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":116,"context_line":"               help\u003d\"\"\""},{"line_number":117,"context_line":"This option abstracts out managing compute host stats to pluggable class."},{"line_number":118,"context_line":"This class manages and updates stats for the local compute host after"},{"line_number":119,"context_line":"an instance is changed. These configurable compute stats may be useful for"},{"line_number":120,"context_line":"a particular scheduler implementation."}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_fe58dbfa","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":73},"updated":"2016-07-01 09:46:07.000000000","message":"ditto","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff8a521801b14296b34ce62875dd045e6ad037ad","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Possible values"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  * nova.compute.stats.Stats (default) or"},{"line_number":125,"context_line":"    A string representing fully qualified class name."},{"line_number":126,"context_line":"\"\"\"),"},{"line_number":127,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_de06bfcc","line":124,"range":{"start_line":124,"start_character":4,"end_line":124,"end_character":41},"updated":"2016-07-01 09:46:07.000000000","message":"drop this (duplication)","commit_id":"be46d60d20e620fb1729c3738c772ad72ee468ac"}]}