)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"f5adc795a3fd2d0254b88d9c89a72b07f637835c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch replaces mox with mock in"},{"line_number":10,"context_line":"tests/unit/api/openstack/compute/test_virtual_interfaces.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Part of blueprint remove-mox-ocata"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ieabff16c5dcbf0e78fddc8e4cdadc5c7d3324eff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a30ddce_5cdbf41a","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":34},"updated":"2017-03-10 20:51:41.000000000","message":"pike","commit_id":"9226a6eb5d999484f097da9012ab06208da90196"}],"nova/tests/unit/api/openstack/compute/test_virtual_interfaces.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7dff4b904550f9962db7a77a9e51b4db0851f5c2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _compute_api_get(context, instance_id, expected_attrs\u003dNone,"},{"line_number":33,"context_line":"                    want_objects\u003dFalse):"},{"line_number":34,"context_line":"    return dict(uuid\u003dFAKE_UUID, id\u003dinstance_id, instance_type_id\u003d1, host\u003d\u0027bob\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_5d619c38","line":33,"range":{"start_line":33,"start_character":20,"end_line":33,"end_character":38},"updated":"2016-05-26 01:00:31.000000000","message":"alignment","commit_id":"afb13738f4a20d5951349a910084e8edeee3d3b8"},{"author":{"_account_id":19935,"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","username":"trananhkma"},"change_message_id":"cf92387d01dad39676da1411465a6859f380003a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _compute_api_get(context, instance_id, expected_attrs\u003dNone,"},{"line_number":33,"context_line":"                    want_objects\u003dFalse):"},{"line_number":34,"context_line":"    return dict(uuid\u003dFAKE_UUID, id\u003dinstance_id, instance_type_id\u003d1, host\u003d\u0027bob\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_51efc31d","line":33,"range":{"start_line":33,"start_character":20,"end_line":33,"end_character":38},"in_reply_to":"bab6814e_5d619c38","updated":"2016-05-26 03:19:21.000000000","message":"Done","commit_id":"afb13738f4a20d5951349a910084e8edeee3d3b8"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"604022456b21718cd61d7d2f46f136449ff38273","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def setUp(self):"},{"line_number":67,"context_line":"        super(ServerVirtualInterfaceTestV21, self).setUp()"},{"line_number":68,"context_line":"        self.fake_context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":69,"context_line":"        self._set_controller()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _set_controller(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_560879d9","line":68,"range":{"start_line":68,"start_character":51,"end_line":68,"end_character":65},"updated":"2016-07-25 16:36:05.000000000","message":"I think here should be also some fake UUID.","commit_id":"9ef221aea068fbe28903a1daea9d4ccee0b5bbba"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42a04bf7c0cece7e5c3da6cd830aef2ade49814b","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_vifs_by_instance\u0027)"},{"line_number":79,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":80,"context_line":"    def test_get_virtual_interfaces_list(self, mock_get, mock_get_vifs):"},{"line_number":81,"context_line":"        mock_get.return_value \u003d _compute_api_get(self.fake_context, FAKE_UUID)"},{"line_number":82,"context_line":"        mock_get_vifs.return_value \u003d _generate_fake_vifs(self.fake_context)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_b458b68b","line":80,"range":{"start_line":80,"start_character":47,"end_line":80,"end_character":70},"updated":"2017-01-29 11:22:51.000000000","message":"Also add check their call with assert_called_once_with.","commit_id":"7dfaf21bfaac6d24564b6af34c86c365130afda7"},{"author":{"_account_id":19935,"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","username":"trananhkma"},"change_message_id":"fcf4dd97b4737a33f29f676376ac32dc2bde0593","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_vifs_by_instance\u0027)"},{"line_number":79,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":80,"context_line":"    def test_get_virtual_interfaces_list(self, mock_get, mock_get_vifs):"},{"line_number":81,"context_line":"        mock_get.return_value \u003d _compute_api_get(self.fake_context, FAKE_UUID)"},{"line_number":82,"context_line":"        mock_get_vifs.return_value \u003d _generate_fake_vifs(self.fake_context)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_a9e3d6d7","line":80,"range":{"start_line":80,"start_character":47,"end_line":80,"end_character":70},"in_reply_to":"3a461143_b458b68b","updated":"2017-02-15 07:11:09.000000000","message":"I think that it is no needed to call mock_get and mock_get_vifs. Because we have already faked these mocks and we got the returned value of these mocks.","commit_id":"7dfaf21bfaac6d24564b6af34c86c365130afda7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6a8557eb6aac2e994fc1dd63d2b193d92a2954b1","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_vifs_by_instance\u0027)"},{"line_number":79,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":80,"context_line":"    def test_get_virtual_interfaces_list(self, mock_get, mock_get_vifs):"},{"line_number":81,"context_line":"        mock_get.return_value \u003d _compute_api_get(self.fake_context, FAKE_UUID)"},{"line_number":82,"context_line":"        mock_get_vifs.return_value \u003d _generate_fake_vifs(self.fake_context)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_ec707ca6","line":80,"range":{"start_line":80,"start_character":47,"end_line":80,"end_character":70},"in_reply_to":"fa31d9ce_a9e3d6d7","updated":"2017-02-15 07:33:58.000000000","message":"true but it make sure right method is being mocked and called by mock.","commit_id":"7dfaf21bfaac6d24564b6af34c86c365130afda7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"42a04bf7c0cece7e5c3da6cd830aef2ade49814b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            expected_attrs\u003dNone)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":107,"context_line":"    def test_list_vifs_neutron_notimplemented(self, mock_get):"},{"line_number":108,"context_line":"        \"\"\"Tests that a 400 is returned when using neutron as the backend\"\"\""},{"line_number":109,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":110,"context_line":"        # reset the controller to use the neutron network API"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_14542a51","line":107,"range":{"start_line":107,"start_character":52,"end_line":107,"end_character":60},"updated":"2017-01-29 11:22:51.000000000","message":"ditto","commit_id":"7dfaf21bfaac6d24564b6af34c86c365130afda7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a02d35710432d743fa2a01612cf10655ac404565","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @mock.patch(\u0027nova.network.api.API.get_vifs_by_instance\u0027)"},{"line_number":79,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":80,"context_line":"    def test_get_virtual_interfaces_list(self, mock_get, mock_get_vifs):"},{"line_number":81,"context_line":"        mock_get.return_value \u003d _compute_api_get(self.fake_context, FAKE_UUID)"},{"line_number":82,"context_line":"        mock_get_vifs.return_value \u003d _generate_fake_vifs(self.fake_context)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_0c6cf0cc","line":80,"range":{"start_line":80,"start_character":46,"end_line":80,"end_character":70},"updated":"2017-02-15 07:34:11.000000000","message":"we should add assert call check for these.","commit_id":"9226a6eb5d999484f097da9012ab06208da90196"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a02d35710432d743fa2a01612cf10655ac404565","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            expected_attrs\u003dNone)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get\u0027)"},{"line_number":115,"context_line":"    def test_list_vifs_neutron_notimplemented(self, mock_get):"},{"line_number":116,"context_line":"        \"\"\"Tests that a 400 is returned when using neutron as the backend\"\"\""},{"line_number":117,"context_line":"        self.flags(use_neutron\u003dTrue)"},{"line_number":118,"context_line":"        # reset the controller to use the neutron network API"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_4c6268d9","line":115,"range":{"start_line":115,"start_character":52,"end_line":115,"end_character":60},"updated":"2017-02-15 07:34:11.000000000","message":"ditto","commit_id":"9226a6eb5d999484f097da9012ab06208da90196"}]}