)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"e0d82f7821b2a4aa48839353c6c046292769f429","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        return self.driver.refresh_security_group_members(security_group_id)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":264,"context_line":"    def refresh_provider_fw_rules(self, context, **_kwargs):"},{"line_number":265,"context_line":"        \"\"\"This call passes straight through to the virtualization driver.\"\"\""},{"line_number":266,"context_line":"        return self.driver.refresh_provider_fw_rules(**_kwargs)"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEH%2F%2F%2BW0%3D","line":264,"updated":"2012-01-25 05:30:27.000000000","message":"Rename _kwargs to kwargs","commit_id":"bd1fa7257df0d785ca62620bf480dfd40ae839d5"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"e0d82f7821b2a4aa48839353c6c046292769f429","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":264,"context_line":"    def refresh_provider_fw_rules(self, context, **_kwargs):"},{"line_number":265,"context_line":"        \"\"\"This call passes straight through to the virtualization driver.\"\"\""},{"line_number":266,"context_line":"        return self.driver.refresh_provider_fw_rules(**_kwargs)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _get_instance_nw_info(self, context, instance):"},{"line_number":269,"context_line":"        \"\"\"Get a list of dictionaries of network data of an instance."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEH%2F%2F%2BW4%3D","line":266,"updated":"2012-01-25 05:30:27.000000000","message":"Please rename to \u0027kwargs\u0027 as this label is now in use.","commit_id":"bd1fa7257df0d785ca62620bf480dfd40ae839d5"}],"nova/network/linux_net.py":[{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"ca2a9cc97f6222315da4d400134f102f5cd8dbcb","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                self.execute(\u0027%s-restore\u0027 % (cmd,), run_as_root\u003dTrue,"},{"line_number":314,"context_line":"                             process_input\u003d\u0027\\n\u0027.join(new_filter),"},{"line_number":315,"context_line":"                             attempts\u003d5)"},{"line_number":316,"context_line":"        LOG.debug(\"IPTablesManager.apply completed with success\")"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def _modify_rules(self, current_lines, table, binary\u003dNone):"},{"line_number":319,"context_line":"        unwrapped_chains \u003d table.unwrapped_chains"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEH%2F%2F%2BnQ%3D","line":316,"updated":"2012-01-24 22:36:14.000000000","message":"Is this useful? If so it needs i18n, but I also don\u0027t mind removing it.","commit_id":"d34975843e799e81ee7325d7452c1ffdda091086"}],"nova/rpc/impl_kombu.py":[{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"fc40c101b62f1b8b2717bf7920ebd8bb018a568b","unresolved":false,"context_lines":[{"line_number":721,"context_line":"            node_args \u003d dict((str(k), v) for k, v in args.iteritems())"},{"line_number":722,"context_line":"            # NOTE(vish): magic is fun!"},{"line_number":723,"context_line":"            LOG.debug(\u0027Method: %s called with args:values: %r\u0027, method,"},{"line_number":724,"context_line":"                                                                     node_args)"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"            rval \u003d node_func(context\u003dctxt, **node_args)"},{"line_number":727,"context_line":"            # Check if the result was a generator"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Bqk%3D","line":724,"updated":"2012-01-24 21:53:56.000000000","message":"Odd indentation.","commit_id":"5f5f2c7d8e7eca0f1b6a4041f4576279bbe4b06e"}],"nova/utils.py":[{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"fc40c101b62f1b8b2717bf7920ebd8bb018a568b","unresolved":false,"context_lines":[{"line_number":1073,"context_line":"            if isinstance(module_data[key], pyclbr.Class):"},{"line_number":1074,"context_line":"                clz \u003d import_class(\"%s.%s\" % (module, key))"},{"line_number":1075,"context_line":"                for method, func in inspect.getmembers(clz, inspect.ismethod):"},{"line_number":1076,"context_line":"                    setattr(clz, method, \\"},{"line_number":1077,"context_line":"                        decorator(\"%s.%s.%s\" % (module, key, method), func))"},{"line_number":1078,"context_line":"            # set the decorator for the function"},{"line_number":1079,"context_line":"            if isinstance(module_data[key], pyclbr.Function):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2Bqc%3D","line":1076,"updated":"2012-01-24 21:53:56.000000000","message":"Shouldn\u0027t need to escape this since it\u0027s wrapped in ().","commit_id":"5f5f2c7d8e7eca0f1b6a4041f4576279bbe4b06e"},{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"fc40c101b62f1b8b2717bf7920ebd8bb018a568b","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"            # set the decorator for the function"},{"line_number":1079,"context_line":"            if isinstance(module_data[key], pyclbr.Function):"},{"line_number":1080,"context_line":"                func \u003d import_class(\"%s.%s\" % (module, key))"},{"line_number":1081,"context_line":"                setattr(sys.modules[module], key, \\"},{"line_number":1082,"context_line":"                    decorator(\"%s.%s\" % (module, key), func))"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2BqY%3D","line":1081,"updated":"2012-01-24 21:53:56.000000000","message":"Shouldn\u0027t need to escape this since it\u0027s wrapped in ().","commit_id":"5f5f2c7d8e7eca0f1b6a4041f4576279bbe4b06e"}],"nova/virt/driver.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"e0d82f7821b2a4aa48839353c6c046292769f429","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        # Note (Deepak): the security_group_id parameter isn\u0027t really"},{"line_number":418,"context_line":"        # needed because each host has one \u0027provider chain\u0027 (typically named"},{"line_number":419,"context_line":"        # nova-compute-provider). So, no need to specify any group_id."},{"line_number":420,"context_line":"        # The xenapi and libvrit implementations are not using it hence."},{"line_number":421,"context_line":"        raise NotImplementedError()"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def reset_network(self, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEH%2F%2F%2BWk%3D","line":420,"updated":"2012-01-25 05:30:27.000000000","message":"Instead of this comment, can you update `nova.virt.driver:ComputeDrive.refresh_provider_fw_rules` to not take any parameters?","commit_id":"bd1fa7257df0d785ca62620bf480dfd40ae839d5"}],"nova/virt/firewall.py":[{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"fc40c101b62f1b8b2717bf7920ebd8bb018a568b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.instances[instance[\u0027id\u0027]] \u003d instance"},{"line_number":130,"context_line":"        self.network_infos[instance[\u0027id\u0027]] \u003d network_info"},{"line_number":131,"context_line":"        self.add_filters_for_instance(instance)"},{"line_number":132,"context_line":"        LOG.debug(\u0027Filters added to the instance: %r\u0027, instance)"},{"line_number":133,"context_line":"        self.refresh_provider_fw_rules()"},{"line_number":134,"context_line":"        LOG.debug(\u0027Provider Firewall Rules refreshed\u0027)"},{"line_number":135,"context_line":"        self.iptables.apply()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2BqM%3D","line":132,"updated":"2012-01-24 21:53:56.000000000","message":"Should be localized.","commit_id":"5f5f2c7d8e7eca0f1b6a4041f4576279bbe4b06e"},{"author":{"_account_id":209,"name":"Josh Kearney","email":"josh@jk0.org","username":"jk0"},"change_message_id":"fc40c101b62f1b8b2717bf7920ebd8bb018a568b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self.add_filters_for_instance(instance)"},{"line_number":132,"context_line":"        LOG.debug(\u0027Filters added to the instance: %r\u0027, instance)"},{"line_number":133,"context_line":"        self.refresh_provider_fw_rules()"},{"line_number":134,"context_line":"        LOG.debug(\u0027Provider Firewall Rules refreshed\u0027)"},{"line_number":135,"context_line":"        self.iptables.apply()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _create_filter(self, ips, chain_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F%2BqI%3D","line":134,"updated":"2012-01-24 21:53:56.000000000","message":"Should be localized.","commit_id":"5f5f2c7d8e7eca0f1b6a4041f4576279bbe4b06e"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"e0d82f7821b2a4aa48839353c6c046292769f429","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            for rule in ipv6_rules:"},{"line_number":387,"context_line":"                self.iptables.ipv6[\u0027filter\u0027].add_rule(\u0027provider\u0027, rule)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def _provider_rules(self):"},{"line_number":390,"context_line":"        \"\"\"Generate a list of rules from provider for IP4 \u0026 IP6.\"\"\""},{"line_number":391,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEH%2F%2F%2BWw%3D","line":389,"updated":"2012-01-25 05:30:27.000000000","message":"Does this need to be implemented?","commit_id":"bd1fa7257df0d785ca62620bf480dfd40ae839d5"}],"nova/virt/xenapi_conn.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"e0d82f7821b2a4aa48839353c6c046292769f429","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        return self._vmops.refresh_security_group_members(security_group_id)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def refresh_provider_fw_rules(self):"},{"line_number":447,"context_line":"        #NOTE(Deepak): the driver.ComputeDriver class has a different"},{"line_number":448,"context_line":"        #signature for this method. It passes an extra parameter called"},{"line_number":449,"context_line":"        #\u0027security_group_id\u0027 which is not needed."},{"line_number":450,"context_line":"        #Python allows this in inheritance (unfortunately)."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEH%2F%2F%2BWo%3D","line":447,"updated":"2012-01-25 05:30:27.000000000","message":"Instead of this comment, can you update `nova.virt.driver:ComputeDrive.refresh_provider_fw_rules` to not take any parameters?","commit_id":"bd1fa7257df0d785ca62620bf480dfd40ae839d5"}]}