)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"8b78698dda7913aff1a7ab129ec92061c786590b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SongRuixia \u003csong.ruixia@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-25 11:26:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"instance can not resize ephemeral in mitaka"},{"line_number":8,"context_line":"In mitaka, boot an instance with ephemeral disk, then resize the"},{"line_number":9,"context_line":"instance, but ephemeral disk.eph0 is not resized."},{"line_number":10,"context_line":"This patch update resize code for ephemeral disk.eph0."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_5958ccfa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2016-05-25 03:26:30.000000000","message":"s/instance/Instance","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"},{"author":{"_account_id":17898,"name":"Jinquan Ni","email":"ni.jinquan@zte.com.cn","username":"jinquanni"},"change_message_id":"8b78698dda7913aff1a7ab129ec92061c786590b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-05-25 11:26:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"instance can not resize ephemeral in mitaka"},{"line_number":8,"context_line":"In mitaka, boot an instance with ephemeral disk, then resize the"},{"line_number":9,"context_line":"instance, but ephemeral disk.eph0 is not resized."},{"line_number":10,"context_line":"This patch update resize code for ephemeral disk.eph0."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_b96738b6","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":64},"updated":"2016-05-25 03:26:30.000000000","message":"Need a blank line before here.","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"},{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"dca63efa7dd7ea1d11ceea6c6e24fa3d29204cdc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-05-25 11:26:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"instance can not resize ephemeral in mitaka"},{"line_number":8,"context_line":"In mitaka, boot an instance with ephemeral disk, then resize the"},{"line_number":9,"context_line":"instance, but ephemeral disk.eph0 is not resized."},{"line_number":10,"context_line":"This patch update resize code for ephemeral disk.eph0."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_a0639a19","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":64},"in_reply_to":"bab6814e_b96738b6","updated":"2016-05-28 07:21:30.000000000","message":"Yes,it is needed a blank line.","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72c7d774df8339c749958fd350aafc53c17b6ab8","unresolved":false,"context_lines":[{"line_number":9401,"context_line":"        wantFiles \u003d ["},{"line_number":9402,"context_line":"            {\u0027filename\u0027: \u0027356a192b7913b04c54574d18c28d46e6395428ab\u0027,"},{"line_number":9403,"context_line":"             \u0027size\u0027: 10 * units.Gi},"},{"line_number":9404,"context_line":"            #{\u0027filename\u0027: filename,"},{"line_number":9405,"context_line":"            # \u0027size\u0027: 20 * units.Gi},"},{"line_number":9406,"context_line":"            ]"},{"line_number":9407,"context_line":"        self.assertEqual(gotFiles, wantFiles)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_eb59d836","line":9404,"updated":"2016-05-25 10:23:19.000000000","message":"What is the reason you had to remove the second file?\nPlease remove commented out code.","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72c7d774df8339c749958fd350aafc53c17b6ab8","unresolved":false,"context_lines":[{"line_number":3026,"context_line":"                                                          os_type_with_default)"},{"line_number":3027,"context_line":""},{"line_number":3028,"context_line":"        ephemeral_gb \u003d instance.ephemeral_gb"},{"line_number":3029,"context_line":"        if \u0027disk.eph0\u0027 in disk_mapping:"},{"line_number":3030,"context_line":"            disk_image \u003d image(\u0027disk.eph0\u0027)"},{"line_number":3031,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":3032,"context_line":"                                   fs_label\u003d\u0027ephemeral0\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0b5a5c83","line":3029,"updated":"2016-05-25 10:23:19.000000000","message":"I think we need a more reasoning why this change solves the problem, \u0027disk.local\u0027 is used in many places in the code. As far as I see it is the default ephemeral disk, see https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L565","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"},{"author":{"_account_id":17532,"name":"Tina Kevin","email":"song.ruixia@zte.com.cn","username":"SongRuixia"},"change_message_id":"e811d13ae87131d67d8bb4281bdf091b2253c810","unresolved":false,"context_lines":[{"line_number":3026,"context_line":"                                                          os_type_with_default)"},{"line_number":3027,"context_line":""},{"line_number":3028,"context_line":"        ephemeral_gb \u003d instance.ephemeral_gb"},{"line_number":3029,"context_line":"        if \u0027disk.eph0\u0027 in disk_mapping:"},{"line_number":3030,"context_line":"            disk_image \u003d image(\u0027disk.eph0\u0027)"},{"line_number":3031,"context_line":"            fn \u003d functools.partial(self._create_ephemeral,"},{"line_number":3032,"context_line":"                                   fs_label\u003d\u0027ephemeral0\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_e3a5ac04","line":3029,"in_reply_to":"bab6814e_0b5a5c83","updated":"2016-05-28 07:51:16.000000000","message":"Yes, as you said, a lot of places  uses the disk.local. In /nova/virt/libvirt/blockinfo.py, When I boot a VM, it will determine whether there is a default ephemeral disk, if there is, the ephemeral disk is named disk.local. If not, take the following procedures will be named disk.ephN. Now in the code, the function has_default_ephemeral return None to default_eph which led to no disk.local. The ephemeral disk is named disk.eph0.\n   code:\n    default_eph \u003d has_default_ephemeral(instance, disk_bus, block_device_info,\n                                        mapping)\n    if default_eph:\n        mapping[\u0027disk.local\u0027] \u003d default_eph\n\nThe reason that default_eph is none is the ephemeral disk of flavor is recorded in the block_device_mapping table in the nova database that lead to block_device_info contain ephemeral information. \nI do not understand the following judgment, why return None when block_device_info contain ephemerals information? \n\n    def has_default_ephemeral(instance, disk_bus, block_device_info, mapping):\n        ephemerals \u003d driver.block_device_info_get_ephemerals(block_device_info)\n        if instance.ephemeral_gb \u003c\u003d 0 or ephemerals:\n            return None\n\nNow I feel I modified the code is not appropriate, and I want to continue later modified.","commit_id":"fa89522fa07b32c1575d491384d0c62025135a94"}]}