)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"76a85940937f8dedf54b24dc9ea610b4465be127","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    Traceback (most recent call last):"},{"line_number":16,"context_line":"      File \"nova/exception.py\", line 140, in __init__"},{"line_number":17,"context_line":"        message \u003d self.msg_fmt % kwargs"},{"line_number":18,"context_line":"    KeyError: u\u0027instance_id\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch changes the mock to use \"instance_id\", which is the correct"},{"line_number":21,"context_line":"kwarg for the format string of the InstanceNotFound exception. It also"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_1855894f","line":18,"updated":"2016-05-25 12:04:57.000000000","message":"See logstash:\n\nhttp://logstash.openstack.org/#dashboard/file/logstash.json?query\u003dproject%3A%5C%22openstack%2Fnova%5C%22%20AND%20message%3A%5C%22KeyError%3A%20u\u0027instance_id\u0027%5C%22","commit_id":"6a422828aeb9707bdcc323075c598962d87d8897"}],"nova/tests/unit/api/openstack/compute/test_server_start_stop.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e8e57ae19f6b855ba2dc4cfbf4295a054f3bb26c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    @mock.patch.object(db, \u0027instance_get_by_uuid\u0027,"},{"line_number":142,"context_line":"                       side_effect\u003dexception.InstanceNotFound("},{"line_number":143,"context_line":"                           instance_id\u003duuids.instance))"},{"line_number":144,"context_line":"    def test_stop_with_bogus_id(self, get_mock):"},{"line_number":145,"context_line":"        body \u003d dict(stop\u003d\"\")"},{"line_number":146,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":147,"context_line":"            self.controller._stop_server, self.req, uuids.instance, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0116b1f0","line":144,"updated":"2016-05-25 13:23:12.000000000","message":"We use a conf fixture [1] to detect such string format errors which should fail the unit test. But the \"mock.patch\" decorator gets placed *before* the fixture is loaded in the base test class at [2]. That\u0027s why this issue didn\u0027t show up in the gate. I\u0027m not quite sure how to solve this without changing all decorators (for exceptions) to a with statement within the method body.\n\nReferences:\n[1] https://github.com/openstack/nova/blob/5252f337f4640c407dd80d6b4ec731fe6b45e63f/nova/tests/unit/conf_fixture.py#L56-L56\n[2] https://github.com/openstack/nova/blob/1a1a41bdbe0dc16ca594236925e77ce99f432b9d/nova/test.py#L210-L210","commit_id":"6a422828aeb9707bdcc323075c598962d87d8897"}]}