)]}'
{"nova/conf/cinder.py":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"590c7122e1558bc246cb83dee5efaf7e08bf5848","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            default\u003d\"volumev2:cinderv2:publicURL\","},{"line_number":26,"context_line":"            help\u003d\"\"\""},{"line_number":27,"context_line":"Info to match when looking for cinder in the service"},{"line_number":28,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":29,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9a1083ad","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":19},"updated":"2016-06-16 03:50:06.000000000","message":"I think we should remove it here :)","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"36ea98bee1bb3a098ef6cd4d4015696754c43395","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            default\u003d\"volumev2:cinderv2:publicURL\","},{"line_number":26,"context_line":"            help\u003d\"\"\""},{"line_number":27,"context_line":"Info to match when looking for cinder in the service"},{"line_number":28,"context_line":"catalog. Format is: separated values of the form:"},{"line_number":29,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_b3a48e57","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":19},"in_reply_to":"7aa08908_9a1083ad","updated":"2016-06-20 19:13:34.000000000","message":"Done","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"590c7122e1558bc246cb83dee5efaf7e08bf5848","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    service_type - volume, volumev2, volumev3"},{"line_number":34,"context_line":"    service_name - cinder"},{"line_number":35,"context_line":"    endpoint_type - PublicURL"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Related options:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1a3e5329","line":36,"updated":"2016-06-16 03:50:06.000000000","message":"Missing default value here.","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"36ea98bee1bb3a098ef6cd4d4015696754c43395","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    service_type - volume, volumev2, volumev3"},{"line_number":34,"context_line":"    service_name - cinder"},{"line_number":35,"context_line":"    endpoint_type - PublicURL"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Related options:"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_d39f9a01","line":36,"in_reply_to":"7aa08908_1a3e5329","updated":"2016-06-20 19:13:34.000000000","message":"Done","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"590c7122e1558bc246cb83dee5efaf7e08bf5848","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Possible values:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    Any integer value."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Related options:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_1a25b309","line":75,"updated":"2016-06-16 03:50:06.000000000","message":"Missing default value here.","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"36ea98bee1bb3a098ef6cd4d4015696754c43395","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Possible values:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    Any integer value."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Related options:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_138ac2bf","line":75,"in_reply_to":"7aa08908_1a25b309","updated":"2016-06-20 19:13:34.000000000","message":"Done","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"590c7122e1558bc246cb83dee5efaf7e08bf5848","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    True, False"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Related options:"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3a1cefc0","line":99,"updated":"2016-06-16 03:50:06.000000000","message":"Missing default value here.","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"36ea98bee1bb3a098ef6cd4d4015696754c43395","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    True, False"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Related options:"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_f38616b8","line":99,"in_reply_to":"7aa08908_3a1cefc0","updated":"2016-06-20 19:13:34.000000000","message":"Done","commit_id":"a48050d5eadab9bbd7029da7454cb990058e0010"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cinder_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    \"cinder\","},{"line_number":21,"context_line":"    title\u003d\"Cinder Options\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cinder_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_9746551f","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":5},"updated":"2016-06-29 10:28:52.000000000","message":"Nit: we should avoid \u0027-\u003e\" changes, we should really just leave them as they are for now.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cinder_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    \"cinder\","},{"line_number":21,"context_line":"    title\u003d\"Cinder Options\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cinder_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d8eab073","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":5},"in_reply_to":"3aaa91ec_9746551f","updated":"2016-06-29 19:25:20.000000000","message":"Reverted on this patch, I will try to revert on other patches as well.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cinder_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    \"cinder\","},{"line_number":21,"context_line":"    title\u003d\"Cinder Options\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cinder_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(\"catalog_info\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b7dd5172","line":21,"updated":"2016-06-29 10:28:52.000000000","message":"can we add the help text for the group too?","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"cinder_group \u003d cfg.OptGroup("},{"line_number":20,"context_line":"    \"cinder\","},{"line_number":21,"context_line":"    title\u003d\"Cinder Options\")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cinder_opts \u003d ["},{"line_number":24,"context_line":"    cfg.StrOpt(\"catalog_info\","}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_38049448","line":21,"in_reply_to":"3aaa91ec_b7dd5172","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            default\u003d\"volumev2:cinderv2:publicURL\","},{"line_number":26,"context_line":"            help\u003d\"\"\""},{"line_number":27,"context_line":"Info to match when looking for cinder in the service"},{"line_number":28,"context_line":"catalog. Format is separated values of the form:"},{"line_number":29,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_770f69e1","line":28,"updated":"2016-06-29 10:28:52.000000000","message":"Nit: we should wrap the lines more correctly here.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            default\u003d\"volumev2:cinderv2:publicURL\","},{"line_number":26,"context_line":"            help\u003d\"\"\""},{"line_number":27,"context_line":"Info to match when looking for cinder in the service"},{"line_number":28,"context_line":"catalog. Format is separated values of the form:"},{"line_number":29,"context_line":"\u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1801d838","line":28,"in_reply_to":"3aaa91ec_770f69e1","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    service_type - volume, volumev2 (default), volumev3"},{"line_number":34,"context_line":"    service_name - cinder, cinderv2 (default)"},{"line_number":35,"context_line":"    endpoint_type - PublicURL"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_777c8972","line":33,"updated":"2016-06-29 10:28:52.000000000","message":"Normally these get a \"*\" at the beginning, so it will eventually render as a list.\n\nSo there are actually many possible values here, technically. I don\u0027t think we can enumerate them all, lets just drop the possible values bit. I think the description is clear enough.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Possible values:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    service_type - volume, volumev2 (default), volumev3"},{"line_number":34,"context_line":"    service_name - cinder, cinderv2 (default)"},{"line_number":35,"context_line":"    endpoint_type - PublicURL"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_58f7e058","line":33,"in_reply_to":"3aaa91ec_777c8972","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Related options:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    None"},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027endpoint_template\u0027,"},{"line_number":43,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_57e06dfa","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":8},"updated":"2016-06-29 10:28:52.000000000","message":"endpoint_template can make Nova ignore this option, probably worth adding that note?","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Related options:"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    None"},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027endpoint_template\u0027,"},{"line_number":43,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b896c4ed","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":8},"in_reply_to":"3aaa91ec_57e06dfa","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"this template for cinder endpoint"},{"line_number":46,"context_line":"e.g. http://localhost:8776/v1/%(project_id)s"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Possible values:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    URL for cinder endpoint API"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Related options:"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_37d3213a","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":31},"updated":"2016-06-29 10:28:52.000000000","message":"Should we not mention that the default is to use the catalog_info to look up the URL in the service catalog.\n\nI like the example, noting the substitution for the project_id.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"this template for cinder endpoint"},{"line_number":46,"context_line":"e.g. http://localhost:8776/v1/%(project_id)s"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Possible values:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    URL for cinder endpoint API"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Related options:"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_98c2e8e7","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":31},"in_reply_to":"3aaa91ec_37d3213a","updated":"2016-06-29 19:25:20.000000000","message":"I think description already states that. It will be repetitive.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Related options:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    None"},{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":57,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_57b7cdf4","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":8},"updated":"2016-06-29 10:28:52.000000000","message":"Maybe note the fallback to use catalog_info?","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Related options:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    None"},{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":57,"context_line":"               help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d8b8f077","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":8},"in_reply_to":"3aaa91ec_57b7cdf4","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":57,"context_line":"               help\u003d\"\"\""},{"line_number":58,"context_line":"Region name of this node"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Possible values:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_37a161aa","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":24},"updated":"2016-06-29 10:28:52.000000000","message":"we should note, this is used when picking the URL in the service catalog.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":57,"context_line":"               help\u003d\"\"\""},{"line_number":58,"context_line":"Region name of this node"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Possible values:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_18af182b","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":24},"in_reply_to":"3aaa91ec_37a161aa","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    None"},{"line_number":67,"context_line":"\"\"\"),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027http_retries\u0027,"},{"line_number":69,"context_line":"               default\u003d3,"},{"line_number":70,"context_line":"               help\u003d\"\"\""},{"line_number":71,"context_line":"Number of times cinderclient should retry on any failed http call"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d79a9d6d","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":14},"updated":"2016-06-29 10:28:52.000000000","message":"is the min_value 0 or 1, we should set that in the conf option here.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    None"},{"line_number":67,"context_line":"\"\"\"),"},{"line_number":68,"context_line":"    cfg.IntOpt(\u0027http_retries\u0027,"},{"line_number":69,"context_line":"               default\u003d3,"},{"line_number":70,"context_line":"               help\u003d\"\"\""},{"line_number":71,"context_line":"Number of times cinderclient should retry on any failed http call"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f86a0cec","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":14},"in_reply_to":"3aaa91ec_d79a9d6d","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Possible values:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    Any integer value. Default is 3."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Related options:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b7955141","line":75,"updated":"2016-06-29 10:28:52.000000000","message":"What does 0 mean here? Does 3 mean we retry 3 times, i.e. 4 attempts in total?","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* Possible values:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    Any integer value. Default is 3."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* Related options:"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_387934c9","line":75,"in_reply_to":"3aaa91ec_b7955141","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                default\u003dTrue,"},{"line_number":83,"context_line":"                help\u003d\"\"\""},{"line_number":84,"context_line":"Allow attach between instance and volume in different"},{"line_number":85,"context_line":"availability zones. If False, volumes attached to an"},{"line_number":86,"context_line":"instance must be in the same availability zone in"},{"line_number":87,"context_line":"Cinder as the instance availability zone in Nova."},{"line_number":88,"context_line":"This also means care should be taken when booting an"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_57b34de9","line":85,"range":{"start_line":85,"start_character":20,"end_line":85,"end_character":28},"updated":"2016-06-29 10:28:52.000000000","message":"maybe start a new line here?\n\nDo we actually describe what happens for the default case, where it is true?\n\nI think if true there are no restrictions, probably worth mentioning that after the if false description.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                default\u003dTrue,"},{"line_number":83,"context_line":"                help\u003d\"\"\""},{"line_number":84,"context_line":"Allow attach between instance and volume in different"},{"line_number":85,"context_line":"availability zones. If False, volumes attached to an"},{"line_number":86,"context_line":"instance must be in the same availability zone in"},{"line_number":87,"context_line":"Cinder as the instance availability zone in Nova."},{"line_number":88,"context_line":"This also means care should be taken when booting an"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_787f3cab","line":85,"range":{"start_line":85,"start_character":20,"end_line":85,"end_character":28},"in_reply_to":"3aaa91ec_57b34de9","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"instance. If that AZ is not in Cinder (or"},{"line_number":93,"context_line":"allow_availability_zone_fallback\u003dFalse in cinder.conf),"},{"line_number":94,"context_line":"the volume create request will fail and the instance"},{"line_number":95,"context_line":"will fail the build request."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_f7ad1989","line":95,"updated":"2016-06-29 10:28:52.000000000","message":"might be nice to fix the wrapping of this text.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"instance. If that AZ is not in Cinder (or"},{"line_number":93,"context_line":"allow_availability_zone_fallback\u003dFalse in cinder.conf),"},{"line_number":94,"context_line":"the volume create request will fail and the instance"},{"line_number":95,"context_line":"will fail the build request."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_98502834","line":95,"in_reply_to":"3aaa91ec_f7ad1989","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"10ac5b867d121201a05a1f582a228fb72cd7106d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"the volume create request will fail and the instance"},{"line_number":95,"context_line":"will fail the build request."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    True (default), False"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Related options:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    None"},{"line_number":104,"context_line":"\"\"\"),"},{"line_number":105,"context_line":"]"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_b77c3121","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":8},"updated":"2016-06-29 10:28:52.000000000","message":"Lets drop all that.","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"ba04a2b3dc489ed9c5b4eb5f8790b64a1b5788b1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"the volume create request will fail and the instance"},{"line_number":95,"context_line":"will fail the build request."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* Possible values:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    True (default), False"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Related options:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    None"},{"line_number":104,"context_line":"\"\"\"),"},{"line_number":105,"context_line":"]"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_d846307a","line":103,"range":{"start_line":97,"start_character":0,"end_line":103,"end_character":8},"in_reply_to":"3aaa91ec_b77c3121","updated":"2016-06-29 19:25:20.000000000","message":"Done","commit_id":"56e037d3a89e03cf1b1f9a68a7dcfe69441b7341"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e882d489f2eebd842cd91e8a200c270bee225899","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":26,"context_line":"            default\u003d\u0027volumev2:cinderv2:publicURL\u0027,"},{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog. Format is"},{"line_number":29,"context_line":"separated values of the form: \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Related options:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_248094f6","line":29,"range":{"start_line":28,"start_character":62,"end_line":29,"end_character":75},"updated":"2016-07-01 10:21:33.000000000","message":"Format this as a \"possible values\" section?","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a2cd884e03c0905f844af39d6201020cfec7f342","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":26,"context_line":"            default\u003d\u0027volumev2:cinderv2:publicURL\u0027,"},{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog. Format is"},{"line_number":29,"context_line":"separated values of the form: \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Related options:"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_5df75cd4","line":29,"range":{"start_line":28,"start_character":62,"end_line":29,"end_character":75},"in_reply_to":"3aaa91ec_248094f6","updated":"2016-07-01 17:37:59.000000000","message":"Done","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e882d489f2eebd842cd91e8a200c270bee225899","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               help\u003d\"\"\""},{"line_number":37,"context_line":"If this option is set then it will override service catalog lookup with"},{"line_number":38,"context_line":"this template for cinder endpoint"},{"line_number":39,"context_line":"e.g. http://localhost:8776/v1/%(project_id)s"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Possible values:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_c493904d","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":44},"updated":"2016-07-01 10:21:33.000000000","message":"Move this into the \"Possible values\" section.","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a2cd884e03c0905f844af39d6201020cfec7f342","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               help\u003d\"\"\""},{"line_number":37,"context_line":"If this option is set then it will override service catalog lookup with"},{"line_number":38,"context_line":"this template for cinder endpoint"},{"line_number":39,"context_line":"e.g. http://localhost:8776/v1/%(project_id)s"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Possible values:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_3df410ce","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":44},"in_reply_to":"3aaa91ec_c493904d","updated":"2016-07-01 17:37:59.000000000","message":"Done","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e882d489f2eebd842cd91e8a200c270bee225899","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Possible values:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Any integer value. Default is 3."},{"line_number":70,"context_line":"\"\"\"),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":72,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_443cc02e","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":36},"updated":"2016-07-01 10:21:33.000000000","message":"remove this (stated on line 59)","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a2cd884e03c0905f844af39d6201020cfec7f342","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Possible values:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Any integer value. Default is 3."},{"line_number":70,"context_line":"\"\"\"),"},{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":72,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_dd298c3c","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":36},"in_reply_to":"3aaa91ec_443cc02e","updated":"2016-07-01 17:37:59.000000000","message":"Done","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e882d489f2eebd842cd91e8a200c270bee225899","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":72,"context_line":"                default\u003dTrue,"},{"line_number":73,"context_line":"                help\u003d\"\"\""},{"line_number":74,"context_line":"Allow attach between instance and volume in different availability zones."},{"line_number":75,"context_line":"If False, volumes attached to an instance must be in the same availability"},{"line_number":76,"context_line":"zone in Cinder as the instance availability zone in Nova."},{"line_number":77,"context_line":"This also means care should be taken when booting an instance from a volume"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_04d2b8d0","line":74,"updated":"2016-07-01 10:21:33.000000000","message":"Can you insert a blank line after this? (summary - break - description)","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"a2cd884e03c0905f844af39d6201020cfec7f342","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":72,"context_line":"                default\u003dTrue,"},{"line_number":73,"context_line":"                help\u003d\"\"\""},{"line_number":74,"context_line":"Allow attach between instance and volume in different availability zones."},{"line_number":75,"context_line":"If False, volumes attached to an instance must be in the same availability"},{"line_number":76,"context_line":"zone in Cinder as the instance availability zone in Nova."},{"line_number":77,"context_line":"This also means care should be taken when booting an instance from a volume"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_bd2e4040","line":74,"in_reply_to":"3aaa91ec_04d2b8d0","updated":"2016-07-01 17:37:59.000000000","message":"Done","commit_id":"a9305487f50b61555c2110d23126383e15126815"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"6ef659694cc83086e76723eb0ac6cf434d5fc92b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_f67bedf2","side":"PARENT","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":40},"updated":"2016-07-07 14:49:38.000000000","message":"Why are these being removed?","commit_id":"d68acca919eae35627f32d6bcf85f1bfdf9ad030"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"798e2f7e6d0587d7dff4eacf3086e4447be38429","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"},{"line_number":5,"context_line":"# needs:fix_opt_registration_consistency"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Copyright (c) 2016 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_d987025f","side":"PARENT","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":40},"in_reply_to":"1aa78d24_f67bedf2","updated":"2016-07-07 14:55:00.000000000","message":"Ed, \nAs per me I fixed all these :). So removing these to consider this file as done in burndown chart.","commit_id":"d68acca919eae35627f32d6bcf85f1bfdf9ad030"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7356b125b5c3b7b94fd5eeeae3e52e6137bfc596","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"cinder_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":26,"context_line":"            default\u003d\u0027volumev2:cinderv2:publicURL\u0027,"},{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_5ab30d0a","line":26,"updated":"2016-07-07 12:43:13.000000000","message":"We need to add a regex here, to validate the \"s:s:s\" style required.","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"acf044e13f3f82118305e51e48a58cc077b36ea8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"cinder_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027catalog_info\u0027,"},{"line_number":26,"context_line":"            default\u003d\u0027volumev2:cinderv2:publicURL\u0027,"},{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_5d9cd00d","line":26,"in_reply_to":"1aa78d24_5ab30d0a","updated":"2016-07-12 15:39:28.000000000","message":"Done","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4970a0ef8ceaafa47b607dda776b23f23d6fe796","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Possible values:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Format is separated values of the form:"},{"line_number":33,"context_line":"    \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_9ae0d52a","line":30,"updated":"2016-07-07 12:38:49.000000000","message":"So technically this line should not get a \"*\" but the lines below should get a \"*\".\n\nSee: https://github.com/openstack/nova/blob/master/nova/conf/serial_console.py","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"acf044e13f3f82118305e51e48a58cc077b36ea8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            help\u003d\"\"\""},{"line_number":28,"context_line":"Info to match when looking for cinder in the service catalog."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Possible values:"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Format is separated values of the form:"},{"line_number":33,"context_line":"    \u003cservice_type\u003e:\u003cservice_name\u003e:\u003cendpoint_type\u003e"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_1dbd2868","line":30,"in_reply_to":"1aa78d24_9ae0d52a","updated":"2016-07-12 15:39:28.000000000","message":"Done","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7356b125b5c3b7b94fd5eeeae3e52e6137bfc596","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Possible values:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    Any string representing region name"},{"line_number":61,"context_line":"\"\"\"),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027http_retries\u0027,"},{"line_number":63,"context_line":"               default\u003d3,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_9a757565","line":60,"updated":"2016-07-07 12:43:13.000000000","message":"What happens by default when there is no region specified?","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"acf044e13f3f82118305e51e48a58cc077b36ea8","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Possible values:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    Any string representing region name"},{"line_number":61,"context_line":"\"\"\"),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027http_retries\u0027,"},{"line_number":63,"context_line":"               default\u003d3,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_7d754cc9","line":60,"in_reply_to":"1aa78d24_9a757565","updated":"2016-07-12 15:39:28.000000000","message":"@John: I could not get this from browsing code. Can you please help with this?","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3bc08d91094be3a6e72cc910f1ef1afd5e700112","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    Any integer value."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":76,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_d9a05093","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":22},"updated":"2016-07-04 16:36:13.000000000","message":"maybe state what the integer values correspond to?","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"acf044e13f3f82118305e51e48a58cc077b36ea8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    Any integer value."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":76,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_fd4f7c8f","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":22},"in_reply_to":"1aa78d24_d9a05093","updated":"2016-07-12 15:39:28.000000000","message":"Done","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7356b125b5c3b7b94fd5eeeae3e52e6137bfc596","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    Any integer value."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":76,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_fa3119a3","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":22},"in_reply_to":"1aa78d24_d9a05093","updated":"2016-07-07 12:43:13.000000000","message":"Maybe state what 0 means. I see ln69 covers the default nicely.","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"acf044e13f3f82118305e51e48a58cc077b36ea8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* Possible values:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    Any integer value."},{"line_number":74,"context_line":"\"\"\"),"},{"line_number":75,"context_line":"    cfg.BoolOpt(\u0027cross_az_attach\u0027,"},{"line_number":76,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_1d4b6888","line":73,"range":{"start_line":73,"start_character":21,"end_line":73,"end_character":22},"in_reply_to":"1aa78d24_fa3119a3","updated":"2016-07-12 15:39:28.000000000","message":"Done","commit_id":"31664a8a127b1e5829564c0fe7b059866505a0b0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"033906a5e64384a090afe001ebb168648dec338e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027os_region_name\u0027,"},{"line_number":55,"context_line":"               help\u003d\"\"\""},{"line_number":56,"context_line":"Region name of this node. This is used when picking the URL in the service"},{"line_number":57,"context_line":"catalog."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_29bff7d0","line":56,"range":{"start_line":56,"start_character":60,"end_line":56,"end_character":62},"updated":"2016-07-27 12:48:40.000000000","message":"Nit: from?","commit_id":"614d8b49ec903e90d0404ac933171e9b413ede20"}]}