)]}'
{"nova/image/glance.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8ebfe4cec812d8cf0683ce27c39d350a9fe1eeb7","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    def _add_location(self, context, image_id, location):"},{"line_number":654,"context_line":"        # \u0027show_multiple_locations\u0027 must be enabled in glance api conf file."},{"line_number":655,"context_line":"        return self._client.call(context, 2, \u0027add_location\u0027, image_id,"},{"line_number":656,"context_line":"                                 location, {})"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def _upload_data(self, context, image_id, data):"},{"line_number":659,"context_line":"        self._client.call(context, 2, \u0027upload\u0027, image_id, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_5f71c943","line":656,"updated":"2016-06-03 11:37:11.000000000","message":"what happens if it is not? What\u0027s the error recovery for it?","commit_id":"8e6809b8f2fac0e192b6cf800515533897663a79"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"983d7dab5a27b63879912ad777f9e527c696d369","unresolved":false,"context_lines":[{"line_number":653,"context_line":"    def _add_location(self, context, image_id, location):"},{"line_number":654,"context_line":"        # \u0027show_multiple_locations\u0027 must be enabled in glance api conf file."},{"line_number":655,"context_line":"        return self._client.call(context, 2, \u0027add_location\u0027, image_id,"},{"line_number":656,"context_line":"                                 location, {})"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    def _upload_data(self, context, image_id, data):"},{"line_number":659,"context_line":"        self._client.call(context, 2, \u0027upload\u0027, image_id, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0948c586","line":656,"in_reply_to":"9abb7d3a_5f71c943","updated":"2016-06-06 17:06:02.000000000","message":"Good point. Done!","commit_id":"8e6809b8f2fac0e192b6cf800515533897663a79"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8ebfe4cec812d8cf0683ce27c39d350a9fe1eeb7","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                sent_service_image_meta[\u0027container_format\u0027] \u003d \u0027bare\u0027"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        location \u003d sent_service_image_meta.pop(\u0027location\u0027, None)"},{"line_number":675,"context_line":"        recv_service_image_meta \u003d self._client.call("},{"line_number":676,"context_line":"            context, 2, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Sending image location in a separate request."}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_3fdb25ef","line":675,"range":{"start_line":675,"start_character":8,"end_line":675,"end_character":31},"updated":"2016-06-03 11:37:11.000000000","message":"can we just call this \"image\" instead. And then save off image_id \u003d image[\u0027id\u0027] for the follow on calls.","commit_id":"8e6809b8f2fac0e192b6cf800515533897663a79"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"983d7dab5a27b63879912ad777f9e527c696d369","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                sent_service_image_meta[\u0027container_format\u0027] \u003d \u0027bare\u0027"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        location \u003d sent_service_image_meta.pop(\u0027location\u0027, None)"},{"line_number":675,"context_line":"        recv_service_image_meta \u003d self._client.call("},{"line_number":676,"context_line":"            context, 2, \u0027create\u0027, **sent_service_image_meta)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"        # Sending image location in a separate request."}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6f422940","line":675,"range":{"start_line":675,"start_character":8,"end_line":675,"end_character":31},"in_reply_to":"9abb7d3a_3fdb25ef","updated":"2016-06-06 17:06:02.000000000","message":"Done","commit_id":"8e6809b8f2fac0e192b6cf800515533897663a79"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f48eaa2d4704cc721736d236b216a063de8a0ced","unresolved":false,"context_lines":[{"line_number":665,"context_line":"                   force_activate\u003dFalse):"},{"line_number":666,"context_line":"        # Glance v1 allows image activation without setting disk and"},{"line_number":667,"context_line":"        # container formats, v2 doesn\u0027t. It leads to the dirtiest workaround"},{"line_number":668,"context_line":"        # where we have to hardcode this parameters."},{"line_number":669,"context_line":"        if force_activate:"},{"line_number":670,"context_line":"            data \u003d \u0027\u0027"},{"line_number":671,"context_line":"            if \u0027disk_format\u0027 not in sent_service_image_meta:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_70acc535","line":668,"updated":"2016-06-06 19:25:24.000000000","message":"I appreciate this comment :)","commit_id":"4a39b8b530b32337749a9e2d2a438b7b2f3430d8"}]}