)]}'
{"nova/tests/unit/virt/libvirt/test_imagecache.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"ecf947f323e909f9b62d15383c38d7dcb7fcecae","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        mock_getmtime.side_effect \u003d lambda path: time.time() - 1000000"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        mock_exist.side_effect \u003d \\"},{"line_number":874,"context_line":"            lambda path: os.path.dirname(path) \u003d\u003d base_dir and \\"},{"line_number":875,"context_line":"                         os.path.basename(path) in expected_exist"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_306d5405","line":873,"range":{"start_line":873,"start_character":33,"end_line":873,"end_character":34},"updated":"2016-05-27 13:51:35.000000000","message":"Should not we use () instead?","commit_id":"f124b85fa4ce2941841a5999979de9d59388ad5c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6d16f80cec74f9557017af0b5e56cdd14c2f5b86","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        mock_getmtime.side_effect \u003d lambda path: time.time() - 1000000"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        mock_exist.side_effect \u003d \\"},{"line_number":874,"context_line":"            lambda path: os.path.dirname(path) \u003d\u003d base_dir and \\"},{"line_number":875,"context_line":"                         os.path.basename(path) in expected_exist"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_8d098634","line":873,"range":{"start_line":873,"start_character":33,"end_line":873,"end_character":34},"in_reply_to":"9abb7d3a_306d5405","updated":"2016-05-27 14:51:26.000000000","message":"pep8 didn\u0027t complain, so I feel like I have a choice here.\n\nAppreciate you\u0027ve chosen not to -1 for a nit (thanks!), but regardless I\u0027m interested to know if we have a style policy on this. I think I\u0027ve heard this before, so perhaps there is (or at least was) a policy on this. I personally use both () and \\ in different circumstances, and here I obviously decided \\ was easier to read.","commit_id":"f124b85fa4ce2941841a5999979de9d59388ad5c"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"1463f7ab2b670b122b8b9faaee765f09de17855b","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        mock_getmtime.side_effect \u003d lambda path: time.time() - 1000000"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        mock_exist.side_effect \u003d \\"},{"line_number":874,"context_line":"            lambda path: os.path.dirname(path) \u003d\u003d base_dir and \\"},{"line_number":875,"context_line":"                         os.path.basename(path) in expected_exist"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_e8fe056a","line":873,"range":{"start_line":873,"start_character":33,"end_line":873,"end_character":34},"in_reply_to":"9abb7d3a_8d098634","updated":"2016-05-30 11:39:29.000000000","message":"well, i\u0027m not pepFT to set -1 for that :)\n\nAs i understand, it is recommended in OS but not required in Nova (probably because there are a lot of legacy code in Nova which does not satisfy the restriction).\n\nsee the 2nd point on http://docs.openstack.org/developer/hacking/#general","commit_id":"f124b85fa4ce2941841a5999979de9d59388ad5c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"43fc94b5941d26e6d38a7c4c890975c3735ab47d","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        mock_getmtime.side_effect \u003d lambda path: time.time() - 1000000"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        mock_exist.side_effect \u003d \\"},{"line_number":874,"context_line":"            lambda path: os.path.dirname(path) \u003d\u003d base_dir and \\"},{"line_number":875,"context_line":"                         os.path.basename(path) in expected_exist"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_03cb431f","line":873,"range":{"start_line":873,"start_character":33,"end_line":873,"end_character":34},"in_reply_to":"9abb7d3a_cda96a7d","updated":"2016-05-31 10:00:55.000000000","message":"I kinda like private functions, like removeFile, when the methods get this long, but its all personal preference.","commit_id":"f124b85fa4ce2941841a5999979de9d59388ad5c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"894639006f67c7b39561a4990db17c8422623b34","unresolved":false,"context_lines":[{"line_number":870,"context_line":""},{"line_number":871,"context_line":"        mock_getmtime.side_effect \u003d lambda path: time.time() - 1000000"},{"line_number":872,"context_line":""},{"line_number":873,"context_line":"        mock_exist.side_effect \u003d \\"},{"line_number":874,"context_line":"            lambda path: os.path.dirname(path) \u003d\u003d base_dir and \\"},{"line_number":875,"context_line":"                         os.path.basename(path) in expected_exist"},{"line_number":876,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_cda96a7d","line":873,"range":{"start_line":873,"start_character":33,"end_line":873,"end_character":34},"in_reply_to":"9abb7d3a_e8fe056a","updated":"2016-05-31 08:38:40.000000000","message":"Thanks for the reference!","commit_id":"f124b85fa4ce2941841a5999979de9d59388ad5c"}]}