)]}'
{"nova/virt/libvirt/imagecache.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4c3396810ad09481db7ca2208305242cedc71356","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    manager considers the file to be in use if it matches an instance\u0027s"},{"line_number":51,"context_line":"    image_ref, kernel_id or ramdisk_id property."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    return hashlib.sha1(image_id.encode(\u0027utf-8\u0027)).hexdigest()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_info_filename(base_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_193674b4","line":53,"updated":"2016-06-02 15:24:48.000000000","message":"A test for this would be trivial right?","commit_id":"960b11ae045a92aff4acc2abb83345cdcc1ae99d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"1673308341ce820881c7713ee24f32e4d93b308c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    manager considers the file to be in use if it matches an instance\u0027s"},{"line_number":51,"context_line":"    image_ref, kernel_id or ramdisk_id property."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    return hashlib.sha1(image_id.encode(\u0027utf-8\u0027)).hexdigest()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_info_filename(base_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_cb53716b","line":53,"in_reply_to":"9abb7d3a_193674b4","updated":"2016-06-02 16:14:02.000000000","message":"What would you want to test? Just that it doesn\u0027t raise an exception? I don\u0027t think you could test its behaviour without implementing the function in the test. Maybe a pre-calculated in and out as a canary against anything weird happening in the hashlib library? Is that useful?\n\nYeah, almost certainly trivial. Which tests do you think are necessary?","commit_id":"960b11ae045a92aff4acc2abb83345cdcc1ae99d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6375c18946faf8de4b35b8666f12bb8920b171d9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    manager considers the file to be in use if it matches an instance\u0027s"},{"line_number":51,"context_line":"    image_ref, kernel_id or ramdisk_id property."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    return hashlib.sha1(image_id.encode(\u0027utf-8\u0027)).hexdigest()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"def get_info_filename(base_path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_ab854dae","line":53,"in_reply_to":"9abb7d3a_cb53716b","updated":"2016-06-02 16:15:46.000000000","message":"I think making sure hashlib gets a bytes() and not a str() is worthwhile.","commit_id":"960b11ae045a92aff4acc2abb83345cdcc1ae99d"}]}