)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"32aaa6f0ea445da0f5c07146e9614152d798a6e1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* None"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_23a187aa","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":6},"updated":"2016-06-06 02:52:32.000000000","message":"I think all these options related to libvirt/virt_type config option?","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"8873328c8454cb1cd056c0403a415fff69173f5c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* None"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3dde8d6d","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":6},"in_reply_to":"7aa08908_23a187aa","updated":"2016-06-06 22:55:41.000000000","message":"So, you meant these options are used only when the virt_type option is set to xen?\nIf that is the case all the options in xenserver.py are related to virt_type config option right? \nI am double checking this because the xenapi_agent_opts which is already merged haven\u0027t included virt_type in related options.","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"f8e5421eb1dd642347a1c0807f3c48fc08b6862f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* None"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_24a2c6fd","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":6},"in_reply_to":"7aa08908_3dde8d6d","updated":"2016-06-07 15:30:29.000000000","message":"Done","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"a9712970675481fe9a1b986341059f35f4a7ad34","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* None"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_69ba1325","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":6},"in_reply_to":"7aa08908_3dde8d6d","updated":"2016-06-07 01:16:32.000000000","message":"yes, I think we need to leave virt_type\u003dxen here as a related option for all the options in this file.\nif xenapi_agent_opts have the same issue, I think you can push another patch","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"32aaa6f0ea445da0f5c07146e9614152d798a6e1","unresolved":false,"context_lines":[{"line_number":212,"context_line":"* ``nova-compute``"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Possible values:"},{"line_number":215,"context_line":"* Any positive integer"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Related options:"},{"line_number":218,"context_line":"* None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e39f7f5d","line":215,"range":{"start_line":215,"start_character":2,"end_line":215,"end_character":22},"updated":"2016-06-06 02:52:32.000000000","message":"Need to list the default value here.","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"8873328c8454cb1cd056c0403a415fff69173f5c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"* ``nova-compute``"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"Possible values:"},{"line_number":215,"context_line":"* Any positive integer"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Related options:"},{"line_number":218,"context_line":"* None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_fd0fe5de","line":215,"range":{"start_line":215,"start_character":2,"end_line":215,"end_character":22},"in_reply_to":"7aa08908_e39f7f5d","updated":"2016-06-06 22:55:41.000000000","message":"Done","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"32aaa6f0ea445da0f5c07146e9614152d798a6e1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"* Any positive integer"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Related options:"},{"line_number":218,"context_line":"* None"},{"line_number":219,"context_line":" \"\"\"),"},{"line_number":220,"context_line":"]"},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_23886722","line":218,"range":{"start_line":218,"start_character":2,"end_line":218,"end_character":6},"updated":"2016-06-06 02:52:32.000000000","message":"depend on libvirt/virt_type config options.","commit_id":"109e5e2503c54557041fdbdd240079a7d75b6486"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"71cd16d78cb05addeb2e9b50645c2f49ea37ff7a","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer(10 is the default value)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* ``virt_type``"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f8ae88e4","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":15},"updated":"2016-06-08 01:25:49.000000000","message":"I think we need more details in this part, please look at the page of this bp, section Quality view and see the positive example [1]\n\nSo, for this related option, IMO we need to add some more words like below:\n\nRelated options:\n* Section ``[libvirt]`` option ``virt_type`` must be set to \u0027xen\u0027 to make this option valid.\n\n[1]. http://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/centralize-config-options.html#quality-view","commit_id":"a42fc02a7b78555155041422cce138b6f0fbe7ed"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"d4c8869f5fe5a0bfcebbb3cbe53f144348c7e96b","unresolved":false,"context_lines":[{"line_number":196,"context_line":"* Any positive integer(10 is the default value)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Related options:"},{"line_number":199,"context_line":"* ``virt_type``"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_cdeab7da","line":199,"range":{"start_line":199,"start_character":2,"end_line":199,"end_character":15},"in_reply_to":"7aa08908_f8ae88e4","updated":"2016-06-08 15:59:51.000000000","message":"Hieu, thanks for the review. I thought about it and if i had to add the line then it should be added to each option in the entire file. Felt like the line will be redundant. So, I left it like that which is quite obvious that virt_type will be xen here. May be I am wrong it looks obvious to me but not for everybody. As you suggested i\u0027ll modify it to be more specific.","commit_id":"a42fc02a7b78555155041422cce138b6f0fbe7ed"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3bf110dabb630b5b0377a960e01c4e0d5bd1541b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"xenserver_group \u003d cfg.OptGroup(\u0027xenserver\u0027,"},{"line_number":20,"context_line":"                               title\u003d\u0027Xenserver Options\u0027,"},{"line_number":21,"context_line":"                               help\u003d\"\"\""},{"line_number":22,"context_line":"Section ``[libvirt]`` option ``virt_type`` must be set to \u0027xen\u0027"},{"line_number":23,"context_line":"to make all the options in this group to be valid."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_e4196c89","line":22,"updated":"2016-07-01 10:27:15.000000000","message":"This is incorrect.\nXenServer options are used when the compute_driver is set to use XenServer.\n\nThe XenServer options have nothing to do with libvirt.","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":19,"context_line":"xenserver_group \u003d cfg.OptGroup(\u0027xenserver\u0027,"},{"line_number":20,"context_line":"                               title\u003d\u0027Xenserver Options\u0027,"},{"line_number":21,"context_line":"                               help\u003d\"\"\""},{"line_number":22,"context_line":"Section ``[libvirt]`` option ``virt_type`` must be set to \u0027xen\u0027"},{"line_number":23,"context_line":"to make all the options in this group to be valid."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_41002036","line":22,"in_reply_to":"3aaa91ec_e4196c89","updated":"2016-07-01 15:50:20.000000000","message":"You are right. I got it wrong. Thanks","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f25ca14341d028068b110e4cf44892d110d561d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"xenserver_group \u003d cfg.OptGroup(\u0027xenserver\u0027,"},{"line_number":20,"context_line":"                               title\u003d\u0027Xenserver Options\u0027,"},{"line_number":21,"context_line":"                               help\u003d\"\"\""},{"line_number":22,"context_line":"Section ``[libvirt]`` option ``virt_type`` must be set to \u0027xen\u0027"},{"line_number":23,"context_line":"to make all the options in this group to be valid."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"xenapi_agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_443e80b8","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":50},"updated":"2016-07-01 10:13:43.000000000","message":"I\u0027d like a description of what this section does in general (presumably configure XenSever?)","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":19,"context_line":"xenserver_group \u003d cfg.OptGroup(\u0027xenserver\u0027,"},{"line_number":20,"context_line":"                               title\u003d\u0027Xenserver Options\u0027,"},{"line_number":21,"context_line":"                               help\u003d\"\"\""},{"line_number":22,"context_line":"Section ``[libvirt]`` option ``virt_type`` must be set to \u0027xen\u0027"},{"line_number":23,"context_line":"to make all the options in this group to be valid."},{"line_number":24,"context_line":"\"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"xenapi_agent_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_21fd143c","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":50},"in_reply_to":"3aaa91ec_443e80b8","updated":"2016-07-01 15:50:20.000000000","message":"Done","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f25ca14341d028068b110e4cf44892d110d561d","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"   * Any positive integer(10 is the default value)"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_a4492462","line":199,"range":{"start_line":199,"start_character":25,"end_line":199,"end_character":50},"updated":"2016-07-01 10:13:43.000000000","message":"drop this (we can see the default on line 193, and it will be set in \u0027nova.conf\u0027)","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"   * Any positive integer(10 is the default value)"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_212074b0","line":199,"range":{"start_line":199,"start_character":25,"end_line":199,"end_character":50},"in_reply_to":"3aaa91ec_1f6cc1ce","updated":"2016-07-01 15:50:20.000000000","message":"true.","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"   * Any positive integer(10 is the default value)"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_0139f8f2","line":199,"range":{"start_line":199,"start_character":25,"end_line":199,"end_character":50},"in_reply_to":"3aaa91ec_a4492462","updated":"2016-07-01 15:50:20.000000000","message":"I had got comments to add default value in the possible values section, so added here as well.","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3bf110dabb630b5b0377a960e01c4e0d5bd1541b","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Possible values:"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"   * Any positive integer(10 is the default value)"},{"line_number":200,"context_line":" \"\"\"),"},{"line_number":201,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":202,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_1f6cc1ce","line":199,"range":{"start_line":199,"start_character":25,"end_line":199,"end_character":50},"in_reply_to":"3aaa91ec_a4492462","updated":"2016-07-01 10:27:15.000000000","message":"I was under the impression that this was requested?\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-06-22.log.html#t2016-06-22T13:01:49","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3bf110dabb630b5b0377a960e01c4e0d5bd1541b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Used only if compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"In nova, multiple XenAPI requests can happen at a time."},{"line_number":208,"context_line":"Configuring this option will serialize access to the XenAPI session,"},{"line_number":209,"context_line":"which allows you to make concurrent XenAPI connections."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_fff3b506","line":208,"updated":"2016-07-01 10:27:15.000000000","message":"parallelize - not serialize :)","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Used only if compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"In nova, multiple XenAPI requests can happen at a time."},{"line_number":208,"context_line":"Configuring this option will serialize access to the XenAPI session,"},{"line_number":209,"context_line":"which allows you to make concurrent XenAPI connections."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_0110d858","line":208,"in_reply_to":"3aaa91ec_fff3b506","updated":"2016-07-01 15:50:20.000000000","message":"Done","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f25ca14341d028068b110e4cf44892d110d561d","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"   * Any positive integer(5 is the default value)"},{"line_number":214,"context_line":" \"\"\"),"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_4465e0de","line":213,"range":{"start_line":213,"start_character":25,"end_line":213,"end_character":49},"updated":"2016-07-01 10:13:43.000000000","message":"Drop this","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6f25ca14341d028068b110e4cf44892d110d561d","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"   * Any positive integer(5 is the default value)"},{"line_number":214,"context_line":" \"\"\"),"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_c49f10b2","line":213,"range":{"start_line":213,"start_character":5,"end_line":213,"end_character":25},"updated":"2016-07-01 10:13:43.000000000","message":"what do these ints correspond to (seconds, right?)","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"29d00c018922f0000297ecc04f1427718e638276","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Possible values:"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"   * Any positive integer(5 is the default value)"},{"line_number":214,"context_line":" \"\"\"),"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_73e24f31","line":213,"range":{"start_line":213,"start_character":5,"end_line":213,"end_character":25},"in_reply_to":"3aaa91ec_c49f10b2","updated":"2016-07-01 15:50:20.000000000","message":"not seconds, it represents the number of connections that can be made.","commit_id":"50a0979fc84b442ccf8852a9659f955c47c50e2b"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c6f4a73bd0ea5bff2924163ce8454b05176e6eef","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Possible values:"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"   * Any positive integer(10 is the default value)"},{"line_number":207,"context_line":" \"\"\"),"},{"line_number":208,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":209,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_73e47dab","line":206,"range":{"start_line":206,"start_character":5,"end_line":206,"end_character":50},"updated":"2016-07-20 13:44:19.000000000","message":"Add min \u003d 0 to IntOpt :)","commit_id":"239c3c86b61fc87aa50837a19cca8b2ff4949006"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c6f4a73bd0ea5bff2924163ce8454b05176e6eef","unresolved":false,"context_lines":[{"line_number":210,"context_line":"               help\u003d\"\"\""},{"line_number":211,"context_line":"Maximum number of concurrent XenAPI connections."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"In nova, multiple XenAPI requests can happen at a time."},{"line_number":214,"context_line":"Configuring this option will parallelize access to the XenAPI"},{"line_number":215,"context_line":"session, which allows you to make concurrent XenAPI connections."},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Possible values:"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_e6c8a9aa","line":215,"range":{"start_line":213,"start_character":0,"end_line":215,"end_character":64},"updated":"2016-07-20 13:44:19.000000000","message":"Hmm a bit of tautology here. Maybe sth short like below is enough?\n\nValue provided in this option denotes the number of connections that can concurrently be made to XenAPI.","commit_id":"239c3c86b61fc87aa50837a19cca8b2ff4949006"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c6f4a73bd0ea5bff2924163ce8454b05176e6eef","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Possible values:"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"   * Any positive integer which represents the number of concurrent"},{"line_number":220,"context_line":"     XenAPI connections that can be made(5 is the default value)."},{"line_number":221,"context_line":" \"\"\"),"},{"line_number":222,"context_line":"]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_93f5b158","line":220,"range":{"start_line":219,"start_character":5,"end_line":220,"end_character":65},"updated":"2016-07-20 13:44:19.000000000","message":"Add min \u003d 0 to IntOpt,\nmight be OK to completely drop this section afterwards, as its description is already included in help text.","commit_id":"239c3c86b61fc87aa50837a19cca8b2ff4949006"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"060eb9ca3796f6ef7996573fe3757870dd7a38e0","unresolved":false,"context_lines":[{"line_number":207,"context_line":"               min\u003d0,"},{"line_number":208,"context_line":"               help\u003d\"\"\""},{"line_number":209,"context_line":"Maximum number of concurrent XenAPI connections."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"In nova, multiple XenAPI requests can happen at a time."},{"line_number":212,"context_line":"Configuring this option will parallelize access to the XenAPI"},{"line_number":213,"context_line":"session, which allows you to make concurrent XenAPI connections."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_6d22eda4","line":210,"updated":"2016-07-26 03:56:53.000000000","message":"I feel the min should be increased to 1 or 2 due to this part of code https://github.com/openstack/nova/blob/5d15918076eef173a3d140f968260aeb19d0614e/nova/virt/xenapi/client/session.py#L133. Can yo please verify it ?","commit_id":"3041906e5c0939580f6a474079273730e74cb898"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"4801f2b39e716803a07b51e212fd87581c207d69","unresolved":false,"context_lines":[{"line_number":207,"context_line":"               min\u003d0,"},{"line_number":208,"context_line":"               help\u003d\"\"\""},{"line_number":209,"context_line":"Maximum number of concurrent XenAPI connections."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"In nova, multiple XenAPI requests can happen at a time."},{"line_number":212,"context_line":"Configuring this option will parallelize access to the XenAPI"},{"line_number":213,"context_line":"session, which allows you to make concurrent XenAPI connections."}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_e127e560","line":210,"in_reply_to":"dada55a8_6d22eda4","updated":"2016-07-26 16:21:29.000000000","message":"True, thanks for pointing out.","commit_id":"3041906e5c0939580f6a474079273730e74cb898"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"d4f7d652cbc55bb1455e7843db6978402714be03","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               the result in this time period, the operation is considered to"},{"line_number":60,"context_line":"               have timed out."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"               Services which consume this:"},{"line_number":63,"context_line":"               * ``nova-compute``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"               Possible values:"},{"line_number":66,"context_line":"               * Any positive integer"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"               Related options:"},{"line_number":69,"context_line":"               * ``agent_version_timeout``"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_01656b44","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":37},"updated":"2016-07-27 22:06:03.000000000","message":"Shouldn\u0027t we drop these sections in this patch or you planning to raise a followup patch for that?","commit_id":"d8b3241be1e7c0fc6740a7668646c396c98d23a8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2bd1dcc01fd4325bb680a2f949914069cebd6f84","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               the result in this time period, the operation is considered to"},{"line_number":60,"context_line":"               have timed out."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"               Services which consume this:"},{"line_number":63,"context_line":"               * ``nova-compute``"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"               Possible values:"},{"line_number":66,"context_line":"               * Any positive integer"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"               Related options:"},{"line_number":69,"context_line":"               * ``agent_version_timeout``"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_041739a4","line":66,"range":{"start_line":62,"start_character":0,"end_line":66,"end_character":37},"in_reply_to":"bacf61ea_01656b44","updated":"2016-07-27 22:31:20.000000000","message":"There is already a patch for these fixes.","commit_id":"d8b3241be1e7c0fc6740a7668646c396c98d23a8"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"d4f7d652cbc55bb1455e7843db6978402714be03","unresolved":false,"context_lines":[{"line_number":200,"context_line":"               default\u003d10,"},{"line_number":201,"context_line":"               min\u003d0,"},{"line_number":202,"context_line":"               help\u003d\"\"\""},{"line_number":203,"context_line":"Timeout in seconds for XenAPI login."},{"line_number":204,"context_line":"\"\"\"),"},{"line_number":205,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":206,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_a189ffcc","line":203,"updated":"2016-07-27 22:06:03.000000000","message":"Maybe little note on what happens on timeout? If not then this can fit in 1 line.","commit_id":"d8b3241be1e7c0fc6740a7668646c396c98d23a8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2bd1dcc01fd4325bb680a2f949914069cebd6f84","unresolved":false,"context_lines":[{"line_number":200,"context_line":"               default\u003d10,"},{"line_number":201,"context_line":"               min\u003d0,"},{"line_number":202,"context_line":"               help\u003d\"\"\""},{"line_number":203,"context_line":"Timeout in seconds for XenAPI login."},{"line_number":204,"context_line":"\"\"\"),"},{"line_number":205,"context_line":"    cfg.IntOpt(\u0027connection_concurrent\u0027,"},{"line_number":206,"context_line":"               default\u003d5,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_441131ac","line":203,"in_reply_to":"bacf61ea_a189ffcc","updated":"2016-07-27 22:31:20.000000000","message":"Done","commit_id":"d8b3241be1e7c0fc6740a7668646c396c98d23a8"}]}