)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fe0cfda1d6406cbf90384752955d5894b67262ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove junk file when ftp transfer failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FzA0%3D","line":9,"updated":"2013-06-10 14:04:26.000000000","message":"Extra space before the comma. Also, I think you want to say \"the image transfer to the IVM host may fail...\"","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"b121504914b777c8107406da42796b4fc44197e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove junk file when ftp transfer failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FwD4%3D","line":9,"in_reply_to":"AAAAPX%2F%2FzA0%3D","updated":"2013-06-11 12:22:16.000000000","message":"Done","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fe0cfda1d6406cbf90384752955d5894b67262ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove junk file when ftp transfer failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FzAc%3D","line":10,"updated":"2013-06-10 14:04:26.000000000","message":"Extra space before the comma and missing space afterwards.","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"b121504914b777c8107406da42796b4fc44197e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove junk file when ftp transfer failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FwD0%3D","line":10,"in_reply_to":"AAAAPX%2F%2FzAc%3D","updated":"2013-06-11 12:22:16.000000000","message":"Done","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fe0cfda1d6406cbf90384752955d5894b67262ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1188884"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FzAM%3D","line":12,"updated":"2013-06-10 14:04:26.000000000","message":"Please fix all the spaces before and after your punctuation.","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"b121504914b777c8107406da42796b4fc44197e3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"During spawn with powervm driver , transfer image file to IVM host"},{"line_number":10,"context_line":"may fail in some conditions ,eg. IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space . It leaves the junk file in IVM host , will disturb next"},{"line_number":12,"context_line":"spawn after resolving environment issue ,need clean it ."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1188884"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FwDw%3D","line":12,"in_reply_to":"AAAAPX%2F%2FzAM%3D","updated":"2013-06-11 12:22:16.000000000","message":"Done","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"2d3d7e7ca7841625cf3f39d89437919712b13f03","unresolved":false,"context_lines":[{"line_number":9,"context_line":"During spawn with powervm driver,the image transfer to the IVM host"},{"line_number":10,"context_line":"may fail in some conditions,eg.IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space.It leaves the junk file in IVM host,will disturb next spawn"},{"line_number":12,"context_line":"after resolving environment issue,need clean it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1188884"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPX%2F%2FvR4%3D","line":12,"updated":"2013-06-11 16:54:53.000000000","message":"Need a space after each period and comma.\n\ns/,/, /\ns/./. /","commit_id":"5e49785245f1f12b2bb403422dd74239f3c9d5a1"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"1861ec4c81a9e5f967a5b41f22d85635a84906ee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"During spawn with powervm driver,the image transfer to the IVM host"},{"line_number":10,"context_line":"may fail in some conditions,eg.IVM host doesn\u0027t have enough disk"},{"line_number":11,"context_line":"space.It leaves the junk file in IVM host,will disturb next spawn"},{"line_number":12,"context_line":"after resolving environment issue,need clean it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fixes bug #1188884"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPX%2F%2Ft6c%3D","line":12,"in_reply_to":"AAAAPX%2F%2FvR4%3D","updated":"2013-06-12 02:07:43.000000000","message":"Done","commit_id":"5e49785245f1f12b2bb403422dd74239f3c9d5a1"}],"nova/tests/virt/powervm/test_powervm.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"2d3d7e7ca7841625cf3f39d89437919712b13f03","unresolved":false,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        self.assertRaises(exception.PowerVMFTPTransferFailed,"},{"line_number":792,"context_line":"                          self.powervm_adapter._copy_image_file,"},{"line_number":793,"context_line":"                          file_path, remote_path)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    def test_copy_image_file_wrong_checksum(self):"},{"line_number":796,"context_line":"        file_path \u003d os.tempnam(\u0027/tmp\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FvR0%3D","line":793,"updated":"2013-06-11 16:54:53.000000000","message":"You test that it raises the exception, but you never test that the file gets deleted, which is the code you added.","commit_id":"5e49785245f1f12b2bb403422dd74239f3c9d5a1"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"1861ec4c81a9e5f967a5b41f22d85635a84906ee","unresolved":false,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        self.assertRaises(exception.PowerVMFTPTransferFailed,"},{"line_number":792,"context_line":"                          self.powervm_adapter._copy_image_file,"},{"line_number":793,"context_line":"                          file_path, remote_path)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    def test_copy_image_file_wrong_checksum(self):"},{"line_number":796,"context_line":"        file_path \u003d os.tempnam(\u0027/tmp\u0027, \u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Ft5s%3D","line":793,"in_reply_to":"AAAAPX%2F%2FvR0%3D","updated":"2013-06-12 02:07:43.000000000","message":"line 787 shows command  \u0027rm\u0027  will be executed with expected parameters.  This is guaranteed by mox.","commit_id":"5e49785245f1f12b2bb403422dd74239f3c9d5a1"}],"nova/virt/powervm/blockdev.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fe0cfda1d6406cbf90384752955d5894b67262ee","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                # Copy file to IVM"},{"line_number":432,"context_line":"                common.ftp_put_command(self.connection_data, source_path,"},{"line_number":433,"context_line":"                                       remote_path)"},{"line_number":434,"context_line":"            except Exception:"},{"line_number":435,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":436,"context_line":"                    cmd \u003d \"/usr/bin/rm -f %s\" % final_path"},{"line_number":437,"context_line":"                    self.run_vios_command_as_root(cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FzAA%3D","line":434,"updated":"2013-06-10 14:04:26.000000000","message":"You already catch Exception and re-raise a single Exception in ftp_put_command(). Please catch that (and only that) here.","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"b121504914b777c8107406da42796b4fc44197e3","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                # Copy file to IVM"},{"line_number":432,"context_line":"                common.ftp_put_command(self.connection_data, source_path,"},{"line_number":433,"context_line":"                                       remote_path)"},{"line_number":434,"context_line":"            except Exception:"},{"line_number":435,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":436,"context_line":"                    cmd \u003d \"/usr/bin/rm -f %s\" % final_path"},{"line_number":437,"context_line":"                    self.run_vios_command_as_root(cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FwD8%3D","line":434,"in_reply_to":"AAAAPX%2F%2FzAA%3D","updated":"2013-06-11 12:22:16.000000000","message":"Done","commit_id":"8d697096a377a6b1fe46d5e1ec773650fb4f603d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b97639222571a2c6b519cd34274dee65d98c25a8","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                       remote_path)"},{"line_number":434,"context_line":"            except exception.PowerVMFTPTransferFailed:"},{"line_number":435,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":436,"context_line":"                    cmd \u003d \"/usr/bin/rm -f %s\" % final_path"},{"line_number":437,"context_line":"                    self.run_vios_command_as_root(cmd)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"            # Verify image file checksums match"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FwlI%3D","line":436,"updated":"2013-06-21 21:46:36.000000000","message":"Should this be remote_path instead of final_path?","commit_id":"84b41d944a841bd21cd72d57dd94ccf4810b6433"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d967aa56595806befa8dbf0e67a81aea7d0b1a59","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                       remote_path)"},{"line_number":434,"context_line":"            except exception.PowerVMFTPTransferFailed:"},{"line_number":435,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":436,"context_line":"                    cmd \u003d \"/usr/bin/rm -f %s\" % final_path"},{"line_number":437,"context_line":"                    self.run_vios_command_as_root(cmd)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"            # Verify image file checksums match"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FwB4%3D","line":436,"in_reply_to":"AAAAPn%2F%2FwNk%3D","updated":"2013-06-22 12:44:25.000000000","message":"OK, the ftp_put_command was throwing me off, that takes a source path to a file and a remote path to a directory, so checking ls and doing rm on final_path is right since that\u0027s to the actual file.  I think the \u0027remote_path\u0027 argument in this method should be renamed to \u0027remote_dir\u0027 or the method docstring needs to be cleaned up because it\u0027s confusing. I shouldn\u0027t have to look at what calls this method to understand how it should word, the docstring and method names should tell me that, but that\u0027s for another patch.","commit_id":"84b41d944a841bd21cd72d57dd94ccf4810b6433"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"edd64cdf4f74dffa6f13e28a813576c1506e6d2f","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                       remote_path)"},{"line_number":434,"context_line":"            except exception.PowerVMFTPTransferFailed:"},{"line_number":435,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":436,"context_line":"                    cmd \u003d \"/usr/bin/rm -f %s\" % final_path"},{"line_number":437,"context_line":"                    self.run_vios_command_as_root(cmd)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"            # Verify image file checksums match"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FwNk%3D","line":436,"in_reply_to":"AAAAPn%2F%2FwlI%3D","updated":"2013-06-22 04:42:38.000000000","message":"remote_path is  the value of CONF.powervm_img_remote_path , a directory ,not a file name . see line #175 ,  And  parameter decompress always is false , so final_path represents the file path on IVM.","commit_id":"84b41d944a841bd21cd72d57dd94ccf4810b6433"}]}