)]}'
{"nova/tests/unit/api/openstack/compute/test_floating_ip_pools.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e4c6ae4b890d26f0ebda540ab7b527e457f7c8cd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        view \u003d self.floating_ip_pools._translate_floating_ip_pools_view(pools)"},{"line_number":43,"context_line":"        self.assertIn(\u0027floating_ip_pools\u0027, view)"},{"line_number":44,"context_line":"        self.assertEqual(pools[0], view[\u0027floating_ip_pools\u0027][0][\u0027name\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(pools[1], view[\u0027floating_ip_pools\u0027][1][\u0027name\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_floating_ips_pools_list(self):"},{"line_number":48,"context_line":"        res_dict \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_bf7a1cef","line":45,"range":{"start_line":45,"start_character":69,"end_line":45,"end_character":72},"updated":"2016-06-08 07:52:28.000000000","message":"order change does not make difference here but m ok for consistency.","commit_id":"72199979815588b5e683d12b81eea71b1ff9e07a"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"f3bc998ae65a3a1920331ce3da576e233ac3ecff","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        view \u003d self.floating_ip_pools._translate_floating_ip_pools_view(pools)"},{"line_number":43,"context_line":"        self.assertIn(\u0027floating_ip_pools\u0027, view)"},{"line_number":44,"context_line":"        self.assertEqual(pools[0], view[\u0027floating_ip_pools\u0027][0][\u0027name\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(pools[1], view[\u0027floating_ip_pools\u0027][1][\u0027name\u0027])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_floating_ips_pools_list(self):"},{"line_number":48,"context_line":"        res_dict \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_24495c60","line":45,"range":{"start_line":45,"start_character":69,"end_line":45,"end_character":72},"in_reply_to":"7aa08908_bf7a1cef","updated":"2016-09-05 07:17:03.000000000","message":"Done","commit_id":"72199979815588b5e683d12b81eea71b1ff9e07a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ebb6e00a0d3703e8705f1afc4e3d9b3bae660d4a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        pools \u003d fake_get_floating_ip_pools(None, self.context)"},{"line_number":42,"context_line":"        view \u003d self.floating_ip_pools._translate_floating_ip_pools_view(pools)"},{"line_number":43,"context_line":"        self.assertIn(\u0027floating_ip_pools\u0027, view)"},{"line_number":44,"context_line":"        self.assertEqual(view[\u0027floating_ip_pools\u0027][0][\u0027name\u0027], pools[0])"},{"line_number":45,"context_line":"        self.assertEqual(view[\u0027floating_ip_pools\u0027][1][\u0027name\u0027], pools[1])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_floating_ips_pools_list(self):"},{"line_number":48,"context_line":"        res_dict \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_51e52ca6","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":72},"updated":"2016-11-22 05:57:04.000000000","message":"you could have leave these as it is.","commit_id":"83be61114dc6246aeec14dbcdd1a0f9fdb49dbd9"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"006def0f64646886bdbcb5b278ac05b5f9a414b5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        pools \u003d fake_get_floating_ip_pools(None, self.context)"},{"line_number":42,"context_line":"        view \u003d self.floating_ip_pools._translate_floating_ip_pools_view(pools)"},{"line_number":43,"context_line":"        self.assertIn(\u0027floating_ip_pools\u0027, view)"},{"line_number":44,"context_line":"        self.assertEqual(view[\u0027floating_ip_pools\u0027][0][\u0027name\u0027], pools[0])"},{"line_number":45,"context_line":"        self.assertEqual(view[\u0027floating_ip_pools\u0027][1][\u0027name\u0027], pools[1])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_floating_ips_pools_list(self):"},{"line_number":48,"context_line":"        res_dict \u003d self.controller.index(self.req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_775f7875","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":72},"in_reply_to":"7a77a97e_51e52ca6","updated":"2016-11-22 07:10:40.000000000","message":"Done","commit_id":"83be61114dc6246aeec14dbcdd1a0f9fdb49dbd9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"dafe62c07f0cdb560144b67399be16b767c99319","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(FloatingIpPoolTestV21, self).setUp()"},{"line_number":33,"context_line":"        self.stub_out(\u0027nova.network.api.API.get_floating_ip_pools\u0027,"},{"line_number":34,"context_line":"                      fake_get_floating_ip_pools)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_13f3cd74","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":67},"updated":"2016-12-13 06:48:30.000000000","message":"As mriedem is making neutron by deafult in tests[1], we should start mocking the both API not just nova-network one. or set flag if tests specific to nova-network only.\n\nBut this tests should run on both so how about mocking the \u0027get_floating_ip_pools\u0027 on nova.network.API() like  - https://review.openstack.org/#/c/396965/4/nova/tests/unit/compute/test_compute_mgr.py\n\n..1 https://review.openstack.org/#/q/topic:bp/use-neutron-by-default","commit_id":"5bfd02a9b585b91deac29e67dcf9c0f94f0cddf7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41374a31cbd1033c5ae5e1a91292fa13e0bb4b2a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(FloatingIpPoolTestV21, self).setUp()"},{"line_number":33,"context_line":"        self.stub_out(\u0027nova.network.api.API.get_floating_ip_pools\u0027,"},{"line_number":34,"context_line":"                      fake_get_floating_ip_pools)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_949d27be","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":67},"in_reply_to":"1a6eadb0_13f3cd74","updated":"2016-12-17 16:05:57.000000000","message":"Agree with gmann here, this API is implemented for both nova-network and neutron APIs in nova, so let\u0027s just use mock on a higher level.","commit_id":"5bfd02a9b585b91deac29e67dcf9c0f94f0cddf7"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d2bafe04dbe1ca808afe0c2657b210b262e76908","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(FloatingIpPoolTestV21, self).setUp()"},{"line_number":33,"context_line":"        self.stub_out(\u0027nova.network.api.API.get_floating_ip_pools\u0027,"},{"line_number":34,"context_line":"                      fake_get_floating_ip_pools)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_b3f47ef2","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":67},"in_reply_to":"1a6eadb0_13f3cd74","updated":"2017-01-04 06:20:21.000000000","message":"Done","commit_id":"5bfd02a9b585b91deac29e67dcf9c0f94f0cddf7"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d2bafe04dbe1ca808afe0c2657b210b262e76908","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(FloatingIpPoolTestV21, self).setUp()"},{"line_number":33,"context_line":"        self.stub_out(\u0027nova.network.api.API.get_floating_ip_pools\u0027,"},{"line_number":34,"context_line":"                      fake_get_floating_ip_pools)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_f3de066c","line":33,"range":{"start_line":33,"start_character":22,"end_line":33,"end_character":67},"in_reply_to":"1a6eadb0_949d27be","updated":"2017-01-04 06:20:21.000000000","message":"Done","commit_id":"5bfd02a9b585b91deac29e67dcf9c0f94f0cddf7"}]}