)]}'
{"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"309ea151e126b2680eee1141cd83d6295b3fb3f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\"Represents a running service on a host.\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    __tablename__ \u003d \u0027services\u0027"},{"line_number":48,"context_line":"    __table_args__ \u003d ()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":51,"context_line":"    host \u003d Column(String(255), nullable\u003dTrue)  # , ForeignKey(\u0027hosts.id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F0o0%3D","line":48,"updated":"2013-06-08 19:26:53.000000000","message":"What\u0027s the purpose of specifying __table_args__ with no args?  Just to be explicit?","commit_id":"57290516365e2d786c50b1e99ddbefa75997ad6d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"be5947d542602e72f511cd2a75831c91aa5835c5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \"\"\"Represents a running service on a host.\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    __tablename__ \u003d \u0027services\u0027"},{"line_number":48,"context_line":"    __table_args__ \u003d ()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":51,"context_line":"    host \u003d Column(String(255), nullable\u003dTrue)  # , ForeignKey(\u0027hosts.id\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F0ng%3D","line":48,"in_reply_to":"AAAAPX%2F%2F0o0%3D","updated":"2013-06-08 19:45:19.000000000","message":"Yes, it shows us that there is NO unique constraints and indexes in this table. And I think it is very important to know exactly that there is no (UC and indexes) .\nEspecially for feature index optimizations.\u003d)","commit_id":"57290516365e2d786c50b1e99ddbefa75997ad6d"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"309ea151e126b2680eee1141cd83d6295b3fb3f1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    __table_args__ \u003d ()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":51,"context_line":"    host \u003d Column(String(255), nullable\u003dTrue)  # , ForeignKey(\u0027hosts.id\u0027))"},{"line_number":52,"context_line":"    binary \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":53,"context_line":"    topic \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":54,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F0oc%3D","line":51,"updated":"2013-06-08 19:26:53.000000000","message":"nullable\u003dTrue is the default, right? I\u0027m assuming the goal is just to be explicit again, or will there eventually be a test to compare the model to the actual table generated via migrations?","commit_id":"57290516365e2d786c50b1e99ddbefa75997ad6d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"be5947d542602e72f511cd2a75831c91aa5835c5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    __table_args__ \u003d ()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":51,"context_line":"    host \u003d Column(String(255), nullable\u003dTrue)  # , ForeignKey(\u0027hosts.id\u0027))"},{"line_number":52,"context_line":"    binary \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":53,"context_line":"    topic \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":54,"context_line":"    report_count \u003d Column(Integer, nullable\u003dFalse, default\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F0nI%3D","line":51,"in_reply_to":"AAAAPX%2F%2F0oc%3D","updated":"2013-06-08 19:45:19.000000000","message":"Yes this will be at the finish, the same story was with db-improve-archiving https://review.openstack.org/#/c/28960/\n\nWe should have the test(s) that check(s) our model and generated schema via migrations. \n\nFor example I see here problem, I think that binary and topic should be specified always..","commit_id":"57290516365e2d786c50b1e99ddbefa75997ad6d"}]}