)]}'
{"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"7d79d16b06305887b7771068c49ef6f40296e1c0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FyWI%3D","line":80,"updated":"2013-06-10 17:55:35.000000000","message":"Why is it that hostname can be NULL, but the other hypervisor info cannot be?","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"86128e5c1cca7b85b8a263bca3a71c915f8e6a77","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fsig%3D","line":80,"in_reply_to":"AAAAPX%2F%2Fs1Y%3D","updated":"2013-06-12 16:20:45.000000000","message":"Fair \u0027nuf.","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8d986d78085e90d54363e87aff4497037312fac6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Ftbg%3D","line":80,"in_reply_to":"AAAAPX%2F%2Ft7c%3D","updated":"2013-06-12 08:41:37.000000000","message":"Chris, Devananda, \n\nI think that at this moment, most important thing is to get real situation in DB.\n\nWe will investigate all these columns, indexes and unique constraints after we sync all models and add tests that checks that all models are up-to-date. \n\nIn this patch I would prefer to avoid any db migrations.","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"04756b26754d33d983862394d770c54a55d82f09","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Ft7c%3D","line":80,"in_reply_to":"AAAAPX%2F%2Ft9g%3D","updated":"2013-06-12 01:49:43.000000000","message":"Well, we do return the hypervisor hostname in xenapi for sure.  But I\u0027m not sure about libvirt.","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"5ba46480043a8ce64c0a74600ebe5c2e31eb1841","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fs1Y%3D","line":80,"in_reply_to":"AAAAPX%2F%2Ftbg%3D","updated":"2013-06-12 14:43:09.000000000","message":"I agree with Boris.  The discussion, while interesting, is outside the scope of the patch. :)","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0db90d7dfac4a2fdb2a046acea3bafc15f7ce756","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fuko%3D","line":80,"in_reply_to":"AAAAPX%2F%2FyCI%3D","updated":"2013-06-11 20:18:23.000000000","message":"Ok.  I suspect that hypervisor_type and version can be NULL if we create the compute_node entry BEFORE we query the hypervisor for any of that info.   But... it\u0027s possible things changed such that we only create the compute_node entry after we query for this info.  One should really double check where compute_node_create is called and with what info.","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"f847bdac16b7e0ae29d28974c40165676f169d17","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Ft9g%3D","line":80,"in_reply_to":"AAAAPX%2F%2FyWI%3D","updated":"2013-06-12 01:13:24.000000000","message":"AIUI, most hypervisors do not set hypervisor_hostname -- I think baremetal is the only one, at least in Grizzly release.\n\nChris, we talked a while back about having nova-compute stop reporting (host, hypervisor_hostname) and move to just reporting (hypervisor_hostname). I imagine that may affect this field\u0027s nullability.","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"317a84755d5b0e6f8d35a6d57c8f1bef465cc3e7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    local_gb_used \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":78,"context_line":"    hypervisor_type \u003d Column(Text, nullable\u003dFalse)"},{"line_number":79,"context_line":"    hypervisor_version \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":80,"context_line":"    hypervisor_hostname \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Free Ram, amount of activity (resize, migration, boot, etc) and"},{"line_number":83,"context_line":"    # the number of running VM\u0027s are a good starting point for what\u0027s"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FyCI%3D","line":80,"in_reply_to":"AAAAPX%2F%2FyWI%3D","updated":"2013-06-10 19:43:57.000000000","message":"Why?, personally I don\u0027t know, this is the main reason, why I am making these patches. To get real situation in DB and then add tests that checks that models are up-to-date with DB state. And then fix all such strange places. \n\nBtw you could take a look at:\nnova/db/sqlalchemy/migrate_repo/versions/133_*:line 227\nto ensure that current state is such","commit_id":"d8adce2e4a20915298804cff72bd60453be640d4"}]}