)]}'
{"nova/tests/unit/test_configdrive2.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"afdedf01319b45b7063f9c121ec6650a3a67114d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        CONF.set_override(\u0027config_drive_format\u0027, \u0027vfat\u0027)"},{"line_number":68,"context_line":"        imagefile \u003d None"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            mock_mkfs.return_value \u003d None"},{"line_number":71,"context_line":"            mock_trycmd.return_value \u003d (None, None)"},{"line_number":72,"context_line":"            mock_execute.return_value \u003d None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"            with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":75,"context_line":"                (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_vfat_\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_a4fe6803","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":44},"updated":"2016-10-04 14:34:36.000000000","message":"nit: you can specify these as \u0027return_value\u0027 arguments to the decorator, iirc?","commit_id":"8a7930e52772449bdf2f52671a8499fb82e0dc1f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c6a6ec8eef82b48c5cc020ca1711c89d0280a74f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        imagefile \u003d None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            with mock.patch.object(utils, \u0027execute\u0027,"},{"line_number":46,"context_line":"                                   return_value\u003dNone) as mock_execute:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"                with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":49,"context_line":"                    (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_iso_\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_b686a663","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":70},"updated":"2016-12-12 15:23:23.000000000","message":"Can you move this to a decorator, please?\n\n    @mock.patch.object(utils, \u0027execute\u0027, return_value\u003dNone)\n    def test_create_configdrive_iso(self):\n        CONF...","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"880a35ff3b1e894794fa23353c132f3f677c0d66","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        imagefile \u003d None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            with mock.patch.object(utils, \u0027execute\u0027,"},{"line_number":46,"context_line":"                                   return_value\u003dNone) as mock_execute:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"                with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":49,"context_line":"                    (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_iso_\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_6355c0f8","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":70},"in_reply_to":"1a6eadb0_b686a663","updated":"2017-02-13 21:01:00.000000000","message":"+1","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"c543d6bbc23bfef02d9ccaf27ef76592889761dd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        imagefile \u003d None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            with mock.patch.object(utils, \u0027execute\u0027,"},{"line_number":46,"context_line":"                                   return_value\u003dNone) as mock_execute:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"                with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":49,"context_line":"                    (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_iso_\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_fcf77f88","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":70},"in_reply_to":"1a6eadb0_b686a663","updated":"2017-02-23 07:20:00.000000000","message":"Sorry, I were busy recently. I have done that. Thanks.","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"10eccb9f8fce12eed3a07a1f7b8e1398e8897c2e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        CONF.set_override(\u0027config_drive_format\u0027, \u0027vfat\u0027)"},{"line_number":68,"context_line":"        imagefile \u003d None"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            mock_mkfs.return_value \u003d None"},{"line_number":71,"context_line":"            mock_trycmd.return_value \u003d (None, None)"},{"line_number":72,"context_line":"            mock_execute.return_value \u003d None"},{"line_number":73,"context_line":"            with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":74,"context_line":"                (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_vfat_\u0027)"},{"line_number":75,"context_line":"                os.close(fd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_a41b75c9","line":72,"range":{"start_line":70,"start_character":1,"end_line":72,"end_character":44},"updated":"2016-12-09 05:43:12.000000000","message":"nit: return_value can be written in the decorator such as L.106:\n\n @mock.patch.object(configdrive, \u0027required_by\u0027, return_value\u003dFalse)","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c6a6ec8eef82b48c5cc020ca1711c89d0280a74f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        CONF.set_override(\u0027config_drive_format\u0027, \u0027vfat\u0027)"},{"line_number":68,"context_line":"        imagefile \u003d None"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            mock_mkfs.return_value \u003d None"},{"line_number":71,"context_line":"            mock_trycmd.return_value \u003d (None, None)"},{"line_number":72,"context_line":"            mock_execute.return_value \u003d None"},{"line_number":73,"context_line":"            with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":74,"context_line":"                (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_vfat_\u0027)"},{"line_number":75,"context_line":"                os.close(fd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_366536e1","line":72,"range":{"start_line":70,"start_character":1,"end_line":72,"end_character":44},"in_reply_to":"3a71b18c_a41b75c9","updated":"2016-12-12 15:23:23.000000000","message":"+1 - I wouldn\u0027t block on this, but seeing as I think the above should be reworked you should probably do this now","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"c543d6bbc23bfef02d9ccaf27ef76592889761dd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        CONF.set_override(\u0027config_drive_format\u0027, \u0027vfat\u0027)"},{"line_number":68,"context_line":"        imagefile \u003d None"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            mock_mkfs.return_value \u003d None"},{"line_number":71,"context_line":"            mock_trycmd.return_value \u003d (None, None)"},{"line_number":72,"context_line":"            mock_execute.return_value \u003d None"},{"line_number":73,"context_line":"            with configdrive.ConfigDriveBuilder(FakeInstanceMD()) as c:"},{"line_number":74,"context_line":"                (fd, imagefile) \u003d tempfile.mkstemp(prefix\u003d\u0027cd_vfat_\u0027)"},{"line_number":75,"context_line":"                os.close(fd)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_3cee77b4","line":72,"range":{"start_line":70,"start_character":1,"end_line":72,"end_character":44},"in_reply_to":"3a71b18c_a41b75c9","updated":"2017-02-23 07:20:00.000000000","message":"Tamura-san: I have done that. Thanks.","commit_id":"57da772df0fc8d33a7fdc6bb7ae0a80e6eba2aa8"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"91015470b15b176a6114557ed81e6951ab7bd6df","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                os.close(fd)"},{"line_number":49,"context_line":"                c.make_drive(imagefile)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            mock_execute.assert_called_once_with(\u0027genisoimage\u0027, \u0027-o\u0027,"},{"line_number":52,"context_line":"                mock.ANY, \u0027-ldots\u0027, \u0027-allow-lowercase\u0027,"},{"line_number":53,"context_line":"                \u0027-allow-multidot\u0027, \u0027-l\u0027, \u0027-publisher\u0027, mock.ANY,"},{"line_number":54,"context_line":"                \u0027-quiet\u0027, \u0027-J\u0027, \u0027-r\u0027, \u0027-V\u0027, \u0027config-2\u0027, mock.ANY,"},{"line_number":55,"context_line":"                attempts\u003d1, run_as_root\u003dFalse)"},{"line_number":56,"context_line":"        finally:"},{"line_number":57,"context_line":"            if imagefile:"},{"line_number":58,"context_line":"                fileutils.delete_if_exists(imagefile)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_9e4d649c","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":46},"updated":"2017-02-24 15:32:28.000000000","message":"nit: please indent this as you did at L75.","commit_id":"c8684da01ceb245802d96677e8a87b93c829eae2"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"e181f7034ab01e10eb2a28de658b1248bd02f573","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                os.close(fd)"},{"line_number":49,"context_line":"                c.make_drive(imagefile)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            mock_execute.assert_called_once_with(\u0027genisoimage\u0027, \u0027-o\u0027,"},{"line_number":52,"context_line":"                mock.ANY, \u0027-ldots\u0027, \u0027-allow-lowercase\u0027,"},{"line_number":53,"context_line":"                \u0027-allow-multidot\u0027, \u0027-l\u0027, \u0027-publisher\u0027, mock.ANY,"},{"line_number":54,"context_line":"                \u0027-quiet\u0027, \u0027-J\u0027, \u0027-r\u0027, \u0027-V\u0027, \u0027config-2\u0027, mock.ANY,"},{"line_number":55,"context_line":"                attempts\u003d1, run_as_root\u003dFalse)"},{"line_number":56,"context_line":"        finally:"},{"line_number":57,"context_line":"            if imagefile:"},{"line_number":58,"context_line":"                fileutils.delete_if_exists(imagefile)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_34b634f9","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":46},"in_reply_to":"da36d5c6_9e4d649c","updated":"2017-02-27 03:58:20.000000000","message":"Done. Thanks.","commit_id":"c8684da01ceb245802d96677e8a87b93c829eae2"}]}