)]}'
{"nova/network/security_group/quantum_driver.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4dd5b3830e07f9e3b76089d9fa62376feb3d8039","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            return True"},{"line_number":343,"context_line":"        elif \u0027port_security_enabled\u0027 not in port and has_ip:"},{"line_number":344,"context_line":"            return True"},{"line_number":345,"context_line":"        return False"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @wrap_check_security_groups_policy"},{"line_number":348,"context_line":"    def add_to_instance(self, context, instance, security_group_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F0Wk%3D","line":345,"updated":"2013-06-09 06:51:39.000000000","message":"Disclaimer: \nthe following code is not tested.\n\nport_security_check \u003d port.get(\u0027port_security_enabled\u0027, True)\nhas_ip \u003d port.get(\u0027fixed_ips\u0027)\nif has_ip:\n    # Returns True if port_security_enabled\u003d\u003dTrue or if it\u0027s missing\n    return port_security_check\nreturn False\n\nIf it works, it might save you an if check.\nI think style looks better too.\n\nBut we\u0027re spliting hairs, to take this as optional advice.","commit_id":"a2520fc212e510746e138310bb849aa89ba98138"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"9e5836c6a3a80afb1dd6d10ecb96f58d3e4d5e03","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            return True"},{"line_number":343,"context_line":"        elif \u0027port_security_enabled\u0027 not in port and has_ip:"},{"line_number":344,"context_line":"            return True"},{"line_number":345,"context_line":"        return False"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    @wrap_check_security_groups_policy"},{"line_number":348,"context_line":"    def add_to_instance(self, context, instance, security_group_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F0UE%3D","line":345,"in_reply_to":"AAAAPX%2F%2F0Wk%3D","updated":"2013-06-09 07:59:34.000000000","message":"i agree i like this better. Thanks","commit_id":"a2520fc212e510746e138310bb849aa89ba98138"}],"nova/tests/api/openstack/compute/contrib/test_quantum_security_groups.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"de0b0cf9a65b8ca3d2dac8c51c4c4a030fa72d52","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        port_security \u003d ret.get(\u0027port_security_enabled\u0027)"},{"line_number":663,"context_line":"        # port_security must be True if security groups are present"},{"line_number":664,"context_line":"        if port_security is False and ret[\u0027security_groups\u0027]:"},{"line_number":665,"context_line":"            raise exception.SecurityGroupCannotBeApplied()"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        if network[\u0027subnets\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FvuY%3D","line":664,"updated":"2013-06-11 14:34:11.000000000","message":"I think \"is False\" is too strict here.  It should be \"if not port_security\"","commit_id":"e9b1997ba49d6846f88acaf4f516261544bde96f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ae3f26a234bfeaa5843d15bca8b0c42b52f77c2b","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        port_security \u003d ret.get(\u0027port_security_enabled\u0027)"},{"line_number":663,"context_line":"        # port_security must be True if security groups are present"},{"line_number":664,"context_line":"        if port_security is False and ret[\u0027security_groups\u0027]:"},{"line_number":665,"context_line":"            raise exception.SecurityGroupCannotBeApplied()"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        if network[\u0027subnets\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FvI8%3D","line":664,"in_reply_to":"AAAAPX%2F%2FvuY%3D","updated":"2013-06-11 17:36:12.000000000","message":"This is actually correct. That said I\u0027ll change line 662 to be: \n\nport_security \u003d ret.get(\u0027port_security_enabled\u0027, True) which will make this code cleaner.","commit_id":"e9b1997ba49d6846f88acaf4f516261544bde96f"}]}