)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"abe1316267f658ffa7c5be4842b056703b81677b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Optimize the function to use the right parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function get_disk_size() has parameter but not use it,"},{"line_number":10,"context_line":"it is strange for us.As rbd backend use rbd_name as"},{"line_number":11,"context_line":"base image.So pass rbd_name to the get_disk_size() function."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I511780e2d72dbd491e28ad6e25a4d33e7e4c3bae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_ba52c4db","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":20},"updated":"2016-07-27 23:16:03.000000000","message":"This is not strange for me, because the docstring which you are trying to remove contain the reason clearly.","commit_id":"c60a42115151b96fb5c53147905a0fa06b4f7d39"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"77569ac9f4cb606c2f7863309918f27b58011af0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Optimize the function to use the right parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function get_disk_size() has parameter but not use it,"},{"line_number":10,"context_line":"it is strange for us.As rbd backend use rbd_name as"},{"line_number":11,"context_line":"base image.So pass rbd_name to the get_disk_size() function."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I511780e2d72dbd491e28ad6e25a4d33e7e4c3bae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_ad20a1f8","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":39},"updated":"2016-06-03 06:44:49.000000000","message":"using","commit_id":"c60a42115151b96fb5c53147905a0fa06b4f7d39"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"77569ac9f4cb606c2f7863309918f27b58011af0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function get_disk_size() has parameter but not use it,"},{"line_number":10,"context_line":"it is strange for us.As rbd backend use rbd_name as"},{"line_number":11,"context_line":"base image.So pass rbd_name to the get_disk_size() function."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I511780e2d72dbd491e28ad6e25a4d33e7e4c3bae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_6d54f953","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":60},"updated":"2016-06-03 06:44:49.000000000","message":"This patch fixes it by passing rbd_name to the get_disk_size() function.","commit_id":"c60a42115151b96fb5c53147905a0fa06b4f7d39"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"26ac05c58ce08b23479edbef7c32c5a52e64e78b","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        return self.driver.exists(self.rbd_name)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def get_disk_size(self, name):"},{"line_number":830,"context_line":"        \"\"\"Returns the size of the virtual disk in bytes."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        The name argument is ignored since this backend already knows"},{"line_number":833,"context_line":"        its name, and callers may pass a non-existent local file path."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a0d810f0","side":"PARENT","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":57},"updated":"2016-06-30 19:19:41.000000000","message":"Hi. Why remove this line? Since the name have a verb describing a function’s operation, it looks good to me, but, is it obvious that returns bytes?","commit_id":"f9a9158db58d07c148aedcb0ceabc8f817d5eba2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"abe1316267f658ffa7c5be4842b056703b81677b","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        return self.driver.exists(self.rbd_name)"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def get_disk_size(self, name):"},{"line_number":830,"context_line":"        \"\"\"Returns the size of the virtual disk in bytes."},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        The name argument is ignored since this backend already knows"},{"line_number":833,"context_line":"        its name, and callers may pass a non-existent local file path."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bae4843b","side":"PARENT","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":57},"in_reply_to":"3aaa91ec_a0d810f0","updated":"2016-07-27 23:16:03.000000000","message":"Yeah, nice point. I also cannot find any reason why we need to remove here..","commit_id":"f9a9158db58d07c148aedcb0ceabc8f817d5eba2"}]}