)]}'
{"nova/tests/unit/api/openstack/compute/test_used_limits.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5b18bf4cf79349158cb35f6063029a1a43f125a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.stubs.Set(quota.QUOTAS, \"get_project_quotas\","},{"line_number":84,"context_line":"                       stub_get_project_quotas)"},{"line_number":85,"context_line":"        if self.ext_mgr is not None:"},{"line_number":86,"context_line":"            self.ext_mgr.is_loaded(\u0027os-used-limits-for-admin\u0027).AndReturn(False)"},{"line_number":87,"context_line":"            self.ext_mgr.is_loaded(\u0027os-server-group-quotas\u0027).AndReturn("},{"line_number":88,"context_line":"                self.include_server_group_quotas)"},{"line_number":89,"context_line":"            self.mox.ReplayAll()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.controller.index(fake_req, res)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_7e5f9972","side":"PARENT","line":88,"range":{"start_line":85,"start_character":8,"end_line":88,"end_character":49},"updated":"2016-07-04 09:06:31.000000000","message":"I\u0027m not overly familiar with the Mox -\u003e mock conversion process, but why was this not necessary anymore? Could you document in the commit message?","commit_id":"4c4591f2cd887fdc22828e12f0c297c051bbd912"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"c3c680dcc62fd8f6e7e10e529fcb6602d0707621","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.stubs.Set(quota.QUOTAS, \"get_project_quotas\","},{"line_number":84,"context_line":"                       stub_get_project_quotas)"},{"line_number":85,"context_line":"        if self.ext_mgr is not None:"},{"line_number":86,"context_line":"            self.ext_mgr.is_loaded(\u0027os-used-limits-for-admin\u0027).AndReturn(False)"},{"line_number":87,"context_line":"            self.ext_mgr.is_loaded(\u0027os-server-group-quotas\u0027).AndReturn("},{"line_number":88,"context_line":"                self.include_server_group_quotas)"},{"line_number":89,"context_line":"            self.mox.ReplayAll()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.controller.index(fake_req, res)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e93ab5cc","side":"PARENT","line":88,"range":{"start_line":85,"start_character":8,"end_line":88,"end_character":49},"in_reply_to":"1aa78d24_7e5f9972","updated":"2016-07-04 09:14:19.000000000","message":"self.ext_mgr is always None (no value assignment for it). So I\u0027ve removed it and all related code.","commit_id":"4c4591f2cd887fdc22828e12f0c297c051bbd912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0cb0e53194313f548a25f53db96a817849e9020f","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.stubs.Set(quota.QUOTAS, \"get_project_quotas\","},{"line_number":84,"context_line":"                       stub_get_project_quotas)"},{"line_number":85,"context_line":"        if self.ext_mgr is not None:"},{"line_number":86,"context_line":"            self.ext_mgr.is_loaded(\u0027os-used-limits-for-admin\u0027).AndReturn(False)"},{"line_number":87,"context_line":"            self.ext_mgr.is_loaded(\u0027os-server-group-quotas\u0027).AndReturn("},{"line_number":88,"context_line":"                self.include_server_group_quotas)"},{"line_number":89,"context_line":"            self.mox.ReplayAll()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.controller.index(fake_req, res)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_498dc930","side":"PARENT","line":88,"range":{"start_line":85,"start_character":8,"end_line":88,"end_character":49},"in_reply_to":"1aa78d24_e93ab5cc","updated":"2016-07-04 09:21:12.000000000","message":"Excellent :) Can you put this in the commit message for future reference?","commit_id":"4c4591f2cd887fdc22828e12f0c297c051bbd912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b8ee48b9726aeb1a816999899d16918ec9c8733","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        fake_req \u003d FakeRequest(self.fake_context)"},{"line_number":118,"context_line":"        fake_req.GET \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        with mock.patch.object(quota.QUOTAS, \u0027get_project_quotas\u0027,"},{"line_number":121,"context_line":"                              return_value\u003d{}) as mock_get_quotas:"},{"line_number":122,"context_line":"            res \u003d wsgi.ResponseObject(obj)"},{"line_number":123,"context_line":"            self.controller.index(fake_req, res)"},{"line_number":124,"context_line":"            self.mock_can.assert_called_once_with(ul_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_37bc1505","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":66},"updated":"2016-12-13 17:03:48.000000000","message":"reviewing this again, I\u0027d prefer to see this as a decorator. any chance you could do this instead?","commit_id":"080679c03dfb72a0e3dd144852663acecc4533f7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b253d6faa273e67f2f67f7aeda02fda167204d0f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        fake_req \u003d FakeRequest(self.fake_context)"},{"line_number":118,"context_line":"        fake_req.GET \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        with mock.patch.object(quota.QUOTAS, \u0027get_project_quotas\u0027,"},{"line_number":121,"context_line":"                              return_value\u003d{}) as mock_get_quotas:"},{"line_number":122,"context_line":"            res \u003d wsgi.ResponseObject(obj)"},{"line_number":123,"context_line":"            self.controller.index(fake_req, res)"},{"line_number":124,"context_line":"            self.mock_can.assert_called_once_with(ul_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_2415389b","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":66},"in_reply_to":"1a6eadb0_37bc1505","updated":"2017-01-18 03:21:09.000000000","message":"yea, better to decorate this.","commit_id":"080679c03dfb72a0e3dd144852663acecc4533f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee0b77af7e2d193058f44e76e7109ec02b20fff4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        fake_req \u003d FakeRequest(self.fake_context)"},{"line_number":118,"context_line":"        fake_req.GET \u003d {\u0027tenant_id\u0027: tenant_id}"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        with mock.patch.object(quota.QUOTAS, \u0027get_project_quotas\u0027,"},{"line_number":121,"context_line":"                              return_value\u003d{}) as mock_get_quotas:"},{"line_number":122,"context_line":"            res \u003d wsgi.ResponseObject(obj)"},{"line_number":123,"context_line":"            self.controller.index(fake_req, res)"},{"line_number":124,"context_line":"            self.mock_can.assert_called_once_with(ul_policies.BASE_POLICY_NAME,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_d82b5380","line":121,"range":{"start_line":120,"start_character":0,"end_line":121,"end_character":66},"in_reply_to":"7a3c09a3_2415389b","updated":"2017-02-09 10:11:16.000000000","message":"+1 for decorators in the future.","commit_id":"080679c03dfb72a0e3dd144852663acecc4533f7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ee0b77af7e2d193058f44e76e7109ec02b20fff4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        with mock.patch.object(quota.QUOTAS, \u0027get_project_quotas\u0027,"},{"line_number":121,"context_line":"                              return_value\u003d{}) as mock_get_quotas:"},{"line_number":122,"context_line":"            res \u003d wsgi.ResponseObject(obj)"},{"line_number":123,"context_line":"            self.controller.index(fake_req, res)"},{"line_number":124,"context_line":"            self.mock_can.assert_called_once_with(ul_policies.BASE_POLICY_NAME,"},{"line_number":125,"context_line":"                                                  target)"},{"line_number":126,"context_line":"            mock_get_quotas.assert_called_once_with(self.fake_context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_78333ff6","line":123,"updated":"2017-02-09 10:11:16.000000000","message":"micro nit: personal preference, but I like a new line either side of the method under test, so its easy to see it.","commit_id":"080679c03dfb72a0e3dd144852663acecc4533f7"}]}