)]}'
{"nova/image/glance.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1fcc43724492b4bf491edc00eac40b1cc24cafc8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    if verifier:"},{"line_number":380,"context_line":"                        verifier.update(chunk)"},{"line_number":381,"context_line":"                        greenthread.sleep(0)"},{"line_number":382,"context_line":"                    data.write(chunk)"},{"line_number":383,"context_line":"                if verifier:"},{"line_number":384,"context_line":"                    verifier.verify()"},{"line_number":385,"context_line":"                    LOG.info(_LI(\u0027Image signature verification succeeded \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9b1ffb5a","line":382,"updated":"2016-06-09 19:02:24.000000000","message":"The sleep on line 365 makes sense, but the data.write(chunk) here should cause a context switch since it\u0027s writing to a file. So the sleep here should be unnecessary.","commit_id":"ae032cfe719404b3fcef214b0c5345a7032eb038"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"03bb5037e13f8583244027329d2708876bd29bdc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    if verifier:"},{"line_number":380,"context_line":"                        verifier.update(chunk)"},{"line_number":381,"context_line":"                        greenthread.sleep(0)"},{"line_number":382,"context_line":"                    data.write(chunk)"},{"line_number":383,"context_line":"                if verifier:"},{"line_number":384,"context_line":"                    verifier.verify()"},{"line_number":385,"context_line":"                    LOG.info(_LI(\u0027Image signature verification succeeded \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_7d62d5d9","line":382,"in_reply_to":"7aa08908_5c0c4294","updated":"2016-06-10 14:46:19.000000000","message":"yes, will update this.","commit_id":"ae032cfe719404b3fcef214b0c5345a7032eb038"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"8acff97383efd2d562d3f69afea915a1209bffe4","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                    if verifier:"},{"line_number":380,"context_line":"                        verifier.update(chunk)"},{"line_number":381,"context_line":"                        greenthread.sleep(0)"},{"line_number":382,"context_line":"                    data.write(chunk)"},{"line_number":383,"context_line":"                if verifier:"},{"line_number":384,"context_line":"                    verifier.verify()"},{"line_number":385,"context_line":"                    LOG.info(_LI(\u0027Image signature verification succeeded \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5c0c4294","line":382,"in_reply_to":"7aa08908_9b1ffb5a","updated":"2016-06-10 13:12:37.000000000","message":"agree.","commit_id":"ae032cfe719404b3fcef214b0c5345a7032eb038"}]}
