)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d8b15606ef0a8943d6e004fcf31ed90987223db4","unresolved":false,"context_lines":[{"line_number":4170,"context_line":"        \"\"\""},{"line_number":4171,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":4172,"context_line":""},{"line_number":4173,"context_line":"            guest_arch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4174,"context_line":""},{"line_number":4175,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":4176,"context_line":"                num_ports \u003d hardware.get_number_of_serial_ports("}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_91a9af27","line":4173,"updated":"2016-06-02 10:59:35.000000000","message":"Again this should be in guest object. probably has a private method. no need to pass instance.","commit_id":"20da8d229e3ea2891a86ce007bd9b7bb7675a884"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"9afaca54d640af6f65d88b82617430be14bcee2e","unresolved":false,"context_lines":[{"line_number":4170,"context_line":"        \"\"\""},{"line_number":4171,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":4172,"context_line":""},{"line_number":4173,"context_line":"            guest_arch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4174,"context_line":""},{"line_number":4175,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":4176,"context_line":"                num_ports \u003d hardware.get_number_of_serial_ports("}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_e69e2c53","line":4173,"in_reply_to":"9abb7d3a_91a9af27","updated":"2016-06-03 14:56:41.000000000","message":"@sahid: As mentioned in change [1], in the long run there should be a \"GuestConfigCreator\" class (or a similar name) which does that. The refactorings in this change series are purely to easier understand the functional change later.\n\n[1] https://review.openstack.org/#/c/323761/2","commit_id":"20da8d229e3ea2891a86ce007bd9b7bb7675a884"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b25d94c35642fda5cab12142281aa39f92614879","unresolved":false,"context_lines":[{"line_number":4170,"context_line":"        \"\"\""},{"line_number":4171,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":4172,"context_line":""},{"line_number":4173,"context_line":"            guest_arch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4174,"context_line":""},{"line_number":4175,"context_line":"            if CONF.serial_console.enabled:"},{"line_number":4176,"context_line":"                num_ports \u003d hardware.get_number_of_serial_ports("}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_2919257a","line":4173,"in_reply_to":"9abb7d3a_e69e2c53","updated":"2016-06-03 15:03:53.000000000","message":"As I said in the previous review, no need of a GestConfigCreate. if you are going to update this part, please consider my comments in hte previous patch. there is no need of instance to be passed as argument of the method, and guest is designed to handle this kind of method.","commit_id":"20da8d229e3ea2891a86ce007bd9b7bb7675a884"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c53964fdada2a813bbee56d62040927d5d03642","unresolved":false,"context_lines":[{"line_number":4221,"context_line":"        \"\"\""},{"line_number":4222,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":4223,"context_line":"            # Create the serial console char devices"},{"line_number":4224,"context_line":"            self._create_serial_console_devices(guest, instance, flavor,"},{"line_number":4225,"context_line":"                                                image_meta)"},{"line_number":4226,"context_line":"            if caps.host.cpu.arch in (arch.S390, arch.S390X):"},{"line_number":4227,"context_line":"                consolepty \u003d vconfig.LibvirtConfigGuestConsole()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_2b278713","side":"PARENT","line":4224,"updated":"2016-06-22 11:23:25.000000000","message":"Not o clear for me, you have removed that private method to put the code instead ?","commit_id":"b82e864c402427d7f5a1208ff274d6f3172da769"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c70d1726754eb7abaa0d3dc798f37989d0616797","unresolved":false,"context_lines":[{"line_number":4221,"context_line":"        \"\"\""},{"line_number":4222,"context_line":"        if virt_type in (\"qemu\", \"kvm\"):"},{"line_number":4223,"context_line":"            # Create the serial console char devices"},{"line_number":4224,"context_line":"            self._create_serial_console_devices(guest, instance, flavor,"},{"line_number":4225,"context_line":"                                                image_meta)"},{"line_number":4226,"context_line":"            if caps.host.cpu.arch in (arch.S390, arch.S390X):"},{"line_number":4227,"context_line":"                consolepty \u003d vconfig.LibvirtConfigGuestConsole()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_e463e218","side":"PARENT","line":4224,"in_reply_to":"3aaa91ec_2b278713","updated":"2016-06-22 14:45:47.000000000","message":"Yeah, I did an inline of the private method because it does 2 different things:\n1) create a \"file\" device\n2) create a \"tcp\" device\nAfter I inlined it, a later change [1] splits them out into their very own methods which do only *one* thing: \n1) _create_guest_log_file_device\n2) _create_guest_tcp_devices\nFrom my POV is was easier to understand the split when they were in one place first.\n\n[1] https://review.openstack.org/#/c/323764/6/nova/virt/libvirt/driver.py","commit_id":"b82e864c402427d7f5a1208ff274d6f3172da769"}]}