)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"f2353264ab7d99bd5ffca1d727521a3930d8ab32","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve help text for glance options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous commit moved the glance options to a"},{"line_number":10,"context_line":"central location. This commit adds additional help text to those options."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint centralize-config-options-newton"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3aaa91ec_b36c7a9d","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":73},"updated":"2016-06-28 13:00:36.000000000","message":"nit: This looks like it might be barely too long for one line.  I think it\u0027s best to wrap at 72 characters, and this line is 73 characters long.","commit_id":"95e0782398ca10d860cd4e47ae871dca0f7a99a8"}],"nova/conf/glance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"699ca89913c9c84dca18597698e6a6dfab397851","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Services which consume this:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"*   ``nova-api``"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_8afe63ac","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":16},"updated":"2016-06-03 06:09:55.000000000","message":"\u0027api_servers\u0027 is also utilized by \u0027nova-compute\u0027.","commit_id":"c6ea4a37011a9ce854d1f62351fab5b4266fddac"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"f4d1827a01c5b2344b5e09ed9ae0ee2dfb04a6c1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Services which consume this:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"*   ``nova-api``"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Related options:"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_91eaebaa","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":16},"in_reply_to":"9abb7d3a_8afe63ac","updated":"2016-06-03 18:45:20.000000000","message":"Done","commit_id":"c6ea4a37011a9ce854d1f62351fab5b4266fddac"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3d978bf087591d2e5beec0ea9389d1dc0c5801cc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"*   Any fully qualified url of the form \"scheme://hostname:port[/path]\""},{"line_number":33,"context_line":"    (i.e. \"http://10.0.1.0:9292\" or \"https://my.glance.server/image\")."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Services which consume this:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"*   ``nova-api``"},{"line_number":38,"context_line":"*   ``nova-compute``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Related options:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_216b7f86","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":20},"updated":"2016-06-14 14:33:11.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5a9aebe1e6555b851a67106912668fa0e48d4026","unresolved":false,"context_lines":[{"line_number":32,"context_line":"*   Any fully qualified url of the form \"scheme://hostname:port[/path]\""},{"line_number":33,"context_line":"    (i.e. \"http://10.0.1.0:9292\" or \"https://my.glance.server/image\")."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Services which consume this:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"*   ``nova-api``"},{"line_number":38,"context_line":"*   ``nova-compute``"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Related options:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d5e995e7","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":20},"in_reply_to":"7aa08908_216b7f86","updated":"2016-06-14 15:26:19.000000000","message":"Done","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3d978bf087591d2e5beec0ea9389d1dc0c5801cc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"*   True, False (default)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Services which consume this:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"*   ``nova-api``"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8127d361","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":16},"updated":"2016-06-14 14:33:11.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5a9aebe1e6555b851a67106912668fa0e48d4026","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"*   True, False (default)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Services which consume this:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"*   ``nova-api``"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Related options:"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_15f03dc8","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":16},"in_reply_to":"7aa08908_8127d361","updated":"2016-06-14 15:26:19.000000000","message":"Done","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3d978bf087591d2e5beec0ea9389d1dc0c5801cc","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"*   Any integer greater than or equal to 0 (Default: 0)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Services which consume this:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"*   ``nova-api``"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Related options:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_c11d5b10","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":16},"updated":"2016-06-14 14:33:11.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5a9aebe1e6555b851a67106912668fa0e48d4026","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"*   Any integer greater than or equal to 0 (Default: 0)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Services which consume this:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"*   ``nova-api``"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Related options:"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_55bc85db","line":81,"range":{"start_line":79,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"7aa08908_c11d5b10","updated":"2016-06-14 15:26:19.000000000","message":"Done","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3d978bf087591d2e5beec0ea9389d1dc0c5801cc","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"*   [file], [] (default)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Services which consume this:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"*   ``nova-api``"},{"line_number":110,"context_line":"*   ``nova-compute``"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Related options:"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_011483e6","line":110,"range":{"start_line":107,"start_character":0,"end_line":110,"end_character":20},"updated":"2016-06-14 14:33:11.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5a9aebe1e6555b851a67106912668fa0e48d4026","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"*   [file], [] (default)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Services which consume this:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"*   ``nova-api``"},{"line_number":110,"context_line":"*   ``nova-compute``"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Related options:"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_75b541eb","line":110,"range":{"start_line":107,"start_character":0,"end_line":110,"end_character":20},"in_reply_to":"7aa08908_011483e6","updated":"2016-06-14 15:26:19.000000000","message":"Done","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3d978bf087591d2e5beec0ea9389d1dc0c5801cc","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"*   True, False(default)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Services which consume this:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"*   ``nova-compute``"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Related options:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_a1dbef4d","line":162,"range":{"start_line":160,"start_character":0,"end_line":162,"end_character":20},"updated":"2016-06-14 14:33:11.000000000","message":"This section is no longer needed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"5a9aebe1e6555b851a67106912668fa0e48d4026","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"*   True, False(default)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Services which consume this:"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"*   ``nova-compute``"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"Related options:"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f5c1314f","line":162,"range":{"start_line":160,"start_character":0,"end_line":162,"end_character":20},"in_reply_to":"7aa08908_a1dbef4d","updated":"2016-06-14 15:26:19.000000000","message":"Done","commit_id":"5955bdefec68aa9c49e63b51ebf5971cf433d3e5"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"d6f1b856b6680a7a1b53206dac9260c1a13909d0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"verification on each image downloaded from Glance."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Nova verifies the signature of a signed image while"},{"line_number":127,"context_line":"downloading that image. If the image signature cannot be verified,"},{"line_number":128,"context_line":"then Nova will not boot the image and instead place the instance"},{"line_number":129,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":130,"context_line":"of the integrity of the image data they are using to create servers."}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_4f9a2963","line":127,"updated":"2016-06-14 17:53:26.000000000","message":"For clarity\u0027s sake we should probably add that image signature verification will fail if the Glance image Nova is downloading has no signature metadata.","commit_id":"0a525eeb2a8da8daf23fe92bf6af405d772f99bb"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"542fb14ba9d617777d3ee37e71b174af848f73dd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"verification on each image downloaded from Glance."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Nova verifies the signature of a signed image while"},{"line_number":127,"context_line":"downloading that image. If the image signature cannot be verified,"},{"line_number":128,"context_line":"then Nova will not boot the image and instead place the instance"},{"line_number":129,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":130,"context_line":"of the integrity of the image data they are using to create servers."}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_fb123457","line":127,"in_reply_to":"7aa08908_4f9a2963","updated":"2016-06-16 22:44:44.000000000","message":"Done","commit_id":"0a525eeb2a8da8daf23fe92bf6af405d772f99bb"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"012f52b2806e651ad407a0a0efd6adb267ea43a1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\"\"\""},{"line_number":43,"context_line":"If set to true, this option allows to perform insecure SSL (https)"},{"line_number":44,"context_line":"requests to glance."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This setting can be used to not verify the certificate of the glance server"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_6c085792","line":43,"range":{"start_line":43,"start_character":21,"end_line":43,"end_character":54},"updated":"2016-06-21 14:20:04.000000000","message":"option allows to perform insecure -\u003e option allows insecure","commit_id":"6d1f77775555f1cb162423bda1de840740a9abda"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"012f52b2806e651ad407a0a0efd6adb267ea43a1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"requests to glance."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This setting can be used to not verify the certificate of the glance server"},{"line_number":47,"context_line":"against the certificate authorities."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Possible values:"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_8c7ae3ef","line":47,"updated":"2016-06-21 14:20:04.000000000","message":"I think the following is more clear:\n\nThis setting can be used to turn off verification of the glance server certificate against the CA.","commit_id":"6d1f77775555f1cb162423bda1de840740a9abda"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"012f52b2806e651ad407a0a0efd6adb267ea43a1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"verifies the signature of a signed image while"},{"line_number":128,"context_line":"downloading that image. If the image signature cannot be verified or if the"},{"line_number":129,"context_line":"image signature metadata is either incomplete or unavailable,"},{"line_number":130,"context_line":"then Nova will not boot the image and instead place the instance"},{"line_number":131,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":132,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_2ca76f50","line":130,"range":{"start_line":130,"start_character":5,"end_line":130,"end_character":51},"updated":"2016-06-21 14:20:04.000000000","message":"-\u003e Nova will not boot the image and instead will place","commit_id":"6d1f77775555f1cb162423bda1de840740a9abda"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86493248e7ac3b1412b86d2d0e07659b92c55087","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # service catalog, however we don\u0027t have a good path there atm."},{"line_number":25,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"This option specifies the list of glance api server endpoints"},{"line_number":28,"context_line":"available to nova. https is used for ssl-based glance api servers."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_b3ce5e58","line":27,"range":{"start_line":27,"start_character":45,"end_line":27,"end_character":51},"updated":"2016-06-22 05:25:09.000000000","message":"servers","commit_id":"4aac9fcc5b549e79b0908befbac2f751e7ea6cd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86493248e7ac3b1412b86d2d0e07659b92c55087","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    cfg.ListOpt(\u0027allowed_direct_url_schemes\u0027,"},{"line_number":76,"context_line":"                default\u003d[],"},{"line_number":77,"context_line":"                help\u003d\"\"\""},{"line_number":78,"context_line":"List of schemes that can be directly accessed."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"This option specifies a list of url schemes that can be downloaded"},{"line_number":81,"context_line":"directly via the direct_url. This direct_URL meta-data comes from glance"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_33654e45","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":46},"updated":"2016-06-22 05:25:09.000000000","message":"List of url schemes that can be directly accessed.","commit_id":"4aac9fcc5b549e79b0908befbac2f751e7ea6cd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86493248e7ac3b1412b86d2d0e07659b92c55087","unresolved":false,"context_lines":[{"line_number":78,"context_line":"List of schemes that can be directly accessed."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"This option specifies a list of url schemes that can be downloaded"},{"line_number":81,"context_line":"directly via the direct_url. This direct_URL meta-data comes from glance"},{"line_number":82,"context_line":"client which can be used by Nova to get the image more efficiently."},{"line_number":83,"context_line":"Nova-compute could benefit from this by invoking a copy when it has"},{"line_number":84,"context_line":"access to the same file system as glance."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_73bb5673","line":82,"range":{"start_line":81,"start_character":29,"end_line":82,"end_character":13},"updated":"2016-06-22 05:25:09.000000000","message":"This direct_url can be fetched from Image metadata which......","commit_id":"4aac9fcc5b549e79b0908befbac2f751e7ea6cd8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"86493248e7ac3b1412b86d2d0e07659b92c55087","unresolved":false,"context_lines":[{"line_number":80,"context_line":"This option specifies a list of url schemes that can be downloaded"},{"line_number":81,"context_line":"directly via the direct_url. This direct_URL meta-data comes from glance"},{"line_number":82,"context_line":"client which can be used by Nova to get the image more efficiently."},{"line_number":83,"context_line":"Nova-compute could benefit from this by invoking a copy when it has"},{"line_number":84,"context_line":"access to the same file system as glance."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Currently supported schemes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_3336ee03","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":12},"updated":"2016-06-22 05:25:09.000000000","message":"nova-compute","commit_id":"4aac9fcc5b549e79b0908befbac2f751e7ea6cd8"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"4ba2723e43d2de82f380091e0583f6df3a46046f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"* Possible values:"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    True or False"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Related options:"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_0862063e","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":8},"updated":"2016-06-24 14:28:33.000000000","message":"nit: If you get to raise another patch, mark which one is default. As the default variable does not show in the docs, so good to add here. http://docs-draft.openstack.org/07/324007/8/check/gate-nova-docs/e17b441//doc/build/html/sample_config.html","commit_id":"95e0782398ca10d860cd4e47ae871dca0f7a99a8"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"4ba2723e43d2de82f380091e0583f6df3a46046f","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    None"},{"line_number":115,"context_line":"\"\"\","},{"line_number":116,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":117,"context_line":"                deprecated_reason\u003d\u0027This is a temporary flag to be removed \u0027"},{"line_number":118,"context_line":"                                  \u0027as soon as the V2 path works\u0027),"},{"line_number":119,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":120,"context_line":"                default\u003dFalse,"},{"line_number":121,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_48e6ceb0","line":118,"range":{"start_line":116,"start_character":16,"end_line":118,"end_character":66},"updated":"2016-06-24 14:28:33.000000000","message":"Also if you can change the sequence, for consistency with other patches. Move these 2 lines above help. Basically help should be the last variable of each option.","commit_id":"95e0782398ca10d860cd4e47ae871dca0f7a99a8"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"f2353264ab7d99bd5ffca1d727521a3930d8ab32","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Possible values:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"*   True, False(default)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Related options:"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_3341aa0c","line":135,"range":{"start_line":135,"start_character":10,"end_line":135,"end_character":24},"updated":"2016-06-28 13:00:36.000000000","message":"nit: for the other defaults, there\u0027s a space before the parentheses:\n\nFalse (default)","commit_id":"95e0782398ca10d860cd4e47ae871dca0f7a99a8"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"d4f8afebb9aac93364fb03567d6712cfb7b2ae2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# needs:fix_opt_description"},{"line_number":2,"context_line":"# needs:check_deprecation_status"},{"line_number":3,"context_line":"# needs:check_opt_group_and_type"},{"line_number":4,"context_line":"# needs:fix_opt_description_indentation"}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_2c756997","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":27},"updated":"2016-07-26 19:44:55.000000000","message":"nit - I think this first line can be removed as a result of the changes  you\u0027ve made for this commit.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1d4a9ded1528e5e3762f3bedb68533a9d13e31f5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Possible values:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"*   Any fully qualified url of the form \"scheme://hostname:port[/path]\""},{"line_number":40,"context_line":"    (i.e. \"http://10.0.1.0:9292\" or \"https://my.glance.server/image\")."},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_740ce642","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":23},"updated":"2016-07-27 21:23:40.000000000","message":"So it looks like code does accept url without http or https appended, but logs a warning. https://github.com/openstack/nova/blob/724bf655704d3ae8995e8a2f81cb5db306a692e1/nova/image/glance.py#L115\nI think its better to have regex here to check url is of proper format.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"de98442fcbc700bc67059f8160beb5911416a028","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Possible values:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"*   Any fully qualified url of the form \"scheme://hostname:port[/path]\""},{"line_number":40,"context_line":"    (i.e. \"http://10.0.1.0:9292\" or \"https://my.glance.server/image\")."},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_15053313","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":23},"in_reply_to":"bacf61ea_36cfd680","updated":"2016-07-29 19:11:36.000000000","message":"yes you are right.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"b64a4e4a0047bacc1bd44a493b8a6b70ae634cc7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Possible values:"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"*   Any fully qualified url of the form \"scheme://hostname:port[/path]\""},{"line_number":40,"context_line":"    (i.e. \"http://10.0.1.0:9292\" or \"https://my.glance.server/image\")."},{"line_number":41,"context_line":"\"\"\"),"},{"line_number":42,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_36cfd680","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":23},"in_reply_to":"bacf61ea_740ce642","updated":"2016-07-28 21:26:52.000000000","message":"ListOpt doesn\u0027t allow regex, only StrOpt does.\nAnd the code is appending http to api_servers if it is not specified. So, I think the validation is handled in code. let me know if this is wrong.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"1d4a9ded1528e5e3762f3bedb68533a9d13e31f5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This option adds support for retrying glance operations."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Specifies the number of retries when uploading / downloading"},{"line_number":57,"context_line":"an image to / from glance."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_8f1a276d","line":57,"updated":"2016-07-27 21:23:40.000000000","message":"Explain a little as what 0 means here.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"b64a4e4a0047bacc1bd44a493b8a6b70ae634cc7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This option adds support for retrying glance operations."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Specifies the number of retries when uploading / downloading"},{"line_number":57,"context_line":"an image to / from glance."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_d744741c","line":57,"in_reply_to":"bacf61ea_8f1a276d","updated":"2016-07-28 21:26:52.000000000","message":"I am not sure on what to add for value 0,I think 0 means no retries which is obvious. In the code it is handled for all the edge cases. So, i guess min will be 1 here.\nhttps://github.com/openstack/nova/blob/master/nova/image/glance.py#L163\nwhat are your suggestions on this raj?","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"de98442fcbc700bc67059f8160beb5911416a028","unresolved":false,"context_lines":[{"line_number":54,"context_line":"This option adds support for retrying glance operations."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Specifies the number of retries when uploading / downloading"},{"line_number":57,"context_line":"an image to / from glance."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_1861ead3","line":57,"in_reply_to":"bacf61ea_d744741c","updated":"2016-07-29 19:11:36.000000000","message":"So just mention that here that 0 means just one try no retry.","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"de98442fcbc700bc67059f8160beb5911416a028","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Specifies the number of retries when uploading / downloading"},{"line_number":57,"context_line":"an image to / from glance."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Possible values:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"*   Any integer greater than or equal to 0 (Default: 0)"},{"line_number":62,"context_line":"\"\"\"),"},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027allowed_direct_url_schemes\u0027,"},{"line_number":64,"context_line":"                default\u003d[],"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_18b8ca29","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":55},"updated":"2016-07-29 19:11:36.000000000","message":"I think you should drop this section. Its clear from docs it is integer and default value is generated in docs","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"de98442fcbc700bc67059f8160beb5911416a028","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.BoolOpt(\u0027use_glance_v1\u0027,"},{"line_number":82,"context_line":"                default\u003dFalse,"},{"line_number":83,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":84,"context_line":"                deprecated_reason\u003d\u0027Glance v1 support will be removed in \u0027"},{"line_number":85,"context_line":"                                  \u0027Ocata\u0027,"},{"line_number":86,"context_line":"                help\u003d\"\"\""},{"line_number":87,"context_line":"This flag allows reverting to glance v1 if for some reason glance v2 doesn\u0027t"},{"line_number":88,"context_line":"work in your environment. This will only exist in Newton, and a fully working"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_987afa75","line":85,"range":{"start_line":84,"start_character":35,"end_line":85,"end_character":41},"updated":"2016-07-29 19:11:36.000000000","message":"Shouldn\u0027t you use triple quotes here for consistency?","commit_id":"157d30bda058619217aa2aabe88b8b5974f1a3bb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af45065ee957e416225c6d600db1c9cba03bc98f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"glance_group \u003d cfg.OptGroup("},{"line_number":18,"context_line":"    \u0027glance\u0027,"},{"line_number":19,"context_line":"    title\u003d\u0027Glance Options\u0027)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"glance_opts \u003d ["},{"line_number":22,"context_line":"    # NOTE(sdague): there is intentionally no default here. This"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9ab12792","line":19,"updated":"2016-08-05 10:36:48.000000000","message":"This group should have help text added.","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"c046e622621cfd86acaa614fa7e56aa465de4fdd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"glance_group \u003d cfg.OptGroup("},{"line_number":18,"context_line":"    \u0027glance\u0027,"},{"line_number":19,"context_line":"    title\u003d\u0027Glance Options\u0027)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"glance_opts \u003d ["},{"line_number":22,"context_line":"    # NOTE(sdague): there is intentionally no default here. This"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_e707d915","line":19,"in_reply_to":"bacf61ea_9ab12792","updated":"2016-08-05 16:01:51.000000000","message":"Done","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af45065ee957e416225c6d600db1c9cba03bc98f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # requires configuration. Eventually this will come from the"},{"line_number":24,"context_line":"    # service catalog, however we don\u0027t have a good path there atm."},{"line_number":25,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"This option specifies the list of glance api servers endpoints"},{"line_number":28,"context_line":"available to nova. https is used for ssl-based glance api servers."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_9a5f6740","line":26,"updated":"2016-08-05 10:36:48.000000000","message":"We should have required\u003dTrue here","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"c046e622621cfd86acaa614fa7e56aa465de4fdd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # requires configuration. Eventually this will come from the"},{"line_number":24,"context_line":"    # service catalog, however we don\u0027t have a good path there atm."},{"line_number":25,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":26,"context_line":"                help\u003d\"\"\""},{"line_number":27,"context_line":"This option specifies the list of glance api servers endpoints"},{"line_number":28,"context_line":"available to nova. https is used for ssl-based glance api servers."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_c70a951f","line":26,"in_reply_to":"bacf61ea_9a5f6740","updated":"2016-08-05 16:01:51.000000000","message":"Done","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"af45065ee957e416225c6d600db1c9cba03bc98f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"image signature metadata is either incomplete or unavailable,"},{"line_number":90,"context_line":"then Nova will not boot the image and instead will place the instance"},{"line_number":91,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":92,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":93,"context_line":"\"\"\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_b58a3c62","line":92,"updated":"2016-08-05 10:36:48.000000000","message":"I feel like there must be other related options to activate this feature.\n\nI think you need to say related options are in the key_manager group, as the key_manager is used for the signature validation.\nhttps://github.com/openstack/nova/blob/6b3dd1bad85d19edb881b3e2413be334cf78144b/nova/conf/key_manager.py#L25","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"c046e622621cfd86acaa614fa7e56aa465de4fdd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"image signature metadata is either incomplete or unavailable,"},{"line_number":90,"context_line":"then Nova will not boot the image and instead will place the instance"},{"line_number":91,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":92,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":93,"context_line":"\"\"\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_671c896a","line":92,"in_reply_to":"bacf61ea_b58a3c62","updated":"2016-08-05 16:01:51.000000000","message":"Done","commit_id":"ece7ebfe759dc70b772403571ef12161068dd2cf"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"29dfc16f9ca32e51770607deab89e8d004607b08","unresolved":false,"context_lines":[{"line_number":17,"context_line":"glance_group \u003d cfg.OptGroup("},{"line_number":18,"context_line":"    \u0027glance\u0027,"},{"line_number":19,"context_line":"    title\u003d\u0027Glance Options\u0027,"},{"line_number":20,"context_line":"    help\u003d\"Configuration options for the Image service\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"glance_opts \u003d ["},{"line_number":23,"context_line":"    # NOTE(sdague): there is intentionally no default here. This"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_4d3cbb2f","line":20,"range":{"start_line":20,"start_character":9,"end_line":20,"end_character":10},"updated":"2016-08-08 14:43:21.000000000","message":"Sp far we have been using single quotes for one liners and triple for multiple. Lets change it to single quote for consistency.","commit_id":"d36097852ca4ba44ac8a47970014d5486178d931"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8edef5aeb7f72f9446fe956c297b5279454cc8e8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\"\"\"),"},{"line_number":45,"context_line":"    cfg.IntOpt(\u0027num_retries\u0027,"},{"line_number":46,"context_line":"               default\u003d0,"},{"line_number":47,"context_line":"               min\u003d0,"},{"line_number":48,"context_line":"               help\u003d\"\"\""},{"line_number":49,"context_line":"This option adds support for retrying glance operations."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3ac371cc_c387c20d","line":47,"updated":"2016-08-15 16:59:27.000000000","message":"Lets drop this and leave the warning. That should be a separate patch really. Just add a TODO in here.\n\nChanged my mind after the recent issues with these kinds of changes.","commit_id":"e258da31c78ffe508cc9d0c3f051a13bd8dc41ee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # TODO(raj_singh): Add \"required\u003dTrue\" flag to this option."},{"line_number":27,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":28,"context_line":"                help\u003d\"\"\""},{"line_number":29,"context_line":"This option specifies the list of glance api servers endpoints"},{"line_number":30,"context_line":"available to nova. https is used for ssl-based glance api servers."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_7f70b472","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":30},"updated":"2016-09-13 12:34:17.000000000","message":"List of...","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":28,"context_line":"                help\u003d\"\"\""},{"line_number":29,"context_line":"This option specifies the list of glance api servers endpoints"},{"line_number":30,"context_line":"available to nova. https is used for ssl-based glance api servers."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_df0540c2","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":19},"updated":"2016-09-13 12:34:17.000000000","message":"Insert a line break here","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027api_insecure\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\"\"\""},{"line_number":40,"context_line":"If set to true, this option allows insecure SSL (https) requests to glance."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"This setting can be used to turn off verification of the glance server"},{"line_number":43,"context_line":"certificate against the certificate authorities."}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_3f7e2c6a","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":34},"updated":"2016-09-13 12:34:17.000000000","message":"Enable","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027num_retries\u0027,"},{"line_number":47,"context_line":"               default\u003d0,"},{"line_number":48,"context_line":"               help\u003d\"\"\""},{"line_number":49,"context_line":"This option adds support for retrying glance operations."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Specifies the number of retries when uploading / downloading"},{"line_number":52,"context_line":"an image to / from glance. 0 means no retries."}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_9fe4983c","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":56},"updated":"2016-09-13 12:34:17.000000000","message":"Enable glance operation retries.","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cfg.BoolOpt(\u0027verify_glance_signatures\u0027,"},{"line_number":84,"context_line":"                default\u003dFalse,"},{"line_number":85,"context_line":"                help\u003d\"\"\""},{"line_number":86,"context_line":"When set to True, this option requires Nova to perform signature"},{"line_number":87,"context_line":"verification on each image downloaded from Glance."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Nova uses the image signature metadata from glance and"},{"line_number":90,"context_line":"verifies the signature of a signed image while"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_bfb87c12","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":50},"updated":"2016-09-13 12:34:17.000000000","message":"Enable image signature verification.","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"444a1fe7ac73ea317b68e9a8bd887015a6397504","unresolved":false,"context_lines":[{"line_number":86,"context_line":"When set to True, this option requires Nova to perform signature"},{"line_number":87,"context_line":"verification on each image downloaded from Glance."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Nova uses the image signature metadata from glance and"},{"line_number":90,"context_line":"verifies the signature of a signed image while"},{"line_number":91,"context_line":"downloading that image. If the image signature cannot be verified or if the"},{"line_number":92,"context_line":"image signature metadata is either incomplete or unavailable,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a89bdaa_9f52d8dc","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":4},"updated":"2016-09-13 12:34:17.000000000","message":"s/Nova/nova/ (it\u0027s the docs guidelines)","commit_id":"de63184f2e19976fe36da98bc850ede56be866b9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fdffa714103c6622a943f001efe06c872df049be","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.ListOpt(\u0027api_servers\u0027,"},{"line_number":28,"context_line":"                help\u003d\"\"\""},{"line_number":29,"context_line":"List of glance api servers endpoints available to nova."},{"line_number":30,"context_line":"https is used for ssl-based glance api servers."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Possible values:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5a8bc5a2_915b5e54","line":30,"updated":"2016-09-22 11:37:01.000000000","message":"One more line break :)\n\n    Summary...\n\n    Longer description","commit_id":"d1fc9c5a65afd0fb8c5abdf8905a0cafaeb8aaf7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8724e40531d7b5e51773d693bbdb8743d68ce633","unresolved":false,"context_lines":[{"line_number":62,"context_line":"image more efficiently. nova-compute could benefit from this by"},{"line_number":63,"context_line":"invoking a copy when it has access to the same file system as glance."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Currently supported schemes:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* [file]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Possible values:"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5a8bc5a2_ffed4926","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":8},"updated":"2016-09-22 11:55:53.000000000","message":"Intention was good, but this replicates \u0027Possible values\u0027. I would prefer to stick with possible values and to remove this.","commit_id":"d1fc9c5a65afd0fb8c5abdf8905a0cafaeb8aaf7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fdffa714103c6622a943f001efe06c872df049be","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                help\u003d\"\"\""},{"line_number":87,"context_line":"Enable image signature verification."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"nova uses the image signature metadata from glance and"},{"line_number":90,"context_line":"verifies the signature of a signed image while"},{"line_number":91,"context_line":"downloading that image. If the image signature cannot be verified or if the"},{"line_number":92,"context_line":"image signature metadata is either incomplete or unavailable,"},{"line_number":93,"context_line":"then nova will not boot the image and instead will place the instance"},{"line_number":94,"context_line":"into an error state. This provides end users with stronger assurances"},{"line_number":95,"context_line":"of the integrity of the image data they are using to create servers."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Related options:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5a8bc5a2_943eecb6","line":95,"range":{"start_line":89,"start_character":0,"end_line":95,"end_character":68},"updated":"2016-09-22 11:37:01.000000000","message":"This should probably be rewrapped\n\nhttp://lglinux.blogspot.ie/2008/01/rewrapping-paragraphs-in-vim.html","commit_id":"d1fc9c5a65afd0fb8c5abdf8905a0cafaeb8aaf7"}],"nova/image/glance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8edef5aeb7f72f9446fe956c297b5279454cc8e8","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            LOG.warning(_LW(\"Treating negative config value (%(retries)s) for \""},{"line_number":165,"context_line":"                            \"\u0027glance.num_retries\u0027 as 0.\"),"},{"line_number":166,"context_line":"                        {\u0027retries\u0027: retries})"},{"line_number":167,"context_line":"            retries \u003d 0"},{"line_number":168,"context_line":"        num_attempts \u003d retries + 1"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        for attempt in range(1, num_attempts + 1):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3ac371cc_e3991e70","side":"PARENT","line":167,"updated":"2016-08-15 16:59:27.000000000","message":"Lets do this in a separate change.","commit_id":"945e7858124cda650f552224ca9b39f855332344"}]}