)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2bf672ebc29041a322cafa0768c761642a78993e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because not all volume drivers require iSCSI it makes sense to not"},{"line_number":10,"context_line":"set the initiator in the connector and let the volume drivers"},{"line_number":11,"context_line":"return an error if iSCSI is required."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"bug #1007084"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAPX%2F%2FpNE%3D","line":11,"updated":"2013-06-13 16:15:31.000000000","message":"I would maybe make it more explicit and state that now libvirt driver\u0027s connector will return only and ip and host properties. Might be worth a doctstring actually","commit_id":"08f7d9418087e8f65b8d8293c8e832591e51685f"}],"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"886678dcb84bff9b993bc45c3d071374089f28e1","unresolved":false,"context_lines":[{"line_number":4528,"context_line":"        # Start test"},{"line_number":4529,"context_line":"        self.mox.ReplayAll()"},{"line_number":4530,"context_line":"        result \u003d libvirt_utils.get_iscsi_initiator()"},{"line_number":4531,"context_line":"        self.assertIsNone(None, result)"},{"line_number":4532,"context_line":""},{"line_number":4533,"context_line":"    def test_create_image(self):"},{"line_number":4534,"context_line":"        self.mox.StubOutWithMock(utils, \u0027execute\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPX%2F%2FrhE%3D","line":4531,"updated":"2013-06-12 21:56:30.000000000","message":"This will do nothing.  None is, by definition, None, so this assert can never trigger.  I think you must have meant to use assertEqual(), which takes two arguments and asserts that they are equal.","commit_id":"4929bc9f00b80ccb983aa838c55c993ecc62f46b"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"717b190ae4840db2259ad30a071c0cdb6200fcf7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    try:"},{"line_number":57,"context_line":"        contents \u003d utils.read_file_as_root(\u0027/etc/iscsi/initiatorname.iscsi\u0027)"},{"line_number":58,"context_line":"    except exception.FileNotFound:"},{"line_number":59,"context_line":"        return"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for l in contents.split(\u0027\\n\u0027):"},{"line_number":62,"context_line":"        if l.startswith(\u0027InitiatorName\u003d\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FpOs%3D","line":59,"updated":"2013-06-13 16:07:55.000000000","message":"This should be an explicit return None, since the caller uses the return value.","commit_id":"08f7d9418087e8f65b8d8293c8e832591e51685f"}]}