)]}'
{"nova/network/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a7c0374f76217dacb4676c2763ea1fdb34c9c950","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            instance_id \u003d instance_uuid"},{"line_number":562,"context_line":"        instance_uuid \u003d instance_id"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":565,"context_line":"        vifs \u003d self.db.virtual_interface_get_by_instance(context,"},{"line_number":566,"context_line":"                                                         instance_uuid)"},{"line_number":567,"context_line":"        networks \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fybs%3D","side":"PARENT","line":564,"updated":"2013-06-10 17:21:10.000000000","message":"Shouldn\u0027t this be:\n\n  host \u003d kwargs.get(\u0027host\u0027, host)\n\n? Otherwise, this is a change in behavior (although I haven\u0027t surveyed the code to see if it matters, but the above would be a safer change.","commit_id":"54e577729d33ad74677edb3f4dc47a5b0cfb1d4c"},{"author":{"_account_id":1636,"name":"David Scannell","email":"dscannell@gridcentric.com","username":"dscannell"},"change_message_id":"e16c3d48f239a3258a358dd3418ac131ec6fadd0","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            instance_id \u003d instance_uuid"},{"line_number":562,"context_line":"        instance_uuid \u003d instance_id"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":565,"context_line":"        vifs \u003d self.db.virtual_interface_get_by_instance(context,"},{"line_number":566,"context_line":"                                                         instance_uuid)"},{"line_number":567,"context_line":"        networks \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FyYc%3D","side":"PARENT","line":564,"in_reply_to":"AAAAPX%2F%2Fybs%3D","updated":"2013-06-10 17:39:53.000000000","message":"I maybe mistaken, but I believe that the key \u0027host\u0027 cannot exist within kwargs because it is already defined as a positional argument. As an example:\n\n    \u003e\u003e\u003e def foo(a, **kwargs):\n    ...     print a\n    ... \n    \u003e\u003e\u003e foo(\"a\",a\u003d\"b\")\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n    TypeError: foo() got multiple values for keyword argument \u0027a\u0027\n\nAnd I also believe that if someone were to pass it as a keyword argument instead of positional, python magic will map it to the correct positional argument based on the name:\n\n    \u003e\u003e\u003e def bar(a,**kwargs):\n    ...     print a, kwargs.get(\u0027a\u0027)\n    ... \n    \u003e\u003e\u003e bar(\"a\")\n    a None\n    \u003e\u003e\u003e bar(a\u003d\"a\")\n    a None\n\nIn other words, I don\u0027t think kwargs.get(\u0027host\u0027) can return anything other than None, so we should just remove the line and use host as is.","commit_id":"54e577729d33ad74677edb3f4dc47a5b0cfb1d4c"}]}