)]}'
{"nova/conf/base.py":[{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e7f765b8578f3b1ab879b40922be01c541763769","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Possible values:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* positive integer"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Services which consumes this:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c9aea797","line":31,"range":{"start_line":31,"start_character":3,"end_line":31,"end_character":8},"updated":"2016-06-07 01:31:19.000000000","message":"please write out the default value here","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"28723ef1df67514be4b09833c223794ce8213c09","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Possible values:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* positive integer"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Services which consumes this:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c53e5927","line":31,"range":{"start_line":31,"start_character":3,"end_line":31,"end_character":8},"in_reply_to":"7aa08908_c9aea797","updated":"2016-06-07 16:56:33.000000000","message":"Done","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e7f765b8578f3b1ab879b40922be01c541763769","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Services which consumes this:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Related options:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e9aba387","line":35,"range":{"start_line":35,"start_character":2,"end_line":35,"end_character":6},"updated":"2016-06-07 01:31:19.000000000","message":"The list of services which consume this is: nova-api, nova-compute and nova-console?","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"28723ef1df67514be4b09833c223794ce8213c09","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Services which consumes this:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Related options:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_486560b3","line":35,"range":{"start_line":35,"start_character":2,"end_line":35,"end_character":6},"in_reply_to":"7aa08908_e9aba387","updated":"2016-06-07 16:56:33.000000000","message":"according to https://wiki.openstack.org/wiki/ConfigOptionsConsistency, section fix_opt_description we do not include services which consumes this in help message anymore. Deleting.","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e7f765b8578f3b1ab879b40922be01c541763769","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \u0027hour\u0027"},{"line_number":52,"context_line":"* \u0027day\u0027"},{"line_number":53,"context_line":"* \u0027month\u0027"},{"line_number":54,"context_line":"* \u0027year\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Services which consumes this:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0991cf52","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":8},"updated":"2016-06-07 01:31:19.000000000","message":"please leave a note here to mark it as default value.","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"28723ef1df67514be4b09833c223794ce8213c09","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* \u0027hour\u0027"},{"line_number":52,"context_line":"* \u0027day\u0027"},{"line_number":53,"context_line":"* \u0027month\u0027"},{"line_number":54,"context_line":"* \u0027year\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Services which consumes this:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_45326960","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":8},"in_reply_to":"7aa08908_0991cf52","updated":"2016-06-07 16:56:33.000000000","message":"Done","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e7f765b8578f3b1ab879b40922be01c541763769","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Services which consumes this:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4972b74a","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":6},"updated":"2016-06-07 01:31:19.000000000","message":"I think the list here is nova-api and nova-compute, please recheck and correct me if I\u0027m wrong.","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"28723ef1df67514be4b09833c223794ce8213c09","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Services which consumes this:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* None"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Related options:"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e8740c69","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":6},"in_reply_to":"7aa08908_4972b74a","updated":"2016-06-07 16:56:33.000000000","message":"according to https://wiki.openstack.org/wiki/ConfigOptionsConsistency, section fix_opt_description we do not include services which consumes this in help message anymore. Deleting.","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e7f765b8578f3b1ab879b40922be01c541763769","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Possible values:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* string with path"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Services which consumes this:"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c99ce75f","line":93,"range":{"start_line":93,"start_character":10,"end_line":93,"end_character":16},"updated":"2016-06-07 01:31:19.000000000","message":"please write out default value here","commit_id":"dc15af781c258eb49a4cccfa10bbe0582126a358"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"950414d6886f1c570322fc7c63c45af1a72fd973","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Possible values:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* string with path"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Related options:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_9357e2c9","line":91,"updated":"2016-06-27 21:28:06.000000000","message":"nit: can you please rephrase this line ? may be \"Path of the directory in string\"","commit_id":"509871e2356fcf573aadd824535412b690ea6f52"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"03f75b099bea718cf88240dd8e7e5a5c51fb5c29","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Possible values:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* string with path"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Related options:"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_42aaad1a","line":91,"in_reply_to":"3aaa91ec_9357e2c9","updated":"2016-06-28 10:32:06.000000000","message":"I think that we cal drop it completely - it is quite obvious, both opt name and description indicate that value should be a path, and there is no default value to describe.","commit_id":"509871e2356fcf573aadd824535412b690ea6f52"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"520e67766bedda06e46769dde24cdf4473a6e695","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":26,"context_line":"Length of generated instance admin passwords."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Possible values:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* positive integer, default is 12"},{"line_number":31,"context_line":"\u0027\u0027\u0027),"},{"line_number":32,"context_line":"    cfg.StrOpt("},{"line_number":33,"context_line":"        \u0027instance_usage_audit_period\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_e3ee9120","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":33},"updated":"2016-07-07 14:29:45.000000000","message":"Deleting, as this is quite obvious.","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ef4ef360c69e6d88d5a14db1f73b63b02cf930d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":37,"context_line":"Time period to generate instance usages for. Time period must be hour, day,"},{"line_number":38,"context_line":"month or year."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* \u0027hour\u0027"},{"line_number":43,"context_line":"* \u0027day\u0027"},{"line_number":44,"context_line":"* \u0027month\u0027 (default)"},{"line_number":45,"context_line":"* \u0027year\u0027"},{"line_number":46,"context_line":"\u0027\u0027\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt("},{"line_number":48,"context_line":"        \u0027use_rootwrap_daemon\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_fae86ce4","line":45,"range":{"start_line":39,"start_character":0,"end_line":45,"end_character":8},"updated":"2016-07-05 15:57:02.000000000","message":"Drop this (it\u0027s already available on lines 34-35)","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"520e67766bedda06e46769dde24cdf4473a6e695","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":37,"context_line":"Time period to generate instance usages for. Time period must be hour, day,"},{"line_number":38,"context_line":"month or year."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Possible values:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* \u0027hour\u0027"},{"line_number":43,"context_line":"* \u0027day\u0027"},{"line_number":44,"context_line":"* \u0027month\u0027 (default)"},{"line_number":45,"context_line":"* \u0027year\u0027"},{"line_number":46,"context_line":"\u0027\u0027\u0027),"},{"line_number":47,"context_line":"    cfg.BoolOpt("},{"line_number":48,"context_line":"        \u0027use_rootwrap_daemon\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_e387b15e","line":45,"range":{"start_line":39,"start_character":0,"end_line":45,"end_character":8},"in_reply_to":"1aa78d24_fae86ce4","updated":"2016-07-07 14:29:45.000000000","message":"Done","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ef4ef360c69e6d88d5a14db1f73b63b02cf930d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* True: Functions specified in ``monkey_patch_modules`` will be patched."},{"line_number":80,"context_line":"* False: No monkey patching will occur (default)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Interdependencies to other options:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_f3b09f45","line":80,"range":{"start_line":80,"start_character":38,"end_line":80,"end_character":49},"updated":"2016-07-05 15:57:02.000000000","message":"Ditto","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ef4ef360c69e6d88d5a14db1f73b63b02cf930d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        help\u003d\"\"\""},{"line_number":75,"context_line":"Determine if monkey patching should be applied."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* True: Functions specified in ``monkey_patch_modules`` will be patched."},{"line_number":80,"context_line":"* False: No monkey patching will occur (default)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Interdependencies to other options:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_1a1738ee","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":49},"updated":"2016-07-05 15:57:02.000000000","message":"Drop this whole thing - it\u0027s boolean so pretty clear what the options are.","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"520e67766bedda06e46769dde24cdf4473a6e695","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        help\u003d\"\"\""},{"line_number":75,"context_line":"Determine if monkey patching should be applied."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* True: Functions specified in ``monkey_patch_modules`` will be patched."},{"line_number":80,"context_line":"* False: No monkey patching will occur (default)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Interdependencies to other options:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_c35435cb","line":80,"range":{"start_line":77,"start_character":0,"end_line":80,"end_character":49},"in_reply_to":"1aa78d24_1a1738ee","updated":"2016-07-07 14:29:45.000000000","message":"Done","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"520e67766bedda06e46769dde24cdf4473a6e695","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* True: Functions specified in ``monkey_patch_modules`` will be patched."},{"line_number":80,"context_line":"* False: No monkey patching will occur (default)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Interdependencies to other options:"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_834ead38","line":80,"range":{"start_line":80,"start_character":38,"end_line":80,"end_character":49},"in_reply_to":"1aa78d24_f3b09f45","updated":"2016-07-07 14:29:45.000000000","message":"Done","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ef4ef360c69e6d88d5a14db1f73b63b02cf930d","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Possible values:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* nova.compute.api:nova.notifications.notify_decorator (default)"},{"line_number":99,"context_line":"* nova.api.ec2.cloud:nova.notifications.notify_decorator"},{"line_number":100,"context_line":"* [...]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_5386d365","line":98,"range":{"start_line":98,"start_character":54,"end_line":98,"end_character":64},"updated":"2016-07-05 15:57:02.000000000","message":"Ditto - not needed","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"520e67766bedda06e46769dde24cdf4473a6e695","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Possible values:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* nova.compute.api:nova.notifications.notify_decorator (default)"},{"line_number":99,"context_line":"* nova.api.ec2.cloud:nova.notifications.notify_decorator"},{"line_number":100,"context_line":"* [...]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_235a59f2","line":98,"range":{"start_line":98,"start_character":54,"end_line":98,"end_character":64},"in_reply_to":"1aa78d24_5386d365","updated":"2016-07-07 14:29:45.000000000","message":"Done","commit_id":"21cf7692bbadf2c2d6a2834c784d70a6f0b37e2d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"431884c77c3c8dcdbb87980a9739b2cbc9c497f2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027instance_usage_audit_period\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027month\u0027,"},{"line_number":31,"context_line":"        choices\u003d(\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027),"},{"line_number":32,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":33,"context_line":"Time period to generate instance usages for. Time period must be hour, day,"},{"line_number":34,"context_line":"month or year."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_90e9561d","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":49},"updated":"2016-07-11 08:52:21.000000000","message":"After check this https://github.com/openstack/nova/blob/master/nova/utils.py#L341 Looks like it isn\u0027t only this four values.","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c559501918739320806ef81d0b099e4eea62f579","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027instance_usage_audit_period\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027month\u0027,"},{"line_number":31,"context_line":"        choices\u003d(\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027),"},{"line_number":32,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":33,"context_line":"Time period to generate instance usages for. Time period must be hour, day,"},{"line_number":34,"context_line":"month or year."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_bcc84da9","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":49},"in_reply_to":"1aa78d24_90e9561d","updated":"2016-07-12 18:22:07.000000000","message":"Done","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6925bf8ec8d36a068e91442e0c90a7c42a3a5c8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027instance_usage_audit_period\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027month\u0027,"},{"line_number":31,"context_line":"        choices\u003d(\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027),"},{"line_number":32,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":33,"context_line":"Time period to generate instance usages for. Time period must be hour, day,"},{"line_number":34,"context_line":"month or year."}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_e6957f40","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":49},"in_reply_to":"1aa78d24_90e9561d","updated":"2016-07-11 11:01:41.000000000","message":"Good catch","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6925bf8ec8d36a068e91442e0c90a7c42a3a5c8b","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Possible values:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Path, default is \u0027/etc/nova/rootwrap.conf\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\u0027\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_06d7ebed","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":44},"updated":"2016-07-11 11:01:41.000000000","message":"Don\u0027t provide the default (it\u0027s available on line 46) and maybe provide a little detail about what this is a path to?","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c559501918739320806ef81d0b099e4eea62f579","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Possible values:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Path, default is \u0027/etc/nova/rootwrap.conf\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"\u0027\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_39ac6f8b","line":52,"range":{"start_line":52,"start_character":2,"end_line":52,"end_character":44},"in_reply_to":"1aa78d24_06d7ebed","updated":"2016-07-12 18:22:07.000000000","message":"Done","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6925bf8ec8d36a068e91442e0c90a7c42a3a5c8b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\u0027\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027tempdir\u0027,"},{"line_number":57,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":58,"context_line":"Explicitly specify the temporary working directory."},{"line_number":59,"context_line":"\u0027\u0027\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt("},{"line_number":61,"context_line":"        \u0027monkey_patch\u0027,"},{"line_number":62,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_66b6afdd","line":59,"range":{"start_line":57,"start_character":13,"end_line":59,"end_character":3},"updated":"2016-07-11 11:01:41.000000000","message":"nit: this would fit on one line, no?","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c559501918739320806ef81d0b099e4eea62f579","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\u0027\u0027\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt("},{"line_number":56,"context_line":"        \u0027tempdir\u0027,"},{"line_number":57,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":58,"context_line":"Explicitly specify the temporary working directory."},{"line_number":59,"context_line":"\u0027\u0027\u0027),"},{"line_number":60,"context_line":"    cfg.BoolOpt("},{"line_number":61,"context_line":"        \u0027monkey_patch\u0027,"},{"line_number":62,"context_line":"        default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_7271050c","line":59,"range":{"start_line":57,"start_character":13,"end_line":59,"end_character":3},"in_reply_to":"1aa78d24_66b6afdd","updated":"2016-07-12 18:22:07.000000000","message":"Done","commit_id":"c482e014ff0fad521c1410ba8aacdbb1bc29f17a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"6d78c95e7037b838b48d225eb680549c8cd499d3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027instance_usage_audit_period\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027month\u0027,"},{"line_number":31,"context_line":"        choices\u003d(\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027),"},{"line_number":32,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":33,"context_line":"Time period to generate instance usages for. It is possible to define optional"},{"line_number":34,"context_line":"offset to given period by appending @ character followed by a number defining"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_0e15829a","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":49},"updated":"2016-07-14 12:14:07.000000000","message":"This parameter means if you input a value out of (\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027). So if you input month@15, you will failed.","commit_id":"3fe1c47ab3d93efdc86f2fdd87dc7c7b59cdd1e7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"16ef4f13ca672c7f9b08e9c877868fc5fde7bd0a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt("},{"line_number":29,"context_line":"        \u0027instance_usage_audit_period\u0027,"},{"line_number":30,"context_line":"        default\u003d\u0027month\u0027,"},{"line_number":31,"context_line":"        choices\u003d(\u0027hour\u0027, \u0027day\u0027, \u0027month\u0027, \u0027year\u0027),"},{"line_number":32,"context_line":"        help\u003d\u0027\u0027\u0027"},{"line_number":33,"context_line":"Time period to generate instance usages for. It is possible to define optional"},{"line_number":34,"context_line":"offset to given period by appending @ character followed by a number defining"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_cc49c234","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":49},"in_reply_to":"1aa78d24_0e15829a","updated":"2016-07-14 12:39:26.000000000","message":"Can I use regular expressions in choices? Or should I drop this line?","commit_id":"3fe1c47ab3d93efdc86f2fdd87dc7c7b59cdd1e7"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"b3156c7a3d23e77827b172b085fb01c80a79a129","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  * nova.api.ec2.cloud:nova.notifications.notify_decorator"},{"line_number":86,"context_line":"  * [...]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Interdependencies to other options:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  * ``monkey_patch``: This must be set to ``True`` for this option to"},{"line_number":91,"context_line":"    have any effect"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_8ee4ed3b","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":34},"updated":"2016-07-27 20:24:05.000000000","message":"Do we have this heading or should this be changed to Related options?","commit_id":"653e120cffb6eccc3b377b01774c5a9da6c0c613"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1fec94d439514ac8f1210c753e3144d859e42cd5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  * nova.api.ec2.cloud:nova.notifications.notify_decorator"},{"line_number":86,"context_line":"  * [...]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Interdependencies to other options:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  * ``monkey_patch``: This must be set to ``True`` for this option to"},{"line_number":91,"context_line":"    have any effect"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_067a0888","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":34},"in_reply_to":"bacf61ea_8ee4ed3b","updated":"2016-08-05 09:02:09.000000000","message":"It should be Related options.","commit_id":"653e120cffb6eccc3b377b01774c5a9da6c0c613"}]}